[GitHub] wu-sheng opened a new issue #1207: Tolerate and ignore unsupport segments

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1207: Tolerate and ignore unsupport segments URL: https://github.com/apache/incubator-skywalking/issues/1207 Because segment data are from multiple languages's agents/SDKs, even some custom plugins, the collector can't count on every trace is perfect. So

[GitHub] wu-sheng opened a new issue #1206: Accept multi entry spans in collector analysis

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1206: Accept multi entry spans in collector analysis URL: https://github.com/apache/incubator-skywalking/issues/1206 Because of MQ consumer, there may have multiple entry spans in a single segment. The collector segment parser should support on this. -

[GitHub] wu-sheng commented on issue #1205: turn off the agent log

2018-05-09 Thread GitBox
wu-sheng commented on issue #1205: turn off the agent log URL: https://github.com/apache/incubator-skywalking/issues/1205#issuecomment-387964965 You could set the log level to **OFF**. ``` # Logging level logging.level=OFF ``` ---

[GitHub] wu-sheng closed issue #1205: turn off the agent log

2018-05-09 Thread GitBox
wu-sheng closed issue #1205: turn off the agent log URL: https://github.com/apache/incubator-skywalking/issues/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] mosesyou opened a new issue #1205: turn off the agent log

2018-05-09 Thread GitBox
mosesyou opened a new issue #1205: turn off the agent log URL: https://github.com/apache/incubator-skywalking/issues/1205 - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question

[GitHub] wu-sheng opened a new issue #1204: Add folder lock to collector's buffer folder

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1204: Add folder lock to collector's buffer folder URL: https://github.com/apache/incubator-skywalking/issues/1204 Based on #1198 , this is a very serious issue, which is also hard to pinpoint. I suggest the collector to add a folder lock mechanism to prevent t

[GitHub] wu-sheng commented on issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-09 Thread GitBox
wu-sheng commented on issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198#issuecomment-387962335 This is caused by @ascrutae 's deployment mistakes. In the demo env, the buffer folders of two collector insta

[GitHub] wu-sheng closed issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-09 Thread GitBox
wu-sheng closed issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198 This is an automated message from the Apache Git Service. To respond to th

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387959620 understand,I have some solution This is an auto

[GitHub] wu-sheng commented on issue #1203: Tracking ignores need to be enhanced

2018-05-09 Thread GitBox
wu-sheng commented on issue #1203: Tracking ignores need to be enhanced URL: https://github.com/apache/incubator-skywalking/issues/1203#issuecomment-387943088 I agree that. And I think we are welcome to discuss and accept this filter mechanism as an optional plugin. --

[GitHub] wu-sheng closed issue #937: Click the Application Menu, Topological graph may Invalid

2018-05-09 Thread GitBox
wu-sheng closed issue #937: Click the Application Menu, Topological graph may Invalid URL: https://github.com/apache/incubator-skywalking/issues/937 This is an automated message from the Apache Git Service. To respond to th

[GitHub] wu-sheng commented on issue #937: Click the Application Menu, Topological graph may Invalid

2018-05-09 Thread GitBox
wu-sheng commented on issue #937: Click the Application Menu, Topological graph may Invalid URL: https://github.com/apache/incubator-skywalking/issues/937#issuecomment-387942880 I will close this for now. No further report since alpha release.

[GitHub] SevenPointOld opened a new issue #1203: Tracking ignores need to be enhanced

2018-05-09 Thread GitBox
SevenPointOld opened a new issue #1203: Tracking ignores need to be enhanced URL: https://github.com/apache/incubator-skywalking/issues/1203 There is a need to ignore some special requests for applications, such as pulling services from the registry, pulling configurations from the config

[GitHub] wu-sheng commented on issue #1166: Optimize topology query

2018-05-09 Thread GitBox
wu-sheng commented on issue #1166: Optimize topology query URL: https://github.com/apache/incubator-skywalking/issues/1166#issuecomment-387940889 Replace by #1202 This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng closed issue #1166: Optimize topology query

2018-05-09 Thread GitBox
wu-sheng closed issue #1166: Optimize topology query URL: https://github.com/apache/incubator-skywalking/issues/1166 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] wu-sheng opened a new issue #1202: Topology query performance optimization

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1202: Topology query performance optimization URL: https://github.com/apache/incubator-skywalking/issues/1202 Right now, many system has a huge number of applications, and complex topology map. Suggest add a new column to reduce the group op in topology query.

[GitHub] wu-sheng opened a new issue #1201: Can't show the detail of Span with empty operation name

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1201: Can't show the detail of Span with empty operation name URL: https://github.com/apache/incubator-skywalking/issues/1201 In trace view, when a span has an empty operation name, the current page can't show it. -

[GitHub] wu-sheng opened a new issue #1200: [New concept] Proposal for Manual Span

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1200: [New concept] Proposal for Manual Span URL: https://github.com/apache/incubator-skywalking/issues/1200 Consider of #1196 and #1044 , also more and more RPC framework, I want to proposal a new type of span, Concept: **Manual Span** # Manual Span M

[GitHub] wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387764220 This is a very typical across-thread scenario, whether cross two or three threads. You should find a way hold **Sn

[GitHub] candyleer commented on issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-09 Thread GitBox
candyleer commented on issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198#issuecomment-387758494 get it This is an automated message from the

[GitHub] wu-sheng commented on issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-09 Thread GitBox
wu-sheng commented on issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198#issuecomment-387753068 Also related #1199 bug. This is an automated

[GitHub] wu-sheng opened a new issue #1199: The cache didn't update when NetworkAddress serverType and spanLayer changed

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1199: The cache didn't update when NetworkAddress serverType and spanLayer changed URL: https://github.com/apache/incubator-skywalking/issues/1199 This issue detected when we review codes for #1198 , the cache will not update since data cached. So NetworkAddres

[GitHub] wu-sheng opened a new issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198 This is a high priority and blocking bug before 5.0.0-beta release. When I and @peng-yongsheng check the data in our demo env, we fou

[GitHub] coveralls commented on issue #1190: Change the intercept point of block call way

2018-05-09 Thread GitBox
coveralls commented on issue #1190: Change the intercept point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190#issuecomment-387471505 [![Coverage Status](https://coveralls.io/builds/16902098/badge)](https://coveralls.io/builds/16902098) Coverage i

[GitHub] ascrutae commented on issue #1190: Change the intercept point of block call way

2018-05-09 Thread GitBox
ascrutae commented on issue #1190: Change the intercept point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190#issuecomment-387718751 The stream screen snapshot: ![181525867504_ pic_hd](https://user-images.githubusercontent.com/12436447/39814001-4ea87996-5

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387710468 the result may be ``` ---main- --thread-3--

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387710468 the result may be ``` ---main- --thread-3--

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387710468 the result may be ``` ---main- --thread-3--

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387710468 the result may be ``` ---main- --thread-3--

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387710468 the result may be ---main- --thread-3--

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387708818 @wu-sheng the work flow of `Async http client` can be drawed as: ![image](https://user-images.githubuserconte

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387708818 @wu-sheng the work flow of `Async http client` can be drawed as: ![image](https://user-images.githubuserconte

[GitHub] wu-sheng closed pull request #1197: Updat ui

2018-05-09 Thread GitBox
wu-sheng closed pull request #1197: Updat ui URL: https://github.com/apache/incubator-skywalking/pull/1197 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] coveralls commented on issue #1197: Updat ui

2018-05-09 Thread GitBox
coveralls commented on issue #1197: Updat ui URL: https://github.com/apache/incubator-skywalking/pull/1197#issuecomment-387691815 [![Coverage Status](https://coveralls.io/builds/16900247/badge)](https://coveralls.io/builds/16900247) Coverage remained the same at 23.362% when pul

[GitHub] hanahmily opened a new pull request #1197: Updat ui

2018-05-09 Thread GitBox
hanahmily opened a new pull request #1197: Updat ui URL: https://github.com/apache/incubator-skywalking/pull/1197 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance

[GitHub] liuhaoyang commented on issue #1195: Invalid calls in Service topology query

2018-05-09 Thread GitBox
liuhaoyang commented on issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195#issuecomment-387682262 I will support this in .NET Agent v0.3. This is an automated

[GitHub] candyleer commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-09 Thread GitBox
candyleer commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-387669774 ok.I will test latter This is an automated messa

[GitHub] wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387668565 > for current version ,one request contains 2 exit span and 3 local span for above image. I think AsyncThread/ex

[GitHub] wu-sheng commented on issue #1195: Invalid calls in Service topology query

2018-05-09 Thread GitBox
wu-sheng commented on issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195#issuecomment-387668249 This recheck service works for me. And I highly recommend we support this in beta2. @hanahmily @ascrutae @liuhaoyang @candyleer

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387667901 for current version ,one request contains 2 exit span and 3 local span for above image. I think `AsyncThread/ex

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387667901 for current version ,one request contains 2 exit span and 3 local span for above image. I think `AsyncThread/ex

[GitHub] peng-yongsheng commented on issue #1195: Invalid calls in Service topology query

2018-05-09 Thread GitBox
peng-yongsheng commented on issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195#issuecomment-387667513 We can add a new service to check application id and instance id when agent reconnect to collector. Flow is: ```

[GitHub] wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387666447 In ideal, one local span in main thread(segment) represents the prepare async http, another exit span in sub threa

[GitHub] wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387665643 1. `#activeSpan` 's NPE is always triggered by the span started in another thread. 1. ContextSnapshot missing m

[GitHub] candyleer opened a new issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer opened a new issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [

[GitHub] wu-sheng commented on issue #1195: Invalid calls in Service topology query

2018-05-09 Thread GitBox
wu-sheng commented on issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195#issuecomment-387662821 I confirmed with the users, they clear ElasticSearch, but don't reboot the monitored application(agent). So no node register and

[GitHub] wu-sheng commented on issue #1195: Invalid calls in Service topology query

2018-05-09 Thread GitBox
wu-sheng commented on issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195#issuecomment-387662821 I confirmed with the users, they clear collector but don't reboot the application. So no node register and calls between unexist

[GitHub] wu-sheng commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-09 Thread GitBox
wu-sheng commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-387660377 @candyleer I want to clear about @peng-yongsheng 's requests. Some of our operation names are using packageName.cl

[GitHub] hanahmily opened a new issue #1195: Invalid calls in Service topology query

2018-05-09 Thread GitBox
hanahmily opened a new issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ]

[GitHub] hanahmily opened a new issue #169: Check data for Sankey chart

2018-05-09 Thread GitBox
hanahmily opened a new issue #169: Check data for Sankey chart URL: https://github.com/apache/incubator-skywalking-ui/issues/169 Invalid data (refers to #141 ) may cause the Service page to crash. This is an automated message

[GitHub] peng-yongsheng commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-09 Thread GitBox
peng-yongsheng commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-387657417 @candyleer Try to search service_name separate by `.` such as `skywalking.incubator.apache.org`. --

[GitHub] hanahmily commented on issue #141: Fail to render Dependency Map

2018-05-09 Thread GitBox
hanahmily commented on issue #141: Fail to render Dependency Map URL: https://github.com/apache/incubator-skywalking-ui/issues/141#issuecomment-387657195 This is another question. The "-175" is invalid node id. The UI project should valid data, and collector project needs to check the

[GitHub] wu-sheng commented on issue #168: Fix Trace search time is null , there is an error

2018-05-09 Thread GitBox
wu-sheng commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387651637 @hanahmily I have to change the milestone and move this into beta release. Please be advised. Codes should be frozen by

[GitHub] wangmh commented on issue #141: Fail to render Dependency Map

2018-05-09 Thread GitBox
wangmh commented on issue #141: Fail to render Dependency Map URL: https://github.com/apache/incubator-skywalking-ui/issues/141#issuecomment-387650129 我那最新版的试验了下,还存在类似的问题 {"data":{"getServiceResponseTimeTrend":{"trendList":[0,0,0,5,399,7,19,239,6,6,0,0,6,50,18,6]},"getServiceThroughputT

[GitHub] hanahmily closed pull request #168: Fix Trace search time is null , there is an error

2018-05-09 Thread GitBox
hanahmily closed pull request #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] coveralls commented on issue #1190: Change the intercept point of block call way

2018-05-09 Thread GitBox
coveralls commented on issue #1190: Change the intercept point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190#issuecomment-387471505 [![Coverage Status](https://coveralls.io/builds/16898220/badge)](https://coveralls.io/builds/16898220) Coverage r