[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388529703 I will test it and provide report in https://github.com/SkywalkingTest/skywalking-agent-testcases .

[GitHub] coveralls commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
coveralls commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388049701 [![Coverage Status](https://coveralls.io/builds/16949876/badge)](https://coveralls.io/builds/16949876) Coverage increased

[GitHub] leizhiyuan opened a new pull request #170: add sofarpc icon

2018-05-11 Thread GitBox
leizhiyuan opened a new pull request #170: add sofarpc icon URL: https://github.com/apache/incubator-skywalking-ui/pull/170 add sofarpc icon This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388524439 @wu-sheng ContextManagerExtendOverrideService I saw dubbo does this. I thought It was a rule. I will remove it.

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761314 ## File path:

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761246 ## File path:

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761246 ## File path:

[GitHub] wu-sheng closed pull request #1216: Fixed the version release bug.

2018-05-11 Thread GitBox
wu-sheng closed pull request #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wu-sheng commented on issue #1216: Fixed the version release bug.

2018-05-11 Thread GitBox
wu-sheng commented on issue #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216#issuecomment-388419662 We can't add these modules in. Fail in RAT check. This is an automated

[GitHub] coveralls commented on issue #1216: Fixed the version release bug.

2018-05-11 Thread GitBox
coveralls commented on issue #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216#issuecomment-388385288 [![Coverage Status](https://coveralls.io/builds/16940018/badge)](https://coveralls.io/builds/16940018) Coverage increased

[GitHub] coveralls commented on issue #1216: Fixed the version release bug.

2018-05-11 Thread GitBox
coveralls commented on issue #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216#issuecomment-388385288 [![Coverage Status](https://coveralls.io/builds/16940010/badge)](https://coveralls.io/builds/16940010) Coverage increased

[GitHub] candyleer opened a new issue #1215: No traceId In trace page sometimes

2018-05-11 Thread GitBox
candyleer opened a new issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ]

[GitHub] wfs0902 opened a new issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6

2018-05-11 Thread GitBox
wfs0902 opened a new issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6 URL: https://github.com/apache/incubator-skywalking/issues/1214 Please answer these questions before submitting your issue. - Why do you submit

[GitHub] wfs0902 commented on issue #1211: The same operation has a duplicate globalTraceID;

2018-05-11 Thread GitBox
wfs0902 commented on issue #1211: The same operation has a duplicate globalTraceID; URL: https://github.com/apache/incubator-skywalking/issues/1211#issuecomment-388293411 Thank you very much,Its generation rules are difficult to replicate in theory, and why the same timestamp is

[GitHub] liuhaoyang commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-11 Thread GitBox
liuhaoyang commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388287017 Maybe we can also support reading `trace.ignore_path` from environment variables.

[GitHub] SevenPointOld opened a new pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-11 Thread GitBox
SevenPointOld opened a new pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213 Please answer these questions before submitting pull request - Why submit this pull request? New

[GitHub] coveralls commented on issue #1212: fix wrong description for chinese document

2018-05-11 Thread GitBox
coveralls commented on issue #1212: fix wrong description for chinese document URL: https://github.com/apache/incubator-skywalking/pull/1212#issuecomment-388272822 [![Coverage Status](https://coveralls.io/builds/16934174/badge)](https://coveralls.io/builds/16934174) Coverage

[GitHub] peng-yongsheng closed pull request #1212: fix wrong description for chinese document

2018-05-11 Thread GitBox
peng-yongsheng closed pull request #1212: fix wrong description for chinese document URL: https://github.com/apache/incubator-skywalking/pull/1212 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] peng-yongsheng commented on issue #1211: The same operation has a duplicate globalTraceID;

2018-05-11 Thread GitBox
peng-yongsheng commented on issue #1211: The same operation has a duplicate globalTraceID; URL: https://github.com/apache/incubator-skywalking/issues/1211#issuecomment-388268675 This is known issues by the version 3.2.6, suggest upgrade to version 5.0.0-alpha. And 5.0.0-beta version