[GitHub] candyleer commented on issue #1194: Modify operationName search from match to match_phrase
candyleer commented on issue #1194: Modify operationName search from match to
match_phrase
URL:
https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-388535368
It works well as expected. @peng-yongsheng
such as
```
{
"from" : 0,
"size" : 20,
"query" : {
"bool" : {
"must" : [
{
"range" : {
"time_bucket" : {
"from" : 20180512144500,
"to" : 2018051215
}
}
},
{
"match_phrase" : {
"service_name" : {
"query" : "com.example.test.TestApplication.test"
}
}
}
]
}
},
"sort" : [
{
"start_time" : {
"order" : "desc"
}
}
]
}
```
return
```
{
"took": 1,
"timed_out": false,
"_shards": {
"total": 2,
"successful": 2,
"skipped": 0,
"failed": 0
},
"hits": {
"total": 1,
"max_score": null,
"hits": [
{
"_index": "segment_duration",
"_type": "type",
"_id": "136.48.1526108176093",
"_score": null,
"_source": {
"duration": 3270,
"start_time": 1526108176093,
"service_name": "com.example.test.TestApplication.test",
"end_time": 1526108179363,
"time_bucket": 20180512145616,
"is_error": 0,
"segment_id": "136.48.1526108176093",
"application_id": -3
},
"sort": [
1526108176093
]
}
]
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #1217: Rewrite Async http client plugin
coveralls commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388535000 [](https://coveralls.io/builds/16950379) Coverage increased (+0.2%) to 23.53% when pulling **1ae21f6a383e18cd2fc74ed0239a7ae4e9dc4b3b on candyleer:async_http_client** into **4e047353f9afbb6cf27c73b0ad3dd0b5f6e29170 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1217: Rewrite Async http client plugin
coveralls commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388535000 [](https://coveralls.io/builds/16950350) Coverage increased (+0.2%) to 23.526% when pulling **1ae21f6a383e18cd2fc74ed0239a7ae4e9dc4b3b on candyleer:async_http_client** into **4e047353f9afbb6cf27c73b0ad3dd0b5f6e29170 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1217: Rewrite Async http client plugin
wu-sheng commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388534809 :+1: I really like this. 2span cost much less than before. @ascrutae please review this and guide him to fix the teat case issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer opened a new pull request #1217: Rewrite Async http client plugin
candyleer opened a new pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [x] Improve performance - Related issues #1196 ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports.  After rewrite, the span of the async http client looks like above in red box. Please review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388529703 I will test it and provide report in https://github.com/SkywalkingTest/skywalking-agent-testcases . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1210: Add sofa rpc plugin integration
coveralls commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388049701 [](https://coveralls.io/builds/16949876) Coverage increased (+0.2%) to 23.56% when pulling **fdede2a849c1a554933cd52921ae5935f62ebcdd on leizhiyuan:sofarpc-integration** into **53b59f22f05e7ff2cdde2ec6d5b40536fb6e7f20 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #170: add sofarpc icon
leizhiyuan commented on issue #170: add sofarpc icon URL: https://github.com/apache/incubator-skywalking-ui/pull/170#issuecomment-388527993 @wu-sheng ok. thanks for you advice, I will change the icon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan opened a new pull request #170: add sofarpc icon
leizhiyuan opened a new pull request #170: add sofarpc icon URL: https://github.com/apache/incubator-skywalking-ui/pull/170 add sofarpc icon This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388524628 Dubbo has it because dubbo is our first plugin, some no-dubbo test codes are in it, because it need test in plugin modules. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388524439 @wu-sheng ContextManagerExtendOverrideService I saw dubbo does this. I thought It was a rule. I will remove it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration
leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin
integration
URL:
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761351
##
File path:
apm-sniffer/apm-sdk-plugin/sofarpc-plugin/src/main/java/org/apache/skywalking/apm/plugin/sofarpc/SofaRpcProviderInterceptor.java
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.sofarpc;
+
+import com.alipay.sofa.rpc.context.RpcInternalContext;
+import com.alipay.sofa.rpc.core.request.SofaRequest;
+import com.alipay.sofa.rpc.core.response.SofaResponse;
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import java.lang.reflect.Method;
+
+/**
+ * @author leizhiyuan
+ */
+public class SofaRpcProviderInterceptor implements
InstanceMethodsAroundInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments,
+ Class[] argumentsTypes, MethodInterceptResult
result) throws Throwable {
+SofaRequest sofaRequest = (SofaRequest) allArguments[0];
+RpcInternalContext rpcContext = RpcInternalContext.getContext();
+boolean isConsumer = rpcContext.isConsumerSide();
+
+AbstractSpan span = null;
+
+if (!isConsumer) {
+ContextCarrier contextCarrier = new ContextCarrier();
+CarrierItem next = contextCarrier.items();
+while (next.hasNext()) {
+next = next.next();
+final Object attachment =
rpcContext.getAttachment(next.getHeadKey());
+if (attachment != null) {
+next.setHeadValue(attachment.toString());
+} else {
+next.setHeadValue("");
+}
+}
+span =
ContextManager.createEntrySpan(generateViewPoint(sofaRequest), contextCarrier);
+
+}
+
+span.setComponent(ComponentsDefine.SOFARPC);
Review comment:
ok,I can make true this call by provide side,I will remove it
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin
integration
URL:
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761314
##
File path:
apm-sniffer/apm-sdk-plugin/sofarpc-plugin/src/main/java/org/apache/skywalking/apm/plugin/sofarpc/SofaRpcConsumerInterceptor.java
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.sofarpc;
+
+import com.alipay.sofa.rpc.client.ProviderInfo;
+import com.alipay.sofa.rpc.context.RpcInternalContext;
+import com.alipay.sofa.rpc.core.request.SofaRequest;
+import com.alipay.sofa.rpc.core.response.SofaResponse;
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import java.lang.reflect.Method;
+
+/**
+ * @author leizhiyuan
+ */
+public class SofaRpcConsumerInterceptor implements
InstanceMethodsAroundInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments,
+ Class[] argumentsTypes, MethodInterceptResult
result) throws Throwable {
+SofaRequest sofaRequest = (SofaRequest) allArguments[0];
+RpcInternalContext rpcContext = RpcInternalContext.getContext();
+boolean isConsumer = rpcContext.isConsumerSide();
+ProviderInfo providerInfo = rpcContext.getProviderInfo();
+
+AbstractSpan span = null;
+
+final String host = providerInfo.getHost();
+final int port = providerInfo.getPort();
+if (isConsumer) {
+final ContextCarrier contextCarrier = new ContextCarrier();
+span =
ContextManager.createExitSpan(generateOperationName(providerInfo, sofaRequest),
contextCarrier, host + ":" + port);
+CarrierItem next = contextCarrier.items();
+while (next.hasNext()) {
+next = next.next();
+rpcContext.getAttachments().put(next.getHeadKey(),
next.getHeadValue());
+}
+}
+Tags.URL.set(span, generateRequestURL(providerInfo, sofaRequest));
+span.setComponent(ComponentsDefine.SOFARPC);
Review comment:
This line maybe cause NullPointException when the isConsumer equals false.
Or remove the judgment if you are sure this instrumentation only call by
consumer side
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin
integration
URL:
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761246
##
File path:
apm-sniffer/apm-sdk-plugin/sofarpc-plugin/src/main/java/org/apache/skywalking/apm/plugin/sofarpc/SofaRpcProviderInterceptor.java
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.sofarpc;
+
+import com.alipay.sofa.rpc.context.RpcInternalContext;
+import com.alipay.sofa.rpc.core.request.SofaRequest;
+import com.alipay.sofa.rpc.core.response.SofaResponse;
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import java.lang.reflect.Method;
+
+/**
+ * @author leizhiyuan
+ */
+public class SofaRpcProviderInterceptor implements
InstanceMethodsAroundInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments,
+ Class[] argumentsTypes, MethodInterceptResult
result) throws Throwable {
+SofaRequest sofaRequest = (SofaRequest) allArguments[0];
+RpcInternalContext rpcContext = RpcInternalContext.getContext();
+boolean isConsumer = rpcContext.isConsumerSide();
+
+AbstractSpan span = null;
+
+if (!isConsumer) {
+ContextCarrier contextCarrier = new ContextCarrier();
+CarrierItem next = contextCarrier.items();
+while (next.hasNext()) {
+next = next.next();
+final Object attachment =
rpcContext.getAttachment(next.getHeadKey());
+if (attachment != null) {
+next.setHeadValue(attachment.toString());
+} else {
+next.setHeadValue("");
+}
+}
+span =
ContextManager.createEntrySpan(generateViewPoint(sofaRequest), contextCarrier);
+
+}
+
+span.setComponent(ComponentsDefine.SOFARPC);
Review comment:
This line maybe cause NullPointException when the `isConsumer` equals
`true`. Or remove the judgment if you are sure this instrumentation only call
by provide side.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin
integration
URL:
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761246
##
File path:
apm-sniffer/apm-sdk-plugin/sofarpc-plugin/src/main/java/org/apache/skywalking/apm/plugin/sofarpc/SofaRpcProviderInterceptor.java
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.sofarpc;
+
+import com.alipay.sofa.rpc.context.RpcInternalContext;
+import com.alipay.sofa.rpc.core.request.SofaRequest;
+import com.alipay.sofa.rpc.core.response.SofaResponse;
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import java.lang.reflect.Method;
+
+/**
+ * @author leizhiyuan
+ */
+public class SofaRpcProviderInterceptor implements
InstanceMethodsAroundInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments,
+ Class[] argumentsTypes, MethodInterceptResult
result) throws Throwable {
+SofaRequest sofaRequest = (SofaRequest) allArguments[0];
+RpcInternalContext rpcContext = RpcInternalContext.getContext();
+boolean isConsumer = rpcContext.isConsumerSide();
+
+AbstractSpan span = null;
+
+if (!isConsumer) {
+ContextCarrier contextCarrier = new ContextCarrier();
+CarrierItem next = contextCarrier.items();
+while (next.hasNext()) {
+next = next.next();
+final Object attachment =
rpcContext.getAttachment(next.getHeadKey());
+if (attachment != null) {
+next.setHeadValue(attachment.toString());
+} else {
+next.setHeadValue("");
+}
+}
+span =
ContextManager.createEntrySpan(generateViewPoint(sofaRequest), contextCarrier);
+
+}
+
+span.setComponent(ComponentsDefine.SOFARPC);
Review comment:
This line maybe cause NullPointException when the `isConsumer` equals `true`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng closed pull request #1216: Fixed the version release bug.
wu-sheng closed pull request #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1216: Fixed the version release bug.
wu-sheng commented on issue #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216#issuecomment-388419662 We can't add these modules in. Fail in RAT check. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1216: Fixed the version release bug.
coveralls commented on issue #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216#issuecomment-388385288 [](https://coveralls.io/builds/16940018) Coverage increased (+0.08%) to 23.439% when pulling **12ae3a70ce034b2abcad024e7e0da8923bceb502 on release/5.0.0-beta** into **4e047353f9afbb6cf27c73b0ad3dd0b5f6e29170 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1216: Fixed the version release bug.
coveralls commented on issue #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216#issuecomment-388385288 [](https://coveralls.io/builds/16940010) Coverage increased (+0.08%) to 23.443% when pulling **12ae3a70ce034b2abcad024e7e0da8923bceb502 on release/5.0.0-beta** into **4e047353f9afbb6cf27c73b0ad3dd0b5f6e29170 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #1216: Fixed the version release bug.
peng-yongsheng opened a new pull request #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Bug fix _ ### Bug fix - Bug description. Version change failure when release version. - How to fix? Add oracle and resin SDK plugin module into parent maven pom. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer opened a new issue #1215: No traceId In trace page sometimes
candyleer opened a new issue #1215: No traceId In trace page sometimes
URL: https://github.com/apache/incubator-skywalking/issues/1215
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Question
- What do you want to know?
___
### Bug
- Which version of SkyWalking, OS and JRE?
master latest
- Which company or project?
- What happen?
If possible, provide a way for reproducing the error. e.g. demo application,
component version.
request
```
http://localhost:8000/api/trace
```
params
```
{"variables":{"condition":{"queryDuration":{"start":"2018-05-11
2133","end":"2018-05-11
2148","step":"MINUTE"},"paging":{"pageNum":1,"pageSize":20,"needTotal":true}}},"query":"\n
query BasicTraces($condition: TraceQueryCondition) {\n
queryBasicTraces(condition: $condition) {\n traces {\nkey:
segmentId\noperationName\nduration\nstart\n
isError\ntraceIds\n }\n total\n}\n }\n"}
```
response
```
{"data":{"queryBasicTraces":{"traces":[{"key":"129.71.1526046512572","operationName":"test","duration":2434,"start":"1526046512572","isError":false,"traceIds":[]},{"key":"129.99.1526046512467","operationName":"httpasyncclient/local","duration":2650,"start":"1526046512475","isError":false,"traceIds":[]},{"key":"129.70.1526046504592","operationName":"http_async","duration":8130,"start":"1526046504605","isError":false,"traceIds":[]},{"key":"128.71.1526046313837","operationName":"test","duration":2360,"start":"1526046313837","isError":false,"traceIds":["128.70.15260463128650001"]},{"key":"128.95.1526046313754","operationName":"httpasyncclient/local","duration":2456,"start":"1526046313768","isError":false,"traceIds":["128.70.15260463128650001"]},{"key":"128.70.1526046312863","operationName":"http_async","duration":965,"start":"1526046312872","isError":false,"traceIds":["128.70.15260463128650001"]},{"key":"127.73.1526046036734","operationName":"test","duration":2006,"start":"1526046036734","isError":false,"traceIds":["127.72.15260460367160001"]},{"key":"127.102.1526046036729","operationName":"Queue/channel-local","duration":2010,"start":"1526046036730","isError":false,"traceIds":["127.72.15260460367160001"]},{"key":"127.72.1526046036716","operationName":"http_async","duration":20,"start":"1526046036716","isError":false,"traceIds":["127.72.15260460367160001"]},{"key":"127.71.1526046025860","operationName":"test","duration":2427,"start":"1526046025860","isError":false,"traceIds":["127.70.15260460251120001"]},{"key":"127.94.1526046025800","operationName":"Queue/channel-local","duration":2510,"start":"1526046025805","isError":false,"traceIds":["127.70.15260460251120001"]},{"key":"127.70.1526046025110","operationName":"http_async","duration":732,"start":"1526046025122","isError":false,"traceIds":["127.70.15260460251120001"]},{"key":"126.79.1526045922262","operationName":"test","duration":2011,"start":"1526045922262","isError":false,"traceIds":["126.79.15260459222620001"]},{"key":"126.109.1526045922257","operationName":"Queue/channel-local","duration":2016,"start":"1526045922258","isError":false,"traceIds":["126.78.15260459222460001"]},{"key":"126.78.1526045922246","operationName":"http_async","duration":20,"start":"1526045922246","isError":false,"traceIds":["126.78.15260459222460001"]},{"key":"126.76.1526045889310","operationName":"test","duration":2439,"start":"1526045889310","isError":false,"traceIds":["126.76.1526045889311"]},{"key":"126.103.1526045889235","operationName":"Queue/channel-local","duration":2527,"start":"1526045889239","isError":false,"traceIds":["126.75.15260458884270001"]},{"key":"126.75.1526045888426","operationName":"http_async","duration":919,"start":"1526045888435","isError":false,"traceIds":["126.75.15260458884270001"]},{"key":"125.79.15260456986460004","operationName":"${server.error.path:${error.path:/error}}","duration":9,"start":"1526045698646","isError":true,"traceIds":["125.79.15260456986460005"]}],"total":19}}}
```
___
### Requirement or improvement
- Please describe about your requirements or improvement suggestions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388312812 ok, I'will support that This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wfs0902 opened a new issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6
wfs0902 opened a new issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6 URL: https://github.com/apache/incubator-skywalking/issues/1214 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know?  ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wfs0902 commented on issue #1211: The same operation has a duplicate globalTraceID；
wfs0902 commented on issue #1211: The same operation has a duplicate globalTraceID； URL: https://github.com/apache/incubator-skywalking/issues/1211#issuecomment-388293411 Thank you very much，Its generation rules are difficult to replicate in theory, and why the same timestamp is generated at different time periods. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liuhaoyang commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
liuhaoyang commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388287017 Maybe we can also support reading `trace.ignore_path` from environment variables. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld opened a new pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld opened a new pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213 Please answer these questions before submitting pull request - Why submit this pull request? New feature provided - Related issues #1203 ___ ___ ### New feature or improvement - The applications can set paths in the plugin cofig file to let agent ignore tracing, use ant path match - This plugin after packing will create its own directory in optional-plugins parent directory, this directory has README.md file(introduce how to use this plugin), config file(plugin config) and plugin jar. I also write an unit test for the plugin This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
