[GitHub] wu-sheng commented on issue #1302: There's a bit of doubt about the way springMVC gets the operationName

wu-sheng commented on issue #1302: There's a bit of doubt about the way springMVC gets the operationName URL: https://github.com/apache/incubator-skywalking/issues/1302#issuecomment-394226236 I guess `parsed path pattern`, you mean the real URL? - Pattern:

[GitHub] wu-sheng commented on issue #1302: There's a bit of doubt about the way springMVC gets the operationName

wu-sheng commented on issue #1302: There's a bit of doubt about the way springMVC gets the operationName URL: https://github.com/apache/incubator-skywalking/issues/1302#issuecomment-394222863 Yes. only use path pattern as the operation name, the backend will aggregate and analysis the

[GitHub] SevenPointOld opened a new issue #1302: There's a bit of doubt about the way springMVC gets the operationName

SevenPointOld opened a new issue #1302: There's a bit of doubt about the way springMVC gets the operationName URL: https://github.com/apache/incubator-skywalking/issues/1302 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question

[GitHub] wu-sheng closed pull request #1301: add SOFARPC to support list

wu-sheng closed pull request #1301: add SOFARPC to support list URL: https://github.com/apache/incubator-skywalking/pull/1301 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] coveralls commented on issue #1301: add SOFARPC to support list

coveralls commented on issue #1301: add SOFARPC to support list URL: https://github.com/apache/incubator-skywalking/pull/1301#issuecomment-394159959 [](https://coveralls.io/builds/17294050) Coverage decreased

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394156287 @wu-sheng ok, I will submit a new pr . This is an automated message

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394156229 @leizhiyuan merged. Thanks. And I think you should submit another Pr to add Sofa into supported list doc.

[GitHub] coveralls commented on issue #1210: Add sofa rpc plugin integration

coveralls commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388049701 [](https://coveralls.io/builds/17293660) Coverage increased

[GitHub] wu-sheng commented on issue #1287: kafka exception

wu-sheng commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394149802 Could we close this issue? Or do you want to discuss optional kafka plugin? This is an

[GitHub] ascrutae commented on issue #1210: Add sofa rpc plugin integration

ascrutae commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394145812 This PR look good to me. Here is the [test

[GitHub] wu-sheng commented on issue #1287: kafka exception

wu-sheng commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394145372 So, you should understand @ascrutae PR is not for supporting 0.10, is for avoiding exception in log. 0.10 kafka is still not under tracing.

[GitHub] wu-sheng commented on issue #1287: kafka exception

wu-sheng commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394145285 I think there is no good way to trace kafka 0.10, if we don't do some assumptions or set some rules. No kafka header, no way to propagation. If

[GitHub] xyydcoo commented on issue #1287: kafka exception

xyydcoo commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394144763 kafka veriosn 0.10.1.1 This is an automated message from the Apache Git Service. To