[GitHub] wu-sheng commented on issue #1302: There's a bit of doubt about the way springMVC gets the operationName
wu-sheng commented on issue #1302: There's a bit of doubt about the way
springMVC gets the operationName
URL:
https://github.com/apache/incubator-skywalking/issues/1302#issuecomment-394226236
I guess `parsed path pattern`, you mean the real URL?
- Pattern: ${spring.application.name}/access/page
- URI: application-xxx/access/page
Right? If yes, try to thing some one will put userid, accountid in the url,
the patter looks like `/prod/order/${orderid}`. Then you can image what
happens... Metrics will be useless..
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng commented on issue #1302: There's a bit of doubt about the way springMVC gets the operationName
wu-sheng commented on issue #1302: There's a bit of doubt about the way springMVC gets the operationName URL: https://github.com/apache/incubator-skywalking/issues/1302#issuecomment-394222863 Yes. only use path pattern as the operation name, the backend will aggregate and analysis the metrics for the service(based on operation name). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld opened a new issue #1302: There's a bit of doubt about the way springMVC gets the operationName
SevenPointOld opened a new issue #1302: There's a bit of doubt about the way springMVC gets the operationName URL: https://github.com/apache/incubator-skywalking/issues/1302 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? Like this,  the `RequestMappingMethodInterceptor#getRequestURL` just get the `RequestMapping` annotation's `path` or `value` as operationName, I think maybe I need the parsed path as operationName. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1301: add SOFARPC to support list
wu-sheng closed pull request #1301: add SOFARPC to support list URL: https://github.com/apache/incubator-skywalking/pull/1301 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/Supported-list.md b/docs/Supported-list.md index 46717ad0c..5cd527a8f 100644 --- a/docs/Supported-list.md +++ b/docs/Supported-list.md @@ -29,6 +29,7 @@ * [Motan](https://github.com/weibocom/motan) 0.2.x -> 1.1.0 * [gRPC](https://github.com/grpc/grpc-java) 1.x * [Apache ServiceComb Java Chassis](https://github.com/apache/incubator-servicecomb-java-chassis) 0.1 -> 0.5,1.0.x + * [SOFARPC](https://github.com/alipay/sofa-rpc) 5.4.0 * MQ * [RocketMQ](https://github.com/apache/rocketmq) 4.x * [Kafka](http://kafka.apache.org) 0.11.0.0 -> 1.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1301: add SOFARPC to support list
coveralls commented on issue #1301: add SOFARPC to support list URL: https://github.com/apache/incubator-skywalking/pull/1301#issuecomment-394159959 [](https://coveralls.io/builds/17294050) Coverage decreased (-0.004%) to 24.001% when pulling **568e524540c9dd533d1f786232267c51fffeb1aa on leizhiyuan:add_sofa_rpc_support_doc** into **c4766ecbf251613bafef55722e26bba554a4aba6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394156287 @wu-sheng ok, I will submit a new pr . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394156229 @leizhiyuan merged. Thanks. And I think you should submit another Pr to add Sofa into supported list doc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1210: Add sofa rpc plugin integration
coveralls commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388049701 [](https://coveralls.io/builds/17293660) Coverage increased (+0.2%) to 24.005% when pulling **cfef3afb3770f12212d30063deef07c705707196 on leizhiyuan:sofarpc-integration** into **7c305fe00c0124f37e0a203ef17c0ffd6c1da302 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1287: kafka exception
wu-sheng commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394149802 Could we close this issue? Or do you want to discuss optional kafka plugin? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #1210: Add sofa rpc plugin integration
ascrutae commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394145812 This PR look good to me. Here is the [test report](https://github.com/SkywalkingTest/agent-integration-test-report/blob/95f805e057ead49905f51423d8f6926139a2cf6b/2018/6/leizhiyuan/testReport-master-2018-06-03-15-20.md) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1287: kafka exception
wu-sheng commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394145372 So, you should understand @ascrutae PR is not for supporting 0.10, is for avoiding exception in log. 0.10 kafka is still not under tracing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1287: kafka exception
wu-sheng commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394145285 I think there is no good way to trace kafka 0.10, if we don't do some assumptions or set some rules. No kafka header, no way to propagation. If and only if kafka consumer and producer are monitored, and always under monitoring. We can do an optional plugin for low versions. Even you have that, you can't install or uninstall agent, if kafka has data. You need to wipe data in it. See our suppoted versions doc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xyydcoo commented on issue #1287: kafka exception
xyydcoo commented on issue #1287: kafka exception URL: https://github.com/apache/incubator-skywalking/issues/1287#issuecomment-394144763 kafka veriosn 0.10.1.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
