[GitHub] hanahmily closed issue #1250: Dashboard to Service page Error
hanahmily closed issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on issue #1250: Dashboard to Service page Error
hanahmily commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-395971903 Duplicate of #1195. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1215: No traceId In trace page sometimes
wu-sheng commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-395971693 > Segment without trace id is invalid data which should be removed in response. If more and more segments that are received concurrently by collectors would increase latency, 20 second is perhaps insufficent. @hanahmily This is caused by no database(ElasticSearch) transaction guarantee. These info belongs two types(tables). So, if backend does query in this way, they have to query again and again, that will cause the performance concern. Do you have any suggestion? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on issue #1215: No traceId In trace page sometimes
hanahmily commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-395971093 Segment without trace id is invalid data which should be removed in response. If more and more segments that are received concurrently by collectors would increase latency, 20 second is perhaps insufficent. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1223: Some doubts about the ui
wu-sheng closed issue #1223: Some doubts about the ui URL: https://github.com/apache/incubator-skywalking/issues/1223 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1223: Some doubts about the ui
wu-sheng commented on issue #1223: Some doubts about the ui URL: https://github.com/apache/incubator-skywalking/issues/1223#issuecomment-395968459 Closing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor
coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395941131 [](https://coveralls.io/builds/17405618) Coverage decreased (-0.03%) to 23.956% when pulling **78b68e0221693ba39b6b336264f24443f4f9f601 on ascrutae:fix/modify-tomcat-buried-point** into **5f81c0068ed16911f2ba8961bb0555b2d91b12c8 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1201: Can't show the detail of Span with empty operation name
wu-sheng closed issue #1201: Can't show the detail of Span with empty operation name URL: https://github.com/apache/incubator-skywalking/issues/1201 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1201: Can't show the detail of Span with empty operation name
wu-sheng commented on issue #1201: Can't show the detail of Span with empty operation name URL: https://github.com/apache/incubator-skywalking/issues/1201#issuecomment-395965490 Uncertain. Close it for now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zouyx closed issue #1298: java.lang.ClassNotFoundException: org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsInter
zouyx closed issue #1298: java.lang.ClassNotFoundException: org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsInter URL: https://github.com/apache/incubator-skywalking/issues/1298 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395964148 @ascrutae Where is the `forward` event? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #1336: Visualize trace by segments
wu-sheng opened a new issue #1336: Visualize trace by segments URL: https://github.com/apache/incubator-skywalking/issues/1336 From #901 discussions, we hope the UI could provide more powerful capabilities to visualize trace. Just order the spans by collectors, don't look like a good way. @hanahmily proposals that, give the UI full right of control. UI received the segments from collector directly, and use some topology map to visualize segment and spans. @hanahmily Please set a milestone for this requirement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #901: Sort segment in more sensible way
wu-sheng closed issue #901: Sort segment in more sensible way URL: https://github.com/apache/incubator-skywalking/issues/901 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #901: Sort segment in more sensible way
wu-sheng commented on issue #901: Sort segment in more sensible way URL: https://github.com/apache/incubator-skywalking/issues/901#issuecomment-395963985 Replace by #1336 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1282: Deploying on Kubernetes
wu-sheng closed issue #1282: Deploying on Kubernetes URL: https://github.com/apache/incubator-skywalking/issues/1282 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1282: Deploying on Kubernetes
wu-sheng commented on issue #1282: Deploying on Kubernetes URL: https://github.com/apache/incubator-skywalking/issues/1282#issuecomment-395963367 Closing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1187: Link to trace query from Thermodynamic graph
wu-sheng closed issue #1187: Link to trace query from Thermodynamic graph URL: https://github.com/apache/incubator-skywalking/issues/1187 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1187: Link to trace query from Thermodynamic graph
wu-sheng commented on issue #1187: Link to trace query from Thermodynamic graph URL: https://github.com/apache/incubator-skywalking/issues/1187#issuecomment-39596 Provided in https://github.com/apache/incubator-skywalking-ui/issues/173 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1176: Hope to Add application name in service search view
wu-sheng closed issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1176: Hope to Add application name in service search view
wu-sheng commented on issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176#issuecomment-395962581 @hanahmily @peng-yongsheng Both sides are provided and merged, I am closing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1335: [Collector]Add application name in service search view
wu-sheng closed pull request #1335: [Collector]Add application name in service
search view
URL: https://github.com/apache/incubator-skywalking/pull/1335
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/service/ServiceInfo.java
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/service/ServiceInfo.java
index 808fe25f3..1a2572808 100644
---
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/service/ServiceInfo.java
+++
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/service/ServiceInfo.java
@@ -24,6 +24,8 @@
public class ServiceInfo {
private int id;
private String name;
+private int applicationId;
+private String applicationName;
public int getId() {
return id;
@@ -40,4 +42,20 @@ public String getName() {
public void setName(String name) {
this.name = name;
}
+
+public int getApplicationId() {
+return applicationId;
+}
+
+public void setApplicationId(int applicationId) {
+this.applicationId = applicationId;
+}
+
+public String getApplicationName() {
+return applicationName;
+}
+
+public void setApplicationName(String applicationName) {
+this.applicationName = applicationName;
+}
}
diff --git
a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/ServiceNameServiceEsUIDAO.java
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/ServiceNameServiceEsUIDAO.java
index 5f7cde54d..d28846a3d 100644
---
a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/ServiceNameServiceEsUIDAO.java
+++
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/ServiceNameServiceEsUIDAO.java
@@ -83,6 +83,7 @@ public ServiceNameServiceEsUIDAO(ElasticSearchClient client) {
ServiceInfo serviceInfo = new ServiceInfo();
serviceInfo.setId(((Number)searchHit.getSource().get(ServiceNameTable.SERVICE_ID.getName())).intValue());
serviceInfo.setName((String)searchHit.getSource().get(ServiceNameTable.SERVICE_NAME.getName()));
+
serviceInfo.setApplicationId(((Number)searchHit.getSource().get(ServiceNameTable.APPLICATION_ID.getName())).intValue());
serviceInfos.add(serviceInfo);
}
return serviceInfos;
diff --git
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/ServiceNameServiceH2UIDAO.java
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/ServiceNameServiceH2UIDAO.java
index 167b8f6a8..16923f2a6 100644
---
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/ServiceNameServiceH2UIDAO.java
+++
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/ServiceNameServiceH2UIDAO.java
@@ -57,8 +57,8 @@ public ServiceNameServiceH2UIDAO(H2Client client) {
@Override
public List searchService(String keyword, int applicationId,
long startTimeMillis, int topN) {
-String dynamicSql = "select {0},{1} from {2} where {3} like ? and {4}
= ? and {5} = ? and {6} >= ? limit ?";
-String sql = SqlBuilder.buildSql(dynamicSql,
ServiceNameTable.SERVICE_ID.getName(), ServiceNameTable.SERVICE_NAME.getName(),
ServiceNameTable.TABLE, ServiceNameTable.SERVICE_NAME.getName(),
ServiceNameTable.SRC_SPAN_TYPE.getName(),
ServiceNameTable.APPLICATION_ID.getName(),
ServiceNameTable.HEARTBEAT_TIME.getName());
+String dynamicSql = "select {0},{1},{2} from {3} where {4} like ? and
{5} = ? and {6} = ? and {7} >= ? limit ?";
+String sql = SqlBuilder.buildSql(dynamicSql,
ServiceNameTable.SERVICE_ID.getName(), ServiceNameTable.SERVICE_NAME.getName(),
ServiceNameTable.APPLICATION_ID.getName(), ServiceNameTable.TABLE,
ServiceNameTable.SERVICE_NAME.getName(),
ServiceNameTable.SRC_SPAN_TYPE.getName(),
ServiceNameTable.APPLICATION_ID.getName(),
ServiceNameTable.HEARTBEAT_TIME.getName());
[GitHub] peng-yongsheng commented on issue #1335: [Collector]Hope to Add application name in service search view
peng-yongsheng commented on issue #1335: [Collector]Hope to Add application
name in service search view
URL:
https://github.com/apache/incubator-skywalking/pull/1335#issuecomment-395959409
@hanahmily UI protocol had been changed for support this issue.
```
extend type Query {
searchService(keyword: String!, applicationId: ID!, topN: Int!):
[ServiceInfo!]!
}
type ServiceInfo {
id: ID!
name: String
applicationId: ID!
applicationName: String
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #1335: [Collector]Hope to Add application name in service search view
peng-yongsheng opened a new pull request #1335: [Collector]Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/pull/1335 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [X] New feature provided - [ ] Improve performance - Related issues #1176 ___ ### New feature or improvement - Describe the details and related test reports. Add application id and code into ServiceInfo. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span
wu-sheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248#issuecomment-395958149 From the application instance id, backend knows already. No need to adjust any plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng closed issue #1124: Duplicated service search result
peng-yongsheng closed issue #1124: Duplicated service search result URL: https://github.com/apache/incubator-skywalking/issues/1124 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1124: Duplicated service search result
peng-yongsheng commented on issue #1124: Duplicated service search result URL: https://github.com/apache/incubator-skywalking/issues/1124#issuecomment-395957961 Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span
peng-yongsheng commented on issue #1248: Hope to add hostname or ip to traceSegment or span URL: https://github.com/apache/incubator-skywalking/issues/1248#issuecomment-395957872 I'm ok. Collector and UI are easy to support it. But there were so many agent plugins need to develop and test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1232: Could not find remote id
wu-sheng closed issue #1232: Could not find remote id URL: https://github.com/apache/incubator-skywalking/issues/1232 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1333: [Collector][Bug] Could not find remote id
wu-sheng closed pull request #1333: [Collector][Bug] Could not find remote id
URL: https://github.com/apache/incubator-skywalking/pull/1333
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-analysis/analysis-alarm/alarm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/alarm/provider/AnalysisAlarmModuleProvider.java
b/apm-collector/apm-collector-analysis/analysis-alarm/alarm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/alarm/provider/AnalysisAlarmModuleProvider.java
index 89df172ca..f6725e97b 100644
---
a/apm-collector/apm-collector-analysis/analysis-alarm/alarm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/alarm/provider/AnalysisAlarmModuleProvider.java
+++
b/apm-collector/apm-collector-analysis/analysis-alarm/alarm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/alarm/provider/AnalysisAlarmModuleProvider.java
@@ -85,9 +85,15 @@ private void registerRemoteData() {
RemoteDataRegisterService remoteDataRegisterService =
getManager().find(RemoteModule.NAME).getService(RemoteDataRegisterService.class);
remoteDataRegisterService.register(ApplicationAlarm.class, new
ApplicationAlarm.InstanceCreator());
remoteDataRegisterService.register(ApplicationAlarmList.class, new
ApplicationAlarmList.InstanceCreator());
+remoteDataRegisterService.register(ApplicationReferenceAlarm.class,
new ApplicationReferenceAlarm.InstanceCreator());
+
remoteDataRegisterService.register(ApplicationReferenceAlarmList.class, new
ApplicationReferenceAlarmList.InstanceCreator());
remoteDataRegisterService.register(InstanceAlarm.class, new
InstanceAlarm.InstanceCreator());
remoteDataRegisterService.register(InstanceAlarmList.class, new
InstanceAlarmList.InstanceCreator());
+remoteDataRegisterService.register(InstanceReferenceAlarm.class, new
InstanceReferenceAlarm.InstanceCreator());
+remoteDataRegisterService.register(InstanceReferenceAlarmList.class,
new InstanceReferenceAlarmList.InstanceCreator());
remoteDataRegisterService.register(ServiceAlarm.class, new
ServiceAlarm.InstanceCreator());
remoteDataRegisterService.register(ServiceAlarmList.class, new
ServiceAlarmList.InstanceCreator());
+remoteDataRegisterService.register(ServiceReferenceAlarm.class, new
ServiceReferenceAlarm.InstanceCreator());
+remoteDataRegisterService.register(ServiceReferenceAlarmList.class,
new ServiceReferenceAlarmList.InstanceCreator());
}
}
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/table/alarm/ApplicationReferenceAlarm.java
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/table/alarm/ApplicationReferenceAlarm.java
index 00705b761..8cdf2bbd4 100644
---
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/table/alarm/ApplicationReferenceAlarm.java
+++
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/table/alarm/ApplicationReferenceAlarm.java
@@ -18,10 +18,9 @@
package org.apache.skywalking.apm.collector.storage.table.alarm;
-import org.apache.skywalking.apm.collector.core.data.Column;
-import org.apache.skywalking.apm.collector.core.data.StreamData;
-import
org.apache.skywalking.apm.collector.core.data.operator.CoverMergeOperation;
-import
org.apache.skywalking.apm.collector.core.data.operator.NonMergeOperation;
+import org.apache.skywalking.apm.collector.core.data.*;
+import org.apache.skywalking.apm.collector.core.data.operator.*;
+import
org.apache.skywalking.apm.collector.remote.service.RemoteDataRegisterService;
/**
* @author peng-yongsheng
@@ -123,4 +122,10 @@ public String getAlarmContent() {
public void setAlarmContent(String alarmContent) {
setDataString(1, alarmContent);
}
+
+public static class InstanceCreator implements
RemoteDataRegisterService.RemoteDataInstanceCreator {
+@Override public RemoteData createInstance() {
+return new ApplicationReferenceAlarm();
+}
+}
}
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/table/alarm/ApplicationReferenceAlarmList.java
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/table/alarm/ApplicationReferenceAlarmList.java
index 12f981d74..61ca18168 100644
---
[GitHub] coveralls commented on issue #1333: [Collector][Bug] Could not find remote id
coveralls commented on issue #1333: [Collector][Bug] Could not find remote id URL: https://github.com/apache/incubator-skywalking/pull/1333#issuecomment-395954210 [](https://coveralls.io/builds/17404649) Coverage decreased (-0.004%) to 23.98% when pulling **b49552e9c2133ab12fcd3d307c529464cc2a04c3 on peng-yongsheng:fixed/1232** into **c2a425f55ab86367aeac4721d2281f1720c0 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liuhaoyang commented on issue #1334: [SpringMVC] after method[Index] intercept failure
liuhaoyang commented on issue #1334: [SpringMVC] after method[Index] intercept failure URL: https://github.com/apache/incubator-skywalking/issues/1334#issuecomment-395954228 looks like the same problem https://github.com/apache/incubator-skywalking/issues/682 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liuhaoyang opened a new issue #1334: [SpringMVC] after method[Index] intercept failure
liuhaoyang opened a new issue #1334: [SpringMVC] after method[Index] intercept failure URL: https://github.com/apache/incubator-skywalking/issues/1334 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? ___ ### Bug - Which version of SkyWalking, OS and JRE? SkyWalking 5.0- beta OS: OSX spring boot version :1.5.1.RELEASE - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ``` ERROR 2018-06-09 17:07:09 InstMethodsInter : class[class springclouddemo.service1.controller.MainController] after method[Index] intercept failure java.lang.NullPointerException at org.apache.skywalking.apm.plugin.spring.mvc.commons.EnhanceRequireObjectCache.getHttpServletResponse(EnhanceRequireObjectCache.java:36) at org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor.afterMethod(AbstractMethodInterceptor.java:77) at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:105) at springclouddemo.service1.controller.MainController.Index(MainController.java) at sun.reflect.GeneratedMethodAccessor46.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205) at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest$original$ZYYNYKE9(InvocableHandlerMethod.java:133) at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest$original$ZYYNYKE9$accessor$FEY8Zbxx(InvocableHandlerMethod.java) at org.springframework.web.method.support.InvocableHandlerMethod$auxiliary$ZWIB2Ibk.call(Unknown Source) at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:93) at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java) at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:116) at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827) at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738) at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85) at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:963) at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:897) at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970) at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:861) at javax.servlet.http.HttpServlet.service(HttpServlet.java:622) at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846) at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:230) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:99) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) at org.springframework.web.filter.HttpPutFormContentFilter.doFilterInternal(HttpPutFormContentFilter.java:105) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) at
[GitHub] peng-yongsheng opened a new pull request #1333: [Collector][Bug] Could not find remote id
peng-yongsheng opened a new pull request #1333: [Collector][Bug] Could not find remote id URL: https://github.com/apache/incubator-skywalking/pull/1333 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues #1232 ___ ### Bug fix - Bug description. RemoteDataMappingIdNotFoundException caused by remote entity did not registered. - How to fix? Some remote entities in alarm module did not registered into remote module. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng closed pull request #1262: Filter non-active service name when UI query.
peng-yongsheng closed pull request #1262: Filter non-active service name when
UI query.
URL: https://github.com/apache/incubator-skywalking/pull/1262
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-analysis/analysis-alarm/alarm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/alarm/provider/AnalysisAlarmModuleProvider.java
b/apm-collector/apm-collector-analysis/analysis-alarm/alarm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/alarm/provider/AnalysisAlarmModuleProvider.java
index eef4b2c67..89df172ca 100644
---
a/apm-collector/apm-collector-analysis/analysis-alarm/alarm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/alarm/provider/AnalysisAlarmModuleProvider.java
+++
b/apm-collector/apm-collector-analysis/analysis-alarm/alarm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/alarm/provider/AnalysisAlarmModuleProvider.java
@@ -19,28 +19,18 @@
package org.apache.skywalking.apm.collector.analysis.alarm.provider;
import
org.apache.skywalking.apm.collector.analysis.alarm.define.AnalysisAlarmModule;
-import
org.apache.skywalking.apm.collector.analysis.alarm.provider.worker.application.ApplicationMetricAlarmGraph;
-import
org.apache.skywalking.apm.collector.analysis.alarm.provider.worker.application.ApplicationReferenceMetricAlarmGraph;
-import
org.apache.skywalking.apm.collector.analysis.alarm.provider.worker.instance.InstanceMetricAlarmGraph;
-import
org.apache.skywalking.apm.collector.analysis.alarm.provider.worker.instance.InstanceReferenceMetricAlarmGraph;
-import
org.apache.skywalking.apm.collector.analysis.alarm.provider.worker.service.ServiceMetricAlarmGraph;
-import
org.apache.skywalking.apm.collector.analysis.alarm.provider.worker.service.ServiceReferenceMetricAlarmGraph;
+import
org.apache.skywalking.apm.collector.analysis.alarm.provider.worker.application.*;
+import
org.apache.skywalking.apm.collector.analysis.alarm.provider.worker.instance.*;
+import
org.apache.skywalking.apm.collector.analysis.alarm.provider.worker.service.*;
import
org.apache.skywalking.apm.collector.analysis.metric.define.AnalysisMetricModule;
import
org.apache.skywalking.apm.collector.analysis.worker.model.base.WorkerCreateListener;
import
org.apache.skywalking.apm.collector.analysis.worker.timer.PersistenceTimer;
import org.apache.skywalking.apm.collector.configuration.ConfigurationModule;
-import org.apache.skywalking.apm.collector.core.module.ModuleDefine;
-import org.apache.skywalking.apm.collector.core.module.ModuleConfig;
-import org.apache.skywalking.apm.collector.core.module.ModuleProvider;
+import org.apache.skywalking.apm.collector.core.module.*;
import org.apache.skywalking.apm.collector.remote.RemoteModule;
import
org.apache.skywalking.apm.collector.remote.service.RemoteDataRegisterService;
import org.apache.skywalking.apm.collector.storage.StorageModule;
-import
org.apache.skywalking.apm.collector.storage.table.alarm.ApplicationAlarm;
-import
org.apache.skywalking.apm.collector.storage.table.alarm.ApplicationAlarmList;
-import org.apache.skywalking.apm.collector.storage.table.alarm.InstanceAlarm;
-import
org.apache.skywalking.apm.collector.storage.table.alarm.InstanceAlarmList;
-import org.apache.skywalking.apm.collector.storage.table.alarm.ServiceAlarm;
-import
org.apache.skywalking.apm.collector.storage.table.alarm.ServiceAlarmList;
+import org.apache.skywalking.apm.collector.storage.table.alarm.*;
/**
* @author peng-yongsheng
@@ -72,23 +62,12 @@ public AnalysisAlarmModuleProvider() {
@Override public void start() {
WorkerCreateListener workerCreateListener = new WorkerCreateListener();
-ServiceMetricAlarmGraph serviceMetricAlarmGraph = new
ServiceMetricAlarmGraph(getManager(), workerCreateListener);
-serviceMetricAlarmGraph.create();
-
-InstanceMetricAlarmGraph instanceMetricAlarmGraph = new
InstanceMetricAlarmGraph(getManager(), workerCreateListener);
-instanceMetricAlarmGraph.create();
-
-ApplicationMetricAlarmGraph applicationMetricAlarmGraph = new
ApplicationMetricAlarmGraph(getManager(), workerCreateListener);
-applicationMetricAlarmGraph.create();
-
-ServiceReferenceMetricAlarmGraph serviceReferenceMetricAlarmGraph =
new ServiceReferenceMetricAlarmGraph(getManager(), workerCreateListener);
-serviceReferenceMetricAlarmGraph.create();
-
-InstanceReferenceMetricAlarmGraph instanceReferenceMetricAlarmGraph =
new InstanceReferenceMetricAlarmGraph(getManager(), workerCreateListener);
-instanceReferenceMetricAlarmGraph.create();
-
-ApplicationReferenceMetricAlarmGraph
applicationReferenceMetricAlarmGraph = new
[GitHub] wu-sheng commented on issue #1322: Add Client version when agent register instance
wu-sheng commented on issue #1322: Add Client version when agent register instance URL: https://github.com/apache/incubator-skywalking/issues/1322#issuecomment-395950971 > User will hardly to find which agent version is different from each others. Agree. That is why I ask for a new page for showing all agent info with group strategy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1262: Filter non-active service name when UI query.
coveralls commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-391712845 [](https://coveralls.io/builds/17404375) Coverage decreased (-0.04%) to 23.984% when pulling **1a0f08f6f36c9f07bfa3f49f63f774be0efd5ea7 on peng-yongsheng:feature/1124** into **a6d9a605ed266a70286423ca241934038bca2b61 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1322: Add Client version when agent register instance
peng-yongsheng commented on issue #1322: Add Client version when agent register instance URL: https://github.com/apache/incubator-skywalking/issues/1322#issuecomment-395950147 > Show in `Running Server` page I propose recall why show agent version to user? what problem need to by solved? The keywords ` hundreds of applications` in your description. User will hardly to find which agent version is different from each others. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor
coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395941131 [](https://coveralls.io/builds/17403964) Coverage decreased (-0.02%) to 24.005% when pulling **0455cb9d12cb856646c11900a2b00d92de94559d on ascrutae:fix/modify-tomcat-buried-point** into **a6d9a605ed266a70286423ca241934038bca2b61 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
