coveralls edited a comment on issue #2605: Support span#error in toolkit
URL: https://github.com/apache/skywalking/pull/2605#issuecomment-489544752
[](https://coveralls.io/builds/23227881)
Coverage increased (+0.06%)
wu-sheng commented on issue #2617: Topology node type error
URL: https://github.com/apache/skywalking/issues/2617#issuecomment-489915393
Then? Why sort affect the result?
This is an automated message from the Apache Git
wu-sheng commented on issue #2587: Support database sql statement parameter
value(optional)
URL: https://github.com/apache/skywalking/issues/2587#issuecomment-489915229
I don't know anything about eclipse, I am an IntelliJ Fun :P
wu-sheng commented on issue #2619: Clean up unnecessary times(1) for test verify
URL: https://github.com/apache/skywalking/pull/2619#issuecomment-489912457
> ./mvnw package
This includes style check. Or import the style file into IDE.
SataQiu edited a comment on issue #2619: Clean up unnecessary times(1) for test
verify
URL: https://github.com/apache/skywalking/pull/2619#issuecomment-489909156
When I run `./mvnw validate`, some errors occur:
```
[ERROR] Failed to execute goal on project apm-agent-core: Could not
SataQiu edited a comment on issue #2619: Clean up unnecessary times(1) for test
verify
URL: https://github.com/apache/skywalking/pull/2619#issuecomment-489909156
When I run `./mvnw validate`, some errors occurs:
```
[ERROR] Failed to execute goal on project apm-agent-core: Could not
SataQiu commented on issue #2619: Clean up unnecessary times(1) for test verify
URL: https://github.com/apache/skywalking/pull/2619#issuecomment-489909156
When I run `./mvnw validate`, some errors occurs:
```
[ERROR] Failed to execute goal on project apm-agent-core: Could not resolve
wu-sheng merged pull request #2618: sync-ui
URL: https://github.com/apache/skywalking/pull/2618
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 8f73159 sync-ui (#2618)
8f73159 is
vision-ken edited a comment on issue #2587: Support database sql statement
parameter value(optional)
URL: https://github.com/apache/skywalking/issues/2587#issuecomment-489904505
Follow
[How-to-build](https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-build.md)
:
vision-ken edited a comment on issue #2587: Support database sql statement
parameter value(optional)
URL: https://github.com/apache/skywalking/issues/2587#issuecomment-489904505
Follow
[How-to-build](https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-build.md)
:
mbao commented on issue #2617: Topology node type error
URL: https://github.com/apache/skywalking/issues/2617#issuecomment-489904415
> What do you mean a large start? I am not following.
When using Mysql, serviceRelationServerCalls is sorted by entity_id as a
result of group by.
vision-ken commented on issue #2587: Support database sql statement parameter
value(optional)
URL: https://github.com/apache/skywalking/issues/2587#issuecomment-489904505
Follow
[How-to-build](https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-build.md)
:
```
coveralls edited a comment on issue #2605: Support span#error in toolkit
URL: https://github.com/apache/skywalking/pull/2605#issuecomment-489544752
[](https://coveralls.io/builds/23227183)
Coverage increased (+0.04%)
coveralls edited a comment on issue #2618: sync-ui
URL: https://github.com/apache/skywalking/pull/2618#issuecomment-489901419
[](https://coveralls.io/builds/23227033)
Coverage remained the same at 16.395% when pulling
zhaoyuguang commented on issue #2616: lettuce thorw npe
URL: https://github.com/apache/skywalking/issues/2616#issuecomment-489901695
@wu-sheng @IanCao Let me fix it, now I have revived the problem.
This is an automated
coveralls commented on issue #2618: sync-ui
URL: https://github.com/apache/skywalking/pull/2618#issuecomment-489901419
[](https://coveralls.io/builds/23227041)
Coverage decreased (-0.002%) to 16.393% when pulling
coveralls commented on issue #2618: sync-ui
URL: https://github.com/apache/skywalking/pull/2618#issuecomment-489901416
[](https://coveralls.io/builds/23227041)
Coverage decreased (-0.002%) to 16.393% when pulling
IanCao commented on issue #2616: lettuce thorw npe
URL: https://github.com/apache/skywalking/issues/2616#issuecomment-489900591
@Allen0710 could you upload the error stack picture and more infomation you
can get..It will help me to solve it quickly. not just code..
coveralls edited a comment on issue #1934: Provide plugin for ShardingSphere
URL: https://github.com/apache/skywalking/pull/1934#issuecomment-439763210
[](https://coveralls.io/builds/23226984)
Coverage increased
SataQiu opened a new pull request #2619: Clean up unnecessary times(1) for test
verify
URL: https://github.com/apache/skywalking/pull/2619
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
-
IanCao commented on issue #2605: Support span#error in toolkit
URL: https://github.com/apache/skywalking/pull/2605#issuecomment-489899463
@wu-sheng please review
This is an automated message from the Apache Git Service.
To
shiluo34 opened a new pull request #2618: sync-ui
URL: https://github.com/apache/skywalking/pull/2618
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
-
coveralls edited a comment on issue #1934: Provide plugin for ShardingSphere
URL: https://github.com/apache/skywalking/pull/1934#issuecomment-439763210
[](https://coveralls.io/builds/23226795)
Coverage increased
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 1f39b19 fix some spelling mistakes
wu-sheng merged pull request #2615: Fix some spelling mistakes
URL: https://github.com/apache/skywalking/pull/2615
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
coveralls edited a comment on issue #2615: Fix some spelling mistakes
URL: https://github.com/apache/skywalking/pull/2615#issuecomment-489894638
[](https://coveralls.io/builds/23226738)
Coverage decreased (-0.002%) to
wu-sheng commented on issue #2617: Topology node type error
URL: https://github.com/apache/skywalking/issues/2617#issuecomment-489895177
What do you mean a large start? I am not following.
This is an automated message from
wu-sheng commented on issue #2570: Fixed the EnvUtilTest to be compatible with
Windows OS and OpenJDK
URL: https://github.com/apache/skywalking/pull/2570#issuecomment-489894795
Fixed in #2593
This is an automated message
wu-sheng closed pull request #2570: Fixed the EnvUtilTest to be compatible with
Windows OS and OpenJDK
URL: https://github.com/apache/skywalking/pull/2570
This is an automated message from the Apache Git Service.
To respond
coveralls commented on issue #2615: Fix some spelling mistakes
URL: https://github.com/apache/skywalking/pull/2615#issuecomment-489894636
[](https://coveralls.io/builds/23226712)
Coverage increased (+0.007%) to
coveralls commented on issue #2615: Fix some spelling mistakes
URL: https://github.com/apache/skywalking/pull/2615#issuecomment-489894638
[](https://coveralls.io/builds/23226712)
Coverage increased (+0.007%) to
mbao opened a new issue #2617: Topology node type error
URL: https://github.com/apache/skywalking/issues/2617
- Why do you submit this issue?
- [ ] Bug
___
### Bug
- Which version of SkyWalking, OS and JRE?
SkyWalking 6.0.0 .
OS centos6
JRE . 8
- Which
coveralls edited a comment on issue #1934: Provide plugin for ShardingSphere
URL: https://github.com/apache/skywalking/pull/1934#issuecomment-439763210
[](https://coveralls.io/builds/23226636)
Coverage increased
WinsonOne commented on issue #2614: dashboard page data
URL: https://github.com/apache/skywalking/issues/2614#issuecomment-489892611
thx
This is an automated message from the Apache Git Service.
To respond to the message,
Allen0710 opened a new issue #2616: lettuce thorw npe
URL: https://github.com/apache/skywalking/issues/2616
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [1 ] Bug
- [ ] Requirement
- [ ] Feature
wu-sheng merged pull request #2612: Remove the unused class loader.
URL: https://github.com/apache/skywalking/pull/2612
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wu-sheng commented on issue #2614: dashboard page data
URL: https://github.com/apache/skywalking/issues/2614#issuecomment-489890529
Check your ElasticSearch and OAP server, whether they have a performance
issue.
This is an
wu-sheng closed issue #2614: dashboard page data
URL: https://github.com/apache/skywalking/issues/2614
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
wu-sheng closed pull request #2613: Shall not use * for static import.
URL: https://github.com/apache/skywalking/pull/2613
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SataQiu opened a new pull request #2615: Fix some spelling mistakes
URL: https://github.com/apache/skywalking/pull/2615
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 4de1fe5 Remove the unused class loader.
coveralls edited a comment on issue #2612: Remove the unused class loader.
URL: https://github.com/apache/skywalking/pull/2612#issuecomment-489884828
[](https://coveralls.io/builds/23226390)
Coverage decreased
wu-sheng commented on issue #2613: Shall not use * for static import.
URL: https://github.com/apache/skywalking/pull/2613#issuecomment-489888143
We can't make sure whether this change will be undone if someone prefers
another way :) If we want to set one way, we need to change style and
coveralls edited a comment on issue #2570: Fixed the EnvUtilTest to be
compatible with Windows OS and OpenJDK
URL: https://github.com/apache/skywalking/pull/2570#issuecomment-488307587
[](https://coveralls.io/builds/23226308)
Coverage remained the same at
wayilau commented on issue #2613: Shall not use * for static import.
URL: https://github.com/apache/skywalking/pull/2613#issuecomment-489886337
> We don't set this rule. If you want to add a new rule, please explain why.
static import is useful to reduce our coding. bug sometime it is
coveralls commented on issue #2612: Remove the unused class loader.
URL: https://github.com/apache/skywalking/pull/2612#issuecomment-489884828
[](https://coveralls.io/builds/23226151)
Coverage remained the same at
liuhaoyang merged pull request #2593: Using PowerMockito to mock System.getent;
URL: https://github.com/apache/skywalking/pull/2593
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
liuhaoyangzz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 16103c6 Using PowerMockito to mock
wu-sheng commented on issue #2613: Shall not use * for static import.
URL: https://github.com/apache/skywalking/pull/2613#issuecomment-489883101
Right now, we are very flexible in most coding styling things, as long as it
doesn't affect the performance and readable, at least I am good for
coveralls edited a comment on issue #2593: Using PowerMockito to mock
System.getent;
URL: https://github.com/apache/skywalking/pull/2593#issuecomment-489438797
[](https://coveralls.io/builds/23226100)
Coverage
wu-sheng commented on issue #2613: Shall not use * for static import.
URL: https://github.com/apache/skywalking/pull/2613#issuecomment-489882473
We don't set this rule. If you want to add a new rule, please explain why.
This
coveralls edited a comment on issue #2593: Using PowerMockito to mock
System.getent;
URL: https://github.com/apache/skywalking/pull/2593#issuecomment-489438797
[](https://coveralls.io/builds/23226052)
Coverage
wayilau opened a new pull request #2613: Shall not use * for static import.
URL: https://github.com/apache/skywalking/pull/2613
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve
wayilau opened a new pull request #2612: Remove the unused class loader.
URL: https://github.com/apache/skywalking/pull/2612
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [x] Improve
wu-sheng commented on issue #2611: skywalking是否兼容springCloud gateway
URL: https://github.com/apache/skywalking/issues/2611#issuecomment-489873891
English only. And thank @SataQiu to point the right one.
This is an automated
wu-sheng closed issue #2611: skywalking是否兼容springCloud gateway
URL: https://github.com/apache/skywalking/issues/2611
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SataQiu commented on issue #2611: skywalking是否兼容springCloud gateway
URL: https://github.com/apache/skywalking/issues/2611#issuecomment-489873720
Ref: https://github.com/apache/skywalking/pull/2517
This is an automated
gaofeng36599 opened a new issue #2611: skywalking是否兼容springCloud gateway
URL: https://github.com/apache/skywalking/issues/2611
我想用skywalking监控网关，出现了问题。
我的网关用的是springboot+springCloud gateway，添加上探针agent后，skywalking报错如下图。
因为我所有的调用都是通过网关做的转发，所以系统整个链路能有网关的信息，烦请各位老师解答下。
DEBUG
coveralls edited a comment on issue #2593: Using PowerMockito to mock
System.getent;
URL: https://github.com/apache/skywalking/pull/2593#issuecomment-489438797
[](https://coveralls.io/builds/23225566)
Coverage
wu-sheng merged pull request #2574: fix docker elasticsearch and oap host
URL: https://github.com/apache/skywalking/pull/2574
This is an automated message from the Apache Git Service.
To respond to the message, please log on
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 4e71085 fix docker elasticsearch and oap
coveralls edited a comment on issue #2574: fix docker elasticsearch and oap host
URL: https://github.com/apache/skywalking/pull/2574#issuecomment-489298977
[](https://coveralls.io/builds/23224812)
Coverage remained
wu-sheng merged pull request #2608: fix webflux cast exception.
URL: https://github.com/apache/skywalking/pull/2608
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
coveralls edited a comment on issue #2608: fix webflux cast exception.
URL: https://github.com/apache/skywalking/pull/2608#issuecomment-489573054
[](https://coveralls.io/builds/23224358)
Coverage remained the same at
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new ea347b8 fix webflux cast exception.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch fix_webflux
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
was d5bdb50 Merge branch 'master' into fix_webflux
The revisions that were on this branch are still
coveralls edited a comment on issue #2574: fix docker elasticsearch and oap host
URL: https://github.com/apache/skywalking/pull/2574#issuecomment-489298977
[](https://coveralls.io/builds/23223975)
Coverage increased
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch fix_webflux
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from e244a60 Merge branch 'master' into fix_webflux
add 12f9991 Add documents for timezone and ttl
coveralls edited a comment on issue #2608: fix webflux cast exception.
URL: https://github.com/apache/skywalking/pull/2608#issuecomment-489573054
[](https://coveralls.io/builds/23223971)
Coverage increased (+0.002%)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch tz
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
was 4d13474 Merge branch 'master' into tz
The revisions that were on this branch are still contained in
other
wu-sheng merged pull request #2607: Add documents for timezone and ttl
URL: https://github.com/apache/skywalking/pull/2607
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 12f9991 Add documents for timezone and
This is an automated email from the ASF dual-hosted git repository.
zhangxin pushed a change to branch fix_webflux
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 534b8dd revert status interceptor.
add b1b11e7 Add appveyor config (#2609)
add e244a60 Merge
coveralls edited a comment on issue #2607: Add documents for timezone and ttl
URL: https://github.com/apache/skywalking/pull/2607#issuecomment-489558635
[](https://coveralls.io/builds/23215035)
Coverage increased
zhaoyuguang edited a comment on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489672272
> You could try, I just bring Xin in the loop, he needs to review after you
done.
>
> Try not to make pr too big, that is
zhaoyuguang edited a comment on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489670411
> > I think it's best to separate reactor-netty, webflux, and gateway.
>
> If you can do this, I think it is a good idea. If you
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489672272
> > I think it's best to separate reactor-netty, webflux, and gateway.
>
> If you can do this, I think it is a good idea. If you could
wu-sheng commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489671851
You could try, I just bring Xin in the loop, he needs to review after you
done.
Try not to make pr too big, that is helpful.
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489670411
> > I think it's best to separate reactor-netty, webflux, and gateway.
>
> If you can do this, I think it is a good idea. If you could
coveralls edited a comment on issue #2593: Using PowerMockito to mock
System.getent;
URL: https://github.com/apache/skywalking/pull/2593#issuecomment-489438797
[](https://coveralls.io/builds/23214705)
Coverage
wu-sheng commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489666729
> I think it's best to separate reactor-netty, webflux, and gateway.
If you can do this, I think it is a good idea. If you could separate
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489664577
> @zhaoyuguang Is this plugin too complex and conflict with other plugins?
If so, let's discuss how to do it first. I noticed this PR is still
wu-sheng commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489662468
@zhaoyuguang Is this plugin too complex and conflict with other plugins? If
so, let's discuss how to do it first. I noticed this PR is still not
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489661461
> In my opinion, this plugin could be split into two plugins: reactor netty
http plugin + spring cloud gateway plugin?
This also relate
This is an automated email from the ASF dual-hosted git repository.
pengys pushed a change to branch tz
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 147711b Merge branch 'master' into tz
add b1b11e7 Add appveyor config (#2609)
add 4d13474 Merge branch
coveralls edited a comment on issue #2607: Add documents for timezone and ttl
URL: https://github.com/apache/skywalking/pull/2607#issuecomment-489558635
[](https://coveralls.io/builds/23214033)
Coverage remained the
wu-sheng commented on issue #2593: Using PowerMockito to mock System.getent;
URL: https://github.com/apache/skywalking/pull/2593#issuecomment-489652402
I have sync your branch, you should have it now.
This is an automated
wu-sheng commented on issue #2593: Using PowerMockito to mock System.getent;
URL: https://github.com/apache/skywalking/pull/2593#issuecomment-489652269
@flycash The appveyor setting file has been merged. Could you open the test
in your PR, and let's wait it pass.
wu-sheng merged pull request #2609: Add windows compile support
URL: https://github.com/apache/skywalking/pull/2609
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new b1b11e7 Add appveyor config (#2609)
This is an automated email from the ASF dual-hosted git repository.
pengys pushed a change to branch tz
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 36092e9 Merge branch 'master' into tz
add b973996 Customizing the management endpoint paths (#2598)
add
coveralls commented on issue #2609: Add windows compile support
URL: https://github.com/apache/skywalking/pull/2609#issuecomment-489640435
[](https://coveralls.io/builds/23212867)
Coverage decreased (-0.002%) to
liuhaoyang opened a new pull request #2609: Add windows compile support
URL: https://github.com/apache/skywalking/pull/2609
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve
IanCao commented on a change in pull request #2605: Support span#error in
toolkit
URL: https://github.com/apache/skywalking/pull/2605#discussion_r281185919
##
File path:
IanCao commented on a change in pull request #2605: Support span#error in
toolkit
URL: https://github.com/apache/skywalking/pull/2605#discussion_r281185985
##
File path:
apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/ActiveSpan.java
IanCao commented on a change in pull request #2605: Support span#error in
toolkit
URL: https://github.com/apache/skywalking/pull/2605#discussion_r281186051
##
File path:
apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/ActiveSpan.java
coveralls edited a comment on issue #2608: fix webflux cast exception.
URL: https://github.com/apache/skywalking/pull/2608#issuecomment-489573054
[](https://coveralls.io/builds/23211828)
Coverage remained the same at
1 - 100 of 193 matches
Mail list logo
