This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 5f420bf Fix service instance relationship ID build bug. (#4075)
add b4ed399 Fix typo. (#4076)
No new
wu-sheng merged pull request #4076: Fix typo.
URL: https://github.com/apache/skywalking/pull/4076
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
codecov-io edited a comment on issue #4076: Fix typo.
URL: https://github.com/apache/skywalking/pull/4076#issuecomment-566406908
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4076?src=pr=h1)
Report
> Merging
codecov-io commented on issue #4076: Fix typo.
URL: https://github.com/apache/skywalking/pull/4076#issuecomment-566406908
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4076?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master@5f420bf`).
wayilau commented on issue #4076: Fix typo.
URL: https://github.com/apache/skywalking/pull/4076#issuecomment-566405689
> We can't, as ASF don't give the permission.
i got it.
This is an automated message from the
wu-sheng commented on issue #4076: Fix typo.
URL: https://github.com/apache/skywalking/pull/4076#issuecomment-566405388
We can't, as ASF don't give the permission.
This is an automated message from the Apache Git Service.
To
wayilau commented on issue #4076: Fix typo.
URL: https://github.com/apache/skywalking/pull/4076#issuecomment-566400995
> Please select label and milestone next time, as you are a committee
already.
OK, I will.
wu-sheng commented on issue #4076: Fix typo.
URL: https://github.com/apache/skywalking/pull/4076#issuecomment-566400639
Please select label and milestone next time, as you are a committee already.
This is an automated message
wayilau commented on issue #4076: Fix typo.
URL: https://github.com/apache/skywalking/pull/4076#issuecomment-566399315
A question, i just modify doc, I think it needs not run all the ci cases.
May be we can use github api to customize our favoriate action. We may have our
test-infra.
wu-sheng merged pull request #4075: Fix service instance relationship ID build
bug.
URL: https://github.com/apache/skywalking/pull/4075
This is an automated message from the Apache Git Service.
To respond to the message,
wayilau opened a new pull request #4076: Fix typo.
URL: https://github.com/apache/skywalking/pull/4076
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- [x]
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from bc77fda Enhance webflux plugin, related to Spring Gateway plugin too.
(#3945)
add 5f420bf Fix service
codecov-io edited a comment on issue #4075: Fix service instance relationship
ID build bug.
URL: https://github.com/apache/skywalking/pull/4075#issuecomment-566392400
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4075?src=pr=h1)
Report
> Merging
codecov-io commented on issue #4075: Fix service instance relationship ID build
bug.
URL: https://github.com/apache/skywalking/pull/4075#issuecomment-566392400
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4075?src=pr=h1)
Report
> Merging
wu-sheng commented on a change in pull request #4075: Fix service instance
relationship ID build bug.
URL: https://github.com/apache/skywalking/pull/4075#discussion_r358604707
##
File path:
wu-sheng commented on a change in pull request #4075: Fix service instance
relationship ID build bug.
URL: https://github.com/apache/skywalking/pull/4075#discussion_r358605026
##
File path:
wu-sheng commented on a change in pull request #4075: Fix service instance
relationship ID build bug.
URL: https://github.com/apache/skywalking/pull/4075#discussion_r358604707
##
File path:
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch instance-rela-id-bug
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 5d4e308 Fix service instance ID build bug.
add 2937f23 Add instance ids into the relation
wu-sheng commented on issue #4047: Modify query SQL for MySQLDAO
URL: https://github.com/apache/skywalking/pull/4047#issuecomment-566382894
@tristaZero Same as @kezhenxu94 's comments. Ignore all jenkins jobs.
SkyWalking has moved in GitHub Action now.
wu-sheng commented on issue #4075: Fix service instance relationship ID build
bug.
URL: https://github.com/apache/skywalking/pull/4075#issuecomment-566382438
FYI @kezhenxu94 @JaredTan95
This is an automated message from the
wu-sheng opened a new pull request #4075: Fix service instance relationship ID
build bug.
URL: https://github.com/apache/skywalking/pull/4075
The existing and unused logic of service instance relationship ID includes
the component ID, which is not suitable for today's topology logic. But
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch instance-rela-id-bug
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 5d4e308b4e8ffb0b3f199edba3968f3969e172b2
Author: Wu Sheng
AuthorDate: Tue Dec 17 13:01:09 2019 +0800
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch instance-rela-id-bug
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 5d4e308 Fix service instance ID build bug.
This branch includes the following new commits:
kezhenxu94 commented on issue #4073: apollo configuration is not working?
URL: https://github.com/apache/skywalking/issues/4073#issuecomment-566381430
@sinoryan not all config items in `application.yml` are dynamically
configurable, check the documentation first, your efforts should not be
kezhenxu94 commented on issue #4047: Modify query SQL for MySQLDAO
URL: https://github.com/apache/skywalking/pull/4047#issuecomment-566380643
> @wu-sheng Hi, i read the error log, however the error context confused me
and i am not sure whether my code changes caused those exception:
>
sinoryan commented on issue #4073: apollo configuration is not working?
URL: https://github.com/apache/skywalking/issues/4073#issuecomment-566372944
> @sinoryan what are your configurations in Apollo, can you share some of
them? Or you can test with the Apollo Demo environment (remember
tristaZero commented on issue #4047: Modify query SQL for MySQLDAO
URL: https://github.com/apache/skywalking/pull/4047#issuecomment-566368271
It's a problem of code styple? I tried to load codeStyple.xml in root path,
but IDEA told me something like ,
```
tristaZero edited a comment on issue #4047: Modify query SQL for MySQLDAO
URL: https://github.com/apache/skywalking/pull/4047#issuecomment-566366879
@wu-sheng Hi, i read the error log, however the error context confused me
and i am not sure whether my code changes caused those exception:
tristaZero commented on issue #4047: Modify query SQL for MySQLDAO
URL: https://github.com/apache/skywalking/pull/4047#issuecomment-566366879
@wu-sheng Hi, i read the error log, however the error context confused me
and i am not sure those my code changes caused those exception:
```
wayilau closed issue #4069: agent.config yaml format ?
URL: https://github.com/apache/skywalking/issues/4069
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wayilau commented on issue #4069: agent.config yaml format ?
URL: https://github.com/apache/skywalking/issues/4069#issuecomment-566348207
Actually, From a technical perspective,I agree with you. Maybe my point just
from a user's mind.
wu-sheng closed issue #2711: Provide plugin for spring-cloud-gateway 2.0.x
URL: https://github.com/apache/skywalking/issues/2711
This is an automated message from the Apache Git Service.
To respond to the message, please log
wu-sheng closed issue #3985: skywalking springcloud gateway plugin not suppot
springcloud greenwish sr4
URL: https://github.com/apache/skywalking/issues/3985
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new bc77fda Enhance webflux plugin, related
wu-sheng closed issue #3805: The webflux-plugin is not working properly
URL: https://github.com/apache/skywalking/issues/3805
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wu-sheng merged pull request #3945: Enhance webflux plugin, related to Spring
Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945
This is an automated message from the Apache Git Service.
To respond to
codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to
Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=h1)
Report
> Merging
wu-sheng merged pull request #4067: [Feature] Add Java agent plugin for Jdk
Threading classes
URL: https://github.com/apache/skywalking/pull/4067
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 3f48790 [Feature] Add Java agent plugin
arugal commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358279488
##
File path:
wu-sheng commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358289028
##
File path:
arugal commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358279488
##
File path:
codecov-io edited a comment on issue #4067: [Feature] Add Java agent plugin for
Jdk Threading classes
URL: https://github.com/apache/skywalking/pull/4067#issuecomment-565802710
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4067?src=pr=h1)
Report
> Merging
kezhenxu94 commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358268427
##
File path:
wu-sheng commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358258793
##
File path:
wu-sheng commented on issue #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#issuecomment-566081628
@JaredTan95 Please take care of #3752
This is an automated message from the Apache Git
wu-sheng merged pull request #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new a6d0366 support min function. (#4072)
codecov-io edited a comment on issue #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#issuecomment-566009941
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4072?src=pr=h1)
Report
> Merging
cyejing commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358242427
##
File path:
codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to
Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=h1)
Report
> Merging
cyejing commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358242427
##
File path:
kezhenxu94 commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358239670
##
File path:
arugal commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358225629
##
File path:
codecov-io edited a comment on issue #4067: [Feature] Add Java agent plugin for
Jdk Threading classes
URL: https://github.com/apache/skywalking/pull/4067#issuecomment-565802710
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4067?src=pr=h1)
Report
> Merging
kezhenxu94 merged pull request #4074: [CI] Add IT/E2E check statuses to index
page
URL: https://github.com/apache/skywalking/pull/4074
This is an automated message from the Apache Git Service.
To respond to the message,
codecov-io commented on issue #4074: [CI] Add IT/E2E check statuses to index
page
URL: https://github.com/apache/skywalking/pull/4074#issuecomment-566051620
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4074?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #4074: [CI] Add IT/E2E check statuses to index page
URL: https://github.com/apache/skywalking/pull/4074#issuecomment-566039825
I could receive some mails when builds fail.
This is an automated
kezhenxu94 opened a new pull request #4074: [CI] Add IT/E2E check statuses to
index page
URL: https://github.com/apache/skywalking/pull/4074
I happened to find that several builds on master has failed and just re-run
them, this patch exposes the check statues in the main page to make them
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch kezhenxu94-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 468239656fa366a94b9abe54630b922a19659d8f
Author: kezhenxu94
AuthorDate: Mon Dec 16 20:13:46 2019
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch kezhenxu94-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 4682396 [CI] Add IT/E2E check statuses to index page
This branch includes the following new
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch min_func
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 2d62011 fix logical bug and update test case.
add 6793aef the same here.
No new revisions were added
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring
Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-566030836
> Hi @cyejing, there are [update
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch min_func
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from ad2ce51 support min function.
add 2d62011 fix logical bug and update test case.
No new revisions were
JaredTan95 commented on a change in pull request #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#discussion_r358193224
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/MinLongMetrics.java
kezhenxu94 commented on issue #4073: apollo configuration is not working?
URL: https://github.com/apache/skywalking/issues/4073#issuecomment-566021150
Apollo Demo Environment: http://106.54.227.205/config.html?#/appid=skywalking
kezhenxu94 closed issue #4073: apollo configuration is not working?
URL: https://github.com/apache/skywalking/issues/4073
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kezhenxu94 commented on issue #4073: apollo configuration is not working?
URL: https://github.com/apache/skywalking/issues/4073#issuecomment-566021014
@sinoryan what are your configurations in Apollo, can you share some of
them? Or you can test with the Apollo Demo environment (remember
arugal edited a comment on issue #3945: Enhance webflux plugin, related to
Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-566014071
Hi @cyejing, there are [update
sinoryan opened a new issue #4073: apollo configuration is not working?
URL: https://github.com/apache/skywalking/issues/4073
### Question
- apollo configuration is not working?
- Which version of SkyWalking, OS and JRE?
6.5.0/ jdk1.8 / es7.5
- What happen?
First: my
arugal commented on issue #3945: Enhance webflux plugin, related to Spring
Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-566014071
Hi @cyejing, there are update submodule in this PR, please recheck.
kezhenxu94 commented on a change in pull request #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#discussion_r358170753
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/MinLongMetrics.java
kezhenxu94 commented on a change in pull request #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#discussion_r358168758
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/MinLongMetrics.java
kezhenxu94 commented on a change in pull request #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#discussion_r358168146
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/MinLongMetrics.java
codecov-io commented on issue #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#issuecomment-566009941
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4072?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to
Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=h1)
Report
> Merging
This is an automated email from the ASF dual-hosted git repository.
innerpeacez pushed a change to tag v1.0.0
in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git.
at cbb2600 (commit)
No new revisions were added by this update.
JaredTan95 commented on issue #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#issuecomment-565991589
Yeah, and we also got `endpoint_latency_max` metrics by `Max` function, but
found there is no `Min` function.
wu-sheng commented on issue #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#issuecomment-565990435
Interesting, but make sense in some cases.
This is an automated message from the Apache Git
JaredTan95 commented on issue #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#issuecomment-565990059
> First, could you share why adding this func?
simplely want to aggregation some metrics as follows:
```shell
service_latency_min =
wu-sheng commented on issue #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072#issuecomment-565988403
First, could you share why adding this func?
This is an automated message from the Apache
JaredTan95 opened a new pull request #4072: support min function.
URL: https://github.com/apache/skywalking/pull/4072
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a commit to branch min_func
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit ad2ce51a2975b6459d7bac4cd10eceef9c2bb87c
Author: JaredTan95
AuthorDate: Mon Dec 16 17:45:13 2019 +0800
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch min_func
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at ad2ce51 support min function.
This branch includes the following new commits:
new ad2ce51 support
wu-sheng merged pull request #33: makefile update
URL: https://github.com/apache/skywalking-kubernetes/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git
The following commit(s) were added to refs/heads/master by this push:
new eb75171 makefile update
innerpeacez opened a new pull request #33: makefile update
URL: https://github.com/apache/skywalking-kubernetes/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring
Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565983869
ok, I adjust the code.
This is an automated message
zhaoyuguang commented on issue #3945: Enhance webflux plugin, related to Spring
Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565980907
Except my code review comment, This pr is LGTM
codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to
Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to
Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr=h1)
Report
> Merging
wu-sheng commented on a change in pull request #3945: Enhance webflux plugin,
related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358115858
##
File path:
zhaoyuguang commented on a change in pull request #3945: Enhance webflux
plugin, related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358113945
##
File path:
zhaoyuguang commented on a change in pull request #3945: Enhance webflux
plugin, related to Spring Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#discussion_r358109254
##
File path:
wu-sheng commented on a change in pull request #4007: spring @Bean annotation
was annotation to the method.
URL: https://github.com/apache/skywalking/pull/4007#discussion_r358105901
##
File path:
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git
The following commit(s) were added to refs/heads/master by this push:
new 2685f77 makefile
new
wu-sheng merged pull request #32: makefile
URL: https://github.com/apache/skywalking-kubernetes/pull/32
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
wu-sheng commented on issue #3945: Enhance webflux plugin, related to Spring
Gateway plugin too.
URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565958483
@zhaoyuguang Could you take a look?
This is an
innerpeacez opened a new pull request #32: makefile
URL: https://github.com/apache/skywalking-kubernetes/pull/32
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wu-sheng commented on a change in pull request #4007: spring @Bean annotation
was annotation to the method.
URL: https://github.com/apache/skywalking/pull/4007#discussion_r358099933
##
File path:
1 - 100 of 101 matches
Mail list logo
