[GitHub] [skywalking] codecov-io commented on issue #4374: [test/plugin] remove the image on docker exit

2020-02-16 Thread GitBox
codecov-io commented on issue #4374: [test/plugin] remove the image on docker exit URL: https://github.com/apache/skywalking/pull/4374#issuecomment-586856227 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr=h1) Report > Merging

[GitHub] [skywalking] wayilau commented on issue #4373: [SWCK] Initiate Backend Operator

2020-02-16 Thread GitBox
wayilau commented on issue #4373: [SWCK] Initiate Backend Operator URL: https://github.com/apache/skywalking/issues/4373#issuecomment-586837716 This is a great job. @Gao Hongtao From: Gao Hongtao Reply-To: apache/skywalking Date: Monday,

[GitHub] [skywalking] hanahmily commented on issue #4373: [SWCK] Initiate Backend Operator

2020-02-16 Thread GitBox
hanahmily commented on issue #4373: [SWCK] Initiate Backend Operator URL: https://github.com/apache/skywalking/issues/4373#issuecomment-586818458 @innerpeacez @wayilau @dmsolr @wu-sheng Please help me review the design document. Thanks.

[GitHub] [skywalking] hanahmily opened a new issue #4373: [SWCK] Initiate Backend Operator

2020-02-16 Thread GitBox
hanahmily opened a new issue #4373: [SWCK] Initiate Backend Operator URL: https://github.com/apache/skywalking/issues/4373 The proposal of SkyWalking Cloud on Kubernetes is put in [mail list

[skywalking] 01/01: Update committer.md

2020-02-16 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 3c7bb03b03041672c5227144d2e730af6aa49bb9 Author: kezhenxu94 AuthorDate: Mon Feb 17 12:43:25 2020

[skywalking] branch kezhenxu94-patch-1 created (now 3c7bb03)

2020-02-16 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 3c7bb03 Update committer.md This branch includes the following new commits: new 3c7bb03

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-16 Thread GitBox
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging

[GitHub] [skywalking] dmsolr closed pull request #4372: change to elastic official image

2020-02-16 Thread GitBox
dmsolr closed pull request #4372: change to elastic official image URL: https://github.com/apache/skywalking/pull/4372 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] dmsolr commented on issue #4372: change to elastic official image

2020-02-16 Thread GitBox
dmsolr commented on issue #4372: change to elastic official image URL: https://github.com/apache/skywalking/pull/4372#issuecomment-586798944 It does not matter with this. We need to remove the image when docker exited. I will fix it on new PR, so I close it.

[GitHub] [skywalking] dmsolr commented on issue #4372: change to elastic official image

2020-02-16 Thread GitBox
dmsolr commented on issue #4372: change to elastic official image URL: https://github.com/apache/skywalking/pull/4372#issuecomment-586795615 ES has a lot of versions. That causes us to download a lot of images. This is an

[GitHub] [skywalking] hanahmily commented on a change in pull request #4364: Support Downsampling Data Packing feature in ES storage implementation

2020-02-16 Thread GitBox
hanahmily commented on a change in pull request #4364: Support Downsampling Data Packing feature in ES storage implementation URL: https://github.com/apache/skywalking/pull/4364#discussion_r379965111 ## File path: oap-server/server-bootstrap/src/main/resources/application.yml

[GitHub] [skywalking] codecov-io commented on issue #4372: change to elastic official image

2020-02-16 Thread GitBox
codecov-io commented on issue #4372: change to elastic official image URL: https://github.com/apache/skywalking/pull/4372#issuecomment-586793284 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4372?src=pr=h1) Report > Merging

[GitHub] [skywalking] dmsolr opened a new pull request #4372: change to elastic official image

2020-02-16 Thread GitBox
dmsolr opened a new pull request #4372: change to elastic official image URL: https://github.com/apache/skywalking/pull/4372 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] [skywalking] dmsolr commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
dmsolr commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-586781392 > @dmsolr Please recheck. The ElasticSearch test fails agian. I don't find any change related to you. Please take a look, what is the issue.

[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-586780704 @dmsolr Please recheck. The ElasticSearch test fails agian. I don't find any change related to you. Please take a look, what is the issue.

[GitHub] [skywalking] Lovnx removed a comment on issue #2346: load balance between agent and backend?

2020-02-16 Thread GitBox
Lovnx removed a comment on issue #2346: load balance between agent and backend? URL: https://github.com/apache/skywalking/issues/2346#issuecomment-586585442 @ywf4026 do you solve this problem? This is an automated message

[GitHub] [skywalking] codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket

2020-02-16 Thread GitBox
wu-sheng commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-586720338 Which one? There are two above This is an

[GitHub] [skywalking] aderm commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket

2020-02-16 Thread GitBox
aderm commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-586719463 @wu-sheng agree with your suggestion This is an

[GitHub] [skywalking] wu-sheng commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket

2020-02-16 Thread GitBox
wu-sheng commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-586718264 As an opposite direction of my previous two PRs about reducing the index number, this runs into another way. We

[GitHub] [skywalking] wu-sheng commented on issue #4371: fix topology node type unknown.

2020-02-16 Thread GitBox
wu-sheng commented on issue #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#issuecomment-586717162 > not httyasyncclient, is httpasyncclient. httpasyncclient belongs to a common network component. cannot really infer the node type through it,

[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-586716319 The ElasticSearch fails twice, I am rerunning it. This is an automated

[GitHub] [skywalking] wu-sheng commented on issue #4104: [FEATURE] Performance profile at method level in production environment

2020-02-16 Thread GitBox
wu-sheng commented on issue #4104: [FEATURE] Performance profile at method level in production environment URL: https://github.com/apache/skywalking/issues/4104#issuecomment-586708407 @Fine0830 This is a backend performance benchmark for analysis button action.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r379903387 ## File path: .github/workflows/e2e.yaml ## @@ -71,15 +73,19 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r379902871 ## File path: .github/workflows/e2e.yaml ## @@ -71,15 +73,19 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r379902233 ## File path: .github/workflows/e2e.yaml ## @@ -71,15 +73,19 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r379902233 ## File path: .github/workflows/e2e.yaml ## @@ -71,15 +73,19 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] aderm edited a comment on issue #4371: fix topology node type unknown.

2020-02-16 Thread GitBox
aderm edited a comment on issue #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#issuecomment-586702666 > > Interceptor uses different components to intercept in different requests, httyasyncclient ( componentId=26 ) and rest-highlevel-client (

[GitHub] [skywalking] aderm edited a comment on issue #4371: fix topology node type unknown.

2020-02-16 Thread GitBox
aderm edited a comment on issue #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#issuecomment-586702666 > > Interceptor uses different components to intercept in different requests, httyasyncclient ( componentId=26 ) and rest-highlevel-client (

[GitHub] [skywalking] aderm commented on issue #4371: fix topology node type unknown.

2020-02-16 Thread GitBox
aderm commented on issue #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#issuecomment-586702666 > > Interceptor uses different components to intercept in different requests, httyasyncclient ( componentId=26 ) and rest-highlevel-client (

[GitHub] [skywalking] wu-sheng commented on issue #4368: Support Daily Index Step feature in the OAP

2020-02-16 Thread GitBox
wu-sheng commented on issue #4368: Support Daily Index Step feature in the OAP URL: https://github.com/apache/skywalking/pull/4368#issuecomment-586702690 @JaredTan95 Yes, so if the user only have low traffic, they could have 70-80 indexes but hosting 1-2weeks later with a small ES cluster.

[skywalking] branch master updated (329f7e1 -> 3342393)

2020-02-16 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 329f7e1 Support Downsampling Data Packing feature in ES storage implementation (#4364) add 3342393

[GitHub] [skywalking] JaredTan95 merged pull request #4368: Support Daily Index Step feature in the OAP

2020-02-16 Thread GitBox
JaredTan95 merged pull request #4368: Support Daily Index Step feature in the OAP URL: https://github.com/apache/skywalking/pull/4368 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] JaredTan95 commented on issue #4368: Support Daily Index Step feature in the OAP

2020-02-16 Thread GitBox
JaredTan95 commented on issue #4368: Support Daily Index Step feature in the OAP URL: https://github.com/apache/skywalking/pull/4368#issuecomment-586702568 LGTM After https://github.com/apache/skywalking/pull/4214 about es index number reduced. This is another optimization.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r379900290 ## File path: .github/workflows/e2e.yaml ## @@ -71,15 +73,19 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4371: fix topology node type unknown.

2020-02-16 Thread GitBox
wu-sheng commented on a change in pull request #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#discussion_r379899569 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TopologyBuilder.java

[GitHub] [skywalking] wu-sheng commented on issue #4371: fix topology node type unknown.

2020-02-16 Thread GitBox
wu-sheng commented on issue #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#issuecomment-586700626 > Interceptor uses different components to intercept in different requests, httyasyncclient ( componentId=26 ) and rest-highlevel-client (

[GitHub] [skywalking] nbacheng commented on issue #4369: apm-webapp compile failed

2020-02-16 Thread GitBox
nbacheng commented on issue #4369: apm-webapp compile failed URL: https://github.com/apache/skywalking/issues/4369#issuecomment-586700253 Thank you. I'll check it myself again. This is an automated message from the Apache

[GitHub] [skywalking] wu-sheng commented on issue #4369: apm-webapp compile failed

2020-02-16 Thread GitBox
wu-sheng commented on issue #4369: apm-webapp compile failed URL: https://github.com/apache/skywalking/issues/4369#issuecomment-586699764 That could be compiled, several PMC members have checked that in the release process.

[GitHub] [skywalking] aderm opened a new pull request #4371: fix topology node type unknown.

2020-02-16 Thread GitBox
aderm opened a new pull request #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] [skywalking] aderm opened a new issue #4370: Topology view page ES node type show Unknow.

2020-02-16 Thread GitBox
aderm opened a new issue #4370: Topology view page ES node type show Unknow. URL: https://github.com/apache/skywalking/issues/4370 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ]

[GitHub] [skywalking] codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr=h1) Report > Merging

[GitHub] [skywalking] nbacheng commented on issue #4369: apm-webapp compile failed

2020-02-16 Thread GitBox
nbacheng commented on issue #4369: apm-webapp compile failed URL: https://github.com/apache/skywalking/issues/4369#issuecomment-586691933 http://mirror.bit.edu.cn/apache/skywalking/6.6.0/apache-skywalking-apm-6.6.0-src.tgz

[GitHub] [skywalking] wu-sheng closed issue #4369: apm-webapp compile failed

2020-02-16 Thread GitBox
wu-sheng closed issue #4369: apm-webapp compile failed URL: https://github.com/apache/skywalking/issues/4369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking] wu-sheng commented on issue #4369: apm-webapp compile failed

2020-02-16 Thread GitBox
wu-sheng commented on issue #4369: apm-webapp compile failed URL: https://github.com/apache/skywalking/issues/4369#issuecomment-586691685 Every commit in this PR has been checked and passed the compiling and tests. This is

[GitHub] [skywalking] wu-sheng commented on issue #4369: apm-webapp compile failed

2020-02-16 Thread GitBox
wu-sheng commented on issue #4369: apm-webapp compile failed URL: https://github.com/apache/skywalking/issues/4369#issuecomment-586691637 Where do you download the source code? I am feeling it is not from our GitHub or release.

[GitHub] [skywalking] nbacheng opened a new issue #4369: apm-webapp compile failed

2020-02-16 Thread GitBox
nbacheng opened a new issue #4369: apm-webapp compile failed URL: https://github.com/apache/skywalking/issues/4369 Please answer these questions before submitting your issue. - Why do you submit this issue? - [√ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ]

[GitHub] [skywalking] codecov-io commented on issue #4368: Support Daily Index Step feature in the OAP

2020-02-16 Thread GitBox
codecov-io commented on issue #4368: Support Daily Index Step feature in the OAP URL: https://github.com/apache/skywalking/pull/4368#issuecomment-586686016 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4368?src=pr=h1) Report > Merging

[skywalking] branch timerseries-step updated (4035022 -> 3ade0f0)

2020-02-16 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch timerseries-step in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 4035022 Fix format. add 3ade0f0 Fix mischanged ES. No new revisions were added by this

[GitHub] [skywalking] wu-sheng commented on issue #4368: Support Daily Index Step feature in the OAP

2020-02-16 Thread GitBox
wu-sheng commented on issue #4368: Support Daily Index Step feature in the OAP URL: https://github.com/apache/skywalking/pull/4368#issuecomment-586682766 @aderm This is another challenge for the PR you are working on, also one of the reason I want to hold that PR(#4353). This will give the

[skywalking] branch timerseries-step updated (58334a1 -> 4035022)

2020-02-16 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch timerseries-step in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 58334a1 Support Daily Index Step. add 4035022 Fix format. No new revisions were added by this

[GitHub] [skywalking] wu-sheng opened a new pull request #4368: Support Daily Index Step feature in the OAP

2020-02-16 Thread GitBox
wu-sheng opened a new pull request #4368: Support Daily Index Step feature in the OAP URL: https://github.com/apache/skywalking/pull/4368 ### Daily Index Step Daily index step(`storage/elasticsearch/dayStep`, default 1) represents the index creation period. In this period, several

[skywalking] branch timerseries-step created (now 58334a1)

2020-02-16 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch timerseries-step in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 58334a1 Support Daily Index Step. This branch includes the following new commits: new 58334a1

[skywalking] 01/01: Support Daily Index Step.

2020-02-16 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch timerseries-step in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 58334a1ba59947a0c935f9b789ccac4cefc35724 Author: Wu Sheng AuthorDate: Sun Feb 16 16:26:39 2020 +0800