[GitHub] [skywalking] wu-sheng commented on issue #4502: SkyWalking not work after two date

2020-03-12 Thread GitBox
wu-sheng commented on issue #4502: SkyWalking not work after two date URL: https://github.com/apache/skywalking/issues/4502#issuecomment-598562594 I don't know why. Usually deleting index and creating indexes at middle night cause more payload, especially for some some ES cluster. The

[GitHub] [skywalking] hanahmily commented on issue #4470: Enable OAP gRPC SSL transportation

2020-03-12 Thread GitBox
hanahmily commented on issue #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#issuecomment-598556447 @wu-sheng e2e test case is added and passed. now I think we can merge it. This

[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException

2020-03-12 Thread GitBox
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException URL: https://github.com/apache/skywalking/pull/4443#issuecomment-598553033 I can't merge now. Do you delete anything. This is an automated

[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException

2020-03-12 Thread GitBox
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException URL: https://github.com/apache/skywalking/pull/4443#issuecomment-598552300 @cngdkxw What do you do? I found the PR closed by you. This is an

[GitHub] [skywalking] cngdkxw closed pull request #4443: RestTemplate async plugin ClassCastException

2020-03-12 Thread GitBox
cngdkxw closed pull request #4443: RestTemplate async plugin ClassCastException URL: https://github.com/apache/skywalking/pull/4443 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] wu-sheng commented on issue #4505: Can skywalking exclude specified Exception?

2020-03-12 Thread GitBox
wu-sheng commented on issue #4505: Can skywalking exclude specified Exception? URL: https://github.com/apache/skywalking/issues/4505#issuecomment-598547279 OneAPM product did very different way. They Even can't 100% sampling, Even far from it. We are different. Again, this can be added

[GitHub] [skywalking] CodeDestiny commented on issue #4505: Can skywalking exclude specified Exception?

2020-03-12 Thread GitBox
CodeDestiny commented on issue #4505: Can skywalking exclude specified Exception? URL: https://github.com/apache/skywalking/issues/4505#issuecomment-598546583 Because in last company,we used OneAPM which can config this,but also thanks a lot

[GitHub] [skywalking] wu-sheng commented on issue #4505: Can skywalking exclude specified Exception?

2020-03-12 Thread GitBox
wu-sheng commented on issue #4505: Can skywalking exclude specified Exception? URL: https://github.com/apache/skywalking/issues/4505#issuecomment-598542221 No, we can't. Using exception to propagate error is not a good idea, and have bad performance. Please consider to remove them.

[GitHub] [skywalking] wu-sheng closed issue #4505: Can skywalking exclude specified Exception?

2020-03-12 Thread GitBox
wu-sheng closed issue #4505: Can skywalking exclude specified Exception? URL: https://github.com/apache/skywalking/issues/4505 This is an automated message from the Apache Git Service. To respond to the message, please log

[skywalking] branch oap-ssl updated (a3034af -> 2625484)

2020-03-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard a3034af Ignore TSL relevant files add 2625484 Ignore TSL relevant files This update added new

[skywalking] branch oap-ssl updated (fd7301f -> a3034af)

2020-03-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from fd7301f Merge branch 'master' into oap-ssl add a3034af Ignore TSL relevant files No new revisions

[GitHub] [skywalking] CodeDestiny opened a new issue #4505: Can skywalking exclude specified Exception?

2020-03-12 Thread GitBox
CodeDestiny opened a new issue #4505: Can skywalking exclude specified Exception? URL: https://github.com/apache/skywalking/issues/4505 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question ___ ### Question - What

[GitHub] [skywalking] codecov-io edited a comment on issue #4443: RestTemplate async plugin ClassCastException

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #4443: RestTemplate async plugin ClassCastException URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr=h1) Report > Merging

[skywalking] branch oap-ssl updated (44f7667 -> fd7301f)

2020-03-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 44f7667 Revert e2e add 9c974b8 Fix unclear doc and add missing variable (#4484) add 069b99b Add

[skywalking] branch oap-ssl updated (1f6974a -> 44f7667)

2020-03-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 1f6974a Update backend add 44f7667 Revert e2e No new revisions were added by this update. Summary

[skywalking] branch oap-ssl updated (d98d242 -> 1f6974a)

2020-03-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from d98d242 Revert "Change backend" add 1f6974a Update backend No new revisions were added by this

[skywalking] branch oap-ssl updated (6f2abc1 -> d98d242)

2020-03-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 6f2abc1 Upload log files add 7a08571 Change backend add d98d242 Revert "Change backend" No new

[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException

2020-03-12 Thread GitBox
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException URL: https://github.com/apache/skywalking/pull/4443#issuecomment-598526403 Thanks for following the review. Prepare to merge. This is an

[GitHub] [skywalking] wu-sheng merged pull request #4504: add KubeSphere in powered-by list

2020-03-12 Thread GitBox
wu-sheng merged pull request #4504: add KubeSphere in powered-by list URL: https://github.com/apache/skywalking/pull/4504 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch master updated: add KubeSphere in powered-by list (#4504)

2020-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 37e93a6 add KubeSphere in powered-by list

[skywalking] branch oap-ssl updated (369fa20 -> 6f2abc1)

2020-03-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 369fa20 Upload log files add 6f2abc1 Upload log files This update added new revisions after undoing

[skywalking] branch oap-ssl updated (9a25e40 -> 369fa20)

2020-03-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 9a25e40 Upload log files add 369fa20 Upload log files This update added new revisions after undoing

[GitHub] [skywalking] jol5 commented on issue #4502: SkyWalking not work after two date

2020-03-12 Thread GitBox
jol5 commented on issue #4502: SkyWalking not work after two date URL: https://github.com/apache/skywalking/issues/4502#issuecomment-598504662 > Seem like someone delete some of data before. And the OAP can't find the metadata. i don't think so! beacuse it reappear always after one

[GitHub] [skywalking] wu-sheng commented on issue #4432: SkyWalking Web Page shows no data

2020-03-12 Thread GitBox
wu-sheng commented on issue #4432: SkyWalking Web Page shows no data URL: https://github.com/apache/skywalking/issues/4432#issuecomment-598265578 No discussion will continue here. Discuss should happen on the official mail list.

[GitHub] [skywalking] CadenOf commented on issue #4432: SkyWalking Web Page shows no data

2020-03-12 Thread GitBox
CadenOf commented on issue #4432: SkyWalking Web Page shows no data URL: https://github.com/apache/skywalking/issues/4432#issuecomment-598257231 It seems that skywalking created so much indices in elasticsearch7 at 00:00 everyday,I delete some older indices then restart skywalking oap

[GitHub] [skywalking] codecov-io edited a comment on issue #4504: add KubeSphere in powered-by list

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #4504: add KubeSphere in powered-by list URL: https://github.com/apache/skywalking/pull/4504#issuecomment-598213153 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4504?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4504: add KubeSphere in powered-by list

2020-03-12 Thread GitBox
wu-sheng commented on a change in pull request #4504: add KubeSphere in powered-by list URL: https://github.com/apache/skywalking/pull/4504#discussion_r391661982 ## File path: docs/powered-by.md ## @@ -149,9 +149,10 @@ or providing commercial products including Apache

[GitHub] [skywalking] codecov-io edited a comment on issue #4504: add KubeSphere in powered-by list

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #4504: add KubeSphere in powered-by list URL: https://github.com/apache/skywalking/pull/4504#issuecomment-598213153 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4504?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4504: add KubeSphere in powered-by list

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #4504: add KubeSphere in powered-by list URL: https://github.com/apache/skywalking/pull/4504#issuecomment-598213153 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4504?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io commented on issue #4504: add KubeSphere in powered-by list

2020-03-12 Thread GitBox
codecov-io commented on issue #4504: add KubeSphere in powered-by list URL: https://github.com/apache/skywalking/pull/4504#issuecomment-598213153 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4504?src=pr=h1) Report > Merging

[GitHub] [skywalking] FeynmanZhou opened a new pull request #4504: add KubeSphere in powered-by list

2020-03-12 Thread GitBox
FeynmanZhou opened a new pull request #4504: add KubeSphere in powered-by list URL: https://github.com/apache/skywalking/pull/4504 Signed-off-by: FeynmanZhou Please answer these questions before submitting pull request - Why submit this pull request? - [x] Add new user in

[skywalking-kubernetes] annotated tag v1.1.0 updated (370e651 -> 79209c4)

2020-03-12 Thread innerpeacez
This is an automated email from the ASF dual-hosted git repository. innerpeacez pushed a change to annotated tag v1.1.0 in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. *** WARNING: tag v1.1.0 was modified! *** from 370e651 (commit) to 79209c4 (tag)

[skywalking-kubernetes] branch master updated: chart 1.1.0 changes (#40)

2020-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git The following commit(s) were added to refs/heads/master by this push: new 370e651 chart 1.1.0 changes

[GitHub] [skywalking-kubernetes] wu-sheng merged pull request #40: chart 1.1.0 changes

2020-03-12 Thread GitBox
wu-sheng merged pull request #40: chart 1.1.0 changes URL: https://github.com/apache/skywalking-kubernetes/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking-kubernetes] innerpeacez opened a new pull request #40: chart 1.1.0 changes

2020-03-12 Thread GitBox
innerpeacez opened a new pull request #40: chart 1.1.0 changes URL: https://github.com/apache/skywalking-kubernetes/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov-io commented on issue #4503: Support servlet 2.5 for Struts2

2020-03-12 Thread GitBox
codecov-io commented on issue #4503: Support servlet 2.5 for Struts2 URL: https://github.com/apache/skywalking/pull/4503#issuecomment-598180259 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4503?src=pr=h1) Report > Merging

[GitHub] [skywalking] muyun12 opened a new pull request #4503: Support servlet 2.5 for Struts2

2020-03-12 Thread GitBox
muyun12 opened a new pull request #4503: Support servlet 2.5 for Struts2 URL: https://github.com/apache/skywalking/pull/4503 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] [skywalking] wu-sheng commented on issue #4496: Application will not quit after main() done

2020-03-12 Thread GitBox
wu-sheng commented on issue #4496: Application will not quit after main() done URL: https://github.com/apache/skywalking/issues/4496#issuecomment-598118731 @kezhenxu94 I agree. But I don't have time to review all right now.

[GitHub] [skywalking] kezhenxu94 commented on issue #4496: Application will not quit after main() done

2020-03-12 Thread GitBox
kezhenxu94 commented on issue #4496: Application will not quit after main() done URL: https://github.com/apache/skywalking/issues/4496#issuecomment-598086119 From my point of view, as an agent, all threads should be daemon? @wu-sheng

[GitHub] [skywalking] wu-sheng commented on issue #4502: SkyWalking not work after two date

2020-03-12 Thread GitBox
wu-sheng commented on issue #4502: SkyWalking not work after two date URL: https://github.com/apache/skywalking/issues/4502#issuecomment-598069913 Seem like someone delete some of data before. And the OAP can't find the metadata.

[GitHub] [skywalking] wu-sheng closed issue #4502: SkyWalking not work after two date

2020-03-12 Thread GitBox
wu-sheng closed issue #4502: SkyWalking not work after two date URL: https://github.com/apache/skywalking/issues/4502 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] CadenOf edited a comment on issue #4432: SkyWalking Web Page shows no data

2020-03-12 Thread GitBox
CadenOf edited a comment on issue #4432: SkyWalking Web Page shows no data URL: https://github.com/apache/skywalking/issues/4432#issuecomment-598058045 @wu-sheng It seems that skywalking had created lots of indexs after the TTL time(7 days), I found some logs in my elasticsearch

[GitHub] [skywalking] jol5 commented on issue #4502: SkyWalking not work after two date

2020-03-12 Thread GitBox
jol5 commented on issue #4502: SkyWalking not work after two date URL: https://github.com/apache/skywalking/issues/4502#issuecomment-598065853 until i delete all skywalking es index This is an automated message from the

[GitHub] [skywalking] jol5 opened a new issue #4502: SkyWalking not work after two date

2020-03-12 Thread GitBox
jol5 opened a new issue #4502: SkyWalking not work after two date URL: https://github.com/apache/skywalking/issues/4502 Please answer these questions before submitting your issue. - Why do you submit this issue? - [*] Question or discussion - [*] Bug - [ ] Requirement -

[GitHub] [skywalking] CadenOf commented on issue #4432: SkyWalking Web Page shows no data

2020-03-12 Thread GitBox
CadenOf commented on issue #4432: SkyWalking Web Page shows no data URL: https://github.com/apache/skywalking/issues/4432#issuecomment-598058045 @wu-sheng It seems that skywalking had created lots of indexs after the TTL time(7 days), I found some logs in my elasticsearch cluster as

[GitHub] [skywalking] wu-sheng commented on issue #4501: Use backend sub topology to replace the front end traversal

2020-03-12 Thread GitBox
wu-sheng commented on issue #4501: Use backend sub topology to replace the front end traversal URL: https://github.com/apache/skywalking/issues/4501#issuecomment-598042800 Another thing is, after we select the group, it will go back to the global if we click `reload`. I think it should

[GitHub] [skywalking] wu-sheng opened a new issue #4501: Use backend sub topology to replace the front end traversal

2020-03-12 Thread GitBox
wu-sheng opened a new issue #4501: Use backend sub topology to replace the front end traversal URL: https://github.com/apache/skywalking/issues/4501 Hi @TinyAllen I think we have an misunderstood in the group topology, we have added a backend interface to do sub topology query,

[GitHub] [skywalking] wu-sheng closed issue #4393: Support service group in the UI

2020-03-12 Thread GitBox
wu-sheng closed issue #4393: Support service group in the UI URL: https://github.com/apache/skywalking/issues/4393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on issue #4393: Support service group in the UI

2020-03-12 Thread GitBox
wu-sheng commented on issue #4393: Support service group in the UI URL: https://github.com/apache/skywalking/issues/4393#issuecomment-598026995 Sub-topology provided through the custom group definition. This is an automated

[GitHub] [skywalking] wu-sheng commented on issue #4392: Support choosing multiple services in the topology page

2020-03-12 Thread GitBox
wu-sheng commented on issue #4392: Support choosing multiple services in the topology page URL: https://github.com/apache/skywalking/issues/4392#issuecomment-598026926 Sub-topology provided through the custom group definition.

[GitHub] [skywalking] wu-sheng closed issue #4392: Support choosing multiple services in the topology page

2020-03-12 Thread GitBox
wu-sheng closed issue #4392: Support choosing multiple services in the topology page URL: https://github.com/apache/skywalking/issues/4392 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] codecov-io edited a comment on issue #4443: RestTemplate async plugin ClassCastException

2020-03-12 Thread GitBox
codecov-io edited a comment on issue #4443: RestTemplate async plugin ClassCastException URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr=h1) Report > Merging