[GitHub] [skywalking] wu-sheng commented on issue #5019: question about alarming local span
wu-sheng commented on issue #5019: URL: https://github.com/apache/skywalking/issues/5019#issuecomment-653367154 https://github.com/apache/skywalking/blob/master/docs/en/guides/Java-Plugin-Development-Guide.md#extension-logic-endpoint-tag-key-x-le This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5019: question about alarming local span
wu-sheng commented on issue #5019: URL: https://github.com/apache/skywalking/issues/5019#issuecomment-653366637 Typically, this should not work, because there are no metrics generated through local spans. But luckily, you have an option in the master and next 8.1 release. We call that logic endpoint from the span. Read the latest doc for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5019: question about alarming local span
wu-sheng closed issue #5019: URL: https://github.com/apache/skywalking/issues/5019 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **increase** coverage by `0.01%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## + Coverage 53.35% 53.37% +0.01% - Complexity 2939 2949 +10 Files 1399 1401 +2 Lines 3040830442 +34 Branches 3389 3390 +1 + Hits 1622516247 +22 - Misses1337813390 +12 Partials805 805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `77.08% <0.00%> (-0.53%)` | `10.00% <0.00%> (ø%)` | | | [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | ... and [9
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.72%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 52.62% -0.73% + Complexity 2939 2870 -69 Files 1399 750 -649 Lines 3040818952 -11456 Branches 3389 1880-1509 - Hits 16225 9974-6251 + Misses13378 8143-5235 - Partials805 835 +30 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.72%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 52.62% -0.73% + Complexity 2939 2870 -69 Files 1399 750 -649 Lines 3040818952 -11456 Branches 3389 1880-1509 - Hits 16225 9974-6251 + Misses13378 8143-5235 - Partials805 835 +30 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.71%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 52.63% -0.72% + Complexity 2939 2870 -69 Files 1399 749 -650 Lines 3040818948 -11460 Branches 3389 1880-1509 - Hits 16225 9974-6251 + Misses13378 8139-5239 - Partials805 835 +30 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.08%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 53.27% -0.09% - Complexity 2939 2949 +10 Files 1399 767 -632 Lines 3040819359 -11049 Branches 3389 1913-1476 - Hits 1622510313-5912 + Misses13378 8188-5190 - Partials805 858 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `2.87%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 50.48% -2.88% + Complexity 2939 2809 -130 Files 1399 749 -650 Lines 3040818948 -11460 Branches 3389 1880-1509 - Hits 16225 9565-6660 + Misses13378 8579-4799 + Partials805 804 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.73%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 52.61% -0.74% + Complexity 2939 2869 -70 Files 1399 749 -650 Lines 3040818948 -11460 Branches 3389 1880-1509 - Hits 16225 9970-6255 + Misses13378 8143-5235 - Partials805 835 +30 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `1.46%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 51.89% -1.47% + Complexity 2939 2848 -91 Files 1399 749 -650 Lines 3040818948 -11460 Branches 3389 1880-1509 - Hits 16225 9833-6392 + Misses13378 8281-5097 - Partials805 834 +29 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `5.25%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 48.10% -5.26% + Complexity 2939 2715 -224 Files 1399 749 -650 Lines 3040818912 -11496 Branches 3389 1879-1510 - Hits 16225 9097-7128 + Misses13378 9043-4335 + Partials805 772 -33 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `5.24%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 48.11% -5.25% + Complexity 2939 2715 -224 Files 1399 747 -652 Lines 3040818906 -11502 Branches 3389 1879-1510 - Hits 16225 9097-7128 + Misses13378 9037-4341 + Partials805 772 -33 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] firolololo opened a new issue #5019: question about alarming local span
firolololo opened a new issue #5019: URL: https://github.com/apache/skywalking/issues/5019 If i write a plugin to establish a local span to intercept the constructor of my own java class, the span will fail in some situation. I try to alarm this situation and configure alarm-setting.xml as following: rules: # alarm _rule: metrics-name: endpoint_sla op: ">" threshold: 60 period: 10 count: 1 silence-period: 5 message: "failed" include-names: - com.example.className in serviceName but not work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.08%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 53.27% -0.09% - Complexity 2939 2949 +10 Files 1399 767 -632 Lines 3040819359 -11049 Branches 3389 1913-1476 - Hits 1622510313-5912 + Misses13378 8188-5190 - Partials805 858 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `15.36%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.35% 37.99% -15.37% + Complexity 2939 2081 -858 = Files 1399 747 -652 Lines 3040818906-11502 Branches 3389 1879 -1510 = - Hits 16225 7183 -9042 + Misses1337811189 -2189 + Partials805 534 -271 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `16.19%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.35% 37.16% -16.20% + Complexity 2939 2044 -895 = Files 1399 746 -653 Lines 3040818887-11521 Branches 3389 1875 -1514 = - Hits 16225 7019 -9206 + Misses1337811333 -2045 + Partials805 535 -270 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `16.22%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.35% 37.13% -16.23% + Complexity 2939 2044 -895 = Files 1399 747 -652 Lines 3040818903-11505 Branches 3389 1879 -1510 = - Hits 16225 7019 -9206 + Misses1337811349 -2029 + Partials805 535 -270 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `16.33%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.35% 37.01% -16.34% + Complexity 2939 2034 -905 = Files 1399 745 -654 Lines 3040818861-11547 Branches 3389 1875 -1514 = - Hits 16225 6982 -9243 + Misses1337811345 -2033 + Partials805 534 -271 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.06%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 53.28% -0.07% - Complexity 2939 2949 +10 Files 1399 765 -634 Lines 3040819353 -11055 Branches 3389 1913-1476 - Hits 1622510313-5912 + Misses13378 8182-5196 - Partials805 858 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.10%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 53.25% -0.11% - Complexity 2939 2942 +3 Files 1399 764 -635 Lines 3040819314 -11094 Branches 3389 1912-1477 - Hits 1622510286-5939 + Misses13378 8172-5206 - Partials805 856 +51 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.93%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 52.42% -0.94% + Complexity 2939 2917 -22 Files 1399 764 -635 Lines 3040819314 -11094 Branches 3389 1912-1477 - Hits 1622510125-6100 + Misses13378 8341-5037 - Partials805 848 +43 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `3.21%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 50.14% -3.22% + Complexity 2939 2834 -105 Files 1399 764 -635 Lines 3040819311 -11097 Branches 3389 1912-1477 - Hits 16225 9684-6541 + Misses13378 8813-4565 - Partials805 814 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `18.52%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.35% 34.83% -18.53% + Complexity 2939 1937 -1002 = Files 1399 743 -656 Lines 3040818803-11605 Branches 3389 1873 -1516 = - Hits 16225 6550 -9675 + Misses1337811732 -1646 + Partials805 521 -284 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `23.26%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.35% 30.09% -23.27% + Complexity 2939 1687 -1252 = Files 1399 743 -656 Lines 3040818773-11635 Branches 3389 1858 -1531 = - Hits 16225 5649-10576 + Misses1337812678 -700 + Partials805 446 -359 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `23.27%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.35% 30.07% -23.28% + Complexity 2939 1685 -1254 = Files 1399 743 -656 Lines 3040818771-11637 Branches 3389 1857 -1532 = - Hits 16225 5646-10579 + Misses1337812678 -700 + Partials805 447 -358 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `53.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4987 +/- ## - Coverage 53.35% 0.00% -53.36% Files 1399 161 -1238 Lines 304084017-26391 Branches 3389 477 -2912 - Hits 16225 0-16225 + Misses133784017 -9361 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1368 more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `53.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4987 +/- ## - Coverage 53.35% 0.00% -53.36% Files 1399 164 -1235 Lines 304084064-26344 Branches 3389 481 -2908 - Hits 16225 0-16225 + Misses133784064 -9314 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `53.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4987 +/- ## - Coverage 53.35% 0.00% -53.36% Files 1399 159 -1240 Lines 304084005-26403 Branches 3389 477 -2912 - Hits 16225 0-16225 + Misses133784005 -9373 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1368 more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `53.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4987 +/- ## - Coverage 53.35% 0.00% -53.36% Files 1399 163 -1236 Lines 304084059-26349 Branches 3389 481 -2908 - Hits 16225 0-16225 + Misses133784059 -9319 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1366 more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `53.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4987 +/- ## - Coverage 53.35% 0.00% -53.36% Files 1399 161 -1238 Lines 304084047-26361 Branches 3389 481 -2908 - Hits 16225 0-16225 + Misses133784047 -9331 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1366 more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `53.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4987 +/- ## - Coverage 53.35% 0.00% -53.36% Files 1399 161 -1238 Lines 304084039-26369 Branches 3389 481 -2908 - Hits 16225 0-16225 + Misses133784039 -9339 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1366 more](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39f2cd3a5f80b28378d93f9424da435253a6c0a6=desc) will **decrease** coverage by `0.11%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.35% 53.24% -0.12% + Complexity 2939 2938 -1 Files 1399 1401 +2 Lines 3040830443 +35 Branches 3389 3390 +1 - Hits 1622516210 -15 - Misses1337813428 +50 Partials805 805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | | | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.37% <0.00%> (-3.79%)` | `24.00% <0.00%> (-1.00%)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `77.08% <0.00%> (-0.53%)` | `10.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.12%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 53.24% -0.13% + Complexity 2945 2938 -7 Files 1400 1401 +1 Lines 3042330443 +20 Branches 3389 3390 +1 - Hits 1623616210 -26 - Misses1338213428 +46 Partials805 805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | | | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.37% <0.00%> (-3.79%)` | `24.00% <0.00%> (-1.00%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `94.33% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | | | [...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh) | `66.17% <0.00%>
[GitHub] [skywalking] fuzhimo commented on issue #5018: how to get the "TID" from my java application when using skywalking-agent
fuzhimo commented on issue #5018: URL: https://github.com/apache/skywalking/issues/5018#issuecomment-653324033 ths ---Original--- From: "kezhenxu94"https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Application-toolkit-trace.md — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #5018: how to get the "TID" from my java application when using skywalking-agent
kezhenxu94 closed issue #5018: URL: https://github.com/apache/skywalking/issues/5018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #5018: how to get the "TID" from my java application when using skywalking-agent
kezhenxu94 commented on issue #5018: URL: https://github.com/apache/skywalking/issues/5018#issuecomment-653320190 Please read docs of OSS before asking, https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Application-toolkit-trace.md This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] fuzhimo opened a new issue #5018: how to get the "TID" from my java application when using skywalking-agent
fuzhimo opened a new issue #5018: URL: https://github.com/apache/skywalking/issues/5018 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5016: agent can support agent.sample_n_per_3_secs of agent property as Dynamic configuration
wu-sheng commented on issue #5016: URL: https://github.com/apache/skywalking/issues/5016#issuecomment-653309792 And, there is a challenge is, when the agent reboot, it would be back to local static config, until the backend pushed the new configs. But, you mean, there is agent fail-safe protection mechanism, why do we need this really? Is there CPU overload for real? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5016: agent can support agent.sample_n_per_3_secs of agent property as Dynamic configuration
wu-sheng commented on issue #5016: URL: https://github.com/apache/skywalking/issues/5016#issuecomment-653306554 How do you know this is happening? I mean `too much traffic`, how do you know the baseline? and when to do this? And when you want to change, which are the targets, for all instances of a service? Then, how could you change and push the command to the agent? A possibility is `Dynamic Configuration Center` -> `OAP` -> `agent`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] killGC commented on issue #5016: agent can support agent.sample_n_per_3_secs of agent property as Dynamic configuration
killGC commented on issue #5016: URL: https://github.com/apache/skywalking/issues/5016#issuecomment-653303273 i expect when application request amount is big，i can reduce agent.sample_n_per_3_secs to ruduce agent using resource This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.12%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 53.24% -0.13% + Complexity 2945 2938 -7 Files 1400 1401 +1 Lines 3042330443 +20 Branches 3389 3390 +1 - Hits 1623616210 -26 - Misses1338213428 +46 Partials805 805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | | | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.37% <0.00%> (-3.79%)` | `24.00% <0.00%> (-1.00%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `94.33% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | | | [...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh) | `66.17% <0.00%>
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4987: support sampleRate as Dynamic Configuration (#4968)
wu-sheng commented on a change in pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#discussion_r449328243
##
File path:
oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceSampleRateWatcher.java
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.receiver.trace.provider;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.server.configuration.api.ConfigChangeWatcher;
+import org.apache.skywalking.oap.server.receiver.trace.module.TraceModule;
+
+import java.util.concurrent.atomic.AtomicReference;
+
+@Slf4j
+public class TraceSampleRateWatcher extends ConfigChangeWatcher {
+private AtomicReference sampleRate;
Review comment:
```suggestion
private AtomicReference sampleRate;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.12%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 53.24% -0.13% + Complexity 2945 2938 -7 Files 1400 1401 +1 Lines 3042330443 +20 Branches 3389 3390 +1 - Hits 1623616210 -26 - Misses1338213428 +46 Partials805 805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | | | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.37% <0.00%> (-3.79%)` | `24.00% <0.00%> (-1.00%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `94.33% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | | | [...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh) | `66.17% <0.00%>
[GitHub] [skywalking] wu-sheng commented on issue #5016: agent can support agent.sample_n_per_3_secs of agent property as Dynamic configuration
wu-sheng commented on issue #5016: URL: https://github.com/apache/skywalking/issues/5016#issuecomment-653269645 I think there is NOT an agent side dynamic configuration mechanism. What do you expect? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #4959: Configmap configuration
wu-sheng commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-653268512 @EvanLjp Please update the document. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch master updated: Optimize the code to prevent mongo statements from being too long (#5017)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 39f2cd3 Optimize the code to prevent mongo statements from being too
long (#5017)
39f2cd3 is described below
commit 39f2cd3a5f80b28378d93f9424da435253a6c0a6
Author: dengliming
AuthorDate: Fri Jul 3 08:07:10 2020 +0800
Optimize the code to prevent mongo statements from being too long (#5017)
---
.../skywalking/apm/plugin/mongodb/v3/support/MongoOperationHelper.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
a/apm-sniffer/apm-sdk-plugin/mongodb-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v3/support/MongoOperationHelper.java
b/apm-sniffer/apm-sdk-plugin/mongodb-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v3/support/MongoOperationHelper.java
index 71c2eb8..42e5ecd 100644
---
a/apm-sniffer/apm-sdk-plugin/mongodb-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v3/support/MongoOperationHelper.java
+++
b/apm-sniffer/apm-sdk-plugin/mongodb-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v3/support/MongoOperationHelper.java
@@ -128,8 +128,7 @@ public class MongoOperationHelper {
}
final int filterLengthLimit =
Config.Plugin.MongoDB.FILTER_LENGTH_LIMIT;
if (filterLengthLimit > 0 && params.length() > filterLengthLimit) {
-params.append("...");
-break;
+return params.substring(0, filterLengthLimit) + "...";
}
}
return params.toString();
[GitHub] [skywalking] wu-sheng merged pull request #5017: Optimize the code to prevent mongo statements from being too long
wu-sheng merged pull request #5017: URL: https://github.com/apache/skywalking/pull/5017 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 53.32% -0.05% + Complexity 2945 2943 -2 Files 1400 1400 Lines 3042330416 -7 Branches 3389 3389 - Hits 1623616219 -17 - Misses1338213393 +11 + Partials805 804 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lugin/mongodb/v3/support/MongoOperationHelper.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbW9uZ29kYi0zLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbW9uZ29kYi92My9zdXBwb3J0L01vbmdvT3BlcmF0aW9uSGVscGVyLmphdmE=) | `7.14% <0.00%> (+0.10%)` | `0.00 <0.00> (ø)` | | | [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `48.33% <0.00%> (-11.67%)` | `6.00% <0.00%> (-1.00%)` | | | [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `83.15% <0.00%> (-4.22%)` | `18.00% <0.00%> (-1.00%)` | | | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `75.52% <0.00%> (-4.20%)` | `9.00% <0.00%> (ø%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `96.22% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | | | [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `77.60% <0.00%> (+0.52%)` | `10.00% <0.00%> (ø%)` | | | [...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh) | `76.92% <0.00%> (+7.69%)` | `3.00% <0.00%> (+1.00%)` | | | [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `100.00% <0.00%> (+42.85%)` | `0.00% <0.00%> (ø%)` | | | [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 53.20% -0.17% + Complexity 2945 2943 -2 Files 1400 765 -635 Lines 3042319331 -11092 Branches 3389 1913-1476 - Hits 1623610285-5951 + Misses13382 8188-5194 - Partials805 858 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | | [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 53.20% -0.17% + Complexity 2945 2943 -2 Files 1400 765 -635 Lines 3042319331 -11092 Branches 3389 1913-1476 - Hits 1623610285-5951 + Misses13382 8188-5194 - Partials805 858 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | | [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.15%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 53.21% -0.16% + Complexity 2945 2943 -2 Files 1400 764 -636 Lines 3042319327 -11096 Branches 3389 1913-1476 - Hits 1623610285-5951 + Misses13382 8184-5198 - Partials805 858 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | | [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 53.32% -0.05% + Complexity 2945 2943 -2 Files 1400 763 -637 Lines 3042319288 -11135 Branches 3389 1912-1477 - Hits 1623610285-5951 + Misses13382 8145-5237 - Partials805 858 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | | [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.30%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 53.05% -0.31% + Complexity 2945 2927 -18 Files 1400 763 -637 Lines 3042319288 -11135 Branches 3389 1912-1477 - Hits 1623610234-6002 + Misses13382 8196-5186 - Partials805 858 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | | [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.34%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 53.02% -0.35% + Complexity 2945 2924 -21 Files 1400 763 -637 Lines 3042319288 -11135 Branches 3389 1912-1477 - Hits 1623610227-6009 + Misses13382 8203-5179 - Partials805 858 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | | [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `1.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 52.09% -1.27% + Complexity 2945 2894 -51 Files 1400 763 -637 Lines 3042319288 -11135 Branches 3389 1912-1477 - Hits 1623610049-6187 + Misses13382 8400-4982 - Partials805 839 +34 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | | [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `1.25%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 52.11% -1.26% + Complexity 2945 2893 -52 Files 1400 763 -637 Lines 3042319280 -11143 Branches 3389 1898-1491 - Hits 1623610048-6188 + Misses13382 8393-4989 - Partials805 839 +34 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | | [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `2.07%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 51.29% -2.08% + Complexity 2945 2869 -76 Files 1400 763 -637 Lines 3042319270 -11153 Branches 3389 1897-1492 - Hits 16236 9884-6352 + Misses13382 8565-4817 - Partials805 821 +16 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | | [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `3.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 50.32% -3.05% + Complexity 2945 2834 -111 Files 1400 761 -639 Lines 3042319264 -11159 Branches 3389 1897-1492 - Hits 16236 9695-6541 + Misses13382 8751-4631 - Partials805 818 +13 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `3.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 50.34% -3.02% + Complexity 2945 2834 -111 Files 1400 761 -639 Lines 3042319256 -11167 Branches 3389 1897-1492 - Hits 16236 9695-6541 + Misses13382 8743-4639 - Partials805 818 +13 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `2.78%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## - Coverage 53.36% 50.58% -2.79% + Complexity 2945 2834 -111 Files 1400 758 -642 Lines 3042319165 -11258 Branches 3389 1886-1503 - Hits 16236 9695-6541 + Misses13382 8652-4730 - Partials805 818 +13 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [.../server/receiver/envoy/als/DependencyResource.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0RlcGVuZGVuY3lSZXNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (-97.15%)` | `0.00% <0.00%> (ø%)` | | | [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | `0.00% <0.00%> (-90.91%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `12.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## = - Coverage 53.36% 40.65% -12.72% + Complexity 2945 2205 -740 = Files 1400 758 -642 Lines 3042319165-11258 Branches 3389 1886 -1503 = - Hits 16236 7791 -8445 + Misses1338210794 -2588 + Partials805 580 -225 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [1019 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `13.54%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## = - Coverage 53.36% 39.81% -13.55% + Complexity 2945 2171 -774 = Files 1400 758 -642 Lines 3042319162-11261 Branches 3389 1886 -1503 = - Hits 16236 7630 -8606 + Misses1338210953 -2429 + Partials805 579 -226 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [1025 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `20.47%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## = - Coverage 53.36% 32.89% -20.48% + Complexity 2945 1836 -1109 = Files 1400 757 -643 Lines 3042318906-11517 Branches 3389 1846 -1543 = - Hits 16236 6219-10017 + Misses1338212251 -1131 + Partials805 436 -369 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1053 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review full
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## = - Coverage 53.36% 32.64% -20.72% + Complexity 2945 1784 -1161 = Files 1400 741 -659 Lines 3042318506-11917 Branches 3389 1813 -1576 = - Hits 16236 6042-10194 + Misses1338212039 -1343 + Partials805 425 -380 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1064 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review full
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `21.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## = - Coverage 53.36% 32.01% -21.36% + Complexity 2945 1746 -1199 = Files 1400 741 -659 Lines 3042318506-11917 Branches 3389 1813 -1576 = - Hits 16236 5924-10312 + Misses1338212157 -1225 + Partials805 425 -380 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1069 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review full
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `21.32%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5017 +/- ## = - Coverage 53.36% 32.03% -21.33% + Complexity 2945 1746 -1199 = Files 1400 740 -660 Lines 3042318490-11933 Branches 3389 1809 -1580 = - Hits 16236 5924-10312 + Misses1338212141 -1241 + Partials805 425 -380 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1070 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review full
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `53.36%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5017 +/- ## - Coverage 53.36% 0.00% -53.37% Files 1400 159 -1241 Lines 304233923-26500 Branches 3389 466 -2923 - Hits 16236 0-16236 + Misses133823923 -9459 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `53.36%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5017 +/- ## - Coverage 53.36% 0.00% -53.37% Files 1400 157 -1243 Lines 304233911-26512 Branches 3389 466 -2923 - Hits 16236 0-16236 + Misses133823911 -9471 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] edited a comment on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `53.36%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5017 +/- ## - Coverage 53.36% 0.00% -53.37% Files 1400 154 -1246 Lines 304233864-26559 Branches 3389 461 -2928 - Hits 16236 0-16236 + Misses133823864 -9518 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1373 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] commented on pull request #5017: Optimize the code to prevent mongo statements from being too long
codecov[bot] commented on pull request #5017: URL: https://github.com/apache/skywalking/pull/5017#issuecomment-653129961 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=h1) Report > Merging [#5017](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `53.36%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5017 +/- ## - Coverage 53.36% 0.00% -53.37% Files 1400 150 -1250 Lines 304233780-26643 Branches 3389 457 -2932 - Hits 16236 0-16236 + Misses133823780 -9602 + Partials805 0 -805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5017?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/5017/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] dengliming opened a new pull request #5017: Optimize the code to prevent mongo statements from being too long
dengliming opened a new pull request #5017:
URL: https://github.com/apache/skywalking/pull/5017
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
I have a long MixedBulkWriteOperation statement in the production
environment, so modify this code to avoid this problem. Please take a look if
it makes sense.
The part of parameters are as follows:
`\"db.statement\":\"MixedBulkWriteOperation{\\\"d\\\": {\\\"$date\\\":
1593707332668}, \\\"b\\\": {\\\"$date\\\": 1593699028000}, \\\"c\\\":
{\\\"$date\\\": 1593697348000}, \\\"tid\\\": \\\"866623046287530\\\",
\\\"vid\\\": {\\\"$numberLong\\\": \\\"10317043\\\"}, \\\"a\\\":
[[\\\"112.566333\\\", \\\"29.529147\\\", \\\"1593699028\\\", \\\"39.0\\\"],
[\\\"112.567002\\\", \\\"29.52939\\\", \\\"1593699022\\\", \\\"43.0\\\"],
[\\\"112.542396\\\", \\\"29.52\\\", \\\"1593703612\\\", \\\"25.0\\\"],
[\\\"112.532834\\\", \\\"29.534214\\\", \\\"1593704944\\\", \\\"69.0\\\"],
[\\\"112.532248\\\", \\\"29.534155\\\", \\\"1593704938\\\", \\\"68.0\\\"],
[\\\"112.543031\\\", \\\"29.530055\\\", \\\"1593703606\\\", \\\"44.0\\\"],
[\\\"112.570258\\\", \\\"29.530724\\\", \\\"1593688378\\\", \\\"0.0\\\"],
[\\\"112.569889\\\", \\\"29.530871\\\", \\\"1593700588\\\", \\\"2.0\\\"],
[\\\"112.573432\\\", \\\"29.531835\\\", \\\"1593693718\\\", \\\"15.0\\\"],
[\\\"112.793778\\\", \\\"29.664507\\\", \\\"1593690682\\\", \\\"77.0\\\"],
[\\\"112.570258\\\", \\\"29.530726\\\", \\\"1593688372\\\", \\\"0.0\\\"],
[\\\"112.569769\\\", \\\"29.531007\\\", \\\"1593700582\\\", \\\"24.0\\\"],
[\\\"112.573684\\\", \\\"29.531921\\\", \\\"1593693712\\\", \\\"15.0\\\"],
[\\\"112.794695\\\", \\\"29.665287\\\", \\\"1593690688\\\", \\\"74.0\\\"],
[\\\"112.565679\\\", \\\"29.528897\\\", \\\"1593699034\\\", \\\"43.0\\\"],
[\\\"112.534283\\\", \\\"29.534365\\\", \\\"1593704950\\\", \\\"46.0\\\"],
[\\\"112.535122\\\", \\\"29.534448\\\", \\\"1593704956\\\", \\\"48.0\\\"],
[\\\"112.541453\\\", \\\"29.529875\\\", \\\"1593703624\\\", \\\"43.0\\\"],
[\\\"112.542053\\\", \\\"29.529955\\\", \\\"1593703618\\\", \\\"14.0\\\"],
[\\\"112.570258\\\", \\\"29.530723\\\", \\\"1593688384\\\", \\\"0.0\\\"],
[\\\"112.569889\\\", \\\"29.530871\\\", \\\"1593700594\\\", \\\"0.0\\\"],
[\\\"112.795917\\\", \\\"29.665807\\\", \\\"1593690694\\\", \\\"81.0\\\"],
[\\\"112.573198\\\", \\\"29.531745\\\", \\\"1593693724\\\", \\\"13.0\\\"],
[\\\"112.578163\\\", \\\"29.533483\\\", \\\"1593701890\\\", \\\"8.0\\\"],
[\\\"112.564297\\\", \\\"29.528371\\\", \\\"1593699046\\\", \\\"38.0\\\"],
[\\\"112.564955\\\", \\\"29.528621\\\", \\\"1593699040\\\", \\\"45.0\\\"],
[\\\"112.577922\\\", \\\"29.53336\\\", \\\"1593701896\\\", \\\"18.0\\\"],
[\\\"112.529023\\\", \\\"29.533802\\\", \\\"1593704920\\\", \\\"60.0\\\"],
[\\\"112.572463\\\", \\\"29.531436\\\", \\\"1593693736\\\", \\\"15.0\\\"],
[\\\"112.568133\\\", \\\"29.532407\\\", \\\"1593700564\\\", \\\"47.0\\\"],
[\\\"112.570723\\\", \\\"29.53013\\\", \\\"1593688396\\\", \\\"30.0\\\"],
[\\\"112.572798\\\", \\\"29.531563\\\", \\\"1593693730\\\", \\\"25.0\\\"],
[\\\"112.570438\\\", \\\"29.530512\\\", \\\"1593688390\\\", \\\"25.0\\\"],
[\\\"112.751139\\\", \\\"29.585057\\\", \\\"1593692404\\\", \\\"52.0\\\"],
[\\\"112.597207\\\", \\\"29.541954\\\", \\\"1593707194\\\", \\\"57.0\\\"],
[\\\"112.563399\\\", \\\"29.528264\\\", \\\"1593699058\\\", \\\"13.0\\\"],
[\\\"112.563758\\\", \\\"29.528343\\\", \\\"1593699052\\\", \\\"27.0\\\"],
[\\\"112.531107\\\", \\\"29.534032\\\", \\\"1593704932\\\", \\\"64.0\\\"],
[\\\"112.54384\\\", \\\"29.530151\\\", \\\"1593703600\\\", `
... more long
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.12%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 53.24% -0.13% + Complexity 2945 2938 -7 Files 1400 1401 +1 Lines 3042330443 +20 Branches 3389 3390 +1 - Hits 1623616210 -26 - Misses1338213428 +46 Partials805 805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | | | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.37% <0.00%> (-3.79%)` | `24.00% <0.00%> (-1.00%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `94.33% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | | | [...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh) | `66.17% <0.00%>
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.12%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 53.24% -0.13% + Complexity 2945 2938 -7 Files 1400 1401 +1 Lines 3042330443 +20 Branches 3389 3390 +1 - Hits 1623616210 -26 - Misses1338213428 +46 Partials805 805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.38% <0.00%> (-64.29%)` | `1.00% <0.00%> (-7.00%)` | | | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `58.37% <0.00%> (-3.79%)` | `24.00% <0.00%> (-1.00%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `94.33% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | | | [...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh) | `66.17% <0.00%>
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.30%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 53.06% -0.31% + Complexity 2945 2938 -7 Files 1400 767 -633 Lines 3042319359 -11064 Branches 3389 1913-1476 - Hits 1623610273-5963 + Misses13382 8231-5151 - Partials805 855 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.88%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 52.48% -0.89% + Complexity 2945 2900 -45 Files 1400 765 -635 Lines 3042319348 -11075 Branches 3389 1913-1476 - Hits 1623610155-6081 + Misses13382 8338-5044 - Partials805 855 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.91%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 52.45% -0.92% + Complexity 2945 2900 -45 Files 1400 767 -633 Lines 3042319359 -11064 Branches 3389 1913-1476 - Hits 1623610155-6081 + Misses13382 8349-5033 - Partials805 855 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.89%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 52.47% -0.90% + Complexity 2945 2898 -47 Files 1400 765 -635 Lines 3042319348 -11075 Branches 3389 1913-1476 - Hits 1623610153-6083 + Misses13382 8340-5042 - Partials805 855 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `1.66%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 51.70% -1.67% + Complexity 2945 2876 -69 Files 1400 765 -635 Lines 3042319348 -11075 Branches 3389 1913-1476 - Hits 1623610003-6233 + Misses13382 8493-4889 - Partials805 852 +47 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `2.53%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 50.83% -2.54% + Complexity 2945 2849 -96 Files 1400 765 -635 Lines 3042319348 -11075 Branches 3389 1913-1476 - Hits 16236 9836-6400 + Misses13382 8669-4713 - Partials805 843 +38 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `4.79%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 48.57% -4.80% + Complexity 2945 2754 -191 Files 1400 765 -635 Lines 3042319312 -1 Branches 3389 1912-1477 - Hits 16236 9381-6855 + Misses13382 9118-4264 - Partials805 813 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `4.69%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 48.67% -4.70% + Complexity 2945 2754 -191 Files 1400 764 -636 Lines 3042319273 -11150 Branches 3389 1911-1478 - Hits 16236 9381-6855 + Misses13382 9079-4303 - Partials805 813 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `14.56%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.36% 38.80% -14.57% + Complexity 2945 2126 -819 = Files 1400 764 -636 Lines 3042319273-11150 Branches 3389 1911 -1478 = - Hits 16236 7478 -8758 + Misses1338211220 -2162 + Partials805 575 -230 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `14.67%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.36% 38.69% -14.68% + Complexity 2945 2118 -827 = Files 1400 764 -636 Lines 3042319273-11150 Branches 3389 1911 -1478 = - Hits 16236 7458 -8778 + Misses1338211241 -2141 + Partials805 574 -231 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `15.48%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.36% 37.88% -15.49% + Complexity 2945 2084 -861 = Files 1400 764 -636 Lines 3042319270-11153 Branches 3389 1911 -1478 = - Hits 16236 7300 -8936 + Misses1338211398 -1984 + Partials805 572 -233 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `0.08%`. > The diff coverage is `46.15%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## - Coverage 53.36% 53.27% -0.09% + Complexity 2945 2944 -1 Files 1400 1401 +1 Lines 3042330444 +21 Branches 3389 3389 - Hits 1623616220 -16 - Misses1338213419 +37 Partials805 805 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `31.57% <31.57%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | | | [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `48.33% <0.00%> (-11.67%)` | `6.00% <0.00%> (-1.00%)` | | | [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `83.15% <0.00%> (-4.22%)` | `18.00% <0.00%> (-1.00%)` | | | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `75.52% <0.00%> (-4.20%)` | `9.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `15.67%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.36% 37.69% -15.68% + Complexity 2945 2076 -869 = Files 1400 764 -636 Lines 3042319270-11153 Branches 3389 1911 -1478 = - Hits 16236 7263 -8973 + Misses1338211438 -1944 + Partials805 569 -236 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `15.83%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.36% 37.53% -15.84% + Complexity 2945 2024 -921 = Files 1400 748 -652 Lines 3042318870-11553 Branches 3389 1878 -1511 = - Hits 16236 7083 -9153 + Misses1338211228 -2154 + Partials805 559 -246 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging [#4987](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d264f914d57ebef3be14c6885739c57c7106ad65=desc) will **decrease** coverage by `19.80%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4987 +/- ## = - Coverage 53.36% 33.56% -19.81% + Complexity 2945 1851 -1094 = Files 1400 748 -652 Lines 3042318852-11571 Branches 3389 1877 -1512 = - Hits 16236 6328 -9908 + Misses1338212037 -1345 + Partials805 487 -318 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...eiver/trace/provider/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTZXJ2aWNlTW9kdWxlQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...eceiver/trace/provider/TraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VTYW1wbGVSYXRlV2F0Y2hlci5qYXZh) | `36.84% <36.84%> (ø)` | `4.00 <4.00> (?)` | | | [.../provider/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1RyYWNlU2VnbWVudFNhbXBsZXIuamF2YQ==) | `75.00% <66.66%> (-5.00%)` | `2.00 <2.00> (ø)` | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | `97.87% <100.00%> (+0.14%)` | `9.00 <0.00> (ø)` | | | [...vider/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL1NlZ21lbnRBbmFseXNpc0xpc3RlbmVyLmphdmE=) | `72.72% <100.00%> (ø)` | `13.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4987/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | |
