[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] killGC commented on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
killGC commented on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-653721181 > My computer compile error, please check the code > ![image](https://user-images.githubusercontent.com/2069772/86501884-da812c80-bdcf-11ea-9dfe-dfddc4d676ff.png) >

[GitHub] [skywalking] changyuxin commented on issue #5027: [possible] SkyWalking - cglib conflict

2020-07-03 Thread GitBox
changyuxin commented on issue #5027: URL: https://github.com/apache/skywalking/issues/5027#issuecomment-653707260 OK This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng commented on issue #5027: [possible] SkyWalking - cglib conflict

2020-07-03 Thread GitBox
wu-sheng commented on issue #5027: URL: https://github.com/apache/skywalking/issues/5027#issuecomment-653706639 SkyWalking doesn't do many changes, basically two things 1. Add an interface dynamically. 1. Add several new fields(including static and instance level) for SkyWalking

[GitHub] [skywalking] changyuxin commented on issue #5027: [possible] SkyWalking - cglib conflict

2020-07-03 Thread GitBox
changyuxin commented on issue #5027: URL: https://github.com/apache/skywalking/issues/5027#issuecomment-653706570 o, thank you, I'll debug it locally This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wu-sheng commented on issue #5027: skywalking8.0.1与cglib冲突

2020-07-03 Thread GitBox
wu-sheng commented on issue #5027: URL: https://github.com/apache/skywalking/issues/5027#issuecomment-653706380 Even so, we can't know why. You need some local debug, which parts cause so-called conflict. This is an

[GitHub] [skywalking] changyuxin commented on issue #5027: skywalking8.0.1与cglib冲突

2020-07-03 Thread GitBox
changyuxin commented on issue #5027: URL: https://github.com/apache/skywalking/issues/5027#issuecomment-653705799 This exception message will appear when skywalking is used,After removing skywalking, the program runs normally

[GitHub] [skywalking] songzhendong edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
songzhendong edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-653703210 My computer compile error, please check the code ![image](https://user-images.githubusercontent.com/2069772/86501884-da812c80-bdcf-11ea-9dfe-dfddc4d676ff.png)

[GitHub] [skywalking] songzhendong commented on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
songzhendong commented on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-653703210 My computer compile error, please check the code ![image](https://user-images.githubusercontent.com/2069772/86501884-da812c80-bdcf-11ea-9dfe-dfddc4d676ff.png)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] killGC commented on a change in pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
killGC commented on a change in pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#discussion_r449608815 ## File path:

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
wu-sheng commented on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-653571247 @songzhendong Could you test this locally? As we don't have e2e for this today, and you are playing the config center these days.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
wu-sheng commented on a change in pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#discussion_r449606222 ## File path:

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5016: agent can support agent.sample_n_per_3_secs of agent property as Dynamic configuration

2020-07-03 Thread GitBox
wu-sheng commented on issue #5016: URL: https://github.com/apache/skywalking/issues/5016#issuecomment-653568919 There are a lot of gaps 1. There is no UI related to the config center, even config center itself is not required, just optional. 1. There is no `config center -> OAP ->

[GitHub] [skywalking] killGC commented on issue #5016: agent can support agent.sample_n_per_3_secs of agent property as Dynamic configuration

2020-07-03 Thread GitBox
killGC commented on issue #5016: URL: https://github.com/apache/skywalking/issues/5016#issuecomment-653564472 > How do you know this is happening? I mean `too much traffic`, how do you know the baseline? and when to do this? > And when you want to change, which are the targets, for all

[GitHub] [skywalking] wu-sheng commented on issue #5027: skywalking8.0.1监控spring boot报错

2020-07-03 Thread GitBox
wu-sheng commented on issue #5027: URL: https://github.com/apache/skywalking/issues/5027#issuecomment-653536621 What do you do? I don't see any SkyWalking codes around the exception stack. The only one is Spring Controller interceptor, which has been invoked. I don't know SkyWalking is

[GitHub] [skywalking] wu-sheng closed issue #5027: skywalking8.0.1监控spring boot报错

2020-07-03 Thread GitBox
wu-sheng closed issue #5027: URL: https://github.com/apache/skywalking/issues/5027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] changyuxin opened a new issue #5027: skywalking8.0.1监控spring boot报错

2020-07-03 Thread GitBox
changyuxin opened a new issue #5027: URL: https://github.com/apache/skywalking/issues/5027 ### Bug - Which version of SkyWalking, OS and JRE? 8.0.1 - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application,

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #321: Feat: Implement endpoint dependency and metrics

2020-07-03 Thread GitBox
wu-sheng commented on pull request #321: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/321#issuecomment-653525013 And another question for this, why `/projectB` endpoint doesn't have upstream endpoint? This doesn't match the reality.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4987: support sampleRate as Dynamic Configuration (#4968)

2020-07-03 Thread GitBox
codecov[bot] edited a comment on pull request #4987: URL: https://github.com/apache/skywalking/pull/4987#issuecomment-651079868 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4987?src=pr=h1) Report > Merging

  1   2   3   >