[skywalking] branch master updated: #4907 - Duplicate Spring MVC endpoint fix (#5084)

2020-07-14 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
 new e356da4  #4907 - Duplicate Spring MVC endpoint fix (#5084)
e356da4 is described below

commit e356da4b0e264a7617b3356febe6d6e25361f20a
Author: Brandon Fergerson 
AuthorDate: Wed Jul 15 09:52:46 2020 +0400

#4907 - Duplicate Spring MVC endpoint fix (#5084)
---
 .../spring/mvc/commons/interceptor/AbstractMethodInterceptor.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java
 
b/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java
index d601067..669d2e8 100644
--- 
a/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java
+++ 
b/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java
@@ -84,9 +84,9 @@ public abstract class AbstractMethodInterceptor implements 
InstanceMethodsAround
 if (requestURL == null) {
 requestURL = getRequestURL(method);
 pathMappingCache.addPathMapping(method, requestURL);
-requestURL = getAcceptedMethodTypes(method) + 
pathMappingCache.findPathMapping(method);
+requestURL = pathMappingCache.findPathMapping(method);
 }
-operationName = requestURL;
+operationName = getAcceptedMethodTypes(method) + requestURL;
 }
 
 HttpServletRequest request = (HttpServletRequest) 
ContextManager.getRuntimeContext()



[GitHub] [skywalking] wu-sheng merged pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-14 Thread GitBox


wu-sheng merged pull request #5084:
URL: https://github.com/apache/skywalking/pull/5084


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] wu-sheng closed issue #4907: one url has two endpoint ?

2020-07-14 Thread GitBox


wu-sheng closed issue #4907:
URL: https://github.com/apache/skywalking/issues/4907


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[skywalking-python] branch master updated: Add PyMsql Plugin (#35)

2020-07-14 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-python.git


The following commit(s) were added to refs/heads/master by this push:
 new c30b10b  Add  PyMsql Plugin (#35)
c30b10b is described below

commit c30b10bc87e2e8c58d9c882e1af04e081b5bb032
Author: huawei 
AuthorDate: Wed Jul 15 13:13:03 2020 +0800

Add  PyMsql Plugin (#35)
---
 README.md  |   1 +
 setup.py   |   3 +-
 skywalking/__init__.py |   1 +
 skywalking/plugins/sw_pymysql/__init__.py  |  57 +++
 skywalking/trace/tags/__init__.py  |   3 +
 .../tags => tests/plugin/sw_pymysql}/__init__.py   |   9 --
 tests/plugin/sw_pymysql/docker-compose.yml |  78 +++
 tests/plugin/sw_pymysql/expected.data.yml  | 109 +
 .../plugin/sw_pymysql/services}/__init__.py|   9 --
 .../plugin/sw_pymysql/services/consumer.py |  24 +++--
 .../plugin/sw_pymysql/services/provider.py |  32 --
 .../plugin/sw_pymysql/test_pymysql.py  |  30 --
 12 files changed, 319 insertions(+), 37 deletions(-)

diff --git a/README.md b/README.md
index 397ad84..55bad83 100644
--- a/README.md
+++ b/README.md
@@ -69,6 +69,7 @@ Library | Plugin Name
 | [urllib.request](https://docs.python.org/3/library/urllib.request.html) | 
`sw_urllib_request` |
 | [requests](https://requests.readthedocs.io/en/master/) | `sw_requests` |
 | [Flask](https://flask.palletsprojects.com/en/1.1.x/) | `sw_flask` |
+| [PyMySQL](https://pymysql.readthedocs.io/en/latest/) | `sw_pymysql` |
 
 ## API
 
diff --git a/setup.py b/setup.py
index 39c495f..c83df15 100644
--- a/setup.py
+++ b/setup.py
@@ -43,7 +43,8 @@ setup(
 extras_require={
 "test": [
 "testcontainers",
-"Werkzeug"
+"Werkzeug",
+"pymysql",
 ],
 },
 classifiers=[
diff --git a/skywalking/__init__.py b/skywalking/__init__.py
index f826ad6..ae9f4c4 100644
--- a/skywalking/__init__.py
+++ b/skywalking/__init__.py
@@ -26,6 +26,7 @@ class Component(Enum):
 General = 7000  # built-in modules that may not have a logo to display
 Flask = 7001
 Requests = 7002
+PyMysql = 7003
 
 
 class Layer(Enum):
diff --git a/skywalking/plugins/sw_pymysql/__init__.py 
b/skywalking/plugins/sw_pymysql/__init__.py
new file mode 100644
index 000..cc512f5
--- /dev/null
+++ b/skywalking/plugins/sw_pymysql/__init__.py
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+import logging
+
+from skywalking import Layer, Component
+from skywalking.trace import tags
+from skywalking.trace.carrier import Carrier
+from skywalking.trace.context import get_context
+from skywalking.trace.tags import Tag
+
+logger = logging.getLogger(__name__)
+
+
+def install():
+# noinspection PyBroadException
+try:
+from pymysql.cursors import Cursor
+
+_execute = Cursor.execute
+
+def _sw_execute(this: Cursor, query, args=None):
+peer = "%s:%s" % (this.connection.host, this.connection.port)
+
+context = get_context()
+carrier = Carrier()
+with context.new_exit_span(op="Mysql/PyMsql/execute", peer=peer, 
carrier=carrier) as span:
+span.layer = Layer.Database
+span.component = Component.PyMysql
+try:
+res = _execute(this, query, args)
+
+span.tag(Tag(key=tags.DbType, val="mysql"))
+span.tag(Tag(key=tags.DbInstance, 
val=this.connection.db.decode("utf-8")))
+span.tag(Tag(key=tags.DbStatement, val=query))
+
+except BaseException as e:
+span.raised()
+raise e
+return res
+
+Cursor.execute = _sw_execute
+except Exception:
+logger.warning('failed to install plugin %s', __name__)
diff --git a/skywalking/trace/tags/__init__.py 
b/skywalking/trace/tags/__init__.py
index 483e71d..0c2ec18 100644
--- 

[GitHub] [skywalking-python] kezhenxu94 merged pull request #35: Add PyMsql Plugin

2020-07-14 Thread GitBox


kezhenxu94 merged pull request #35:
URL: https://github.com/apache/skywalking-python/pull/35


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


kezhenxu94 commented on a change in pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#discussion_r454789951



##
File path: docs/en/setup/backend/backend-receivers.md
##
@@ -128,3 +129,20 @@ receiver-oc:
 gRPCHost: ${SW_OC_RECEIVER_GRPC_HOST:0.0.0.0}
 gRPCPort: ${SW_OC_RECEIVER_GRPC_PORT:55678}
 ```
+
+## Kafka receiver
+
+Kafka Receiver supports to receive `TraceSegment`, `JVMMetrics` and others of 
Agent reported as gRPC Receiver.
+Currently, it has to connect to the whole topic or single partition of topic 
when OAP is in cluster mode.
+And we have to configure **Zookeeper** as the OAP cluster management tool.

Review comment:
   I suggest not to use too many different terms when you're saying the 
same thing
   
   ```suggestion
   And we have to configure **Zookeeper** as the OAP cluster coordinator.
   ```

##
File path: docs/en/setup/backend/backend-receivers.md
##
@@ -128,3 +129,20 @@ receiver-oc:
 gRPCHost: ${SW_OC_RECEIVER_GRPC_HOST:0.0.0.0}
 gRPCPort: ${SW_OC_RECEIVER_GRPC_PORT:55678}
 ```
+
+## Kafka receiver
+
+Kafka Receiver supports to receive `TraceSegment`, `JVMMetrics` and others of 
Agent reported as gRPC Receiver.
+Currently, it has to connect to the whole topic or single partition of topic 
when OAP is in cluster mode.
+And we have to configure **Zookeeper** as the OAP cluster management tool.
+
+**Suggestion and recommend**, creating the Kafka topics by self before OAP 
Server starting. Although OAP server
+will create these if not exist.
+
+To active the `default` implementation:
+```yaml
+receiver-kafka:
+  selector: ${SW_RECEIVER_KAFKA:-}

Review comment:
   `-` won't active the implementation, instead, it disables the 
implementation

##
File path: docs/en/setup/backend/backend-receivers.md
##
@@ -128,3 +129,20 @@ receiver-oc:
 gRPCHost: ${SW_OC_RECEIVER_GRPC_HOST:0.0.0.0}
 gRPCPort: ${SW_OC_RECEIVER_GRPC_PORT:55678}
 ```
+
+## Kafka receiver

Review comment:
   The doc on agent side is missing?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.12%`.
   > The diff coverage is `31.07%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   + Coverage 52.25%   52.37%   +0.12% 
   - Complexity 2963 2971   +8 
   
 Files   778 1431 +653 
 Lines 1952331098   +11575 
 Branches   1924 3435+1511 
   
   + Hits  1020116288+6087 
   - Misses 847214005+5533 
   + Partials850  805  -45 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...t/core/kafka/KafkaContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FDb250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ng/apm/agent/core/kafka/KafkaJVMServiceSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FKVk1TZXJ2aWNlU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/apm/agent/core/kafka/KafkaProducerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FQcm9kdWNlck1hbmFnZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../apm/agent/core/kafka/KafkaProfileTaskService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FQcm9maWxlVGFza1NlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...gent/core/kafka/KafkaServiceManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FTZXJ2aWNlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/kafka/KafkaTraceSegmentService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FUcmFjZVNlZ21lbnRTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `0.47%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   51.77%   -0.48% 
   - Complexity 2963 2971   +8 
   
 Files   778  786   +8 
 Lines 1952319763 +240 
 Branches   1924 1933   +9 
   
   + Hits  1020110232  +31 
   - Misses 8472 8675 +203 
   - Partials850  856   +6 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `0.47%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   51.77%   -0.48% 
   - Complexity 2963 2971   +8 
   
 Files   778  786   +8 
 Lines 1952319763 +240 
 Branches   1924 1933   +9 
   
   + Hits  1020110232  +31 
   - Misses 8472 8675 +203 
   - Partials850  856   +6 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `0.47%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   51.77%   -0.48% 
   - Complexity 2963 2971   +8 
   
 Files   778  786   +8 
 Lines 1952319763 +240 
 Branches   1924 1933   +9 
   
   + Hits  1020110232  +31 
   - Misses 8472 8675 +203 
   - Partials850  856   +6 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `0.52%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   51.72%   -0.53% 
   - Complexity 2963 2967   +4 
   
 Files   778  786   +8 
 Lines 1952319763 +240 
 Branches   1924 1933   +9 
   
   + Hits  1020110223  +22 
   - Misses 8472 8683 +211 
   - Partials850  857   +7 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `0.56%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   51.68%   -0.57% 
   - Complexity 2963 2966   +3 
   
 Files   778  786   +8 
 Lines 1952319763 +240 
 Branches   1924 1933   +9 
   
   + Hits  1020110215  +14 
   - Misses 8472 8691 +219 
   - Partials850  857   +7 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `1.33%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   50.91%   -1.34% 
   + Complexity 2963 2942  -21 
   
 Files   778  786   +8 
 Lines 1952319745 +222 
 Branches   1924 1918   -6 
   
   - Hits  1020110053 -148 
   - Misses 8472 8852 +380 
   + Partials850  840  -10 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `1.35%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   50.89%   -1.36% 
   + Complexity 2963 2942  -21 
   
 Files   778  786   +8 
 Lines 1952319753 +230 
 Branches   1924 1932   +8 
   
   - Hits  1020110054 -147 
   - Misses 8472 8859 +387 
   + Partials850  840  -10 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `1.32%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   50.92%   -1.33% 
   + Complexity 2963 2942  -21 
   
 Files   778  784   +6 
 Lines 1952319739 +216 
 Branches   1924 1918   -6 
   
   - Hits  1020110053 -148 
   - Misses 8472 8846 +374 
   + Partials850  840  -10 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `1.33%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   50.91%   -1.34% 
   + Complexity 2963 2939  -24 
   
 Files   778  783   +5 
 Lines 1952319735 +212 
 Branches   1924 1918   -6 
   
   - Hits  1020110049 -152 
   - Misses 8472 8845 +373 
   + Partials850  841   -9 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `1.31%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   50.93%   -1.32% 
   + Complexity 2963 2942  -21 
   
 Files   778  783   +5 
 Lines 1952319735 +212 
 Branches   1924 1918   -6 
   
   - Hits  1020110053 -148 
   - Misses 8472 8842 +370 
   + Partials850  840  -10 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `1.90%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   50.34%   -1.91% 
   + Complexity 2963 2917  -46 
   
 Files   778  780   +2 
 Lines 1952319688 +165 
 Branches   1924 1914  -10 
   
   - Hits  10201 9912 -289 
   - Misses 8472 8936 +464 
   + Partials850  840  -10 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `1.22%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   51.02%   -1.23% 
   + Complexity 2963 2939  -24 
   
 Files   778  781   +3 
 Lines 1952319693 +170 
 Branches   1924 1914  -10 
   
   - Hits  1020110049 -152 
   - Misses 8472 8803 +331 
   + Partials850  841   -9 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `1.91%`.
   > The diff coverage is `16.83%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   50.33%   -1.92% 
   + Complexity 2963 2917  -46 
   
 Files   778  781   +3 
 Lines 1952319693 +170 
 Branches   1924 1914  -10 
   
   - Hits  10201 9912 -289 
   - Misses 8472 8941 +469 
   + Partials850  840  -10 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `12.62%`.
   > The diff coverage is `3.78%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 52.25%   39.62%   -12.63% 
   + Complexity 2963 2241  -722 
   =
 Files   778  780+2 
 Lines 1952319688  +165 
 Branches   1924 1914   -10 
   =
   - Hits  10201 7801 -2400 
   - Misses 847211304 +2832 
   + Partials850  583  -267 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking-python] alonelaval commented on a change in pull request #35: add PyMsql Plugin

2020-07-14 Thread GitBox


alonelaval commented on a change in pull request #35:
URL: https://github.com/apache/skywalking-python/pull/35#discussion_r454781021



##
File path: skywalking/plugins/sw_pymysql/__init__.py
##
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+import logging
+
+from skywalking import Layer, Component
+from skywalking.trace import tags
+from skywalking.trace.carrier import Carrier
+from skywalking.trace.context import get_context
+from skywalking.trace.tags import Tag
+
+logger = logging.getLogger(__name__)
+
+
+def install():
+# noinspection PyBroadException
+try:
+from pymysql.cursors import Cursor
+
+_execute = Cursor.execute
+
+def _sw_execute(this: Cursor, query, args=None):

Review comment:
   > 
   
   > we can provide another option to allow the users to collect the `args`, 
though that can be done in another PR as an enhancement, if you want to do 
that, refer to `plugin.mysql.trace_sql_parameters` and 
`plugin.mysql.sql_parameters_max_length` in 
https://github.com/apache/skywalking/blob/cc9ea271a720e8def161a583595f75da9bda77a5/docs/en/setup/service-agent/java-agent/README.md#table-of-agent-configuration-properties
   
   ok
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `2.94%`.
   > The diff coverage is `16.15%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 52.25%   49.30%   -2.95% 
   + Complexity 2963 2875  -88 
   
 Files   778  780   +2 
 Lines 1952319688 +165 
 Branches   1924 1914  -10 
   
   - Hits  10201 9707 -494 
   - Misses 8472 9160 +688 
   + Partials850  821  -29 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/ManagementConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9NYW5hZ2VtZW50Q29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../provider/handler/TraceSegmentConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9UcmFjZVNlZ21lbnRDb25zdW1lckhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...receiver/kafka/provider/KafkaConsumerProvider.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvS2Fma2FDb25zdW1lclByb3ZpZGVyLmphdmE=)
 | `20.00% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `17.82%`.
   > The diff coverage is `3.78%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 52.25%   34.42%   -17.83% 
   + Complexity 2963 2000  -963 
   =
 Files   778  779+1 
 Lines 1952319604   +81 
 Branches   1924 1912   -12 
   =
   - Hits  10201 6748 -3453 
   - Misses 847212354 +3882 
   + Partials850  502  -348 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `15.41%`.
   > The diff coverage is `3.78%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 52.25%   36.83%   -15.42% 
   + Complexity 2963 2106  -857 
   =
 Files   778  779+1 
 Lines 1952319649  +126 
 Branches   1924 1913   -11 
   =
   - Hits  10201 7238 -2963 
   - Misses 847211879 +3407 
   + Partials850  532  -318 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `18.04%`.
   > The diff coverage is `3.78%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 52.25%   34.20%   -18.05% 
   + Complexity 2963 1949 -1014 
   =
 Files   778  763   -15 
 Lines 1952319204  -319 
 Branches   1924 1879   -45 
   =
   - Hits  10201 6569 -3632 
   - Misses 847212144 +3672 
   + Partials850  491  -359 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking-python] alonelaval commented on a change in pull request #35: add PyMsql Plugin

2020-07-14 Thread GitBox


alonelaval commented on a change in pull request #35:
URL: https://github.com/apache/skywalking-python/pull/35#discussion_r454780475



##
File path: tests/plugin/sw_pymysql/services/provider.py
##
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import time
+
+from skywalking import agent, config
+
+if __name__ == '__main__':
+config.service_name = 'provider'
+config.logging_level = 'DEBUG'
+agent.start()
+
+from flask import Flask, jsonify
+import pymysql.cursors

Review comment:
   ok
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `22.15%`.
   > The diff coverage is `3.78%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 52.25%   30.09%   -22.16% 
   + Complexity 2963 1743 -1220 
   =
 Files   778  763   -15 
 Lines 1952319184  -339 
 Branches   1924 1877   -47 
   =
   - Hits  10201 5773 -4428 
   - Misses 847212965 +4493 
   + Partials850  446  -404 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `22.29%`.
   > The diff coverage is `3.78%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 52.25%   29.95%   -22.30% 
   + Complexity 2963 1734 -1229 
   =
 Files   778  763   -15 
 Lines 1952319184  -339 
 Branches   1924 1877   -47 
   =
   - Hits  10201 5747 -4454 
   - Misses 847212991 +4519 
   + Partials850  446  -404 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ka/provider/handler/JVMMetricsConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9KVk1NZXRyaWNzQ29uc3VtZXJIYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4847   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 160  -618 
 Lines 195234035-15488 
 Branches   1924 480 -1444 
   
   - Hits  10201   0-10201 
   + Misses 84724035 -4437 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [744 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4847   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 162  -616 
 Lines 195234047-15476 
 Branches   1924 480 -1444 
   
   - Hits  10201   0-10201 
   + Misses 84724047 -4425 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [744 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4847   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 157  -621 
 Lines 195233936-15587 
 Branches   1924 469 -1455 
   
   - Hits  10201   0-10201 
   + Misses 84723936 -4536 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [747 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4847   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 158  -620 
 Lines 195233976-15547 
 Branches   1924 473 -1451 
   
   - Hits  10201   0-10201 
   + Misses 84723976 -4496 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-79.67%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-72.47%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-46.92%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [747 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.16%`.
   > The diff coverage is `31.07%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   + Coverage 52.25%   52.41%   +0.16% 
   - Complexity 2963 2969   +6 
   
 Files   778 1430 +652 
 Lines 1952331063   +11540 
 Branches   1924 3437+1513 
   
   + Hits  1020116281+6080 
   - Misses 847213977+5505 
   + Partials850  805  -45 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...t/core/kafka/KafkaContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FDb250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ng/apm/agent/core/kafka/KafkaJVMServiceSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FKVk1TZXJ2aWNlU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../apm/agent/core/kafka/KafkaProfileTaskService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FQcm9maWxlVGFza1NlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ent/core/kafka/KafkaServiceManagementProducer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FTZXJ2aWNlTWFuYWdlbWVudFByb2R1Y2VyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...gent/core/kafka/KafkaServiceManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FTZXJ2aWNlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/kafka/KafkaTraceSegmentService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FUcmFjZVNlZ21lbnRTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
  

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/c5972c2b7da417ca6fe2e0e76d1eb5dac77f669c=desc)
 will **decrease** coverage by `0.68%`.
   > The diff coverage is `31.07%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   52.41%   -0.69% 
   + Complexity 2985 2969  -16 
   
 Files  1417 1430  +13 
 Lines 3071931063 +344 
 Branches   3417 3437  +20 
   
   - Hits  1631016281  -29 
   - Misses1360513977 +372 
   - Partials804  805   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...t/core/kafka/KafkaContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FDb250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ng/apm/agent/core/kafka/KafkaJVMServiceSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FKVk1TZXJ2aWNlU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../apm/agent/core/kafka/KafkaProfileTaskService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FQcm9maWxlVGFza1NlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ent/core/kafka/KafkaServiceManagementProducer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FTZXJ2aWNlTWFuYWdlbWVudFByb2R1Y2VyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...gent/core/kafka/KafkaServiceManagementService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FTZXJ2aWNlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/kafka/KafkaTraceSegmentService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FUcmFjZVNlZ21lbnRTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (ø)` | |
   | 
[...r/receiver/kafka/KafkaConsumerHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvS2Fma2FDb25zdW1lckhhbmRsZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...a/provider/handler/ProfileTaskConsumerHandler.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmcta2Fma2EtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIva2Fma2EvcHJvdmlkZXIvaGFuZGxlci9Qcm9maWxlVGFza0NvbnN1bWVySGFuZGxlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
  

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.79%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.05%   +0.79% 
   - Complexity 2963 2985  +22 
   
 Files   778 1418 +640 
 Lines 1952330720   +11197 
 Branches   1924 3416+1492 
   
   + Hits  1020116297+6096 
   - Misses 847213618+5146 
   + Partials850  805  -45 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...log/logback/v1/x/logstash/TraceIdJsonProvider.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9sb2dzdGFzaC9UcmFjZUlkSnNvblByb3ZpZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...k/v1/x/logstash/TraceIdJsonProviderActivation.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2dzdGFzaC9UcmFjZUlkSnNvblByb3ZpZGVyQWN0aXZhdGlvbi5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../v1/x/logstash/TraceIdJsonProviderInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1sb2diYWNrLTEueC1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbG9nL2xvZ2JhY2svdjEveC9sb2dzdGFzaC9UcmFjZUlkSnNvblByb3ZpZGVySW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #35: add PyMsql Plugin

2020-07-14 Thread GitBox


kezhenxu94 commented on a change in pull request #35:
URL: https://github.com/apache/skywalking-python/pull/35#discussion_r454751695



##
File path: skywalking/plugins/sw_pymysql/__init__.py
##
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+import logging
+
+from skywalking import Layer, Component
+from skywalking.trace import tags
+from skywalking.trace.carrier import Carrier
+from skywalking.trace.context import get_context
+from skywalking.trace.tags import Tag
+
+logger = logging.getLogger(__name__)
+
+
+def install():
+# noinspection PyBroadException
+try:
+from pymysql.cursors import Cursor
+
+_execute = Cursor.execute
+
+def _sw_execute(this: Cursor, query, args=None):

Review comment:
   we can provide another option to allow the users to collect the `args`, 
though that can be done in another PR as an enhancement, if you want to do 
that, refer to `plugin.mysql.trace_sql_parameters` and 
`plugin.mysql.sql_parameters_max_length` in 
https://github.com/apache/skywalking/blob/cc9ea271a720e8def161a583595f75da9bda77a5/docs/en/setup/service-agent/java-agent/README.md#table-of-agent-configuration-properties
 

##
File path: tests/plugin/sw_pymysql/services/provider.py
##
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import time
+
+from skywalking import agent, config
+
+if __name__ == '__main__':
+config.service_name = 'provider'
+config.logging_level = 'DEBUG'
+agent.start()
+
+from flask import Flask, jsonify
+import pymysql.cursors

Review comment:
   Add `pymysql` to 
https://github.com/apache/skywalking-python/blob/10f5dbdc1952d23e5cbddf75548ca87e2d378d3a/setup.py#L44-L47
 so that others could install the module when running `make setup-test` locally





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.08%   +0.83% 
   - Complexity 2963 2985  +22 
   
 Files   778  779   +1 
 Lines 1952319511  -12 
 Branches   1924 1910  -14 
   
   + Hits  1020110357 +156 
   + Misses 8472 8292 -180 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `50.34% <0.00%> (+0.34%)` | `12.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.08%   +0.83% 
   - Complexity 2963 2985  +22 
   
 Files   778  779   +1 
 Lines 1952319511  -12 
 Branches   1924 1910  -14 
   
   + Hits  1020110357 +156 
   + Misses 8472 8292 -180 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `50.34% <0.00%> (+0.34%)` | `12.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.08%   +0.83% 
   - Complexity 2963 2985  +22 
   
 Files   778  779   +1 
 Lines 1952319511  -12 
 Branches   1924 1910  -14 
   
   + Hits  1020110357 +156 
   + Misses 8472 8292 -180 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `50.34% <0.00%> (+0.34%)` | `12.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.08%   +0.83% 
   - Complexity 2963 2985  +22 
   
 Files   778  779   +1 
 Lines 1952319511  -12 
 Branches   1924 1910  -14 
   
   + Hits  1020110357 +156 
   + Misses 8472 8292 -180 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `50.34% <0.00%> (+0.34%)` | `12.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.08%   +0.83% 
   - Complexity 2963 2985  +22 
   
 Files   778  779   +1 
 Lines 1952319511  -12 
 Branches   1924 1910  -14 
   
   + Hits  1020110357 +156 
   + Misses 8472 8292 -180 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `50.34% <0.00%> (+0.34%)` | `12.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.09%   +0.84% 
   - Complexity 2963 2985  +22 
   
 Files   778  778  
 Lines 1952319507  -16 
 Branches   1924 1910  -14 
   
   + Hits  1020110357 +156 
   + Misses 8472 8288 -184 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `50.34% <0.00%> (+0.34%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.09%   +0.84% 
   - Complexity 2963 2985  +22 
   
 Files   778  778  
 Lines 1952319507  -16 
 Branches   1924 1910  -14 
   
   + Hits  1020110357 +156 
   + Misses 8472 8288 -184 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `50.34% <0.00%> (+0.34%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.82%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.07%   +0.82% 
   - Complexity 2963 2984  +21 
   
 Files   778  778  
 Lines 1952319507  -16 
 Branches   1924 1910  -14 
   
   + Hits  1020110353 +152 
   + Misses 8472 8292 -180 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [13 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.09%   +0.84% 
   - Complexity 2963 2985  +22 
   
 Files   778  778  
 Lines 1952319507  -16 
 Branches   1924 1910  -14 
   
   + Hits  1020110357 +156 
   + Misses 8472 8288 -184 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `50.34% <0.00%> (+0.34%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.17%   +0.92% 
   - Complexity 2963 2984  +21 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110353 +152 
   + Misses 8472 8253 -219 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [14 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.16%   +0.91% 
   - Complexity 2963 2982  +19 
   
 Files   778  777   -1 
 Lines 1952319468  -55 
 Branches   1924 1909  -15 
   
   + Hits  1020110351 +150 
   + Misses 8472 8255 -217 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh)
 | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh)
 | | | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `1.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.33%   +1.07% 
   - Complexity 2963 2982  +19 
   
 Files   778  775   -3 
 Lines 1952319409 -114 
 Branches   1924 1902  -22 
   
   + Hits  1020110351 +150 
   + Misses 8472 8196 -276 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh)
 | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `1.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.44%   +1.18% 
   - Complexity 2963 2982  +19 
   
 Files   778  774   -4 
 Lines 1952319369 -154 
 Branches   1924 1898  -26 
   
   + Hits  1020110351 +150 
   + Misses 8472 8156 -316 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh)
 | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `1.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.44%   +1.18% 
   - Complexity 2963 2982  +19 
   
 Files   778  774   -4 
 Lines 1952319369 -154 
 Branches   1924 1898  -26 
   
   + Hits  1020110351 +150 
   + Misses 8472 8156 -316 
   - Partials850  862  +12 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh)
 | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==)
 | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | | | |
   | 
[...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `8.51%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   - Coverage 52.25%   43.73%   -8.52% 
   + Complexity 2963 2348 -615 
   
 Files   778  771   -7 
 Lines 1952319286 -237 
 Branches   1924 1881  -43 
   
   - Hits  10201 8435-1766 
   - Misses 847210227+1755 
   + Partials850  624 -226 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [148 
more](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `8.37%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   - Coverage 52.25%   43.87%   -8.38% 
   + Complexity 2963 2348 -615 
   
 Files   778  766  -12 
 Lines 1952319226 -297 
 Branches   1924 1874  -50 
   
   - Hits  10201 8435-1766 
   - Misses 847210167+1695 
   + Partials850  624 -226 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [149 
more](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `13.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5031   +/-   ##
   =
   - Coverage 52.25%   38.79%   -13.46% 
   + Complexity 2963 2140  -823 
   =
 Files   778  764   -14 
 Lines 1952319214  -309 
 Branches   1924 1874   -50 
   =
   - Hits  10201 7455 -2746 
   - Misses 847211217 +2745 
   + Partials850  542  -308 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [186 
more](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree-more)
 | |
   
   --
   
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `13.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5031   +/-   ##
   =
   - Coverage 52.25%   38.88%   -13.37% 
   + Complexity 2963 2142  -821 
   =
 Files   778  764   -14 
 Lines 1952319214  -309 
 Branches   1924 1874   -50 
   =
   - Hits  10201 7472 -2729 
   - Misses 847211200 +2728 
   + Partials850  542  -308 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [183 
more](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree-more)
 | |
   
   --
   
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `16.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5031   +/-   ##
   =
   - Coverage 52.25%   36.13%   -16.12% 
   + Complexity 2963 1990  -973 
   =
 Files   778  748   -30 
 Lines 1952318801  -722 
 Branches   1924 1840   -84 
   =
   - Hits  10201 6794 -3407 
   - Misses 847211487 +3015 
   + Partials850  520  -330 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [232 
more](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree-more)
 | |
   
   --
   
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `21.20%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5031   +/-   ##
   =
   - Coverage 52.25%   31.04%   -21.21% 
   + Complexity 2963 1740 -1223 
   =
 Files   778  748   -30 
 Lines 1952318747  -776 
 Branches   1924 1839   -85 
   =
   - Hits  10201 5820 -4381 
   - Misses 847212471 +3999 
   + Partials850  456  -394 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [278 
more](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree-more)
 | |
   
   --
   
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.06%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   + Coverage 52.25%   52.32%   +0.06% 
   + Complexity 2963 2943  -20 
   
 Files   778  778  
 Lines 1952319524   +1 
 Branches   1924 1924  
   
   + Hits  1020110215  +14 
   + Misses 8472 8450  -22 
   - Partials850  859   +9 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-80.00%)` | `3.00% <0.00%> (-6.00%)` | |
   | 
[.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==)
 | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
   | 
[...king/oap/server/core/storage/model/ColumnName.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9Db2x1bW5OYW1lLmphdmE=)
 | `58.33% <0.00%> (-41.67%)` | `4.00% <0.00%> (-3.00%)` | |
   | 
[...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh)
 | `0.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[.../oap/server/core/storage/model/ModelInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9Nb2RlbEluc3RhbGxlci5qYXZh)
 | `27.77% <0.00%> (-27.78%)` | `3.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   + Coverage 52.25%   52.30%   +0.05% 
   + Complexity 2963 2943  -20 
   
 Files   778  780   +2 
 Lines 1952319530   +7 
 Branches   1924 1924  
   
   + Hits  1020110215  +14 
   + Misses 8472 8456  -16 
   - Partials850  859   +9 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-80.00%)` | `3.00% <0.00%> (-6.00%)` | |
   | 
[.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==)
 | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
   | 
[...king/oap/server/core/storage/model/ColumnName.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9Db2x1bW5OYW1lLmphdmE=)
 | `58.33% <0.00%> (-41.67%)` | `4.00% <0.00%> (-3.00%)` | |
   | 
[...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh)
 | `0.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[.../oap/server/core/storage/model/ModelInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9Nb2RlbEluc3RhbGxlci5qYXZh)
 | `27.77% <0.00%> (-27.78%)` | `3.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `0.64%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   - Coverage 52.25%   51.60%   -0.65% 
   + Complexity 2963 2919  -44 
   
 Files   778  778  
 Lines 1952319524   +1 
 Branches   1924 1924  
   
   - Hits  1020110076 -125 
   - Misses 8472 8590 +118 
   - Partials850  858   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-80.00%)` | `3.00% <0.00%> (-6.00%)` | |
   | 
[.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==)
 | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `0.63%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   - Coverage 52.25%   51.61%   -0.64% 
   + Complexity 2963 2919  -44 
   
 Files   778  777   -1 
 Lines 1952319520   -3 
 Branches   1924 1924  
   
   - Hits  1020110076 -125 
   - Misses 8472 8586 +114 
   - Partials850  858   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-80.00%)` | `3.00% <0.00%> (-6.00%)` | |
   | 
[.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==)
 | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `1.39%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   - Coverage 52.25%   50.86%   -1.40% 
   + Complexity 2963 2898  -65 
   
 Files   778  777   -1 
 Lines 1952319520   -3 
 Branches   1924 1924  
   
   - Hits  10201 9928 -273 
   - Misses 8472 8737 +265 
   - Partials850  855   +5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `14.28% <0.00%> (-80.00%)` | `3.00% <0.00%> (-6.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5031   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 154  -624 
 Lines 195233833-15690 
 Branches   1924 452 -1472 
   
   - Hits  10201   0-10201 
   + Misses 84723833 -4639 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [746 
more](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `3.76%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   - Coverage 52.25%   48.49%   -3.77% 
   + Complexity 2963 2798 -165 
   
 Files   778  777   -1 
 Lines 1952319484  -39 
 Branches   1924 1923   -1 
   
   - Hits  10201 9448 -753 
   - Misses 8472 9217 +745 
   + Partials850  819  -31 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==)
 | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=)
 | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `3.81%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   - Coverage 52.25%   48.43%   -3.82% 
   + Complexity 2963 2795 -168 
   
 Files   778  777   -1 
 Lines 1952319484  -39 
 Branches   1924 1923   -1 
   
   - Hits  10201 9438 -763 
   - Misses 8472 9228 +756 
   + Partials850  818  -32 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==)
 | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=)
 | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `6.80%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   - Coverage 52.25%   45.44%   -6.81% 
   + Complexity 2963 2602 -361 
   
 Files   778  761  -17 
 Lines 1952319084 -439 
 Branches   1924 1890  -34 
   
   - Hits  10201 8672-1529 
   - Misses 8472 9664+1192 
   + Partials850  748 -102 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh)
 | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
   | 
[.../server/storage/plugin/influxdb/TableMetaInfo.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9UYWJsZU1ldGFJbmZvLmphdmE=)
 | `0.00% <0.00%> (-93.34%)` | `0.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5031   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 150  -628 
 Lines 195233793-15730 
 Branches   1924 448 -1476 
   
   - Hits  10201   0-10201 
   + Misses 84723793 -4679 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [749 
more](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `8.17%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   - Coverage 52.25%   44.07%   -8.18% 
   + Complexity 2963 2553 -410 
   
 Files   778  761  -17 
 Lines 1952319070 -453 
 Branches   1924 1889  -35 
   
   - Hits  10201 8405-1796 
   - Misses 8472 9930+1458 
   + Partials850  735 -115 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...rage/plugin/influxdb/base/InfluxInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `11.03%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5095   +/-   ##
   =
   - Coverage 52.25%   41.21%   -11.04% 
   + Complexity 2963 2417  -546 
   =
 Files   778  761   -17 
 Lines 1952319054  -469 
 Branches   1924 1887   -37 
   =
   - Hits  10201 7854 -2347 
   - Misses 847210514 +2042 
   + Partials850  686  -164 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `10.94%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5095   +/-   ##
   =
   - Coverage 52.25%   41.30%   -10.95% 
   + Complexity 2963 2415  -548 
   =
 Files   778  758   -20 
 Lines 1952319007  -516 
 Branches   1924 1883   -41 
   =
   - Hits  10201 7851 -2350 
   - Misses 847210468 +1996 
   + Partials850  688  -162 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `11.04%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5095   +/-   ##
   =
   - Coverage 52.25%   41.20%   -11.05% 
   + Complexity 2963 2415  -548 
   =
 Files   778  761   -17 
 Lines 1952319054  -469 
 Branches   1924 1887   -37 
   =
   - Hits  10201 7851 -2350 
   - Misses 847210515 +2043 
   + Partials850  688  -162 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `10.93%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5095   +/-   ##
   =
   - Coverage 52.25%   41.31%   -10.94% 
   + Complexity 2963 2415  -548 
   =
 Files   778  758   -20 
 Lines 1952319001  -522 
 Branches   1924 1870   -54 
   =
   - Hits  10201 7851 -2350 
   - Misses 847210462 +1990 
   + Partials850  688  -162 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.64% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5031: issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE…

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5031:
URL: https://github.com/apache/skywalking/pull/5031#issuecomment-653839925


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=h1) 
Report
   > Merging 
[#5031](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5031/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5031  +/-   ##
   
   + Coverage 52.25%   53.11%   +0.86% 
   - Complexity 2963 2989  +26 
   
 Files   778  780   +2 
 Lines 1952319521   -2 
 Branches   1924 1910  -14 
   
   + Hits  1020110369 +168 
   + Misses 8472 8291 -181 
   - Partials850  861  +11 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5031?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=)
 | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `58.00% <0.00%> (-2.00%)` | `7.00% <0.00%> (ø%)` | |
   | 
[...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=)
 | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `50.34% <0.00%> (+0.34%)` | `12.00% <0.00%> (ø%)` | |
   | 
[.../storage/plugin/jdbc/h2/dao/H2MetricsQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5031/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc1F1ZXJ5REFPLmphdmE=)
 | `55.81% <0.00%> (+0.42%)` | `13.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `20.93%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5095   +/-   ##
   =
   - Coverage 52.25%   31.31%   -20.94% 
   + Complexity 2963 1781 -1182 
   =
 Files   778  755   -23 
 Lines 1952318951  -572 
 Branches   1924 1869   -55 
   =
   - Hits  10201 5934 -4267 
   - Misses 847212567 +4095 
   + Partials850  450  -400 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [252 
more](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `21.02%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5095   +/-   ##
   =
   - Coverage 52.25%   31.22%   -21.03% 
   + Complexity 2963 1779 -1184 
   =
 Files   778  755   -23 
 Lines 1952318951  -572 
 Branches   1924 1869   -55 
   =
   - Hits  10201 5917 -4284 
   - Misses 847212584 +4112 
   + Partials850  450  -400 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [255 
more](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `21.93%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5095   +/-   ##
   =
   - Coverage 52.25%   30.31%   -21.94% 
   + Complexity 2963 1735 -1228 
   =
 Files   778  755   -23 
 Lines 1952318939  -584 
 Branches   1924 1869   -55 
   =
   - Hits  10201 5742 -4459 
   - Misses 847212749 +4277 
   + Partials850  448  -402 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [275 
more](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `22.41%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5095   +/-   ##
   =
   - Coverage 52.25%   29.83%   -22.42% 
   + Complexity 2963 1706 -1257 
   =
 Files   778  755   -23 
 Lines 1952318939  -584 
 Branches   1924 1868   -56 
   =
   - Hits  10201 5651 -4550 
   - Misses 847212848 +4376 
   + Partials850  440  -410 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [288 
more](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5095   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 161  -617 
 Lines 195234034-15489 
 Branches   1924 483 -1441 
   
   - Hits  10201   0-10201 
   + Misses 84724034 -4438 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [742 
more](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5095   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 159  -619 
 Lines 195234022-15501 
 Branches   1924 483 -1441 
   
   - Hits  10201   0-10201 
   + Misses 84724022 -4450 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [742 
more](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5095   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 159  -619 
 Lines 195234014-15509 
 Branches   1924 483 -1441 
   
   - Hits  10201   0-10201 
   + Misses 84724014 -4458 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [743 
more](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `52.25%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5095   +/-   ##
   
   - Coverage 52.25%   0.00%   -52.26% 
   
 Files   778 149  -629 
 Lines 195233779-15744 
 Branches   1924 454 -1470 
   
   - Hits  10201   0-10201 
   + Misses 84723779 -4693 
   + Partials850   0  -850 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [751 
more](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5095: Branch quartz scheduler

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5095:
URL: https://github.com/apache/skywalking/pull/5095#issuecomment-658060228


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=h1) 
Report
   > Merging 
[#5095](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **increase** coverage by `0.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5095/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5095  +/-   ##
   
   + Coverage 52.25%   53.22%   +0.97% 
   - Complexity 2963 2994  +31 
   
 Files   778 1415 +637 
 Lines 1952330635   +2 
 Branches   1924 3430+1506 
   
   + Hits  1020116307+6106 
   - Misses 847213524+5052 
   + Partials850  804  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5095?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ticsearch7/client/ElasticSearch7InsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdJbnNlcnRSZXF1ZXN0LmphdmE=)
 | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh)
 | `84.61% <0.00%> (-15.39%)` | `4.00% <0.00%> (ø%)` | |
   | 
[...server/core/analysis/worker/AlarmNotifyWorker.java](https://codecov.io/gh/apache/skywalking/pull/5095/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL0FsYXJtTm90aWZ5V29ya2VyLmphdmE=)
 | `85.71% <0.00%> (-14.29%)` | `3.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=h1) 
Report
   > Merging 
[#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `20.32%`.
   > The diff coverage is `7.69%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5099/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5099   +/-   ##
   =
   - Coverage 52.25%   31.92%   -20.33% 
   + Complexity 2963 1837 -1126 
   =
 Files   778  765   -13 
 Lines 1952319114  -409 
 Branches   1924 1891   -33 
   =
   - Hits  10201 6102 -4099 
   - Misses 847212564 +4092 
   + Partials850  448  -402 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh)
 | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
   | 
[...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
   | 
[...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=)
 | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
   | 
[...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==)
 | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=h1) 
Report
   > Merging 
[#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `21.15%`.
   > The diff coverage is `7.69%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5099/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5099   +/-   ##
   =
   - Coverage 52.25%   31.09%   -21.16% 
   + Complexity 2963 1785 -1178 
   =
 Files   778  762   -16 
 Lines 1952319091  -432 
 Branches   1924 1891   -33 
   =
   - Hits  10201 5936 -4265 
   - Misses 847212707 +4235 
   + Partials850  448  -402 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh)
 | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
   | 
[...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
   | 
[...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=)
 | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
   | 
[...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==)
 | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=h1) 
Report
   > Merging 
[#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `20.32%`.
   > The diff coverage is `7.69%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5099/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5099   +/-   ##
   =
   - Coverage 52.25%   31.92%   -20.33% 
   + Complexity 2963 1837 -1126 
   =
 Files   778  765   -13 
 Lines 1952319114  -409 
 Branches   1924 1891   -33 
   =
   - Hits  10201 6102 -4099 
   - Misses 847212564 +4092 
   + Partials850  448  -402 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh)
 | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
   | 
[...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
   | 
[...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=)
 | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
   | 
[...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==)
 | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=h1) 
Report
   > Merging 
[#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `20.32%`.
   > The diff coverage is `7.69%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5099/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5099   +/-   ##
   =
   - Coverage 52.25%   31.92%   -20.33% 
   + Complexity 2963 1837 -1126 
   =
 Files   778  765   -13 
 Lines 1952319114  -409 
 Branches   1924 1891   -33 
   =
   - Hits  10201 6102 -4099 
   - Misses 847212564 +4092 
   + Partials850  448  -402 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh)
 | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
   | 
[...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
   | 
[...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=)
 | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
   | 
[...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==)
 | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5099: [WIP]Storage elasticsearch health check

2020-07-14 Thread GitBox


codecov[bot] edited a comment on pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099#issuecomment-658447635


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=h1) 
Report
   > Merging 
[#5099](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ce2469dbecbc137c856b262dd8df4f78dc37f60f=desc)
 will **decrease** coverage by `20.32%`.
   > The diff coverage is `7.69%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5099/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5099   +/-   ##
   =
   - Coverage 52.25%   31.92%   -20.33% 
   + Complexity 2963 1837 -1126 
   =
 Files   778  765   -13 
 Lines 1952319114  -409 
 Branches   1924 1891   -33 
   =
   - Hits  10201 6102 -4099 
   - Misses 847212564 +4092 
   + Partials850  448  -402 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5099?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh)
 | `0.00% <0.00%> (-62.85%)` | `0.00 <0.00> (-25.00)` | |
   | 
[...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh)
 | `5.40% <0.00%> (-60.82%)` | `2.00 <0.00> (-7.00)` | |
   | 
[...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==)
 | `93.18% <0.00%> (+1.51%)` | `10.00 <1.00> (ø)` | |
   | 
[...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=)
 | `50.70% <50.00%> (-2.82%)` | `12.00 <2.00> (-1.00)` | |
   | 
[...rver/library/client/healthcheck/HealthChecker.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2hlYWx0aGNoZWNrL0hlYWx0aENoZWNrZXIuamF2YQ==)
 | `57.14% <57.14%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5099/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 

  1   2   3   4   5   6   7   >