[GitHub] [skywalking-python] kezhenxu94 commented on pull request #39: Add PyMsql Sql Parameters

2020-07-17 Thread GitBox
kezhenxu94 commented on pull request #39: URL: https://github.com/apache/skywalking-python/pull/39#issuecomment-660432902 @alonelaval can you add the config into the existing test case and verify? This is an automated

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking-rocketbot-ui] alonelaval opened a new pull request #331: Add PyMsql icon

2020-07-17 Thread GitBox
alonelaval opened a new pull request #331: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] commented on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging [#5121](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=desc) into

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5121: URL: https://github.com/apache/skywalking/pull/5121#issuecomment-660417837 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5121?src=pr=h1) Report > Merging

[GitHub] [skywalking] alonelaval opened a new pull request #5121: Add PyMysql component

2020-07-17 Thread GitBox
alonelaval opened a new pull request #5121: URL: https://github.com/apache/skywalking/pull/5121 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - - [x] New feature provided - [ ] Improve performance -

[GitHub] [skywalking] wu-sheng commented on issue #5118: Spring Cloud gateway : Why all endpoind is a fixed value “WEBFLUX.handle”

2020-07-17 Thread GitBox
wu-sheng commented on issue #5118: URL: https://github.com/apache/skywalking/issues/5118#issuecomment-660395141 All things have been changed in 8.0. Read v3 protocol. Same as storage level. This is an automated message

[GitHub] [skywalking] janecms commented on issue #5118: Spring Cloud gateway : Why all endpoind is a fixed value “WEBFLUX.handle”

2020-07-17 Thread GitBox
janecms commented on issue #5118: URL: https://github.com/apache/skywalking/issues/5118#issuecomment-660394402 After upgrading to version 8.0.1, I found that the problem has been resolved. Can you tell me, if you upgrade from skywalking 6.6 to 8.0, is the underlying storage still

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
wu-sheng commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660156645 > I wonder if the plug-in configuration needs to be refactored,for example mysql At the code level, yes. But you still could keep the config name unchanged. You just

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660155212 I wonder if the plug-in configuration needs to be refactored,for example mysql This is an automated message

[GitHub] [skywalking] wu-sheng commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
wu-sheng commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660154349 Once we have this feature, this plugin will be more elegant, because there will be no code changed in the agent core, purely plugin. Same as the Kafka transport plugin.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking-python] alonelaval opened a new pull request #39: add PyMsql Sql Parameters

2020-07-17 Thread GitBox
alonelaval opened a new pull request #39: URL: https://github.com/apache/skywalking-python/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660152081 i open a new issue first This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
wu-sheng commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660150916 @EvanLjp Yes, this one and #4847 show, the config of different plugins have been keeping added into the core Config. I want to remove this first. That is the reason I

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp removed a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp removed a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660147945 @wu-sheng the PR is for agent discovery This is an automated message from the Apache Git

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660147945 @wu-sheng the PR is for agent discovery This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

  1   2   3   4   >