[GitHub] [skywalking-python] kezhenxu94 edited a comment on pull request #36: Refactor: move __init__.py to individual file

2020-07-19 Thread GitBox


kezhenxu94 edited a comment on pull request #36:
URL: https://github.com/apache/skywalking-python/pull/36#issuecomment-660610354


   The 0.2.0 is due by the end of this month, July 30, 2020



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `0.48%`.
   > The diff coverage is `28.96%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   52.60%   -0.49% 
   - Complexity 2993 3011  +18 
   
 Files  1419 1434  +15 
 Lines 3072731150 +423 
 Branches   3419 3435  +16 
   
   + Hits  1631516388  +73 
   - Misses1361213976 +364 
   + Partials800  786  -14 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...t/core/kafka/KafkaContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FDb250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ng/apm/agent/core/kafka/KafkaJVMServiceSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FKVk1TZXJ2aWNlU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/apm/agent/core/kafka/KafkaProducerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FQcm9kdWNlck1hbmFnZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...gent/core/kafka/KafkaProfileTaskServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FQcm9maWxlVGFza1NlcnZpY2VDbGllbnQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ore/kafka/KafkaServiceManagementServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FTZXJ2aWNlTWFuYWdlbWVudFNlcnZpY2VDbGllbnQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ent/core/kafka/KafkaTraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FUcmFjZVNlZ21lbnRTZXJ2aWNlQ2xpZW50LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   + Coverage 53.07%   53.10%   +0.03% 
   - Complexity 2997 3000   +3 
   
 Files  1420  783 -637 
 Lines 3081719650   -11167 
 Branches   3425 1927-1498 
   
   - Hits  1635610436-5920 
   + Misses13659 8354-5305 
   - Partials802  860  +58 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.76%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.31%   -0.77% 
   + Complexity 2997 2966  -31 
   
 Files  1420  783 -637 
 Lines 3081719647   -11170 
 Branches   3425 1927-1498 
   
   - Hits  1635610278-6078 
   + Misses13659 8511-5148 
   - Partials802  858  +56 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.74%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.32%   -0.75% 
   + Complexity 2997 2966  -31 
   
 Files  1420  781 -639 
 Lines 3081719641   -11176 
 Branches   3425 1927-1498 
   
   - Hits  1635610278-6078 
   + Misses13659 8505-5154 
   - Partials802  858  +56 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.76%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.31%   -0.77% 
   + Complexity 2997 2964  -33 
   
 Files  1420  781 -639 
 Lines 3081719641   -11176 
 Branches   3425 1927-1498 
   
   - Hits  1635610275-6081 
   + Misses13659 8508-5151 
   - Partials802  858  +56 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.73%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.34%   -0.74% 
   + Complexity 2997 2964  -33 
   
 Files  1420  779 -641 
 Lines 3081719630   -11187 
 Branches   3425 1927-1498 
   
   - Hits  1635610275-6081 
   + Misses13659 8497-5162 
   - Partials802  858  +56 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.81%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.25%   -0.82% 
   + Complexity 2997 2962  -35 
   
 Files  1420  779 -641 
 Lines 3081719630   -11187 
 Branches   3425 1927-1498 
   
   - Hits  1635610258-6098 
   + Misses13659 8514-5145 
   - Partials802  858  +56 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.91%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.15%   -0.92% 
   + Complexity 2997 2954  -43 
   
 Files  1420  779 -641 
 Lines 3081719630   -11187 
 Branches   3425 1927-1498 
   
   - Hits  1635610238-6118 
   + Misses13659 8535-5124 
   - Partials802  857  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `0.39%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   52.70%   -0.40% 
   - Complexity 2993 3011  +18 
   
 Files  1419  789 -630 
 Lines 3072719807   -10920 
 Branches   3419 1931-1488 
   
   - Hits  1631510439-5876 
   + Misses13612 8509-5103 
   - Partials800  859  +59 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.86%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.21%   -0.87% 
   + Complexity 2997 2953  -44 
   
 Files  1420  778 -642 
 Lines 3081719606   -11211 
 Branches   3425 1909-1516 
   
   - Hits  1635610237-6119 
   + Misses13659 8512-5147 
   - Partials802  857  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.90%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.17%   -0.91% 
   + Complexity 2997 2953  -44 
   
 Files  1420  779 -641 
 Lines 3081719622   -11195 
 Branches   3425 1913-1512 
   
   - Hits  1635610237-6119 
   + Misses13659 8528-5131 
   - Partials802  857  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.79%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.28%   -0.80% 
   + Complexity 2997 2953  -44 
   
 Files  1420  777 -643 
 Lines 3081719580   -11237 
 Branches   3425 1909-1516 
   
   - Hits  1635610237-6119 
   + Misses13659 8486-5173 
   - Partials802  857  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `0.87%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   52.19%   -0.88% 
   + Complexity 2997 2949  -48 
   
 Files  1420  777 -643 
 Lines 3081719580   -11237 
 Branches   3425 1909-1516 
   
   - Hits  1635610220-6136 
   + Misses13659 8504-5155 
   - Partials802  856  +54 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `1.68%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   51.38%   -1.69% 
   + Complexity 2997 2925  -72 
   
 Files  1420  777 -643 
 Lines 3081719570   -11247 
 Branches   3425 1908-1517 
   
   - Hits  1635610057-6299 
   + Misses13659 8674-4985 
   - Partials802  839  +37 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `1.67%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   51.40%   -1.68% 
   + Complexity 2997 2925  -72 
   
 Files  1420  776 -644 
 Lines 3081719565   -11252 
 Branches   3425 1908-1517 
   
   - Hits  1635610057-6299 
   + Misses13659 8669-4990 
   - Partials802  839  +37 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `1.68%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   51.39%   -1.69% 
   + Complexity 2997 2922  -75 
   
 Files  1420  776 -644 
 Lines 3081719565   -11252 
 Branches   3425 1908-1517 
   
   - Hits  1635610055-6301 
   + Misses13659 8671-4988 
   - Partials802  839  +37 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `2.38%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   50.69%   -2.39% 
   + Complexity 2997 2901  -96 
   
 Files  1420  776 -644 
 Lines 3081719565   -11252 
 Branches   3425 1908-1517 
   
   - Hits  16356 9918-6438 
   + Misses13659 8809-4850 
   - Partials802  838  +36 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `12.55%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5129   +/-   ##
   =
   - Coverage 53.07%   40.51%   -12.56% 
   + Complexity 2997 2393  -604 
   =
 Files  1420  760  -660 
 Lines 3081719069-11748 
 Branches   3425 1871 -1554 
   =
   - Hits  16356 7726 -8630 
   + Misses1365910661 -2998 
   + Partials802  682  -120 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `97.89% <100.00%> (+0.33%)` | `17.00 <1.00> (+1.00)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [1037 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `0.39%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   52.70%   -0.40% 
   - Complexity 2993 3011  +18 
   
 Files  1419  789 -630 
 Lines 3072719807   -10920 
 Branches   3419 1931-1488 
   
   - Hits  1631510439-5876 
   + Misses13612 8509-5103 
   - Partials800  859  +59 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `2.23%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   50.84%   -2.24% 
   + Complexity 2997  687-2310 
   
 Files  1420  163-1257 
 Lines 30817 4087   -26730 
 Branches   3425  484-2941 
   
   - Hits  16356 2078   -14278 
   + Misses13659 1746   -11913 
   + Partials802  263 -539 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=)
 | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | ... and [1336 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `1.91%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   51.16%   -1.92% 
   + Complexity 2997  686-2311 
   
 Files  1420  162-1258 
 Lines 30817 4048   -26769 
 Branches   3425  483-2942 
   
   - Hits  16356 2071   -14285 
   + Misses13659 1713   -11946 
   + Partials802  264 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=)
 | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | ... and [1337 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `2.40%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   50.67%   -2.41% 
   + Complexity 2997  686-2311 
   
 Files  1420  163-1257 
 Lines 30817 4087   -26730 
 Branches   3425  484-2941 
   
   - Hits  16356 2071   -14285 
   + Misses13659 1752   -11907 
   + Partials802  264 -538 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `80.00% <100.00%> (-4.75%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=)
 | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | ... and [1336 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `1.93%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5129  +/-   ##
   
   - Coverage 53.07%   51.13%   -1.94% 
   + Complexity 2997  686-2311 
   
 Files  1420  162-1258 
 Lines 30817 4048   -26769 
 Branches   3425  483-2942 
   
   - Hits  16356 2070   -14286 
   + Misses13659 1713   -11946 
   + Partials802  265 -537 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `78.33% <100.00%> (-6.42%)` | `7.00 <0.00> (ø)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==)
 | `0.00% <0.00%> (-87.06%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=)
 | `0.00% <0.00%> (-69.24%)` | `0.00% <0.00%> (ø%)` | |
   | 
[.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=)
 | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==)
 | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | 
[...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==)
 | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
   | 
[.../apm/agent/core/context/trace/TraceSegmentRef.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnRSZWYuamF2YQ==)
 | `0.00% <0.00%> (-53.34%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=)
 | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
   | ... and [1337 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `0.38%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   52.71%   -0.39% 
   - Complexity 2993 3011  +18 
   
 Files  1419  788 -631 
 Lines 3072719803   -10924 
 Branches   3419 1931-1488 
   
   - Hits  1631510439-5876 
   + Misses13612 8505-5107 
   - Partials800  859  +59 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `53.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5129   +/-   ##
   
   - Coverage 53.07%   0.00%   -53.08% 
   
 Files  1420 162 -1258 
 Lines 308174048-26769 
 Branches   3425 483 -2942 
   
   - Hits  16356   0-16356 
   + Misses136594048 -9611 
   + Partials802   0  -802 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1395 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=continue).
 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `0.36%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   52.73%   -0.37% 
   - Complexity 2993 3011  +18 
   
 Files  1419  786 -633 
 Lines 3072719797   -10930 
 Branches   3419 1931-1488 
   
   - Hits  1631510439-5876 
   + Misses13612 8499-5113 
   - Partials800  859  +59 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `1.12%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   51.96%   -1.13% 
   + Complexity 2993 2988   -5 
   
 Files  1419  786 -633 
 Lines 3072719797   -10930 
 Branches   3419 1931-1488 
   
   - Hits  1631510288-6027 
   + Misses13612 8654-4958 
   - Partials800  855  +55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `1.87%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   51.22%   -1.88% 
   + Complexity 2993 2942  -51 
   
 Files  1419  786 -633 
 Lines 3072719797   -10930 
 Branches   3419 1931-1488 
   
   - Hits  1631510141-6174 
   + Misses13612 8802-4810 
   - Partials800  854  +54 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `53.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5129   +/-   ##
   
   - Coverage 53.07%   0.00%   -53.08% 
   
 Files  1420 157 -1263 
 Lines 308173912-26905 
 Branches   3425 459 -2966 
   
   - Hits  16356   0-16356 
   + Misses136593912 -9747 
   + Partials802   0  -802 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1394 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=continue).
 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `2.73%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   50.36%   -2.74% 
   + Complexity 2993 2911  -82 
   
 Files  1419  786 -633 
 Lines 3072719797   -10930 
 Branches   3419 1931-1488 
   
   - Hits  16315 9971-6344 
   + Misses13612 8984-4628 
   - Partials800  842  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `53.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5129   +/-   ##
   
   - Coverage 53.07%   0.00%   -53.08% 
   
 Files  1420 150 -1270 
 Lines 308173801-27016 
 Branches   3425 454 -2971 
   
   - Hits  16356   0-16356 
   + Misses136593801 -9858 
   + Partials802   0  -802 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [1395 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `53.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5129   +/-   ##
   
   - Coverage 53.07%   0.00%   -53.08% 
   
 Files  1420 153 -1267 
 Lines 308173843-26974 
 Branches   3425 454 -2971 
   
   - Hits  16356   0-16356 
   + Misses136593843 -9816 
   + Partials802   0  -802 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [1395 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `53.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5129   +/-   ##
   
   - Coverage 53.07%   0.00%   -53.08% 
   
 Files  1420 147 -1273 
 Lines 308173702-27115 
 Branches   3425 443 -2982 
   
   - Hits  16356   0-16356 
   + Misses136593702 -9957 
   + Partials802   0  -802 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [1397 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `53.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5129   +/-   ##
   
   - Coverage 53.07%   0.00%   -53.08% 
   
 Files  1420 150 -1270 
 Lines 308173793-27024 
 Branches   3425 454 -2971 
   
   - Hits  16356   0-16356 
   + Misses136593793 -9866 
   + Partials802   0  -802 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [1395 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `2.73%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   50.36%   -2.74% 
   + Complexity 2993 2911  -82 
   
 Files  1419  786 -633 
 Lines 3072719797   -10930 
 Branches   3419 1931-1488 
   
   - Hits  16315 9971-6344 
   + Misses13612 8984-4628 
   - Partials800  842  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `2.68%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   50.40%   -2.69% 
   + Complexity 2993 2911  -82 
   
 Files  1419  785 -634 
 Lines 3072719781   -10946 
 Branches   3419 1927-1492 
   
   - Hits  16315 9971-6344 
   + Misses13612 8968-4644 
   - Partials800  842  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `2.61%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   50.48%   -2.62% 
   + Complexity 2993 2911  -82 
   
 Files  1419  783 -636 
 Lines 3072719750   -10977 
 Branches   3419 1927-1492 
   
   - Hits  16315 9971-6344 
   + Misses13612 8937-4675 
   - Partials800  842  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `2.59%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   50.50%   -2.60% 
   + Complexity 2993 2911  -82 
   
 Files  1419  783 -636 
 Lines 3072719742   -10985 
 Branches   3419 1927-1492 
   
   - Hits  16315 9971-6344 
   + Misses13612 8929-4683 
   - Partials800  842  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `2.79%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   50.29%   -2.80% 
   + Complexity 2993 2901  -92 
   
 Files  1419  783 -636 
 Lines 3072719742   -10985 
 Branches   3419 1927-1492 
   
   - Hits  16315 9930-6385 
   + Misses13612 8978-4634 
   - Partials800  834  +34 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `3.76%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   49.33%   -3.77% 
   + Complexity 2993 2858 -135 
   
 Files  1419  778 -641 
 Lines 3072719626   -11101 
 Branches   3419 1915-1504 
   
   - Hits  16315 9682-6633 
   + Misses13612 9122-4490 
   - Partials800  822  +22 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `4.94%`.
   > The diff coverage is `19.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   48.14%   -4.95% 
   + Complexity 2993 2769 -224 
   
 Files  1419  762 -657 
 Lines 3072719195   -11532 
 Branches   3419 1881-1538 
   
   - Hits  16315 9242-7073 
   + Misses13612 9163-4449 
   + Partials800  790  -10 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | 
[...ver/trace/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyTGlzdGVuZXJNYW5hZ2VyLmphdmE=)
 | `100.00% <ø> (ø)` | `3.00 <0.00> (?)` | |
   | 
[...eceiver/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/receiver/trace/parser/SpanTags.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9TcGFuVGFncy5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ap/server/receiver/trace/parser/TraceAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9UcmFjZUFuYWx5emVyLmphdmE=)
 | `72.22% <ø> (ø)` | `19.00 <0.00> (?)` | |
   | 
[...ceiver/trace/parser/listener/AnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9BbmFseXNpc0xpc3RlbmVyLmphdmE=)
 | `100.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | ... and 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `14.93%`.
   > The diff coverage is `5.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 53.09%   38.16%   -14.94% 
   + Complexity 2993 2130  -863 
   =
 Files  1419  762  -657 
 Lines 3072719195-11532 
 Branches   3419 1881 -1538 
   =
   - Hits  16315 7326 -8989 
   + Misses1361211318 -2294 
   + Partials800  551  -249 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-69.45%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-50.55%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `31.81% <ø> (ø)` | `5.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | ... and [1101 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] wu-sheng merged pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


wu-sheng merged pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[skywalking] branch master updated (b9892ab -> e0325a4)

2020-07-19 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from b9892ab  update ui submodule (#5128)
 add e0325a4  Configmap configuration (#4959)

No new revisions were added by this update.

Summary of changes:
 docs/en/setup/backend/dynamic-config.md|  17 
 oap-server/server-bootstrap/pom.xml|   5 +
 .../src/main/resources/application.yml |   4 +
 .../configuration-k8s-configmap}/pom.xml   |  21 ++--
 .../configmap/ConfigmapConfigurationProvider.java} |  30 +++---
 .../configmap/ConfigmapConfigurationSettings.java} |  20 ++--
 .../ConfigmapConfigurationWatcherRegister.java}|  49 -
 .../configmap/ConfigurationConfigmapInformer.java} |  67 +
 ...alking.oap.server.library.module.ModuleProvider |   2 +-
 .../ConfigmapConfigWatcherRegisterTest.java|  94 ++
 .../ConfigmapConfigurationProviderTest.java}   |  26 ++---
 .../skywalking-dynamic-configmap.example.yaml  | 109 +
 oap-server/server-configuration/pom.xml|   1 +
 13 files changed, 323 insertions(+), 122 deletions(-)
 copy oap-server/{server-receiver-plugin/opencensus-receiver-plugin => 
server-configuration/configuration-k8s-configmap}/pom.xml (73%)
 copy 
oap-server/server-configuration/{grpc-configuration-sync/src/main/java/org/apache/skywalking/oap/server/configuration/grpc/GRPCConfigurationProvider.java
 => 
configuration-k8s-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigmapConfigurationProvider.java}
 (66%)
 copy 
oap-server/{server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/ClusterModuleKubernetesConfig.java
 => 
server-configuration/configuration-k8s-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigmapConfigurationSettings.java}
 (75%)
 copy 
oap-server/server-configuration/{configuration-apollo/src/main/java/org/apache/skywalking/oap/server/configuration/apollo/ApolloConfigWatcherRegister.java
 => 
configuration-k8s-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigmapConfigurationWatcherRegister.java}
 (50%)
 copy 
oap-server/{server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
 => 
server-configuration/configuration-k8s-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigurationConfigmapInformer.java}
 (57%)
 copy oap-server/{exporter => 
server-configuration/configuration-k8s-configmap}/src/main/resources/META-INF/services/org.apache.skywalking.oap.server.library.module.ModuleProvider
 (89%)
 create mode 100644 
oap-server/server-configuration/configuration-k8s-configmap/src/test/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigmapConfigWatcherRegisterTest.java
 copy 
oap-server/{server-cluster-plugin/cluster-zookeeper-plugin/src/test/java/org/apache/skywalking/oap/server/cluster/plugin/zookeeper/ClusterModuleZookeeperProviderTest.java
 => 
server-configuration/configuration-k8s-configmap/src/test/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigmapConfigurationProviderTest.java}
 (63%)
 create mode 100644 
oap-server/server-configuration/configuration-k8s-configmap/src/test/resources/skywalking-dynamic-configmap.example.yaml



[GitHub] [skywalking] wu-sheng closed issue #4800: Is it a good idea to dynamic get config from configMap in kubernetes

2020-07-19 Thread GitBox


wu-sheng closed issue #4800:
URL: https://github.com/apache/skywalking/issues/4800


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `17.97%`.
   > The diff coverage is `5.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 53.09%   35.12%   -17.98% 
   + Complexity 2993 1978 -1015 
   =
 Files  1419  762  -657 
 Lines 3072719186-11541 
 Branches   3419 1880 -1539 
   =
   - Hits  16315 6739 -9576 
   + Misses1361211931 -1681 
   + Partials800  516  -284 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-69.45%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-50.55%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `29.54% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | ... and [1115 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `23.09%`.
   > The diff coverage is `5.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 53.09%   30.00%   -23.10% 
   + Complexity 2993 1737 -1256 
   =
 Files  1419  762  -657 
 Lines 3072719131-11596 
 Branches   3419 1878 -1541 
   =
   - Hits  16315 5740-10575 
   + Misses1361212945  -667 
   + Partials800  446  -354 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-69.45%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-50.55%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `29.54% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | ... and [1136 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `22.98%`.
   > The diff coverage is `5.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 53.09%   30.10%   -22.99% 
   + Complexity 2993 1745 -1248 
   =
 Files  1419  762  -657 
 Lines 3072719131-11596 
 Branches   3419 1878 -1541 
   =
   - Hits  16315 5760-10555 
   + Misses1361212924  -688 
   + Partials800  447  -353 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-69.45%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-50.55%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `29.54% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | ... and [1135 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `20.45%`.
   > The diff coverage is `5.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 53.09%   32.63%   -20.46% 
   + Complexity 2993 1880 -1113 
   =
 Files  1419  762  -657 
 Lines 3072719150-11577 
 Branches   3419 1879 -1540 
   =
   - Hits  16315 6250-10065 
   + Misses1361212414 -1198 
   + Partials800  486  -314 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-69.45%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-50.55%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `29.54% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | ... and [1123 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `23.19%`.
   > The diff coverage is `5.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 53.09%   29.89%   -23.20% 
   + Complexity 2993 1734 -1259 
   =
 Files  1419  762  -657 
 Lines 3072719131-11596 
 Branches   3419 1877 -1542 
   =
   - Hits  16315 5720-10595 
   + Misses1361212963  -649 
   + Partials800  448  -352 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-69.45%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-50.55%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `96.34% <ø> (ø)` | `15.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `29.54% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | ... and [1137 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `23.24%`.
   > The diff coverage is `5.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4847   +/-   ##
   =
   - Coverage 53.09%   29.84%   -23.25% 
   + Complexity 2993 1733 -1260 
   =
 Files  1419  762  -657 
 Lines 3072719131-11596 
 Branches   3419 1877 -1542 
   =
   - Hits  16315 5710-10605 
   + Misses1361212972  -640 
   + Partials800  449  -351 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-69.45%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-50.55%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `96.34% <ø> (ø)` | `15.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...r/receiver/trace/UninstrumentedGatewaysConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1VuaW5zdHJ1bWVudGVkR2F0ZXdheXNDb25maWcuamF2YQ==)
 | `29.54% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[.../oap/server/receiver/trace/module/TraceModule.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL21vZHVsZS9UcmFjZU1vZHVsZS5qYXZh)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (?)` | |
   | ... and [1137 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660663984


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=h1) 
Report
   > Merging 
[#5129](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/3fdfdf3b83a1d6d80066c321eb3f05568657aba7=desc)
 will **decrease** coverage by `21.91%`.
   > The diff coverage is `44.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5129/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5129   +/-   ##
   =
   - Coverage 53.07%   31.16%   -21.92% 
   =
 Files  1420 1356   -64 
 Lines 3081729235 -1582 
 Branches   3425 3672  +247 
   =
   - Hits  16356 9110 -7246 
   - Misses1365919306 +5647 
   - Partials802  819   +17 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5129?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `11.62% <ø> (-57.34%)` | `0.00 <0.00> (-21.00)` | |
   | 
[...p/server/core/source/ServiceInstanceJVMThread.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZUpWTVRocmVhZC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...iver/jvm/provider/handler/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTVNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `0.00% <0.00%> (-97.57%)` | `0.00 <0.00> (-16.00)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `71.66% <100.00%> (-13.08%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...he/skywalking/oap/server/core/source/Endpoint.java](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | ... and [626 
more](https://codecov.io/gh/apache/skywalking/pull/5129/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `53.09%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4847   +/-   ##
   
   - Coverage 53.09%   0.00%   -53.10% 
   
 Files  1419 159 -1260 
 Lines 307273951-26776 
 Branches   3419 469 -2950 
   
   - Hits  16315   0-16315 
   + Misses136123951 -9661 
   + Partials800   0  -800 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-69.45%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-50.55%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1372 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=continue).

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `53.09%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4847   +/-   ##
   
   - Coverage 53.09%   0.00%   -53.10% 
   
 Files  1419 157 -1262 
 Lines 307273939-26788 
 Branches   3419 469 -2950 
   
   - Hits  16315   0-16315 
   + Misses136123939 -9673 
   + Partials800   0  -800 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-84.75%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...lking/apm/agent/core/jvm/JVMServiceGRPCSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2VHUlBDU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...apm/agent/core/plugin/loader/AgentClassLoader.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=)
 | `0.00% <0.00%> (-69.45%)` | `0.00 <0.00> (-15.00)` | |
   | 
[.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-50.55%)` | `0.00 <0.00> (-9.00)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1372 
more](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=continue).

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) 
Report
   > Merging 
[#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/62f76881de990917f229e5121e9094f977599da3=desc)
 will **decrease** coverage by `0.57%`.
   > The diff coverage is `31.23%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4847/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4847  +/-   ##
   
   - Coverage 53.09%   52.51%   -0.58% 
   - Complexity 2993 3002   +9 
   
 Files  1419 1433  +14 
 Lines 3072731112 +385 
 Branches   3419 3438  +19 
   
   + Hits  1631516340  +25 
   - Misses1361213983 +371 
   + Partials800  789  -11 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...t/core/kafka/KafkaContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FDb250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ng/apm/agent/core/kafka/KafkaJVMServiceSender.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FKVk1TZXJ2aWNlU2VuZGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/apm/agent/core/kafka/KafkaProducerManager.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FQcm9kdWNlck1hbmFnZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...gent/core/kafka/KafkaProfileTaskServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FQcm9maWxlVGFza1NlcnZpY2VDbGllbnQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ore/kafka/KafkaServiceManagementServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FTZXJ2aWNlTWFuYWdlbWVudFNlcnZpY2VDbGllbnQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ent/core/kafka/KafkaTraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcmVwb3J0ZXItcGx1Z2lucy9rYWZrYS1yZXBvcnRlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUva2Fma2EvS2Fma2FUcmFjZVNlZ21lbnRTZXJ2aWNlQ2xpZW50LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=)
 | `97.56% <ø> (ø)` | `16.00 <0.00> (?)` | |
   | 
[.../receiver/trace/DBLatencyThresholdsAndWatcher.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL0RCTGF0ZW5jeVRocmVzaG9sZHNBbmRXYXRjaGVyLmphdmE=)
 | `60.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
   | 
[...erver/receiver/trace/TraceServiceModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/4847/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3RyYWNlL1RyYWNlU2VydmljZU1vZHVsZUNvbmZpZy5qYXZh)
 | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.11%`.
   > The diff coverage is `35.84%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.00%   +0.11% 
   - Complexity 2984 2997  +13 
   
 Files   781 1425 +644 
 Lines 1962230880   +11258 
 Branches   1927 3427+1500 
   
   + Hits  1037816367+5989 
   - Misses 838613710+5324 
   + Partials858  803  -55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `3.44% <3.44%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `55.55% <55.55%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `85.71% <85.71%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> 

[GitHub] [skywalking] EvanLjp commented on issue #5130: Plugin Config Loader

2020-07-19 Thread GitBox


EvanLjp commented on issue #5130:
URL: https://github.com/apache/skywalking/issues/5130#issuecomment-660785695


   ok,i read this code first



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.11%`.
   > The diff coverage is `35.84%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.00%   +0.11% 
   - Complexity 2984 2997  +13 
   
 Files   781 1425 +644 
 Lines 1962230880   +11258 
 Branches   1927 3427+1500 
   
   + Hits  1037816367+5989 
   - Misses 838613710+5324 
   + Partials858  803  -55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `3.44% <3.44%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `55.55% <55.55%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `85.71% <85.71%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> 

[GitHub] [skywalking] wu-sheng commented on issue #5130: Plugin Config Loader

2020-07-19 Thread GitBox


wu-sheng commented on issue #5130:
URL: https://github.com/apache/skywalking/issues/5130#issuecomment-660785248


   > define a container to contain the plugin config,for example Map
   
   Read `SnifferConfigInitializer#initialize`. You just need a little refactor 
about this, and support to set a new Config Class. Such as providing a new 
method `public static void initialize(String agentOptions, Class config)`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] wu-sheng commented on issue #5130: Plugin Config Loader

2020-07-19 Thread GitBox


wu-sheng commented on issue #5130:
URL: https://github.com/apache/skywalking/issues/5130#issuecomment-660784708


   > define a interface called Plugin Config
   
   Why do you need this? I think any class is suitable for Config 
initialization.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


stalary commented on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660784673


   > 
[OALLexer.g4](https://github.com/apache/skywalking/blob/master/oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4)
 and 
[OALParser.g4](https://github.com/apache/skywalking/blob/master/oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALParser.g4)
 are missing, Please follow 
[scope-definitions.md](https://github.com/apache/skywalking/blob/master/docs/en/concepts-and-designs/scope-definitions.md).
   
   Thanks. I will correct it later



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.11%`.
   > The diff coverage is `35.84%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.00%   +0.11% 
   - Complexity 2984 2997  +13 
   
 Files   781 1425 +644 
 Lines 1962230880   +11258 
 Branches   1927 3427+1500 
   
   + Hits  1037816367+5989 
   - Misses 838613710+5324 
   + Partials858  803  -55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `3.44% <3.44%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `55.55% <55.55%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `85.71% <85.71%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> 

[GitHub] [skywalking] arugal commented on pull request #5129: Add jvm_thread metrics

2020-07-19 Thread GitBox


arugal commented on pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660784230


   
[OALLexer.g4](https://github.com/apache/skywalking/blob/master/oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4)
 and 
[OALParser.g4](https://github.com/apache/skywalking/blob/master/oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALParser.g4)
 are missing, Please follow 
[scope-definitions.md](https://github.com/apache/skywalking/blob/master/docs/en/concepts-and-designs/scope-definitions.md).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.11%`.
   > The diff coverage is `35.84%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.00%   +0.11% 
   - Complexity 2984 2997  +13 
   
 Files   781 1425 +644 
 Lines 1962230880   +11258 
 Branches   1927 3427+1500 
   
   + Hits  1037816367+5989 
   - Misses 838613710+5324 
   + Partials858  803  -55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `3.44% <3.44%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `55.55% <55.55%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `85.71% <85.71%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.13%`.
   > The diff coverage is `35.84%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.02%   +0.13% 
   - Complexity 2984 2997  +13 
   
 Files   781 1424 +643 
 Lines 1962230869   +11247 
 Branches   1927 3427+1500 
   
   + Hits  1037816367+5989 
   - Misses 838613699+5313 
   + Partials858  803  -55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `3.44% <3.44%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `55.55% <55.55%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `85.71% <85.71%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `80.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 

[skywalking] branch zipkin updated: Set up across thread test.

2020-07-19 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch zipkin
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/zipkin by this push:
 new edebf0e  Set up across thread test.
edebf0e is described below

commit edebf0eba09cfd3c0c5d02dd7eee0421216fbbe3
Author: Wu Sheng 
AuthorDate: Mon Jul 20 09:49:16 2020 +0800

Set up across thread test.
---
 .../apm/agent/core/context/ContextSnapshot.java|  2 ++
 .../reporter/zipkin/ZipkinTracerContext.java   | 23 +
 .../plugin/reporter/zipkin/ContextManageTest.java  | 39 ++
 3 files changed, 64 insertions(+)

diff --git 
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextSnapshot.java
 
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextSnapshot.java
index 8031b4e..74507da 100644
--- 
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextSnapshot.java
+++ 
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextSnapshot.java
@@ -21,6 +21,7 @@ package org.apache.skywalking.apm.agent.core.context;
 import java.util.HashMap;
 import java.util.Map;
 import lombok.Getter;
+import lombok.Setter;
 import org.apache.skywalking.apm.agent.core.context.ids.DistributedTraceId;
 
 /**
@@ -29,6 +30,7 @@ import 
org.apache.skywalking.apm.agent.core.context.ids.DistributedTraceId;
  */
 public class ContextSnapshot {
 @Getter
+@Setter
 private PrimaryContextSnapshot primaryContextSnapshot;
 @Getter
 private CorrelationContext correlationContext;
diff --git 
a/apm-sniffer/optional-reporter-plugins/zipkin-reporter-plugin/src/main/java/org/apache/skywalking/apm/plugin/reporter/zipkin/ZipkinTracerContext.java
 
b/apm-sniffer/optional-reporter-plugins/zipkin-reporter-plugin/src/main/java/org/apache/skywalking/apm/plugin/reporter/zipkin/ZipkinTracerContext.java
index cee544c..9576145 100644
--- 
a/apm-sniffer/optional-reporter-plugins/zipkin-reporter-plugin/src/main/java/org/apache/skywalking/apm/plugin/reporter/zipkin/ZipkinTracerContext.java
+++ 
b/apm-sniffer/optional-reporter-plugins/zipkin-reporter-plugin/src/main/java/org/apache/skywalking/apm/plugin/reporter/zipkin/ZipkinTracerContext.java
@@ -30,6 +30,7 @@ import org.apache.skywalking.apm.agent.core.context.AsyncSpan;
 import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
 import org.apache.skywalking.apm.agent.core.context.ContextSnapshot;
 import org.apache.skywalking.apm.agent.core.context.CorrelationContext;
+import org.apache.skywalking.apm.agent.core.context.PrimaryContextSnapshot;
 import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
 
 /**
@@ -90,6 +91,7 @@ public class ZipkinTracerContext implements 
AbstractTracerContext {
 public ContextSnapshot capture() {
 final TraceContext traceContext = tracing.currentTraceContext().get();
 ContextSnapshot contextSnapshot = new 
ContextSnapshot(correlationContext);
+
contextSnapshot.setPrimaryContextSnapshot(ZipkinMockPrimaryContextSnapshot.INSTANCE);
 contextSnapshot.addCustomContext(B3_ACROSS_THREAD, traceContext);
 return contextSnapshot;
 }
@@ -179,4 +181,25 @@ public class ZipkinTracerContext implements 
AbstractTracerContext {
 }
 return zipkinSpan;
 }
+
+/**
+ * Mock Primary Context Snapshot is just a place holder for adopting 
SkyWalking kernel across thread propagation.
+ */
+private static class ZipkinMockPrimaryContextSnapshot extends 
PrimaryContextSnapshot {
+private static ZipkinMockPrimaryContextSnapshot INSTANCE = new 
ZipkinMockPrimaryContextSnapshot();
+
+private ZipkinMockPrimaryContextSnapshot() {
+super(null, null, 0, null);
+}
+
+@Override
+public boolean isFromCurrent() {
+return false;
+}
+
+@Override
+public boolean isValid() {
+return true;
+}
+}
 }
diff --git 
a/apm-sniffer/optional-reporter-plugins/zipkin-reporter-plugin/src/test/java/org/apache/skywalking/apm/plugin/reporter/zipkin/ContextManageTest.java
 
b/apm-sniffer/optional-reporter-plugins/zipkin-reporter-plugin/src/test/java/org/apache/skywalking/apm/plugin/reporter/zipkin/ContextManageTest.java
index 6b38566..3f8b14c 100644
--- 
a/apm-sniffer/optional-reporter-plugins/zipkin-reporter-plugin/src/test/java/org/apache/skywalking/apm/plugin/reporter/zipkin/ContextManageTest.java
+++ 
b/apm-sniffer/optional-reporter-plugins/zipkin-reporter-plugin/src/test/java/org/apache/skywalking/apm/plugin/reporter/zipkin/ContextManageTest.java
@@ -22,12 +22,14 @@ import java.util.List;
 import org.apache.skywalking.apm.agent.core.boot.ServiceManager;
 import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
 import 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 
[.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.08%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   52.97%   +0.08% 
   - Complexity 2984 2987   +3 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   - Hits  1037810377   -1 
   + Misses 8386 8353  -33 
   + Partials858  857   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==)
 | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
   | 
[...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=)
 | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
   | 
[...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=)
 | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **increase** coverage by `0.27%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   + Coverage 52.88%   53.16%   +0.27% 
   - Complexity 2984 2997  +13 
   
 Files   781  781  
 Lines 1962219587  -35 
 Branches   1927 1913  -14 
   
   + Hits  1037810414  +36 
   + Misses 8386 8315  -71 
 Partials858  858  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `58.08% <0.00%> (-4.42%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=)
 | | | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | | | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `1.58%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   - Coverage 52.88%   51.30%   -1.59% 
   + Complexity 2984 2928  -56 
   
 Files   781  780   -1 
 Lines 1962219548  -74 
 Branches   1927 1912  -15 
   
   - Hits  1037810029 -349 
   - Misses 8386 8676 +290 
   + Partials858  843  -15 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh)
 | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `1.60%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   - Coverage 52.88%   51.28%   -1.61% 
   + Complexity 2984 2927  -57 
   
 Files   781  778   -3 
 Lines 1962219537  -85 
 Branches   1927 1912  -15 
   
   - Hits  1037810019 -359 
   - Misses 8386 8676 +290 
   + Partials858  842  -16 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh)
 | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `14.75%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4959   +/-   ##
   =
   - Coverage 52.88%   38.13%   -14.76% 
   + Complexity 2984 2175  -809 
   =
 Files   781  778-3 
 Lines 1962219523   -99 
 Branches   1927 1911   -16 
   =
   - Hits  10378 7445 -2933 
   - Misses 838611526 +3140 
   + Partials858  552  -306 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `3.53%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4959  +/-   ##
   
   - Coverage 52.88%   49.35%   -3.54% 
   + Complexity 2984 2854 -130 
   
 Files   781  778   -3 
 Lines 1962219523  -99 
 Branches   1927 1911  -16 
   
   - Hits  10378 9635 -743 
   - Misses 8386 9064 +678 
   + Partials858  824  -34 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `21.87%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4959   +/-   ##
   =
   - Coverage 52.88%   31.01%   -21.88% 
   + Complexity 2984 1778 -1206 
   =
 Files   781  762   -19 
 Lines 1962219040  -582 
 Branches   1927 1874   -53 
   =
   - Hits  10378 5905 -4473 
   - Misses 838612688 +4302 
   + Partials858  447  -411 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `22.88%`.
   > The diff coverage is `9.43%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4959   +/-   ##
   =
   - Coverage 52.88%   30.00%   -22.89% 
   + Complexity 2984 1732 -1252 
   =
 Files   781  762   -19 
 Lines 1962219028  -594 
 Branches   1927 1874   -53 
   =
   - Hits  10378 5709 -4669 
   - Misses 838612872 +4486 
   + Partials858  447  -411 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uUHJvdmlkZXIuamF2YQ==)
 | `44.44% <44.44%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...tion/configmap/ConfigmapConfigurationSettings.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uU2V0dGluZ3MuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `52.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4959   +/-   ##
   
   - Coverage 52.88%   0.00%   -52.89% 
   
 Files   781 162  -619 
 Lines 196224001-15621 
 Branches   1927 470 -1457 
   
   - Hits  10378   0-10378 
   + Misses 83864001 -4385 
   + Partials858   0  -858 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [743 
more](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


EvanLjp commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r456986342



##
File path: docs/en/setup/backend/dynamic-config.md
##
@@ -103,3 +103,20 @@ configuration:
 appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}
 period: ${SW_CONFIG_APOLLO_PERIOD:5}
 ```
+
+## Dynamic Configuration Kuberbetes Configmap Implementation
+

Review comment:
   
![image](https://user-images.githubusercontent.com/31562192/87890941-fee53600-ca6a-11ea-9050-e7feab079b9e.png)
   code like before





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `52.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4959   +/-   ##
   
   - Coverage 52.88%   0.00%   -52.89% 
   
 Files   781 159  -622 
 Lines 196223947-15675 
 Branches   1927 463 -1464 
   
   - Hits  10378   0-10378 
   + Misses 83863947 -4439 
   + Partials858   0  -858 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [746 
more](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `52.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4959   +/-   ##
   
   - Coverage 52.88%   0.00%   -52.89% 
   
 Files   781 158  -623 
 Lines 196223942-15680 
 Branches   1927 463 -1464 
   
   - Hits  10378   0-10378 
   + Misses 83863942 - 
   + Partials858   0  -858 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [747 
more](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] EvanLjp opened a new issue #5130: Plugin Cnfig Loader

2020-07-19 Thread GitBox


EvanLjp opened a new issue #5130:
URL: https://github.com/apache/skywalking/issues/5130


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   
   - [ ] Feature or performance improvement
   
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.
   
   A spi interface to load plugin config
   
   
   ### implementation
   1. define a interface called Plugin Config
   2. define a spi interface to load Plugin Config(all config schema is defined 
by submitter)
   3. define a container to contain the plugin config,for example Map
   4. the container is shared with all agent plugins
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) 
Report
   > Merging 
[#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b9892ab1d46037093708abe77eb90ce11cded1d3=desc)
 will **decrease** coverage by `52.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4959/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4959   +/-   ##
   
   - Coverage 52.88%   0.00%   -52.89% 
   
 Files   781 149  -632 
 Lines 196223781-15841 
 Branches   1927 454 -1473 
   
   - Hits  10378   0-10378 
   + Misses 83863781 -4605 
   + Partials858   0  -858 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [753 
more](https://codecov.io/gh/apache/skywalking/pull/4959/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-19 Thread GitBox


EvanLjp commented on pull request #5120:
URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660749877


   no porblem , i would like be to open a new issue first
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] EvanLjp commented on pull request #4959: Configmap configuration

2020-07-19 Thread GitBox


EvanLjp commented on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660749551


   all done



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   3   4   5   6   >