[GitHub] [skywalking] novayoung commented on a change in pull request #5396: Optimize: truncate parameterString

novayoung commented on a change in pull request #5396: URL: https://github.com/apache/skywalking/pull/5396#discussion_r478128141 ## File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/PreparedStatementParameterBuilder.java ##

[GitHub] [skywalking] dmsolr commented on a change in pull request #5396: Optimize: truncate parameterString

dmsolr commented on a change in pull request #5396: URL: https://github.com/apache/skywalking/pull/5396#discussion_r478104142 ## File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/PreparedStatementParameterBuilder.java ## @@

[GitHub] [skywalking] dmsolr commented on a change in pull request #5396: Optimize: truncate parameterString

dmsolr commented on a change in pull request #5396: URL: https://github.com/apache/skywalking/pull/5396#discussion_r478104142 ## File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/PreparedStatementParameterBuilder.java ## @@

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

wu-sheng commented on a change in pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#discussion_r478046006 ## File path: test/plugin/scenarios/elasticjob-2.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/elasticjob/controller/CaseController.java

[GitHub] [skywalking] XuejiaoZhang commented on issue #5394: Clarify the `Observe service mesh through ALS` steps in README

XuejiaoZhang commented on issue #5394: URL: https://github.com/apache/skywalking/issues/5394#issuecomment-681323603 Could anyone update either skywalking or skywalking-kubernetes document to include the steps of integrate Skywalking with Istio through ALS via the helm install way? This

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] innerpeacez commented on issue #5394: Clarify the `Observe service mesh through ALS` steps in README

innerpeacez commented on issue #5394: URL: https://github.com/apache/skywalking/issues/5394#issuecomment-681321347 Ok i will remove it. @wu-sheng This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] hailin0 commented on a change in pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

hailin0 commented on a change in pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#discussion_r478020263 ## File path: test/plugin/scenarios/elasticjob-2.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/elasticjob/controller/CaseController.java

[GitHub] [skywalking] hailin0 commented on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

hailin0 commented on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681318454 > Why reopen? The tests fail with reasons. is misoperation This is an automated message from the

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#discussion_r478009937 ## File path: docs/en/concepts-and-designs/oal.md ## @@ -53,6 +53,12 @@ In this case, input are request of each ServiceInstanceJVMCPU scope, avg is

[GitHub] [skywalking] wu-sheng commented on issue #5394: Clarify the `Observe service mesh through ALS` steps in README

wu-sheng commented on issue #5394: URL: https://github.com/apache/skywalking/issues/5394#issuecomment-681312855 Then, I think `SW_ENVOY_ALS_ENABLED` should be removed. Because the docker entry script doesn't use this anymore. It used to be like this,

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

codecov[bot] edited a comment on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681002950 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5395?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

codecov[bot] edited a comment on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681002950 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5395?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

codecov[bot] edited a comment on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681002950 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5395?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

codecov[bot] edited a comment on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681002950 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5395?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#discussion_r477977118 ## File path: docs/en/concepts-and-designs/oal.md ## @@ -53,6 +53,12 @@ In this case, input are request of each ServiceInstanceJVMCPU scope, avg is

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

codecov[bot] edited a comment on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681002950 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5395?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

codecov[bot] edited a comment on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681002950 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5395?src=pr=h1) Report > Merging

[GitHub] [skywalking] innerpeacez commented on issue #5394: Clarify the `Observe service mesh through ALS` steps in README

innerpeacez commented on issue #5394: URL: https://github.com/apache/skywalking/issues/5394#issuecomment-681309246  Checked that this configuration exists @wu-sheng

[GitHub] [skywalking] thanq commented on pull request #5335: fix bug about webflux broken trace

thanq commented on pull request #5335: URL: https://github.com/apache/skywalking/pull/5335#issuecomment-681309082 Is this webflux use @requestbody with problem solved? i have same question, Can you give me some ideas?

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#discussion_r477968150 ## File path: docs/README.md ## @@ -66,6 +66,8 @@ If you are already familiar with SkyWalking, you could use this catalog to find * [Plugin

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] novayoung opened a new pull request #5396: Optimize: truncate parameterString

novayoung opened a new pull request #5396: URL: https://github.com/apache/skywalking/pull/5396 cut the string as soon as it reached the length limitation Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] gengmengong commented on issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index]

gengmengong commented on issue #3395: URL: https://github.com/apache/skywalking/issues/3395#issuecomment-681307691 I have met the same problem too. OAP logs: ``` 2020-08-26 23:09:09,522 - org.apache.skywalking.oap.server.core.analysis.worker.MetricsPersistentWorker -43856557

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] gengmengong removed a comment on issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index]

gengmengong removed a comment on issue #3395: URL: https://github.com/apache/skywalking/issues/3395#issuecomment-681307208 I have met the same problem too. OAP logs: `2020-08-26 23:09:09,522 - org.apache.skywalking.oap.server.core.analysis.worker.MetricsPersistentWorker

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] gengmengong commented on issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index]

gengmengong commented on issue #3395: URL: https://github.com/apache/skywalking/issues/3395#issuecomment-681307208 I have met the same problem too. OAP logs: `2020-08-26 23:09:09,522 - org.apache.skywalking.oap.server.core.analysis.worker.MetricsPersistentWorker -43856557

[GitHub] [skywalking] wu-sheng commented on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

wu-sheng commented on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681306184 Why reopen? The tests fail with reasons. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

wu-sheng commented on a change in pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#discussion_r477954433 ## File path: test/plugin/scenarios/elasticjob-2.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/elasticjob/controller/CaseController.java

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

wu-sheng commented on a change in pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#discussion_r477954206 ## File path: test/plugin/scenarios/elasticjob-2.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/elasticjob/controller/CaseController.java

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

codecov[bot] edited a comment on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681002950 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5395?src=pr=h1) Report > Merging

[GitHub] [skywalking] hailin0 removed a comment on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

hailin0 removed a comment on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681303831 > ``` > [ERROR] assertSuccess(org.apache.skywalking.apm.plugin.esjob.JobExecutorInterceptorTest) Time elapsed: 0.011 s <<< FAILURE! >

[GitHub] [skywalking] hailin0 commented on pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

hailin0 commented on pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#issuecomment-681303831 > ``` > [ERROR] assertSuccess(org.apache.skywalking.apm.plugin.esjob.JobExecutorInterceptorTest) Time elapsed: 0.011 s <<< FAILURE! > java.lang.AssertionError: >

[GitHub] [skywalking] hailin0 closed pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

hailin0 closed pull request #5395: URL: https://github.com/apache/skywalking/pull/5395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: Support Browser protocol at OAP

codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5357: JsonLogger implementation (#5356)

codecov[bot] edited a comment on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-676903106 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5357?src=pr=h1) Report > Merging

[GitHub] [skywalking] hailin0 commented on a change in pull request #5395: Add logic-endpoint and testcase for elasticjob-2.x plugin

hailin0 commented on a change in pull request #5395: URL: https://github.com/apache/skywalking/pull/5395#discussion_r477895146 ## File path: test/plugin/scenarios/elasticjob-2.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/elasticjob/job/JobConfig.java ## @@ -0,0

[GitHub] [skywalking] wu-sheng edited a comment on issue #5394: Clarify the `Observe service mesh through ALS` steps in README

wu-sheng edited a comment on issue #5394: URL: https://github.com/apache/skywalking/issues/5394#issuecomment-681248695 @innerpeacez From my understanding, `SW_ENVOY_ALS_ENABLED` system env has not been required anymore. Could you check the `application.yml` inside the image? ```

[GitHub] [skywalking] wu-sheng commented on issue #5394: Clarify the `Observe service mesh through ALS` steps in README

wu-sheng commented on issue #5394: URL: https://github.com/apache/skywalking/issues/5394#issuecomment-681248695 @innerpeacez From my understanding, `SW_ENVOY_ALS_ENABLED` system env has not been required anymore. Could you check the `application.yml` inside the image? ``

[GitHub] [skywalking-kubernetes] innerpeacez merged pull request #53: Add Values for init container in case of using private regestry;fix a whitespace/newline trimming bug

innerpeacez merged pull request #53: URL: https://github.com/apache/skywalking-kubernetes/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[skywalking-kubernetes] branch master updated: Add Values for init container in case of using private regestry; fix a whitespace/newline trimming bug (#53)

This is an automated email from the ASF dual-hosted git repository. innerpeacez pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git The following commit(s) were added to refs/heads/master by this push: new e7073eb Add Values for

[GitHub] [skywalking] innerpeacez commented on issue #5394: Clarify the `Observe service mesh through ALS` steps in README

innerpeacez commented on issue #5394: URL: https://github.com/apache/skywalking/issues/5394#issuecomment-681240810 HELM CHARTS: oap-deployment.yaml  You may also need

  1   2   3   4   5   6   >