[skywalking-nodejs] branch cleanup updated (2fa4cca -> 8edf467)

2020-11-29 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git. from 2fa4cca Clean up unused codes and polish add 8edf467 Temporarily disable review requires No

[GitHub] [skywalking] vcjmhg commented on a change in pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
vcjmhg commented on a change in pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#discussion_r532388916 ## File path: apm-sniffer/apm-sdk-plugin/logger-plugin/src/main/java/org/apache/skywalking/apm/plugin/logger/define/Log4j2LoggerInstrumentation.java

[GitHub] [skywalking-nodejs] kezhenxu94 opened a new pull request #3: Clean up unused codes and polish

2020-11-29 Thread GitBox
kezhenxu94 opened a new pull request #3: URL: https://github.com/apache/skywalking-nodejs/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] vcjmhg commented on a change in pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
vcjmhg commented on a change in pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#discussion_r532388916 ## File path: apm-sniffer/apm-sdk-plugin/logger-plugin/src/main/java/org/apache/skywalking/apm/plugin/logger/define/Log4j2LoggerInstrumentation.java

[skywalking-nodejs] branch cleanup created (now 2fa4cca)

2020-11-29 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git. at 2fa4cca Clean up unused codes and polish This branch includes the following new commits: new

[skywalking-nodejs] 01/01: Clean up unused codes and polish

2020-11-29 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch cleanup in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git commit 2fa4cca1aed3b34c5fe17c15ed72a54403b8a853 Author: kezhenxu94 AuthorDate: Mon Nov 30 15:09:44 2020 +0800

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #5: Add API && Plugin framework registry

2020-11-29 Thread GitBox
EvanLjp commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532381384 ## File path: internal/pkg/api/plugin.go ## @@ -0,0 +1,94 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[skywalking-satellite] branch plugin-framework updated (eb6ae36 -> 9f19b41)

2020-11-29 Thread liujiapeng
This is an automated email from the ASF dual-hosted git repository. liujiapeng pushed a change to branch plugin-framework in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git. from eb6ae36 polish Dispatcher comments add 9f19b41 polish comments & add ForwardType

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 This is an automated message from the Apache Git Service. To respond to the message, please log

[skywalking-kubernetes] branch cm/binary updated (1b99dc1 -> 13bfa73)

2020-11-29 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch cm/binary in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. from 1b99dc1 Update main repo commit hash add 13bfa73 Fix test No new revisions were added

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 This is an automated message from the Apache Git Service. To respond to the message, please log

[skywalking-kubernetes] branch cm/binary updated (d1ebf85 -> 1b99dc1)

2020-11-29 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch cm/binary in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. from d1ebf85 enhancement: allow mounting binary data files add 1b99dc1 Update main repo

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #5: Add API && Plugin framework registry

2020-11-29 Thread GitBox
kezhenxu94 commented on a change in pull request #5: URL: https://github.com/apache/skywalking-satellite/pull/5#discussion_r532362284 ## File path: internal/pkg/api/event.go ## @@ -0,0 +1,103 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +//

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5915: Make meter receiver support MAL

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5915: URL: https://github.com/apache/skywalking/pull/5915#issuecomment-734761122 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5915?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
EvanLjp edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735548071 > I think this feature is good for me. But there are some questions in my mind: > > > > 1. Only collect log when having an active span. But we all know

[GitHub] [skywalking] EvanLjp commented on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
EvanLjp commented on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735548071 > I think this feature is good for me. But there are some questions in my mind: > > > > 1. Only collect log when having an active span. But we all know the

[GitHub] [skywalking] wu-sheng commented on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
wu-sheng commented on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735547937 @EvanLjp We have the log integrated solution, which is complex, and binding it with trace is requiring the backend change for adding log module. The log module is

[GitHub] [skywalking] EvanLjp edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
EvanLjp edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735541538 I think this feature is good for me. But there are some questions in my mind: 1. Only collect log when having an active span. But we all know the active span

[GitHub] [skywalking] zender-projects commented on issue #5924: print warn log very fast

2020-11-29 Thread GitBox
zender-projects commented on issue #5924: URL: https://github.com/apache/skywalking/issues/5924#issuecomment-735539119 > There should be a `service-apdex-threshold.yml` file in your `/config`, which would make the `warning` goes away. Which version are you using? i use 8.1.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
wu-sheng commented on a change in pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#discussion_r532335840 ## File path: apm-sniffer/apm-sdk-plugin/logger-plugin/src/main/java/org/apache/skywalking/apm/plugin/logger/Log4j2LoggerInterceptor.java ## @@ -0,0

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
wu-sheng commented on a change in pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#discussion_r532335397 ## File path: apm-sniffer/apm-sdk-plugin/logger-plugin/src/main/java/org/apache/skywalking/apm/plugin/logger/Log4j2LoggerInterceptor.java ## @@ -0,0

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5914: [WIP]add error log(log4j,logback) to span log event

2020-11-29 Thread GitBox
codecov[bot] edited a comment on pull request #5914: URL: https://github.com/apache/skywalking/pull/5914#issuecomment-735030014 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5914?src=pr=h1) Report > Merging

  1   2   3   >