[GitHub] candyleer commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
candyleer commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387601766 this looks good for this validation. but another question. actually I want to a way to fetch the newest traces in

[GitHub] hanahmily opened a new pull request #1192: Fix #1186 Webapp read timeout config

2018-05-08 Thread GitBox
hanahmily opened a new pull request #1192: Fix #1186 Webapp read timeout config URL: https://github.com/apache/incubator-skywalking/pull/1192 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided

[GitHub] wu-sheng commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
wu-sheng commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387605003 Last 15 mins for quick search works for me. Info you that, we will add more links for trace query in beta2, which will

[GitHub] candyleer opened a new pull request #1194: Modify operationName search from match to match_phrase

2018-05-08 Thread GitBox
candyleer opened a new pull request #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New

[GitHub] candyleer commented on issue #168: Fix Trace search time is null , there is an error

2018-05-08 Thread GitBox
candyleer commented on issue #168: Fix Trace search time is null ,there is an error URL: https://github.com/apache/incubator-skywalking-ui/pull/168#issuecomment-387604376 haha , `data range` is a mistake..it's date a prototype about what i say

[GitHub] wu-sheng closed pull request #1192: Fix #1186 Webapp read timeout config

2018-05-08 Thread GitBox
wu-sheng closed pull request #1192: Fix #1186 Webapp read timeout config URL: https://github.com/apache/incubator-skywalking/pull/1192 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng closed issue #1186: Webapp read timeout config

2018-05-08 Thread GitBox
wu-sheng closed issue #1186: Webapp read timeout config URL: https://github.com/apache/incubator-skywalking/issues/1186 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng closed pull request #1189: Update UI licenses

2018-05-08 Thread GitBox
wu-sheng closed pull request #1189: Update UI licenses URL: https://github.com/apache/incubator-skywalking/pull/1189 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng opened a new issue #1188: Span detail in trace view should be in message box

2018-05-08 Thread GitBox
wu-sheng opened a new issue #1188: Span detail in trace view should be in message box URL: https://github.com/apache/incubator-skywalking/issues/1188 In Beta, we change the span in the bottom of the trace view, some one give us the feedback: > If the trace contains a lot of spans,

[GitHub] candyleer commented on issue #1184: Update FAQ doc

2018-05-08 Thread GitBox
candyleer commented on issue #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184#issuecomment-387350056 no problem This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng opened a new issue #1187: Link to trace query from Thermodynamic graph

2018-05-08 Thread GitBox
wu-sheng opened a new issue #1187: Link to trace query from Thermodynamic graph URL: https://github.com/apache/incubator-skywalking/issues/1187 User can click the each element in Thermodynamic graph, then query the traces in the given timeline and duration.

[GitHub] liuhaoyang commented on issue #1188: Span detail in trace view should be in message box

2018-05-08 Thread GitBox
liuhaoyang commented on issue #1188: Span detail in trace view should be in message box URL: https://github.com/apache/incubator-skywalking/issues/1188#issuecomment-387332715 Is it possible to support spans to collapse and expand based on dependencies? Just like zipkin:

[GitHub] wu-sheng commented on issue #1188: Span detail in trace view should be in message box

2018-05-08 Thread GitBox
wu-sheng commented on issue #1188: Span detail in trace view should be in message box URL: https://github.com/apache/incubator-skywalking/issues/1188#issuecomment-387333759 I and @hanahmily have some aggressive ideas, but we are afraid may effect the stable. So may choose an easy but

[GitHub] candyleer commented on issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-09 Thread GitBox
candyleer commented on issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198#issuecomment-387758494 get it This is an automated message from

[GitHub] wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
wu-sheng commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387764220 This is a very typical across-thread scenario, whether cross two or three threads. You should find a way hold

[GitHub] wu-sheng opened a new issue #1200: [New concept] Proposal for Manual Span

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1200: [New concept] Proposal for Manual Span URL: https://github.com/apache/incubator-skywalking/issues/1200 Consider of #1196 and #1044 , also more and more RPC framework, I want to proposal a new type of span, Concept: **Manual Span** # Manual Span

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387710468 the result may be ``` ---main- --thread-3--

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387710468 the result may be ``` ---main- --thread-3--

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387710468 the result may be ---main- --thread-3--

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387710468 the result may be ``` ---main-

[GitHub] wu-sheng commented on issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-09 Thread GitBox
wu-sheng commented on issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198#issuecomment-387753068 Also related #1199 bug. This is an automated

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387708818 @wu-sheng the work flow of `Async http client` can be drawed as:

[GitHub] ascrutae commented on issue #1190: Change the intercept point of block call way

2018-05-09 Thread GitBox
ascrutae commented on issue #1190: Change the intercept point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190#issuecomment-387718751 The stream screen snapshot: ![181525867504_

[GitHub] wu-sheng opened a new issue #1199: The cache didn't update when NetworkAddress serverType and spanLayer changed

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1199: The cache didn't update when NetworkAddress serverType and spanLayer changed URL: https://github.com/apache/incubator-skywalking/issues/1199 This issue detected when we review codes for #1198 , the cache will not update since data cached. So

[GitHub] coveralls commented on issue #1190: Change the intercept point of block call way

2018-05-09 Thread GitBox
coveralls commented on issue #1190: Change the intercept point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190#issuecomment-387471505 [![Coverage Status](https://coveralls.io/builds/16902098/badge)](https://coveralls.io/builds/16902098) Coverage

[GitHub] wu-sheng opened a new issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198 This is a high priority and blocking bug before 5.0.0-beta release. When I and @peng-yongsheng check the data in our demo env, we

[GitHub] coveralls commented on issue #1117: FAQ about protoc plugin fails when build

2018-04-27 Thread GitBox
coveralls commented on issue #1117: FAQ about protoc plugin fails when build URL: https://github.com/apache/incubator-skywalking/pull/1117#issuecomment-384678924 [![Coverage Status](https://coveralls.io/builds/16724437/badge)](https://coveralls.io/builds/16724437) Coverage

[GitHub] hanahmily commented on issue #163: Collecting topology map data

2018-04-27 Thread GitBox
hanahmily commented on issue #163: Collecting topology map data URL: https://github.com/apache/incubator-skywalking-ui/issues/163#issuecomment-384572717 ```json { "data":{ "getClusterTopology":{ "nodes":[ { "id":"-57",

[GitHub] SoberChina opened a new pull request #1126: :memo: docs(5.0): 修改文档

2018-04-27 Thread GitBox
SoberChina opened a new pull request #1126: :memo: docs(5.0): 修改文档 URL: https://github.com/apache/incubator-skywalking/pull/1126 Signed-off-by: liweigao Please answer these questions before submitting pull request - Why submit this pull request?

[GitHub] wengangJi commented on a change in pull request #1117: Protoc Plugin fails when build

2018-04-27 Thread GitBox
wengangJi commented on a change in pull request #1117: Protoc Plugin fails when build URL: https://github.com/apache/incubator-skywalking/pull/1117#discussion_r184605515 ## File path: docs/en/FAQ/Protoc-Plugin-Fails-When-Build.md ## @@ -0,0 +1,8 @@ +**Problem**: +- When

[GitHub] coveralls commented on issue #1117: FAQ about protoc plugin fails when build

2018-04-27 Thread GitBox
coveralls commented on issue #1117: FAQ about protoc plugin fails when build URL: https://github.com/apache/incubator-skywalking/pull/1117#issuecomment-384678924 [![Coverage Status](https://coveralls.io/builds/16724116/badge)](https://coveralls.io/builds/16724116) Coverage

[GitHub] coveralls commented on issue #1117: FAQ about protoc plugin fails when build

2018-04-27 Thread GitBox
coveralls commented on issue #1117: FAQ about protoc plugin fails when build URL: https://github.com/apache/incubator-skywalking/pull/1117#issuecomment-384678924 [![Coverage Status](https://coveralls.io/builds/16724281/badge)](https://coveralls.io/builds/16724281) Coverage

[GitHub] coveralls commented on issue #1126: Remove unless doc link

2018-04-27 Thread GitBox
coveralls commented on issue #1126: Remove unless doc link URL: https://github.com/apache/incubator-skywalking/pull/1126#issuecomment-384905596 [![Coverage Status](https://coveralls.io/builds/16724977/badge)](https://coveralls.io/builds/16724977) Coverage increased (+0.004%) to

[GitHub] wu-sheng commented on a change in pull request #1117: Protoc Plugin fails when build

2018-04-27 Thread GitBox
wu-sheng commented on a change in pull request #1117: Protoc Plugin fails when build URL: https://github.com/apache/incubator-skywalking/pull/1117#discussion_r184605180 ## File path: docs/README_ZH.md ## @@ -40,3 +40,7 @@ *

[GitHub] coveralls commented on issue #1117: FAQ about protoc plugin fails when build

2018-04-27 Thread GitBox
coveralls commented on issue #1117: FAQ about protoc plugin fails when build URL: https://github.com/apache/incubator-skywalking/pull/1117#issuecomment-384678924 [![Coverage Status](https://coveralls.io/builds/16724039/badge)](https://coveralls.io/builds/16724039) Coverage

[GitHub] wu-sheng closed pull request #1117: FAQ about protoc plugin fails when build

2018-04-27 Thread GitBox
wu-sheng closed pull request #1117: FAQ about protoc plugin fails when build URL: https://github.com/apache/incubator-skywalking/pull/1117 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] coveralls commented on issue #1126: Remove unless doc link

2018-04-27 Thread GitBox
coveralls commented on issue #1126: Remove unless doc link URL: https://github.com/apache/incubator-skywalking/pull/1126#issuecomment-384905596 [![Coverage Status](https://coveralls.io/builds/16724939/badge)](https://coveralls.io/builds/16724939) Coverage increased (+0.004%) to

[GitHub] coveralls commented on issue #1121: Fixed windows startup.bat script error

2018-04-27 Thread GitBox
coveralls commented on issue #1121: Fixed windows startup.bat script error URL: https://github.com/apache/incubator-skywalking/pull/1121#issuecomment-384509175 [![Coverage Status](https://coveralls.io/builds/16729312/badge)](https://coveralls.io/builds/16729312) Coverage

[GitHub] ascrutae commented on issue #1120: An exception thrown with using the startup.bat boot script on windows

2018-04-27 Thread GitBox
ascrutae commented on issue #1120: An exception thrown with using the startup.bat boot script on windows URL: https://github.com/apache/incubator-skywalking/issues/1120#issuecomment-384992066 #1121 can resolve this issue , and thanks for your contributions

[GitHub] wu-sheng closed issue #1120: An exception thrown with using the startup.bat boot script on windows

2018-04-27 Thread GitBox
wu-sheng closed issue #1120: An exception thrown with using the startup.bat boot script on windows URL: https://github.com/apache/incubator-skywalking/issues/1120 This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng closed pull request #1121: Fixed windows startup.bat script error

2018-04-27 Thread GitBox
wu-sheng closed pull request #1121: Fixed windows startup.bat script error URL: https://github.com/apache/incubator-skywalking/pull/1121 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] wu-sheng closed issue #1128: 浙江钱宝网络科技有限公司

2018-04-27 Thread GitBox
wu-sheng closed issue #1128: 浙江钱宝网络科技有限公司 URL: https://github.com/apache/incubator-skywalking/issues/1128 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] wu-sheng closed pull request #1129: Fix #1127 Comparison method violates its general contract

2018-04-27 Thread GitBox
wu-sheng closed pull request #1129: Fix #1127 Comparison method violates its general contract URL: https://github.com/apache/incubator-skywalking/pull/1129 This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng closed issue #1127: getTopNApplicationThroughput causing sorting error

2018-04-27 Thread GitBox
wu-sheng closed issue #1127: getTopNApplicationThroughput causing sorting error URL: https://github.com/apache/incubator-skywalking/issues/1127 This is an automated message from the Apache Git Service. To respond to the

[GitHub] coveralls commented on issue #1129: Fix #1127 Comparison method violates its general contract

2018-04-27 Thread GitBox
coveralls commented on issue #1129: Fix #1127 Comparison method violates its general contract URL: https://github.com/apache/incubator-skywalking/pull/1129#issuecomment-385135402 [![Coverage Status](https://coveralls.io/builds/16740112/badge)](https://coveralls.io/builds/16740112)

[GitHub] candyleer commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
candyleer commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385188021 I am interested in this feature am I'm glad to help to complete if I can.Does it mean when a user use `zipkin` in

[GitHub] candyleer commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
candyleer commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385188021 I am interested in this feature am I'm glad to help to complete if I can.Does it mean when a user use `zipkin` in

[GitHub] peng-yongsheng closed issue #1122: Set the attribute which is always 0

2018-04-28 Thread GitBox
peng-yongsheng closed issue #1122: Set the attribute which is always 0 URL: https://github.com/apache/incubator-skywalking/issues/1122 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] zuojunfang opened a new issue #1128: 浙江钱宝网络科技有限公司

2018-04-27 Thread GitBox
zuojunfang opened a new issue #1128: 浙江钱宝网络科技有限公司 URL: https://github.com/apache/incubator-skywalking/issues/1128 浙江钱宝网络科技有限公司 https://www.qsdjf.com/index.html This is an automated message from the Apache Git

[GitHub] hanahmily opened a new issue #1127: getTopNApplicationThroughput causing sorting error

2018-04-27 Thread GitBox
hanahmily opened a new issue #1127: getTopNApplicationThroughput causing sorting error URL: https://github.com/apache/incubator-skywalking/issues/1127 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x]

[GitHub] wu-sheng commented on issue #1128: 浙江钱宝网络科技有限公司

2018-04-27 Thread GitBox
wu-sheng commented on issue #1128: 浙江钱宝网络科技有限公司 URL: https://github.com/apache/incubator-skywalking/issues/1128#issuecomment-385133693 Please comment in here: https://github.com/apache/incubator-skywalking/issues/443 Thanks for sharing.

[GitHub] zuojunfang commented on issue #443: Which companies are using SkyWalking

2018-04-27 Thread GitBox
zuojunfang commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-385133686 浙江钱宝网络科技有限公司 https://www.qsdjf.com/index.html This is an

[GitHub] hanahmily opened a new pull request #1129: Fix #1127 Comparison method violates its general contract

2018-04-27 Thread GitBox
hanahmily opened a new pull request #1129: Fix #1127 Comparison method violates its general contract URL: https://github.com/apache/incubator-skywalking/pull/1129 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ]

[GitHub] wu-sheng commented on issue #1129: Fix #1127 Comparison method violates its general contract

2018-04-27 Thread GitBox
wu-sheng commented on issue #1129: Fix #1127 Comparison method violates its general contract URL: https://github.com/apache/incubator-skywalking/pull/1129#issuecomment-385134452 FYI @peng-yongsheng When there are two or more same values in list, trigger the exception.

[GitHub] ascrutae commented on issue #1120: An exception thrown with using the startup.bat boot script on windows

2018-04-27 Thread GitBox
ascrutae commented on issue #1120: An exception thrown with using the startup.bat boot script on windows URL: https://github.com/apache/incubator-skywalking/issues/1120#issuecomment-384874016 Maybe you can try the following command and it seems works: ``` > set

[GitHub] ascrutae commented on issue #1120: An exception thrown with using the startup.bat boot script on windows

2018-04-27 Thread GitBox
ascrutae commented on issue #1120: An exception thrown with using the startup.bat boot script on windows URL: https://github.com/apache/incubator-skywalking/issues/1120#issuecomment-384874016 Maybe you can try the following command and it seems works: ``` > set

[GitHub] yuleyule66 commented on issue #1120: An exception thrown with using the startup.bat boot script on windows

2018-04-27 Thread GitBox
yuleyule66 commented on issue #1120: An exception thrown with using the startup.bat boot script on windows URL: https://github.com/apache/incubator-skywalking/issues/1120#issuecomment-384872175 @ascrutae Hello, This is my console output : ``` > echo %JAVA_HOME% C:\Program

[GitHub] yuleyule66 commented on issue #1120: An exception thrown with using the startup.bat boot script on windows

2018-04-27 Thread GitBox
yuleyule66 commented on issue #1120: An exception thrown with using the startup.bat boot script on windows URL: https://github.com/apache/incubator-skywalking/issues/1120#issuecomment-384876111 I think i found the reason , my `JAVA_HOME` env is `C:\Program Files\Java\jdk1.8.0_151\` ,

[GitHub] yuleyule66 commented on issue #1120: An exception thrown with using the startup.bat boot script on windows

2018-04-27 Thread GitBox
yuleyule66 commented on issue #1120: An exception thrown with using the startup.bat boot script on windows URL: https://github.com/apache/incubator-skywalking/issues/1120#issuecomment-384876111 I think i found the reason , my `JAVA_HOME` env is `C:\Program Files\Java\jdk1.8.0_151\` ,

[GitHub] wu-sheng opened a new issue #1130: Remove alarm in topology and application topology

2018-04-28 Thread GitBox
wu-sheng opened a new issue #1130: Remove alarm in topology and application topology URL: https://github.com/apache/incubator-skywalking/issues/1130 Alarm in these two page bring people confuse, when some application trigger alarm in a short window during the query time. So, I

[GitHub] wu-sheng opened a new issue #1131: Use timeline graph to show alarm in topology and application topology page

2018-04-28 Thread GitBox
wu-sheng opened a new issue #1131: Use timeline graph to show alarm in topology and application topology page URL: https://github.com/apache/incubator-skywalking/issues/1131 This feature should replace the current alarm visualization, old will be removed in #1130 . Each

[GitHub] wu-sheng opened a new issue #1132: Support graph query based on duration

2018-04-28 Thread GitBox
wu-sheng opened a new issue #1132: Support graph query based on duration URL: https://github.com/apache/incubator-skywalking/issues/1132 For interact with #1131 , when click the alarm in timeline graph, the page should jump to alarm page and query which alarms occur.

[GitHub] peng-yongsheng opened a new pull request #1133: Use LinkList to collect unique records.

2018-04-28 Thread GitBox
peng-yongsheng opened a new pull request #1133: Use LinkList to collect unique records. URL: https://github.com/apache/incubator-skywalking/pull/1133 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Improve performance -

[GitHub] coveralls commented on issue #1133: Use LinkList to collect unique records.

2018-04-28 Thread GitBox
coveralls commented on issue #1133: Use LinkList to collect unique records. URL: https://github.com/apache/incubator-skywalking/pull/1133#issuecomment-385176117 [![Coverage Status](https://coveralls.io/builds/16742848/badge)](https://coveralls.io/builds/16742848) Coverage

[GitHub] coveralls commented on issue #1209: Update screenshot for new release.

2018-05-10 Thread GitBox
coveralls commented on issue #1209: Update screenshot for new release. URL: https://github.com/apache/incubator-skywalking/pull/1209#issuecomment-387995728 [![Coverage Status](https://coveralls.io/builds/16917599/badge)](https://coveralls.io/builds/16917599) Coverage remained

[GitHub] wu-sheng closed pull request #1190: Change the intercept point of block call way

2018-05-10 Thread GitBox
wu-sheng closed pull request #1190: Change the intercept point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] wu-sheng commented on issue #1193: New screenshots for beta release.

2018-05-10 Thread GitBox
wu-sheng commented on issue #1193: New screenshots for beta release. URL: https://github.com/apache/incubator-skywalking/issues/1193#issuecomment-388008274 fixed in #1044 This is an automated message from the Apache Git

[GitHub] wu-sheng closed issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception

2018-05-10 Thread GitBox
wu-sheng closed issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044 This is an automated message from the Apache Git

[GitHub] wu-sheng commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception

2018-05-10 Thread GitBox
wu-sheng commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044#issuecomment-387991592 Fixed in #1190 This is

[GitHub] wu-sheng commented on issue #1193: New screenshots for beta release.

2018-05-10 Thread GitBox
wu-sheng commented on issue #1193: New screenshots for beta release. URL: https://github.com/apache/incubator-skywalking/issues/1193#issuecomment-388008274 fixed in #1044 This is an automated message from the Apache Git

[GitHub] wu-sheng closed issue #1193: New screenshots for beta release.

2018-05-10 Thread GitBox
wu-sheng closed issue #1193: New screenshots for beta release. URL: https://github.com/apache/incubator-skywalking/issues/1193 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wu-sheng closed pull request #1209: Update screenshot for new release.

2018-05-10 Thread GitBox
wu-sheng closed pull request #1209: Update screenshot for new release. URL: https://github.com/apache/incubator-skywalking/pull/1209 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] coveralls commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
coveralls commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388049701 [![Coverage Status](https://coveralls.io/builds/16920576/badge)](https://coveralls.io/builds/16920576) Coverage increased

[GitHub] leizhiyuan opened a new pull request #1210: sofa rpc integration

2018-05-10 Thread GitBox
leizhiyuan opened a new pull request #1210: sofa rpc integration URL: https://github.com/apache/incubator-skywalking/pull/1210 Please answer these questions before submitting pull request - Why submit this pull request? New feature provided, support sofa rpc - Related

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388057995 FYI @candyleer welcome to join the reviewer team. This is an automated

[GitHub] wu-sheng commented on issue #1166: Optimize topology query

2018-05-09 Thread GitBox
wu-sheng commented on issue #1166: Optimize topology query URL: https://github.com/apache/incubator-skywalking/issues/1166#issuecomment-387940889 Replace by #1202 This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng opened a new issue #1202: Topology query performance optimization

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1202: Topology query performance optimization URL: https://github.com/apache/incubator-skywalking/issues/1202 Right now, many system has a huge number of applications, and complex topology map. Suggest add a new column to reduce the group op in topology query.

[GitHub] wu-sheng closed issue #1166: Optimize topology query

2018-05-09 Thread GitBox
wu-sheng closed issue #1166: Optimize topology query URL: https://github.com/apache/incubator-skywalking/issues/1166 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng commented on issue #1203: Tracking ignores need to be enhanced

2018-05-09 Thread GitBox
wu-sheng commented on issue #1203: Tracking ignores need to be enhanced URL: https://github.com/apache/incubator-skywalking/issues/1203#issuecomment-387943088 I agree that. And I think we are welcome to discuss and accept this filter mechanism as an optional plugin.

[GitHub] wu-sheng commented on issue #937: Click the Application Menu, Topological graph may Invalid

2018-05-09 Thread GitBox
wu-sheng commented on issue #937: Click the Application Menu, Topological graph may Invalid URL: https://github.com/apache/incubator-skywalking/issues/937#issuecomment-387942880 I will close this for now. No further report since alpha release.

[GitHub] wu-sheng closed issue #937: Click the Application Menu, Topological graph may Invalid

2018-05-09 Thread GitBox
wu-sheng closed issue #937: Click the Application Menu, Topological graph may Invalid URL: https://github.com/apache/incubator-skywalking/issues/937 This is an automated message from the Apache Git Service. To respond to

[GitHub] candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception

2018-05-09 Thread GitBox
candyleer commented on issue #1196: Complex span info for AsyncHttpClient and exception URL: https://github.com/apache/incubator-skywalking/issues/1196#issuecomment-387959620 understand,I have some solution This is an

[GitHub] wu-sheng opened a new issue #1201: Can't show the detail of Span with empty operation name

2018-05-09 Thread GitBox
wu-sheng opened a new issue #1201: Can't show the detail of Span with empty operation name URL: https://github.com/apache/incubator-skywalking/issues/1201 In trace view, when a span has an empty operation name, the current page can't show it.

[GitHub] SevenPointOld opened a new issue #1203: Tracking ignores need to be enhanced

2018-05-09 Thread GitBox
SevenPointOld opened a new issue #1203: Tracking ignores need to be enhanced URL: https://github.com/apache/incubator-skywalking/issues/1203 There is a need to ignore some special requests for applications, such as pulling services from the registry, pulling configurations from the

[GitHub] wu-sheng opened a new issue #1204: Add folder lock to collector's buffer folder

2018-05-10 Thread GitBox
wu-sheng opened a new issue #1204: Add folder lock to collector's buffer folder URL: https://github.com/apache/incubator-skywalking/issues/1204 Based on #1198 , this is a very serious issue, which is also hard to pinpoint. I suggest the collector to add a folder lock mechanism to prevent

[GitHub] wu-sheng opened a new issue #1206: Accept multi entry spans in collector analysis

2018-05-10 Thread GitBox
wu-sheng opened a new issue #1206: Accept multi entry spans in collector analysis URL: https://github.com/apache/incubator-skywalking/issues/1206 Because of MQ consumer, there may have multiple entry spans in a single segment. The collector segment parser should support on this.

[GitHub] wu-sheng opened a new issue #1207: Tolerate and ignore unsupport segments

2018-05-10 Thread GitBox
wu-sheng opened a new issue #1207: Tolerate and ignore unsupport segments URL: https://github.com/apache/incubator-skywalking/issues/1207 Because segment data are from multiple languages's agents/SDKs, even some custom plugins, the collector can't count on every trace is perfect.

[GitHub] SevenPointOld opened a new issue #1208: Why a trace chain displays two operation names

2018-05-10 Thread GitBox
SevenPointOld opened a new issue #1208: Why a trace chain displays two operation names URL: https://github.com/apache/incubator-skywalking/issues/1208 ![image](https://user-images.githubusercontent.com/12181207/39857539-4693d1a0-5466-11e8-9eac-375359468596.png) they have same traceId

[GitHub] wu-sheng commented on issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-10 Thread GitBox
wu-sheng commented on issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198#issuecomment-387962335 This is caused by @ascrutae 's deployment mistakes. In the demo env, the buffer folders of two collector

[GitHub] wu-sheng closed issue #1198: NetworkAddress serverType and spanLayer may be not right

2018-05-10 Thread GitBox
wu-sheng closed issue #1198: NetworkAddress serverType and spanLayer may be not right URL: https://github.com/apache/incubator-skywalking/issues/1198 This is an automated message from the Apache Git Service. To respond to

[GitHub] wu-sheng closed issue #1208: Why a trace chain displays two operation names

2018-05-10 Thread GitBox
wu-sheng closed issue #1208: Why a trace chain displays two operation names URL: https://github.com/apache/incubator-skywalking/issues/1208 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng commented on issue #1208: Why a trace chain displays two operation names

2018-05-10 Thread GitBox
wu-sheng commented on issue #1208: Why a trace chain displays two operation names URL: https://github.com/apache/incubator-skywalking/issues/1208#issuecomment-387976832 Because the trace query is based on trace segment, not trace. In a distributed system, you can't use a single id to

[GitHub] mosesyou opened a new issue #1205: turn off the agent log

2018-05-10 Thread GitBox
mosesyou opened a new issue #1205: turn off the agent log URL: https://github.com/apache/incubator-skywalking/issues/1205 - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question

[GitHub] wu-sheng opened a new pull request #1209: Update screenshot for new release.

2018-05-10 Thread GitBox
wu-sheng opened a new pull request #1209: Update screenshot for new release. URL: https://github.com/apache/incubator-skywalking/pull/1209 Ready for 5.0.0-beta release. This is an automated message from the Apache Git

[GitHub] wu-sheng closed issue #1205: turn off the agent log

2018-05-10 Thread GitBox
wu-sheng closed issue #1205: turn off the agent log URL: https://github.com/apache/incubator-skywalking/issues/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng commented on issue #1205: turn off the agent log

2018-05-10 Thread GitBox
wu-sheng commented on issue #1205: turn off the agent log URL: https://github.com/apache/incubator-skywalking/issues/1205#issuecomment-387964965 You could set the log level to **OFF**. ``` # Logging level logging.level=OFF ```

[GitHub] coveralls commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
coveralls commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388049701 [![Coverage Status](https://coveralls.io/builds/16922502/badge)](https://coveralls.io/builds/16922502) Coverage increased

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388079962 For validate your plugin, there are several steps you should follow: 1. Provide Topology, trace and service map to prove your data.

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388089270 @leizhiyuan My suggestion is based on operation name is treated as a string only, and I saw dot and method name in it. So the agent,

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388076819 @wu-sheng ok, I will add some changes. I debuged my demo application and skywalking-agent ,I can make sure there has an

<    1   2   3   4   5   6   7   8   9   10   >