[GitHub] coveralls commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
coveralls commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388049701 [![Coverage Status](https://coveralls.io/builds/16949876/badge)](https://coveralls.io/builds/16949876) Coverage increased

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761246 ## File path:

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388529703 I will test it and provide report in https://github.com/SkywalkingTest/skywalking-agent-testcases .

[GitHub] candyleer opened a new pull request #1217: Rewrite Async http client plugin

2018-05-12 Thread GitBox
candyleer opened a new pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided -

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761246 ## File path:

[GitHub] candyleer commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-12 Thread GitBox
candyleer commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-388535368 It works well as expected. @peng-yongsheng such as ``` { "from" : 0, "size" : 20,

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761351 ## File path:

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187761314 ## File path:

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388524439 @wu-sheng ContextManagerExtendOverrideService I saw dubbo does this. I thought It was a rule. I will remove it.

[GitHub] leizhiyuan opened a new pull request #170: add sofarpc icon

2018-05-11 Thread GitBox
leizhiyuan opened a new pull request #170: add sofarpc icon URL: https://github.com/apache/incubator-skywalking-ui/pull/170 add sofarpc icon This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] leizhiyuan commented on issue #170: add sofarpc icon

2018-05-11 Thread GitBox
leizhiyuan commented on issue #170: add sofarpc icon URL: https://github.com/apache/incubator-skywalking-ui/pull/170#issuecomment-388527993 @wu-sheng ok. thanks for you advice, I will change the icon. This is an automated

[GitHub] wu-sheng commented on issue #1217: Rewrite Async http client plugin

2018-05-12 Thread GitBox
wu-sheng commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388534809 :+1: I really like this. 2span cost much less than before. @ascrutae please review this and guide him to fix the teat case issue.

[GitHub] coveralls commented on issue #1217: Rewrite Async http client plugin

2018-05-12 Thread GitBox
coveralls commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388535000 [![Coverage Status](https://coveralls.io/builds/16950504/badge)](https://coveralls.io/builds/16950504) Coverage increased

[GitHub] candyleer opened a new pull request #1218: ix http_client plugin

2018-05-12 Thread GitBox
candyleer opened a new pull request #1218: ix http_client plugin URL: https://github.com/apache/incubator-skywalking/pull/1218 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] candyleer commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-12 Thread GitBox
candyleer commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-388535368 It works well as expected. @peng-yongsheng such as ``` { "from" : 0, "size" : 20,

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388524628 Dubbo has it because dubbo is our first plugin, some no-dubbo test codes are in it, because it need test in plugin modules.

[GitHub] coveralls commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-12 Thread GitBox
coveralls commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-387610938 [![Coverage Status](https://coveralls.io/builds/16950380/badge)](https://coveralls.io/builds/16950380)

[GitHub] coveralls commented on issue #1218: Fix http_client plugin

2018-05-12 Thread GitBox
coveralls commented on issue #1218: Fix http_client plugin URL: https://github.com/apache/incubator-skywalking/pull/1218#issuecomment-388550178 [![Coverage Status](https://coveralls.io/builds/16951579/badge)](https://coveralls.io/builds/16951579) Coverage decreased (-0.005%) to

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804736 ## File path:

[GitHub] candyleer commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
candyleer commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187805028 ## File path:

[GitHub] candyleer commented on issue #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
candyleer commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388635799 I will all the enhance class and method as constant variables This is

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804908 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804858 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804932 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804927 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804934 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804912 ## File path:

[GitHub] candyleer commented on issue #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
candyleer commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388636416 OK,thanks for you review and I will follow your suggestions This is an

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804867 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804871 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804867 ## File path:

[GitHub] ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
ascrutae commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187804858 ## File path:

[GitHub] candyleer commented on a change in pull request #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
candyleer commented on a change in pull request #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#discussion_r187805003 ## File path:

[GitHub] wu-sheng closed pull request #1218: Fix http_client plugin

2018-05-13 Thread GitBox
wu-sheng closed pull request #1218: Fix http_client plugin URL: https://github.com/apache/incubator-skywalking/pull/1218 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng closed issue #1211: The same operation has a duplicate globalTraceID;

2018-05-13 Thread GitBox
wu-sheng closed issue #1211: The same operation has a duplicate globalTraceID; URL: https://github.com/apache/incubator-skywalking/issues/1211 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6

2018-05-13 Thread GitBox
wu-sheng commented on issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6 URL: https://github.com/apache/incubator-skywalking/issues/1214#issuecomment-388668300 What do you mean about stack number? The whole project is

[GitHub] wu-sheng closed issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6

2018-05-13 Thread GitBox
wu-sheng closed issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6 URL: https://github.com/apache/incubator-skywalking/issues/1214 This is an automated

[GitHub] coveralls commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-13 Thread GitBox
coveralls commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-387610938 [![Coverage Status](https://coveralls.io/builds/16962218/badge)](https://coveralls.io/builds/16962218)

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820793 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187819683 ## File path: apm-sniffer/optional-plugins/trace-ignore-plugin/README.md

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820927 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820993 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820481 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820358 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@ -98,11

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820452 ## File path: apm-sniffer/optional-plugins/trace-ignore-plugin/README.md

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187821464 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187821901 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187822108 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187822039 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187822748 ## File path:

[GitHub] candyleer commented on issue #1194: Modify operationName search from match to match_phrase

2018-05-13 Thread GitBox
candyleer commented on issue #1194: Modify operationName search from match to match_phrase URL: https://github.com/apache/incubator-skywalking/pull/1194#issuecomment-388676751 Yes ,I tested, it works .it just like ``` select * from table where service_name like "%value%" ```

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798 ![image](https://user-images.githubusercontent.com/2684384/39975112-40e321f6-575f-11e8-8bfc-4e895f779cb3.png) I debuged

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798 ![image](https://user-images.githubusercontent.com/2684384/39975112-40e321f6-575f-11e8-8bfc-4e895f779cb3.png) I debuged locally,

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798 ![image](https://user-images.githubusercontent.com/2684384/39975112-40e321f6-575f-11e8-8bfc-4e895f779cb3.png) I debuged locally,

[GitHub] coveralls commented on issue #1212: fix wrong description for chinese document

2018-05-11 Thread GitBox
coveralls commented on issue #1212: fix wrong description for chinese document URL: https://github.com/apache/incubator-skywalking/pull/1212#issuecomment-388272822 [![Coverage Status](https://coveralls.io/builds/16934174/badge)](https://coveralls.io/builds/16934174) Coverage

[GitHub] peng-yongsheng closed pull request #1212: fix wrong description for chinese document

2018-05-11 Thread GitBox
peng-yongsheng closed pull request #1212: fix wrong description for chinese document URL: https://github.com/apache/incubator-skywalking/pull/1212 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] wfs0902 opened a new issue #1211: The same operation has a duplicate globalTraceID;

2018-05-10 Thread GitBox
wfs0902 opened a new issue #1211: The same operation has a duplicate globalTraceID; URL: https://github.com/apache/incubator-skywalking/issues/1211 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ]

[GitHub] wfs0902 commented on issue #1211: The same operation has a duplicate globalTraceID;

2018-05-10 Thread GitBox
wfs0902 commented on issue #1211: The same operation has a duplicate globalTraceID; URL: https://github.com/apache/incubator-skywalking/issues/1211#issuecomment-388264238 定位不到问题发生的原因; This is an automated message from the

[GitHub] SevenPointOld opened a new pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-11 Thread GitBox
SevenPointOld opened a new pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213 Please answer these questions before submitting pull request - Why submit this pull request? New

[GitHub] ma-xiao-guang-64 opened a new pull request #1212: fix wrong description for chinese document

2018-05-10 Thread GitBox
ma-xiao-guang-64 opened a new pull request #1212: fix wrong description for chinese document URL: https://github.com/apache/incubator-skywalking/pull/1212 fix wrong description for chinese document This is an automated

[GitHub] peng-yongsheng commented on issue #1211: The same operation has a duplicate globalTraceID;

2018-05-11 Thread GitBox
peng-yongsheng commented on issue #1211: The same operation has a duplicate globalTraceID; URL: https://github.com/apache/incubator-skywalking/issues/1211#issuecomment-388268675 This is known issues by the version 3.2.6, suggest upgrade to version 5.0.0-alpha. And 5.0.0-beta version

[GitHub] liuhaoyang commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-11 Thread GitBox
liuhaoyang commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388287017 Maybe we can also support reading `trace.ignore_path` from environment variables.

[GitHub] wfs0902 commented on issue #1211: The same operation has a duplicate globalTraceID;

2018-05-11 Thread GitBox
wfs0902 commented on issue #1211: The same operation has a duplicate globalTraceID; URL: https://github.com/apache/incubator-skywalking/issues/1211#issuecomment-388293411 Thank you very much,Its generation rules are difficult to replicate in theory, and why the same timestamp is

[GitHub] wfs0902 opened a new issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6

2018-05-11 Thread GitBox
wfs0902 opened a new issue #1214: The topology of the application interconnects with each other to display the number stack@version3.2.6 URL: https://github.com/apache/incubator-skywalking/issues/1214 Please answer these questions before submitting your issue. - Why do you submit

[GitHub] coveralls commented on issue #1216: Fixed the version release bug.

2018-05-11 Thread GitBox
coveralls commented on issue #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216#issuecomment-388385288 [![Coverage Status](https://coveralls.io/builds/16940018/badge)](https://coveralls.io/builds/16940018) Coverage increased

[GitHub] coveralls commented on issue #1216: Fixed the version release bug.

2018-05-11 Thread GitBox
coveralls commented on issue #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216#issuecomment-388385288 [![Coverage Status](https://coveralls.io/builds/16940010/badge)](https://coveralls.io/builds/16940010) Coverage increased

[GitHub] candyleer opened a new issue #1215: No traceId In trace page sometimes

2018-05-11 Thread GitBox
candyleer opened a new issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ]

[GitHub] peng-yongsheng opened a new pull request #1216: Fixed the version release bug.

2018-05-11 Thread GitBox
peng-yongsheng opened a new pull request #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Bug fix _ ### Bug fix - Bug

[GitHub] wu-sheng closed pull request #1216: Fixed the version release bug.

2018-05-11 Thread GitBox
wu-sheng closed pull request #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wu-sheng commented on issue #1216: Fixed the version release bug.

2018-05-11 Thread GitBox
wu-sheng commented on issue #1216: Fixed the version release bug. URL: https://github.com/apache/incubator-skywalking/pull/1216#issuecomment-388419662 We can't add these modules in. Fail in RAT check. This is an automated

[GitHub] wu-sheng closed issue #1013: Analysis dependencies of nodejs webpack

2018-05-08 Thread GitBox
wu-sheng closed issue #1013: Analysis dependencies of nodejs webpack URL: https://github.com/apache/incubator-skywalking/issues/1013 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] wu-sheng commented on issue #1013: Analysis dependencies of nodejs webpack

2018-05-08 Thread GitBox
wu-sheng commented on issue #1013: Analysis dependencies of nodejs webpack URL: https://github.com/apache/incubator-skywalking/issues/1013#issuecomment-387370287 Done. This is an automated message from the Apache Git

[GitHub] coveralls commented on issue #1184: Update FAQ doc

2018-05-08 Thread GitBox
coveralls commented on issue #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184#issuecomment-387086981 [![Coverage Status](https://coveralls.io/builds/16882264/badge)](https://coveralls.io/builds/16882264) Coverage remained the same at 23.358%

[GitHub] coveralls commented on issue #1184: Update FAQ doc

2018-05-08 Thread GitBox
coveralls commented on issue #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184#issuecomment-387086981 [![Coverage Status](https://coveralls.io/builds/16882278/badge)](https://coveralls.io/builds/16882278) Coverage remained the same at 23.358%

[GitHub] ascrutae opened a new pull request #1190: Change the buired point of block call way

2018-05-08 Thread GitBox
ascrutae opened a new pull request #1190: Change the buired point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature

[GitHub] coveralls commented on issue #1175: Fix Parent Application Instance Id is 0

2018-05-05 Thread GitBox
coveralls commented on issue #1175: Fix Parent Application Instance Id is 0 URL: https://github.com/apache/incubator-skywalking/pull/1175#issuecomment-386809795 [![Coverage Status](https://coveralls.io/builds/16848406/badge)](https://coveralls.io/builds/16848406) Coverage

[GitHub] wu-sheng closed pull request #1175: Fix Parent Application Instance Id is 0

2018-05-05 Thread GitBox
wu-sheng closed pull request #1175: Fix Parent Application Instance Id is 0 URL: https://github.com/apache/incubator-skywalking/pull/1175 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] wu-sheng closed issue #1174: Duplicate Service Name And application id is 0

2018-05-05 Thread GitBox
wu-sheng closed issue #1174: Duplicate Service Name And application id is 0 URL: https://github.com/apache/incubator-skywalking/issues/1174 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng opened a new issue #1177: The number of Kafka is incorrect

2018-05-05 Thread GitBox
wu-sheng opened a new issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177 ![image](https://user-images.githubusercontent.com/5441976/39664274-5d476350-50b3-11e8-84ca-85243c9becaa.png) In this topology, these is only one

[GitHub] wu-sheng commented on issue #1174: Duplicate Service Name And application id is 0

2018-05-05 Thread GitBox
wu-sheng commented on issue #1174: Duplicate Service Name And application id is 0 URL: https://github.com/apache/incubator-skywalking/issues/1174#issuecomment-386811653 FYI @peng-yongsheng This may be why there is service's applicationId is 0.

[GitHub] wu-sheng commented on issue #1176: Hope to Add application name in service search view

2018-05-05 Thread GitBox
wu-sheng commented on issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176#issuecomment-386811713 Yes, it is. It is on the roadmap. This is an

[GitHub] candyleer opened a new pull request #1178: Fix If traceId not exists result will return all traces

2018-05-05 Thread GitBox
candyleer opened a new pull request #1178: Fix If traceId not exists result will return all traces URL: https://github.com/apache/incubator-skywalking/pull/1178 Please answer these questions before submitting pull request - Why submit this pull request? - [x ] Bug fix - [ ]

[GitHub] wu-sheng closed pull request #1184: Update FAQ doc

2018-05-08 Thread GitBox
wu-sheng closed pull request #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] coveralls commented on issue #1190: Change the buired point of block call way

2018-05-08 Thread GitBox
coveralls commented on issue #1190: Change the buired point of block call way URL: https://github.com/apache/incubator-skywalking/pull/1190#issuecomment-387471505 [![Coverage Status](https://coveralls.io/builds/16887638/badge)](https://coveralls.io/builds/16887638) Coverage

[GitHub] coveralls commented on issue #1179: Fix first formula, like #1164

2018-05-05 Thread GitBox
coveralls commented on issue #1179: Fix first formula, like #1164 URL: https://github.com/apache/incubator-skywalking/pull/1179#issuecomment-386851449 [![Coverage Status](https://coveralls.io/builds/16852285/badge)](https://coveralls.io/builds/16852285) Coverage remained the

[GitHub] wu-sheng closed pull request #1180: Docs/fix grpc dirname

2018-05-05 Thread GitBox
wu-sheng closed pull request #1180: Docs/fix grpc dirname URL: https://github.com/apache/incubator-skywalking/pull/1180 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] coveralls commented on issue #1180: Docs/fix grpc dirname

2018-05-05 Thread GitBox
coveralls commented on issue #1180: Docs/fix grpc dirname URL: https://github.com/apache/incubator-skywalking/pull/1180#issuecomment-386855287 [![Coverage Status](https://coveralls.io/builds/16852621/badge)](https://coveralls.io/builds/16852621) Coverage increased (+0.004%) to

[GitHub] brucewu-fly closed pull request #1170: Fix protobuf dirname for apm-remote-grpc-provider

2018-05-05 Thread GitBox
brucewu-fly closed pull request #1170: Fix protobuf dirname for apm-remote-grpc-provider URL: https://github.com/apache/incubator-skywalking/pull/1170 This is an automated message from the Apache Git Service. To respond to

[GitHub] brucewu-fly opened a new pull request #1180: Docs/fix grpc dirname

2018-05-05 Thread GitBox
brucewu-fly opened a new pull request #1180: Docs/fix grpc dirname URL: https://github.com/apache/incubator-skywalking/pull/1180 The directory should be apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/generated-sources/protobuf rather than

[GitHub] brucewu-fly opened a new pull request #1170: Fix protobuf dirname for apm-remote-grpc-provider

2018-05-04 Thread GitBox
brucewu-fly opened a new pull request #1170: Fix protobuf dirname for apm-remote-grpc-provider URL: https://github.com/apache/incubator-skywalking/pull/1170 The directory should be `apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/generated-sources/protobuf` rather than

[GitHub] coveralls commented on issue #1170: Fix protobuf dirname for apm-remote-grpc-provider

2018-05-04 Thread GitBox
coveralls commented on issue #1170: Fix protobuf dirname for apm-remote-grpc-provider URL: https://github.com/apache/incubator-skywalking/pull/1170#issuecomment-386570135 [![Coverage Status](https://coveralls.io/builds/16833185/badge)](https://coveralls.io/builds/16833185)

[GitHub] coveralls commented on issue #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
coveralls commented on issue #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122 [![Coverage Status](https://coveralls.io/builds/16832558/badge)](https://coveralls.io/builds/16832558) Coverage

[GitHub] hanahmily opened a new pull request #1171: Submodule/skywalking ui

2018-05-04 Thread GitBox
hanahmily opened a new pull request #1171: Submodule/skywalking ui URL: https://github.com/apache/incubator-skywalking/pull/1171 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ]

[GitHub] wu-sheng closed issue #1177: The number of Kafka is incorrect

2018-05-05 Thread GitBox
wu-sheng closed issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng commented on issue #1177: The number of Kafka is incorrect

2018-05-05 Thread GitBox
wu-sheng commented on issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177#issuecomment-386845098 I have pinpointed this issue. We really need to refact all component libraries. This is an agent issue, caused by old design.

[GitHub] wu-sheng opened a new issue #1177: The number of Kafka is incorrect

2018-05-05 Thread GitBox
wu-sheng opened a new issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177 ![image](https://user-images.githubusercontent.com/5441976/39664274-5d476350-50b3-11e8-84ca-85243c9becaa.png) In this topology, these is only one

[GitHub] candyleer opened a new pull request #1179: Fix first formula, like #1164

2018-05-05 Thread GitBox
candyleer opened a new pull request #1179: Fix first formula, like #1164 URL: https://github.com/apache/incubator-skywalking/pull/1179 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ]

[GitHub] wu-sheng commented on issue #1176: Hope to Add application name in service search view

2018-05-05 Thread GitBox
wu-sheng commented on issue #1176: Hope to Add application name in service search view URL: https://github.com/apache/incubator-skywalking/issues/1176#issuecomment-386811807 Add new query service based on applicationId. And redesign the service view.

[GitHub] coveralls commented on issue #1178: Fix If traceId not exists result will return all traces

2018-05-05 Thread GitBox
coveralls commented on issue #1178: Fix If traceId not exists result will return all traces URL: https://github.com/apache/incubator-skywalking/pull/1178#issuecomment-386815145 [![Coverage Status](https://coveralls.io/builds/16848816/badge)](https://coveralls.io/builds/16848816)

[GitHub] wu-sheng commented on issue #1172: improvement:hope skywalking ui support multi environment data viewing

2018-05-04 Thread GitBox
wu-sheng commented on issue #1172: improvement:hope skywalking ui support multi environment data viewing URL: https://github.com/apache/incubator-skywalking/issues/1172#issuecomment-386608084 What do you mean `multi environment data viewing`? I am not following.

<    1   2   3   4   5   6   7   8   9   10   >