mrproliu opened a new pull request, #10180:
URL: https://github.com/apache/skywalking/pull/10180
Fixed the issue in Zipkin Lens UI where attached events were not displayed
when searching for traces. The case was caused by the trace display not
triggering a new query after a search.
-
lujiajing1126 opened a new pull request, #10181:
URL: https://github.com/apache/skywalking/pull/10181
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #10171, #10166 .
- [ ] Update the [`CHANGES`
log](htt
wankai123 commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051757788
##
oap-server/server-query-plugin/zipkin-query-plugin/src/main/java/org/apache/skywalking/oap/query/zipkin/handler/ZipkinQueryHandler.java:
##
@@ -304,6 +306,16
wu-sheng commented on issue #10179:
URL: https://github.com/apache/skywalking/issues/10179#issuecomment-1357035965
We don't create so many threads, what do you mean memory leak?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wu-sheng commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051759903
##
oap-server/server-query-plugin/zipkin-query-plugin/src/main/java/org/apache/skywalking/oap/query/zipkin/handler/ZipkinQueryHandler.java:
##
@@ -304,6 +306,16 @
mrproliu commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051773432
##
oap-server/server-query-plugin/zipkin-query-plugin/src/main/java/org/apache/skywalking/oap/query/zipkin/handler/ZipkinQueryHandler.java:
##
@@ -304,6 +306,16 @
dylanforest commented on issue #10179:
URL: https://github.com/apache/skywalking/issues/10179#issuecomment-1357065198
It's NOT memory leak. The thread leak is no created by the agent. It's
triggered by the service which the agent is wathing.
The problem is when skywalking-java monitoring
mohammedtabish0 commented on issue #10137:
URL: https://github.com/apache/skywalking/issues/10137#issuecomment-1357104550
Can I pick this up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
lujiajing1126 commented on PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#issuecomment-1357136658
Ready for review @wu-sheng @hanahmily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
cylrk commented on issue #8831:
URL: https://github.com/apache/skywalking/issues/8831#issuecomment-1357140775
Is this problem solved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wu-sheng commented on issue #10137:
URL: https://github.com/apache/skywalking/issues/10137#issuecomment-1357153792
@mohammedtabish0 Please go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
wu-sheng commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051843980
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
wu-sheng commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051844394
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
wu-sheng commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051844830
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
wu-sheng commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051845417
##
oap-server-bom/pom.xml:
##
@@ -73,7 +73,7 @@
3.0.0
4.4.13
1.21
-0.2.1
+
0.3.0-SNAPSHOT
Review Comment:
A TODO be
wu-sheng commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051846060
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
wu-sheng commented on issue #10179:
URL: https://github.com/apache/skywalking/issues/10179#issuecomment-1357158156
>As a contrast, Pinpoint's agent does not have the problem.
There is no point to mention this. Please don't do this in further
discussion.
--
This is an automated mess
wu-sheng commented on issue #10179:
URL: https://github.com/apache/skywalking/issues/10179#issuecomment-1357159079
> After tracing the agent's thread, we local time cost at
ThreadProvider.getThreadMetrics().
This func takes 400ms to check all 4000 threads' status in our case, and
this pr
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051858384
##
oap-server-bom/pom.xml:
##
@@ -73,7 +73,7 @@
3.0.0
4.4.13
1.21
-0.2.1
+
0.3.0-SNAPSHOT
Review Comment:
adde
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051860881
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.j
hanahmily commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051880548
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
mrproliu commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051882298
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
wu-sheng commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051883005
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
wu-sheng commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051883652
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
wu-sheng commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051884049
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
mrproliu commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051885915
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
mrproliu commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051885915
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
mrproliu commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051891966
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
wu-sheng commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051894599
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDA
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051896140
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.j
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051897198
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.j
dylanforest commented on issue #10179:
URL: https://github.com/apache/skywalking/issues/10179#issuecomment-1357229336
> Yes, this is how it works. What do you want to ask?
Is this frequency necessary？I checked the oap, the related metrics are
aggregated by longAvg() in 1min.
I wonder
hanahmily commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051902160
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
dylanforest commented on issue #10179:
URL: https://github.com/apache/skywalking/issues/10179#issuecomment-1357231945
> There is no point to mention this. Please don't do this in further
discussion
Got
--
This is an automated message from the Apache Git Service.
To resp
wu-sheng commented on PR #107:
URL:
https://github.com/apache/skywalking-nodejs/pull/107#issuecomment-1357232192
`sw8` is the required key in the API. This PR can't be accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wu-sheng closed pull request #107: fix: add namespace for trace id prefix
URL: https://github.com/apache/skywalking-nodejs/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
hanahmily commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051902703
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
hanahmily commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1051903547
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
wu-sheng commented on issue #10179:
URL: https://github.com/apache/skywalking/issues/10179#issuecomment-1357234990
> > Yes, this is how it works. What do you want to ask?
>
> Is this frequency necessary？I checked the oap, the related metrics are
aggregated by longAvg() in 1min. I wond
lujiajing1126 commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051916589
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQu
dylanforest commented on issue #10179:
URL: https://github.com/apache/skywalking/issues/10179#issuecomment-1357286004
I will, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
rootsongjc opened a new pull request, #549:
URL: https://github.com/apache/skywalking-website/pull/549
New blog: Boost Root Cause Analysis Quickly With SkyWalking’s New
Trace-Metrics Association Feature
--
This is an automated message from the Apache Git Service.
To respond to the messag
netlify[bot] commented on PR #549:
URL:
https://github.com/apache/skywalking-website/pull/549#issuecomment-1357298384
### 👷 Deploy Preview for
*skywalking-website-preview* processing.
| Name | Link |
|-||
|🔨 Latest co
rootsongjc closed pull request #549: Blog: Boost Root Cause Analysis Quickly
With SkyWalking’s New Trace-Metrics Association Feature
URL: https://github.com/apache/skywalking-website/pull/549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wu-sheng commented on code in PR #549:
URL:
https://github.com/apache/skywalking-website/pull/549#discussion_r1051945675
##
content/zh/diagnose-service-mesh-network-performance-with-ebpf/en.md:
##
@@ -0,0 +1,44 @@
+## Background
Review Comment:
This seems not expected.
-
lujiajing1126 opened a new pull request, #10184:
URL: https://github.com/apache/skywalking/pull/10184
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [x] Update the [`CHANGES`
log](https://github.co
netlify[bot] commented on PR #550:
URL:
https://github.com/apache/skywalking-website/pull/550#issuecomment-1357306627
### 👷 Deploy Preview for
*skywalking-website-preview* processing.
| Name | Link |
|-||
|🔨 Latest co
wu-sheng commented on PR #550:
URL:
https://github.com/apache/skywalking-website/pull/550#issuecomment-1357348448
I think you miss the first image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
wu-sheng closed pull request #10180: Fix cannot display attached events when
using Zipkin Lens UI query traces
URL: https://github.com/apache/skywalking/pull/10180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
wu-sheng merged PR #10184:
URL: https://github.com/apache/skywalking/pull/10184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
wu-sheng merged PR #550:
URL: https://github.com/apache/skywalking-website/pull/550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubs
Superskyyy commented on issue #8831:
URL: https://github.com/apache/skywalking/issues/8831#issuecomment-1358064558
> Is this problem solved?
RocketbotUI is now obsolete and replaced by BoosterUI
[here](https://github.com/apache/skywalking-booster-ui), you will need to
upgrade your sk
Superskyyy opened a new pull request, #261:
URL: https://github.com/apache/skywalking-python/pull/261
- Log reporter was missing the endpoint property so this change follows Java
agent implementation on primary endpoint.
- Some chore on typing
sonatype-lift[bot] commented on code in PR #261:
URL: https://github.com/apache/skywalking-python/pull/261#discussion_r1052626838
##
skywalking/trace/context.py:
##
@@ -116,27 +139,23 @@ def new_local_span(self, op: str) -> Span:
if span is not None:
return
wu-sheng opened a new pull request, #10185:
URL: https://github.com/apache/skywalking/pull/10185
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [x] Update the [`CHANGES`
log](https://github.com/apa
kezhenxu94 commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-1358788050
No sure but you might need to regenerate the zipkin-license from the new
Lens dependency's package.json and package-lock.json， if they have new
dependencies or versions changes in
wu-sheng commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-135871
> No sure but you might need to regenerate the zipkin-license from the new
Lens dependency's package.json and package-lock.json， if they have new
dependencies or versions changes in
wu-sheng commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-1358789090
Do you mean I need to copy the lock file again from the Zipkin repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wu-sheng commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1052887101
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
wu-sheng commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1052887998
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
kezhenxu94 commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-1358817722
> Do you mean I need to copy the lock file again from the Zipkin repo?
You have to regenerate the zipkin-LICENSE from the package.json and
package-lock.json in
https://gith
kezhenxu94 merged PR #261:
URL: https://github.com/apache/skywalking-python/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
kezhenxu94 opened a new pull request, #10186:
URL: https://github.com/apache/skywalking/pull/10186
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [ ] Update the [`CHANGES`
log](https://github.com/a
wu-sheng merged PR #10186:
URL: https://github.com/apache/skywalking/pull/10186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
wu-sheng commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-1358870805
@kezhenxu94 Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
netlify[bot] commented on PR #551:
URL:
https://github.com/apache/skywalking-website/pull/551#issuecomment-1358912383
### 👷 Deploy Preview for
*skywalking-website-preview* processing.
| Name | Link |
|-||
|🔨 Latest co
kezhenxu94 merged PR #10185:
URL: https://github.com/apache/skywalking/pull/10185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
wu-sheng merged PR #551:
URL: https://github.com/apache/skywalking-website/pull/551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubs
Fine0830 opened a new pull request, #211:
URL: https://github.com/apache/skywalking-booster-ui/pull/211
Avoids being unable to drag process nodes for the first time.
Video
https://user-images.githubusercontent.com/20871783/208623596-3e10ef44-dd41-43ef-bd1e-af03feccfaa9.mov
wu-sheng merged PR #211:
URL: https://github.com/apache/skywalking-booster-ui/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-uns
zhyyu opened a new pull request, #10187:
URL: https://github.com/apache/skywalking/pull/10187
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [x] Update the [`CHANGES`
log](https://github.com/apache
kezhenxu94 merged PR #108:
URL: https://github.com/apache/skywalking-showcase/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-uns
wu-sheng commented on PR #10187:
URL: https://github.com/apache/skywalking/pull/10187#issuecomment-1359099478
Could you explain more about how this override happens? They are two
classes, why would one will override the other?
--
This is an automated message from the Apache Git Service.
T
kezhenxu94 commented on code in PR #10187:
URL: https://github.com/apache/skywalking/pull/10187#discussion_r1053249349
##
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java:
##
@@ -523,6 +524,9 @@ private void writeGeneratedFile(CtClass metricsClass,
S
kezhenxu94 commented on PR #10187:
URL: https://github.com/apache/skywalking/pull/10187#issuecomment-1359273387
> Could you explain more about how this override happens? They are two
classes, why would one will override the other?
For dispatcher classes, it uses the `scopeName + "Disp
wu-sheng commented on PR #10187:
URL: https://github.com/apache/skywalking/pull/10187#issuecomment-1359319813
Be careful of full class name, it would be an issue for window(too long file
path, sometimes show on git clone as well.)
--
This is an automated message from the Apache Git Servic
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1053335649
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.j
lujiajing1126 commented on PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#issuecomment-1359412615
### ServiceRelationServiceSide
Schema
```protobuf
measure {
metadata {
group: "measure-default"
name: "service_relation_server_side_hour"
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1053351236
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.j
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1053364911
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.j
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1053364911
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.j
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1053372873
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.j
Superskyyy opened a new pull request, #262:
URL: https://github.com/apache/skywalking-python/pull/262
Minor chore on tag class to enforce string-compatible type.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the iss
kezhenxu94 merged PR #262:
URL: https://github.com/apache/skywalking-python/pull/262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
wu-sheng commented on PR #10187:
URL: https://github.com/apache/skywalking/pull/10187#issuecomment-1360678620
As this file is generated sequentially, you could generate `_index` when the
name is in conflict.
In your case, maybe `ServiceDispatcher.class` and
`ServiceDispatcher_1.class` a
wu-sheng commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1053907877
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
zhyyu commented on code in PR #10187:
URL: https://github.com/apache/skywalking/pull/10187#discussion_r1053909864
##
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java:
##
@@ -523,6 +524,9 @@ private void writeGeneratedFile(CtClass metricsClass,
String
zhyyu commented on PR #10187:
URL: https://github.com/apache/skywalking/pull/10187#issuecomment-1360695522
> As this file is generated sequentially, you could generate `_index` when
the name is in conflict. In your case, maybe `ServiceDispatcher.class` and
`ServiceDispatcher_1.class` are a
kezhenxu94 opened a new pull request, #10188:
URL: https://github.com/apache/skywalking/pull/10188
- [x] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #. NO
- [x] Update the [`CHANGES`
log](https://github.co
kezhenxu94 merged PR #10188:
URL: https://github.com/apache/skywalking/pull/10188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
naah69 opened a new issue, #10189:
URL: https://github.com/apache/skywalking/issues/10189
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
naah69 commented on issue #10189:
URL: https://github.com/apache/skywalking/issues/10189#issuecomment-1361114232
i had used filter to deal it.
but i think it is so ugly.
is there any better way to reslove it ?
https://user-images.githubusercontent.com/25682169/208879417-1727a81d-6025
wu-sheng commented on issue #10189:
URL: https://github.com/apache/skywalking/issues/10189#issuecomment-1361116267
Let's see @BFergerson has any suggestions.
@naah69 For a community, there is nothing urgent. All PMC members are
volunteers here, they just contribute and answer question
wu-sheng closed issue #10189: [Bug] Vertx worker thread can't get TraceId
URL: https://github.com/apache/skywalking/issues/10189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mrproliu opened a new pull request, #10191:
URL: https://github.com/apache/skywalking/pull/10191
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [x] Update the [`CHANGES`
log](https://github.com/apache/skywalking/blob/master/d
mrproliu merged PR #10191:
URL: https://github.com/apache/skywalking/pull/10191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
hanahmily commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1054800562
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.java:
lujiajing1126 commented on code in PR #10181:
URL: https://github.com/apache/skywalking/pull/10181#discussion_r1054998036
##
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBTopologyQueryDAO.j
wankai123 opened a new pull request, #10192:
URL: https://github.com/apache/skywalking/pull/10192
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [X] Tests(including UT, IT, E2E) are added to ver
wu-sheng commented on code in PR #10192:
URL: https://github.com/apache/skywalking/pull/10192#discussion_r1055030840
##
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java:
##
@@ -355,18 +355,20 @@ public void start() throws ModuleS
501 - 600 of 182422 matches
Mail list logo
