[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-22 Thread GitBox
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390936276 Promise This is an automated

[GitHub] coveralls commented on issue #1252: Update release doc and related script

2018-05-22 Thread GitBox
coveralls commented on issue #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252#issuecomment-390857578 [![Coverage Status](https://coveralls.io/builds/17108182/badge)](https://coveralls.io/builds/17108182) Coverage

[GitHub] coveralls commented on issue #1252: Update release doc and related script

2018-05-22 Thread GitBox
coveralls commented on issue #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252#issuecomment-390857578 [![Coverage Status](https://coveralls.io/builds/17108683/badge)](https://coveralls.io/builds/17108683) Coverage

[GitHub] candyleer opened a new pull request #1253: fix NPE when has connection exception

2018-05-21 Thread GitBox
candyleer opened a new pull request #1253: fix NPE when has connection exception URL: https://github.com/apache/incubator-skywalking/pull/1253 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided

[GitHub] coveralls commented on issue #1253: Fix NPE in Okhttp plugin when connect failed

2018-05-21 Thread GitBox
coveralls commented on issue #1253: Fix NPE in Okhttp plugin when connect failed URL: https://github.com/apache/incubator-skywalking/pull/1253#issuecomment-390867553 [![Coverage Status](https://coveralls.io/builds/17099260/badge)](https://coveralls.io/builds/17099260) Coverage

[GitHub] wu-sheng opened a new issue #1260: Remove all Apache licenses files in dist release packages.

2018-05-23 Thread GitBox
wu-sheng opened a new issue #1260: Remove all Apache licenses files in dist release packages. URL: https://github.com/apache/incubator-skywalking/issues/1260 From last release vote: > There are bunch of Apache Licenses in the binary kit which are stand Apache Licenses. We can do

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-23 Thread GitBox
coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290 [![Coverage

[GitHub] peng-yongsheng commented on issue #1215: No traceId In trace page sometimes

2018-05-23 Thread GitBox
peng-yongsheng commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-391294323 Delay times will be more and more longer when collector received too much segments. I suggest that setting the start time at

[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-23 Thread GitBox
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391246857 @ascrutae Do you have any suggestion for this?

[GitHub] wu-sheng commented on issue #1204: Add folder lock to collector's buffer folder

2018-05-23 Thread GitBox
wu-sheng commented on issue #1204: Add folder lock to collector's buffer folder URL: https://github.com/apache/incubator-skywalking/issues/1204#issuecomment-391253224 Provided. This is an automated message from the Apache

[GitHub] wu-sheng closed issue #1204: Add folder lock to collector's buffer folder

2018-05-23 Thread GitBox
wu-sheng closed issue #1204: Add folder lock to collector's buffer folder URL: https://github.com/apache/incubator-skywalking/issues/1204 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng commented on issue #1215: No traceId In trace page sometimes

2018-05-23 Thread GitBox
wu-sheng commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-391294693 +1 FYI @hanahmily This is an automated message from the Apache Git

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-23 Thread GitBox
coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290 [![Coverage

[GitHub] wu-sheng commented on issue #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu…

2018-05-22 Thread GitBox
wu-sheng commented on issue #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu… URL: https://github.com/apache/incubator-skywalking-ui/pull/172#issuecomment-391181889 @ajanthan Look like your CI fails.

[GitHub] candyleer commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-22 Thread GitBox
candyleer commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391214448 ok,I will test in last case This is an

[GitHub] xjr100419 opened a new issue #1257: TraceContext.traceId() [Ignored Trace]

2018-05-22 Thread GitBox
xjr100419 opened a new issue #1257: TraceContext.traceId() [Ignored Trace] URL: https://github.com/apache/incubator-skywalking/issues/1257 __ ### Question TraceContext.traceId() return [Ignored Trace] SkyWalking3.2.6 window centos7 jkd8 in spring cloud .I have many

[GitHub] peng-yongsheng closed pull request #1252: Update release doc and related script

2018-05-22 Thread GitBox
peng-yongsheng closed pull request #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252 This is an automated message from the Apache Git Service. To respond to the

[GitHub] peng-yongsheng opened a new pull request #1259: Add folder lock to collector's buffer folder

2018-05-23 Thread GitBox
peng-yongsheng opened a new pull request #1259: Add folder lock to collector's buffer folder URL: https://github.com/apache/incubator-skywalking/pull/1259 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [X] New

[GitHub] ascrutae commented on issue #1258: Segment buffer pre read failure

2018-05-22 Thread GitBox
ascrutae commented on issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258#issuecomment-391208222 Cloud you describe you demo more detail? It is important to help us to locate this issue.

[GitHub] wu-sheng commented on issue #1258: Segment buffer pre read failure

2018-05-22 Thread GitBox
wu-sheng commented on issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258#issuecomment-391212292 @peng-yongsheng could you consider to ignore and abandon traces can't be analysis? And just log it.

[GitHub] coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-22 Thread GitBox
coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391136082 [![Coverage Status](https://coveralls.io/builds/17118537/badge)](https://coveralls.io/builds/17118537)

[GitHub] coveralls commented on issue #1259: Add folder lock to collector's buffer folder

2018-05-23 Thread GitBox
coveralls commented on issue #1259: Add folder lock to collector's buffer folder URL: https://github.com/apache/incubator-skywalking/pull/1259#issuecomment-391240003 [![Coverage Status](https://coveralls.io/builds/17119722/badge)](https://coveralls.io/builds/17119722) Coverage

[GitHub] dinggel opened a new issue #1258: Segment buffer pre read failure

2018-05-22 Thread GitBox
dinggel opened a new issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258 __ ### Question - What do you want to know? Make a mistake every three seconds: 2018-05-23 10:44:37,174 -

[GitHub] coveralls commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-22 Thread GitBox
coveralls commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391208952 [![Coverage Status](https://coveralls.io/builds/17118181/badge)](https://coveralls.io/builds/17118181)

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-22 Thread GitBox
coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290 [![Coverage

[GitHub] peng-yongsheng commented on issue #1258: Segment buffer pre read failure

2018-05-22 Thread GitBox
peng-yongsheng commented on issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258#issuecomment-391216708 Single segment contains multiple entry span planning support in 5.0.0-beta2 version. So ignore this exception.

[GitHub] ajanthan commented on a change in pull request #1255: Fixing #1231. Adding order and status to trace query.

2018-05-23 Thread GitBox
ajanthan commented on a change in pull request #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#discussion_r190452217 ## File path:

[GitHub] hanahmily closed pull request #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu…

2018-05-23 Thread GitBox
hanahmily closed pull request #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu… URL: https://github.com/apache/incubator-skywalking-ui/pull/172 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] hanahmily opened a new issue #175: Filter nodes by appCode

2018-05-23 Thread GitBox
hanahmily opened a new issue #175: Filter nodes by appCode URL: https://github.com/apache/incubator-skywalking-ui/issues/175 Select multiple appCode or write a regular expression to filter nodes in topology map. This is

[GitHub] wu-sheng closed pull request #1255: Fixing #1231. Adding order and status to trace query.

2018-05-24 Thread GitBox
wu-sheng closed pull request #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ajanthan commented on a change in pull request #1255: Fixing #1231. Adding order and status to trace query.

2018-05-23 Thread GitBox
ajanthan commented on a change in pull request #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#discussion_r190452419 ## File path:

[GitHub] hanahmily opened a new issue #173: Linking heatmap of dashboard to trace search page

2018-05-23 Thread GitBox
hanahmily opened a new issue #173: Linking heatmap of dashboard to trace search page URL: https://github.com/apache/incubator-skywalking-ui/issues/173 On clicking a block in heatmap, the page will be route to trace page which will display some data related to this block.

[GitHub] hanahmily opened a new issue #174: Convert single user node to multiple ones

2018-05-23 Thread GitBox
hanahmily opened a new issue #174: Convert single user node to multiple ones URL: https://github.com/apache/incubator-skywalking-ui/issues/174 Currently there is only one user node representing entry point. This would result in different applications being linked together that reduces the

[GitHub] wu-sheng closed pull request #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-23 Thread GitBox
wu-sheng closed pull request #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] wu-sheng closed pull request #1240: Add application filter for service and two conditions for trace query.

2018-05-24 Thread GitBox
wu-sheng closed pull request #1240: Add application filter for service and two conditions for trace query. URL: https://github.com/apache/incubator-skywalking/pull/1240 This is an automated message from the Apache Git

[GitHub] ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-23 Thread GitBox
ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391575681 @wu-sheng @peng-yongsheng I sent an updated pull request. Please review it.

[GitHub] ajanthan commented on issue #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu…

2018-05-23 Thread GitBox
ajanthan commented on issue #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu… URL: https://github.com/apache/incubator-skywalking-ui/pull/172#issuecomment-391545558 Fixed formatting errors. This

[GitHub] ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-23 Thread GitBox
ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391545410 Updated the pull request as requested. This is an

[GitHub] candyleer commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-23 Thread GitBox
candyleer commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391563518 test passed.

[GitHub] peng-yongsheng commented on issue #1215: No traceId In trace page sometimes

2018-05-23 Thread GitBox
peng-yongsheng commented on issue #1215: No traceId In trace page sometimes URL: https://github.com/apache/incubator-skywalking/issues/1215#issuecomment-391294323 Delay times will be more and more longer when collector received too much segments. I suggest that setting the end time at the

[GitHub] ascrutae commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-23 Thread GitBox
ascrutae commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391530381 I had fix this. maybe you can try This is

[GitHub] wu-sheng commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-23 Thread GitBox
wu-sheng commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391553545 > Here is the test report Thanks. Continue to wait for @candyleer feedback. :)

[GitHub] wu-sheng commented on issue #1251: Add sha512 into the release vote mail

2018-05-23 Thread GitBox
wu-sheng commented on issue #1251: Add sha512 into the release vote mail URL: https://github.com/apache/incubator-skywalking/issues/1251#issuecomment-391553618 Provided This is an automated message from the Apache Git

[GitHub] peng-yongsheng commented on a change in pull request #1255: Fixing #1231. Adding order and status to trace query.

2018-05-23 Thread GitBox
peng-yongsheng commented on a change in pull request #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#discussion_r190442975 ## File path:

[GitHub] wu-sheng commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-23 Thread GitBox
wu-sheng commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391550097 @ajanthan Your CI fails. This is an automated

[GitHub] ascrutae commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-23 Thread GitBox
ascrutae commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391544193 Here is the [test

[GitHub] wu-sheng commented on issue #1245: Use -RC(x) suffixes in vote process

2018-05-23 Thread GitBox
wu-sheng commented on issue #1245: Use -RC(x) suffixes in vote process URL: https://github.com/apache/incubator-skywalking/issues/1245#issuecomment-391553858 Provided This is an automated message from the Apache Git Service.

[GitHub] wu-sheng closed issue #1245: Use -RC(x) suffixes in vote process

2018-05-23 Thread GitBox
wu-sheng closed issue #1245: Use -RC(x) suffixes in vote process URL: https://github.com/apache/incubator-skywalking/issues/1245 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wu-sheng closed issue #1246: Add `re-tag` step in release document

2018-05-23 Thread GitBox
wu-sheng closed issue #1246: Add `re-tag` step in release document URL: https://github.com/apache/incubator-skywalking/issues/1246 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] wu-sheng closed issue #1247: Guide release committer to add a full git path in release announce and vote mail

2018-05-23 Thread GitBox
wu-sheng closed issue #1247: Guide release committer to add a full git path in release announce and vote mail URL: https://github.com/apache/incubator-skywalking/issues/1247 This is an automated message from the Apache Git

[GitHub] wu-sheng commented on issue #1246: Add `re-tag` step in release document

2018-05-23 Thread GitBox
wu-sheng commented on issue #1246: Add `re-tag` step in release document URL: https://github.com/apache/incubator-skywalking/issues/1246#issuecomment-391553706 Provided This is an automated message from the Apache Git

[GitHub] wu-sheng closed issue #1243: support RuntimeContext feature

2018-05-23 Thread GitBox
wu-sheng closed issue #1243: support RuntimeContext feature URL: https://github.com/apache/incubator-skywalking/issues/1243 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng closed issue #1251: Add sha512 into the release vote mail

2018-05-23 Thread GitBox
wu-sheng closed issue #1251: Add sha512 into the release vote mail URL: https://github.com/apache/incubator-skywalking/issues/1251 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] wu-sheng commented on issue #1247: Guide release committer to add a full git path in release announce and vote mail

2018-05-23 Thread GitBox
wu-sheng commented on issue #1247: Guide release committer to add a full git path in release announce and vote mail URL: https://github.com/apache/incubator-skywalking/issues/1247#issuecomment-391553695 Provided This is an

[GitHub] wu-sheng closed pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-23 Thread GitBox
wu-sheng closed pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-23 Thread GitBox
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391550932 Merged, hope you could provide a blog to tell people to use it.

[GitHub] wu-sheng commented on a change in pull request #1255: Fixing #1231. Adding order and status to trace query.

2018-05-23 Thread GitBox
wu-sheng commented on a change in pull request #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#discussion_r190443384 ## File path:

[GitHub] wu-sheng closed issue #462: [Agent] Plugin for Spring ThreadPoolTaskExecutor

2018-05-24 Thread GitBox
wu-sheng closed issue #462: [Agent] Plugin for Spring ThreadPoolTaskExecutor URL: https://github.com/apache/incubator-skywalking/issues/462 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng commented on issue #1231: Add order and status options in trace query.

2018-05-24 Thread GitBox
wu-sheng commented on issue #1231: Add order and status options in trace query. URL: https://github.com/apache/incubator-skywalking/issues/1231#issuecomment-391632777 Provided. Thanks to @ajanthan This is an automated

[GitHub] wu-sheng closed issue #1231: Add order and status options in trace query.

2018-05-24 Thread GitBox
wu-sheng closed issue #1231: Add order and status options in trace query. URL: https://github.com/apache/incubator-skywalking/issues/1231 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng closed issue #1238: NPE when use hystrix in spring

2018-05-24 Thread GitBox
wu-sheng closed issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring

2018-05-24 Thread GitBox
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-391632726 Fixed. This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages

2018-05-24 Thread GitBox
wu-sheng commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages URL: https://github.com/apache/incubator-skywalking/issues/1236#issuecomment-391633056 @wfs0902 Could you recheck this for our master code? I assume it is fixed. If fix fails,

[GitHub] wu-sheng closed issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages

2018-05-24 Thread GitBox
wu-sheng closed issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages URL: https://github.com/apache/incubator-skywalking/issues/1236 This is an automated message from the Apache Git

[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-24 Thread GitBox
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391629031 @SevenPointOld I think you miss add your README to incubating features menu.

[GitHub] coveralls commented on issue #1261: Sync UI about trace query.

2018-05-24 Thread GitBox
coveralls commented on issue #1261: Sync UI about trace query. URL: https://github.com/apache/incubator-skywalking/pull/1261#issuecomment-391633574 [![Coverage Status](https://coveralls.io/builds/17142195/badge)](https://coveralls.io/builds/17142195) Coverage decreased

[GitHub] carlvine500 commented on issue #462: [Agent] Plugin for Spring ThreadPoolTaskExecutor

2018-05-24 Thread GitBox
carlvine500 commented on issue #462: [Agent] Plugin for Spring ThreadPoolTaskExecutor URL: https://github.com/apache/incubator-skywalking/issues/462#issuecomment-391603189 @wu-sheng I think it's already supported , @wtj199101 follow my example: ``` ExecutorService threadPool

[GitHub] wu-sheng opened a new pull request #1261: Sync UI about trace query.

2018-05-24 Thread GitBox
wu-sheng opened a new pull request #1261: Sync UI about trace query. URL: https://github.com/apache/incubator-skywalking/pull/1261 Because I merged the new trace query, I have to submit this UI sync. Otherwise, most likely, trace query will not be able to use. FYI

[GitHub] peng-yongsheng closed issue #1195: Invalid calls in Service topology query

2018-05-24 Thread GitBox
peng-yongsheng closed issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] peng-yongsheng commented on issue #1195: Invalid calls in Service topology query

2018-05-24 Thread GitBox
peng-yongsheng commented on issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195#issuecomment-391644247 Add check method into agent-collector protocol to avoid system exception when users clean all of the data in storage. It

[GitHub] ascrutae opened a new pull request #1256: Fix occure the NPE when SpringMVC and hystrix work together

2018-05-22 Thread GitBox
ascrutae opened a new pull request #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ]

[GitHub] ajanthan opened a new pull request #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu…

2018-05-22 Thread GitBox
ajanthan opened a new pull request #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu… URL: https://github.com/apache/incubator-skywalking-ui/pull/172 Fixing issue[1231](https://github.com/apache/incubator-skywalking/issues/1231). Enabling trace search by status

[GitHub] ajanthan opened a new pull request #1255: Fixing #1231. Adding order and status to trace query.

2018-05-22 Thread GitBox
ajanthan opened a new pull request #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ *] New

[GitHub] coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-22 Thread GitBox
coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391136082 [![Coverage Status](https://coveralls.io/builds/17113658/badge)](https://coveralls.io/builds/17113658)

[GitHub] wu-sheng commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-22 Thread GitBox
wu-sheng commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391163251 Thanks and look forward to have this soon. This

[GitHub] wu-sheng commented on a change in pull request #1252: Update release doc and related script

2018-05-22 Thread GitBox
wu-sheng commented on a change in pull request #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252#discussion_r190070122 ## File path: tools/releasing/create_source_release.sh ## @@ -20,11 +20,13 @@ # This script

[GitHub] ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query.

2018-05-22 Thread GitBox
ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391161821 OK. Let me change Ints to enum and resend the pull request.

[GitHub] SevenPointOld commented on issue #1265: Add introduce doc to incubating features menu

2018-05-25 Thread GitBox
SevenPointOld commented on issue #1265: Add introduce doc to incubating features menu URL: https://github.com/apache/incubator-skywalking/pull/1265#issuecomment-391985959 >I changes some English doc. Thanks, my English is poor~ >.<

[GitHub] wu-sheng commented on issue #1265: Add introduce doc to incubating features menu

2018-05-25 Thread GitBox
wu-sheng commented on issue #1265: Add introduce doc to incubating features menu URL: https://github.com/apache/incubator-skywalking/pull/1265#issuecomment-391986273 Don't worry, I am not a English native too. Just try my best.

[GitHub] wu-sheng closed pull request #1265: Add introduce doc to incubating features menu

2018-05-25 Thread GitBox
wu-sheng closed pull request #1265: Add introduce doc to incubating features menu URL: https://github.com/apache/incubator-skywalking/pull/1265 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] wu-sheng commented on issue #1265: Add introduce doc to incubating features menu

2018-05-25 Thread GitBox
wu-sheng commented on issue #1265: Add introduce doc to incubating features menu URL: https://github.com/apache/incubator-skywalking/pull/1265#issuecomment-391986273 Don't worry, I am not an English native too. Just try my best.

[GitHub] wu-sheng commented on a change in pull request #1266: Change component definitions

2018-05-25 Thread GitBox
wu-sheng commented on a change in pull request #1266: Change component definitions URL: https://github.com/apache/incubator-skywalking/pull/1266#discussion_r190916985 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1266: Change component definitions

2018-05-25 Thread GitBox
wu-sheng commented on a change in pull request #1266: Change component definitions URL: https://github.com/apache/incubator-skywalking/pull/1266#discussion_r190928095 ## File path: apm-collector/apm-collector-boot/src/main/resources/component-libraries.yml ## @@ -123,7

[GitHub] coveralls commented on issue #1264: way to solve Import-Project-Eclipse-RequireItems-Exception

2018-05-25 Thread GitBox
coveralls commented on issue #1264: way to solve Import-Project-Eclipse-RequireItems-Exception URL: https://github.com/apache/incubator-skywalking/pull/1264#issuecomment-392114773 [![Coverage Status](https://coveralls.io/builds/17160381/badge)](https://coveralls.io/builds/17160381)

[GitHub] wu-sheng commented on a change in pull request #1266: Change component definitions

2018-05-25 Thread GitBox
wu-sheng commented on a change in pull request #1266: Change component definitions URL: https://github.com/apache/incubator-skywalking/pull/1266#discussion_r190916245 ## File path: apm-collector/apm-collector-boot/src/main/resources/component-libraries.yml ## @@ -123,7

[GitHub] coveralls commented on issue #1265: Add introduce doc to incubating features menu

2018-05-25 Thread GitBox
coveralls commented on issue #1265: Add introduce doc to incubating features menu URL: https://github.com/apache/incubator-skywalking/pull/1265#issuecomment-392181221 [![Coverage Status](https://coveralls.io/builds/17162912/badge)](https://coveralls.io/builds/17162912)

[GitHub] coveralls commented on issue #1265: Add introduce doc to incubating features menu

2018-05-25 Thread GitBox
coveralls commented on issue #1265: Add introduce doc to incubating features menu URL: https://github.com/apache/incubator-skywalking/pull/1265#issuecomment-392181221 [![Coverage Status](https://coveralls.io/builds/17162414/badge)](https://coveralls.io/builds/17162414)

[GitHub] coveralls commented on issue #1264: way to solve Import-Project-Eclipse-RequireItems-Exception

2018-05-25 Thread GitBox
coveralls commented on issue #1264: way to solve Import-Project-Eclipse-RequireItems-Exception URL: https://github.com/apache/incubator-skywalking/pull/1264#issuecomment-392114773 [![Coverage Status](https://coveralls.io/builds/17163821/badge)](https://coveralls.io/builds/17163821)

[GitHub] coveralls commented on issue #1265: Add introduce doc to incubating features menu

2018-05-25 Thread GitBox
coveralls commented on issue #1265: Add introduce doc to incubating features menu URL: https://github.com/apache/incubator-skywalking/pull/1265#issuecomment-392181221 [![Coverage Status](https://coveralls.io/builds/17163096/badge)](https://coveralls.io/builds/17163096)

[GitHub] ascrutae commented on a change in pull request #1266: Change component definitions

2018-05-25 Thread GitBox
ascrutae commented on a change in pull request #1266: Change component definitions URL: https://github.com/apache/incubator-skywalking/pull/1266#discussion_r190920795 ## File path: apm-collector/apm-collector-boot/src/main/resources/component-libraries.yml ## @@ -123,7

[GitHub] ascrutae commented on a change in pull request #1266: Change component definitions

2018-05-25 Thread GitBox
ascrutae commented on a change in pull request #1266: Change component definitions URL: https://github.com/apache/incubator-skywalking/pull/1266#discussion_r190920795 ## File path: apm-collector/apm-collector-boot/src/main/resources/component-libraries.yml ## @@ -123,7

[GitHub] coveralls commented on issue #1264: way to solve Import-Project-Eclipse-RequireItems-Exception

2018-05-25 Thread GitBox
coveralls commented on issue #1264: way to solve Import-Project-Eclipse-RequireItems-Exception URL: https://github.com/apache/incubator-skywalking/pull/1264#issuecomment-392114773 [![Coverage Status](https://coveralls.io/builds/17161823/badge)](https://coveralls.io/builds/17161823)

[GitHub] coveralls commented on issue #1266: Change component definitions

2018-05-25 Thread GitBox
coveralls commented on issue #1266: Change component definitions URL: https://github.com/apache/incubator-skywalking/pull/1266#issuecomment-392117629 [![Coverage Status](https://coveralls.io/builds/17162800/badge)](https://coveralls.io/builds/17162800) Coverage decreased

[GitHub] wu-sheng opened a new pull request #1267: Adjust the release doc

2018-05-25 Thread GitBox
wu-sheng opened a new pull request #1267: Adjust the release doc URL: https://github.com/apache/incubator-skywalking/pull/1267 Make tag rule more clear. @peng-yongsheng Please check, is this right? This is an automated

[GitHub] wu-sheng commented on issue #1264: way to solve Import-Project-Eclipse-RequireItems-Exception

2018-05-25 Thread GitBox
wu-sheng commented on issue #1264: way to solve Import-Project-Eclipse-RequireItems-Exception URL: https://github.com/apache/incubator-skywalking/pull/1264#issuecomment-392219303 @hardzhang Could do fix the markdown style issue? Hope to merge this soon. A doc related pr should be

[GitHub] coveralls commented on issue #1266: Change component definitions

2018-05-25 Thread GitBox
coveralls commented on issue #1266: Change component definitions URL: https://github.com/apache/incubator-skywalking/pull/1266#issuecomment-392117629 [![Coverage Status](https://coveralls.io/builds/17167903/badge)](https://coveralls.io/builds/17167903) Coverage decreased

[GitHub] wu-sheng commented on issue #1266: Change component definitions

2018-05-25 Thread GitBox
wu-sheng commented on issue #1266: Change component definitions URL: https://github.com/apache/incubator-skywalking/pull/1266#issuecomment-392224503 @ascrutae Your CI fails. Please recheck. This is an automated message from

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-25 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-392228770 `origin/zipkin/receiver-v1` branch has been created. I am going to build the skeleton for Zipkin data, started with

[GitHub] wu-sheng commented on issue #1177: The number of Kafka is incorrect

2018-05-25 Thread GitBox
wu-sheng commented on issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177#issuecomment-392237380 @ajanthan Look like you are facing this issue too. I can explain to you with more details. The reason I called this a design issue, it

[GitHub] ajanthan commented on issue #1177: The number of Kafka is incorrect

2018-05-25 Thread GitBox
ajanthan commented on issue #1177: The number of Kafka is incorrect URL: https://github.com/apache/incubator-skywalking/issues/1177#issuecomment-392232253 @wu-sheng I guess you have found the root cause of the issue. Could you please describe your findings?

<    1   2   3   4   5   6   7   8   9   10   >