[GitHub] wu-sheng commented on a change in pull request #1331: modify the document

2018-06-08 Thread GitBox
wu-sheng commented on a change in pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331#discussion_r193998527 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,10 @@ CATALINA_OPTS="$CATALINA_OPTS

[GitHub] candyleer opened a new issue #1327: Application Avg Throughput Issue

2018-06-08 Thread GitBox
candyleer opened a new issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ]

[GitHub] wu-sheng commented on issue #1327: Application Avg Throughput Issue

2018-06-08 Thread GitBox
wu-sheng commented on issue #1327: Application Avg Throughput Issue URL: https://github.com/apache/incubator-skywalking/issues/1327#issuecomment-395672039 @peng-yongsheng Could you give some explanation about how does the collector calculate the throughputs of server? The UI did a

[GitHub] SoberChina opened a new pull request #1328: Modify the document

2018-06-08 Thread GitBox
SoberChina opened a new pull request #1328: Modify the document URL: https://github.com/apache/incubator-skywalking/pull/1328 Please answer these questions before submitting pull request - Why submit this pull request? Modify the document - Related issues ___

[GitHub] wu-sheng commented on issue #1329: tomcat 探针使用说明修改

2018-06-08 Thread GitBox
wu-sheng commented on issue #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329#issuecomment-395692551 You don't need to close every time. Just update your branch. This is an automated

[GitHub] wu-sheng commented on issue #151: Place conjecture nodes outside application topology

2018-06-08 Thread GitBox
wu-sheng commented on issue #151: Place conjecture nodes outside application topology URL: https://github.com/apache/incubator-skywalking-ui/issues/151#issuecomment-395717743 After we provided new filter mechanism for topology map, do we still implement this? even in the future?

[GitHub] wu-sheng commented on issue #1324: UI service error

2018-06-07 Thread GitBox
wu-sheng commented on issue #1324: UI service error URL: https://github.com/apache/incubator-skywalking/issues/1324#issuecomment-395655938 Haha, too many duplicate issue. This is an automated message from the Apache Git

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395658256 wait a moment ,i will show you the reason This is an automated

[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395658112 @candyleer Could you be specific about how? Or trigger what? This

[GitHub] candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
candyleer commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395657915 @ascrutae @wu-sheng I have tried this solution, but this will trigger other problem

[GitHub] haotian2015 opened a new pull request #1329: tomcat 探针使用说明修改

2018-06-08 Thread GitBox
haotian2015 opened a new pull request #1329: tomcat 探针使用说明修改 URL: https://github.com/apache/incubator-skywalking/pull/1329 tomcat 探针使用说明修改 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] SoberChina commented on issue #1331: modify the document

2018-06-08 Thread GitBox
SoberChina commented on issue #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331#issuecomment-395698847 The pr [#1330](https://github.com/apache/incubator-skywalking/pull/1330) is in conflict with me.

[GitHub] wu-sheng commented on issue #178: 5.0.0/beta2

2018-06-08 Thread GitBox
wu-sheng commented on issue #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178#issuecomment-395725070 @hanahmily Merge is OK to me. Thise three could be considered, because @peng-yongsheng can't be ready in this week. So, consider at least one more week

[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395660899 @ascrutae What do you mean about `event should be display in the trace topology`? Event of a new local span?

[GitHub] haotian2015 opened a new issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document.

2018-06-08 Thread GitBox
haotian2015 opened a new issue #1326: There is a problem in the agent configuration of tomcat 8 in quick start document. URL: https://github.com/apache/incubator-skywalking/issues/1326 linux 环境下,tomcat 7和tomcat8的探针配置应该是一样的,文档中tomcat8的配置应该是windows系统的配置

[GitHub] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395676001 I am saying, creating span for `forward` is high payload for agent. It is not necessary. Please consider 1. Use RuntimeContext to

[GitHub] SoberChina commented on a change in pull request #1331: modify the document

2018-06-08 Thread GitBox
SoberChina commented on a change in pull request #1331: modify the document URL: https://github.com/apache/incubator-skywalking/pull/1331#discussion_r194000297 ## File path: docs/en/Deploy-skywalking-agent.md ## @@ -39,5 +39,10 @@ CATALINA_OPTS="$CATALINA_OPTS

[GitHub] wu-sheng commented on issue #1332: trace detail ui:enable span detail panel always visible when there are lots of trace spans

2018-06-08 Thread GitBox
wu-sheng commented on issue #1332: trace detail ui:enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332#issuecomment-395706125 I understood and received this feedback before. @hanahmily Please make the

[GitHub] hanahmily opened a new pull request #178: 5.0.0/beta2

2018-06-08 Thread GitBox
hanahmily opened a new pull request #178: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/178 Merge to master This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] adriancole commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-07 Thread GitBox
adriancole commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-395458531 @wu-sheng so the remoteEndpoint is optional in zipkin's schema, representing usually network layer detail of the upstream

[GitHub] candyleer commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
candyleer commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#discussion_r194208823 ## File path:

[GitHub] wu-sheng commented on issue #1332: trace detail ui:enable span detail panel always visible when there are lots of trace spans

2018-06-08 Thread GitBox
wu-sheng commented on issue #1332: trace detail ui:enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332#issuecomment-395929732 Moved to UI issue already.

[GitHub] wu-sheng closed issue #1332: trace detail ui:enable span detail panel always visible when there are lots of trace spans

2018-06-08 Thread GitBox
wu-sheng closed issue #1332: trace detail ui:enable span detail panel always visible when there are lots of trace spans URL: https://github.com/apache/incubator-skywalking/issues/1332 This is an automated message from the

[GitHub] wu-sheng closed issue #1304: UNIMPLEMENTED: Method not found: ApplicationRegisterService/applicationCodeRegister

2018-06-08 Thread GitBox
wu-sheng closed issue #1304: UNIMPLEMENTED: Method not found: ApplicationRegisterService/applicationCodeRegister URL: https://github.com/apache/incubator-skywalking/issues/1304 This is an automated message from the Apache

[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395921149 @wu-sheng @candyleer I had change the code. and now the spring mvc plugin will not create the entry span when every forward even

[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395921149 @wu-sheng @candyleer I had change the code. and now the spring mvc plugin will not create the entry span when every forward

[GitHub] wu-sheng opened a new issue #179: Change chars to black from white in trace page

2018-06-08 Thread GitBox
wu-sheng opened a new issue #179: Change chars to black from white in trace page URL: https://github.com/apache/incubator-skywalking-ui/issues/179 This is the feedback from community. This is an automated message from the

[GitHub] wu-sheng opened a new issue #180: Improve user experience of span detail in trace page

2018-06-08 Thread GitBox
wu-sheng opened a new issue #180: Improve user experience of span detail in trace page URL: https://github.com/apache/incubator-skywalking-ui/issues/180 If there are many spans in trace, span detail is at the bottom of page, even can't see in default page. Need to scroll page to see.

[GitHub] wu-sheng closed issue #1279: trace graphql query error..

2018-06-08 Thread GitBox
wu-sheng closed issue #1279: trace graphql query error.. URL: https://github.com/apache/incubator-skywalking/issues/1279 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] gamefundas commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent

2018-06-18 Thread GitBox
gamefundas commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent URL: https://github.com/apache/incubator-skywalking/issues/1361#issuecomment-398144366 In our spring security implementation one of the bean post processor does the

[GitHub] coveralls commented on issue #1273: Zipkin receiver in SkyWalking collector

2018-06-16 Thread GitBox
coveralls commented on issue #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-392457692 [![Coverage Status](https://coveralls.io/builds/17528313/badge)](https://coveralls.io/builds/17528313) Coverage

[GitHub] sky-syk commented on issue #1349: collector always print errro logs

2018-06-15 Thread GitBox
sky-syk commented on issue #1349: collector always print errro logs URL: https://github.com/apache/incubator-skywalking/issues/1349#issuecomment-397781750 i have solved this problem ,the cause of is the configure of ElasticSearch , threadpool.bulk.size is too small

[GitHub] wu-sheng opened a new issue #1359: Run more tests in Zipkin examples

2018-06-16 Thread GitBox
wu-sheng opened a new issue #1359: Run more tests in Zipkin examples URL: https://github.com/apache/incubator-skywalking/issues/1359 In #1273 , I just test sleuth MVC example only. That is definitely not enough. @adriancole What other example projects do you suggest to run by us?

[GitHub] coveralls commented on issue #1357: Fix #1356: Remove unused depencies package

2018-06-16 Thread GitBox
coveralls commented on issue #1357: Fix #1356: Remove unused depencies package URL: https://github.com/apache/incubator-skywalking/pull/1357#issuecomment-397802525 [![Coverage Status](https://coveralls.io/builds/17527812/badge)](https://coveralls.io/builds/17527812) Coverage

[GitHub] wu-sheng closed issue #1356: the dubbo-plugin uses an unsupported version of RestEasy

2018-06-16 Thread GitBox
wu-sheng closed issue #1356: the dubbo-plugin uses an unsupported version of RestEasy URL: https://github.com/apache/incubator-skywalking/issues/1356 This is an automated message from the Apache Git Service. To respond to

[GitHub] ascrutae commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy

2018-06-16 Thread GitBox
ascrutae commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy URL: https://github.com/apache/incubator-skywalking/issues/1356#issuecomment-397801164 @wu-sheng The `jackson` package is imported by `resteasy-jackson-provider` package. Not `dubbo` package, so

[GitHub] wu-sheng closed pull request #1357: Fix #1356: Remove unused depencies package

2018-06-16 Thread GitBox
wu-sheng closed pull request #1357: Fix #1356: Remove unused depencies package URL: https://github.com/apache/incubator-skywalking/pull/1357 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] coveralls commented on issue #1273: Zipkin receiver in SkyWalking collector

2018-06-16 Thread GitBox
coveralls commented on issue #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-392457692 [![Coverage Status](https://coveralls.io/builds/17528985/badge)](https://coveralls.io/builds/17528985) Coverage

[GitHub] ascrutae commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy

2018-06-16 Thread GitBox
ascrutae commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy URL: https://github.com/apache/incubator-skywalking/issues/1356#issuecomment-397801164 @wu-sheng The `jackson` package is imported by `resteasy-jackson-provider` package. Not `dubbo` package, so

[GitHub] ascrutae opened a new pull request #1357: Fix #1356: Remove unused depencies package

2018-06-16 Thread GitBox
ascrutae opened a new pull request #1357: Fix #1356: Remove unused depencies package URL: https://github.com/apache/incubator-skywalking/pull/1357 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature

[GitHub] coveralls commented on issue #1273: Zipkin receiver in SkyWalking collector

2018-06-16 Thread GitBox
coveralls commented on issue #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-392457692 [![Coverage Status](https://coveralls.io/builds/17528973/badge)](https://coveralls.io/builds/17528973) Coverage

[GitHub] wu-sheng opened a new issue #1358: Replace Caffeine with new expired mechanism in zipkin receiver

2018-06-16 Thread GitBox
wu-sheng opened a new issue #1358: Replace Caffeine with new expired mechanism in zipkin receiver URL: https://github.com/apache/incubator-skywalking/issues/1358 In the initial version of Zipkin receiver, we use Caffeine as the buffer and use Caffeine expire mechanism to make sure trace

[GitHub] wu-sheng opened a new issue #1360: Look volunteers to translate(sync) English documents to Chinese

2018-06-16 Thread GitBox
wu-sheng opened a new issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360 We want to find some volunteers to help us to sync and translate new English documents to Chinese. They are out of date now.

[GitHub] doublebody commented on issue #1350: spring mvc plugin fails

2018-06-14 Thread GitBox
doublebody commented on issue #1350: spring mvc plugin fails URL: https://github.com/apache/incubator-skywalking/issues/1350#issuecomment-397230260 it may caused by spring security ? This is an automated message from the

[GitHub] doublebody closed issue #1350: spring mvc plugin fails

2018-06-14 Thread GitBox
doublebody closed issue #1350: spring mvc plugin fails URL: https://github.com/apache/incubator-skywalking/issues/1350 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] doublebody commented on issue #1350: spring mvc plugin fails

2018-06-14 Thread GitBox
doublebody commented on issue #1350: spring mvc plugin fails URL: https://github.com/apache/incubator-skywalking/issues/1350#issuecomment-397275679 已解决,spring-boot-devtools,RestartClassLoader影响 This is an automated message

[GitHub] wu-sheng commented on issue #1349: collector always print errro logs

2018-06-14 Thread GitBox
wu-sheng commented on issue #1349: collector always print errro logs URL: https://github.com/apache/incubator-skywalking/issues/1349#issuecomment-397211308 If you even removed ElasticSearch Data, please reboot your application.

[GitHub] coveralls commented on issue #1351: 修改更新

2018-06-14 Thread GitBox
coveralls commented on issue #1351: 修改更新 URL: https://github.com/apache/incubator-skywalking/pull/1351#issuecomment-397219286 [![Coverage Status](https://coveralls.io/builds/17486458/badge)](https://coveralls.io/builds/17486458) Coverage decreased (-0.004%) to 23.943% when

[GitHub] doublebody commented on issue #1350: spring mvc plugin fails

2018-06-14 Thread GitBox
doublebody commented on issue #1350: spring mvc plugin fails URL: https://github.com/apache/incubator-skywalking/issues/1350#issuecomment-397257684 INFO 2018-06-14 19:06:51 GetBeanInterceptor : this EnhancedInstance classload is

[GitHub] wu-sheng commented on a change in pull request #1347: support shardingjdbc database storage feature

2018-06-14 Thread GitBox
wu-sheng commented on a change in pull request #1347: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1347#discussion_r195410337 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1347: support shardingjdbc database storage feature

2018-06-14 Thread GitBox
wu-sheng commented on a change in pull request #1347: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1347#discussion_r195410323 ## File path:

[GitHub] wu-sheng commented on issue #1349: collector always print errro logs

2018-06-14 Thread GitBox
wu-sheng commented on issue #1349: collector always print errro logs URL: https://github.com/apache/incubator-skywalking/issues/1349#issuecomment-397211088 Could you try to upgrade your ElasticSearch to 5.5+? We have no experience in dealing with problems like this.

[GitHub] chidaodezhongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature

2018-06-14 Thread GitBox
chidaodezhongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1347#discussion_r195356683 ## File path:

[GitHub] ascrutae commented on issue #1350: spring mvc plugin fails

2018-06-14 Thread GitBox
ascrutae commented on issue #1350: spring mvc plugin fails URL: https://github.com/apache/incubator-skywalking/issues/1350#issuecomment-397216412 I am afraid not that we don't fixed this issue yet. Because There is an `ClassCastException` exception display in the stack. and it show me

[GitHub] coveralls commented on issue #1347: support shardingjdbc database storage feature

2018-06-14 Thread GitBox
coveralls commented on issue #1347: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1347#issuecomment-396498997 [![Coverage Status](https://coveralls.io/builds/17489556/badge)](https://coveralls.io/builds/17489556)

[GitHub] chidaodezhongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature

2018-06-14 Thread GitBox
chidaodezhongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1347#discussion_r195356341 ## File path:

[GitHub] wu-sheng commented on issue #1361: Spring Boot application startup fails with 5.0 beta agent

2018-06-16 Thread GitBox
wu-sheng commented on issue #1361: Spring Boot application startup fails with 5.0 beta agent URL: https://github.com/apache/incubator-skywalking/issues/1361#issuecomment-397842718 Could you provide a demo application to reproduce the DI failure. @ascrutae maybe this is springboot

[GitHub] gamefundas opened a new issue #1361: Spring Boot application startup fails with 5.0 beta agent

2018-06-16 Thread GitBox
gamefundas opened a new issue #1361: Spring Boot application startup fails with 5.0 beta agent URL: https://github.com/apache/incubator-skywalking/issues/1361 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion

[GitHub] coveralls commented on issue #1366: Add architecture design doc

2018-06-18 Thread GitBox
coveralls commented on issue #1366: Add architecture design doc URL: https://github.com/apache/incubator-skywalking/pull/1366#issuecomment-398085867 [![Coverage Status](https://coveralls.io/builds/17550386/badge)](https://coveralls.io/builds/17550386) Coverage decreased

[GitHub] coveralls commented on issue #1366: Add architecture design doc

2018-06-18 Thread GitBox
coveralls commented on issue #1366: Add architecture design doc URL: https://github.com/apache/incubator-skywalking/pull/1366#issuecomment-398085867 [![Coverage Status](https://coveralls.io/builds/17548664/badge)](https://coveralls.io/builds/17548664) Coverage increased

[GitHub] coveralls commented on issue #1366: Add architecture design doc

2018-06-18 Thread GitBox
coveralls commented on issue #1366: Add architecture design doc URL: https://github.com/apache/incubator-skywalking/pull/1366#issuecomment-398085867 [![Coverage Status](https://coveralls.io/builds/17548731/badge)](https://coveralls.io/builds/17548731) Coverage remained the same

[GitHub] coveralls commented on issue #1366: Add architecture design doc

2018-06-18 Thread GitBox
coveralls commented on issue #1366: Add architecture design doc URL: https://github.com/apache/incubator-skywalking/pull/1366#issuecomment-398085867 [![Coverage Status](https://coveralls.io/builds/17549010/badge)](https://coveralls.io/builds/17549010) Coverage increased

[GitHub] wu-sheng commented on issue #1364: Recommended architecture for micro services

2018-06-18 Thread GitBox
wu-sheng commented on issue #1364: Recommended architecture for micro services URL: https://github.com/apache/incubator-skywalking/issues/1364#issuecomment-398100975 And you could find more details in here:

[GitHub] gamefundas commented on issue #1364: Recommended architecture for micro services

2018-06-18 Thread GitBox
gamefundas commented on issue #1364: Recommended architecture for micro services URL: https://github.com/apache/incubator-skywalking/issues/1364#issuecomment-398116169 The TCP/gRPC proxy kind of makes sense. Will explore that option.

[GitHub] wu-sheng closed pull request #1273: Zipkin receiver in SkyWalking collector

2018-06-18 Thread GitBox
wu-sheng closed pull request #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng opened a new pull request #1366: Add architecture design doc

2018-06-18 Thread GitBox
wu-sheng opened a new pull request #1366: Add architecture design doc URL: https://github.com/apache/incubator-skywalking/pull/1366 Provide the basic principles of SkyWalking architecture design. This is an automated message

[GitHub] gamefundas commented on issue #1365: Spring boot integration and trying to get this to work

2018-06-18 Thread GitBox
gamefundas commented on issue #1365: Spring boot integration and trying to get this to work URL: https://github.com/apache/incubator-skywalking/issues/1365#issuecomment-398100515 Managed to get it running by having javaagent as the first parameter. However I am getting the following

[GitHub] wu-sheng commented on issue #1364: Recommended architecture for micro services

2018-06-18 Thread GitBox
wu-sheng commented on issue #1364: Recommended architecture for micro services URL: https://github.com/apache/incubator-skywalking/issues/1364#issuecomment-398230677 > The TCP/gRPC proxy kind of makes sense. Will explore that option. For more details considered, just a proxy for

[GitHub] wu-sheng commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent

2018-06-18 Thread GitBox
wu-sheng commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent URL: https://github.com/apache/incubator-skywalking/issues/1361#issuecomment-398231371 > I don't see a way to change this common code. Any chance we can configure skywalking

[GitHub] coveralls edited a comment on issue #1366: Add architecture design doc

2018-06-18 Thread GitBox
coveralls edited a comment on issue #1366: Add architecture design doc URL: https://github.com/apache/incubator-skywalking/pull/1366#issuecomment-398085867 [![Coverage Status](https://coveralls.io/builds/17560744/badge)](https://coveralls.io/builds/17560744) Coverage remained

[GitHub] wu-sheng closed pull request #1366: Add architecture design doc

2018-06-18 Thread GitBox
wu-sheng closed pull request #1366: Add architecture design doc URL: https://github.com/apache/incubator-skywalking/pull/1366 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] coveralls edited a comment on issue #1366: Add architecture design doc

2018-06-18 Thread GitBox
coveralls edited a comment on issue #1366: Add architecture design doc URL: https://github.com/apache/incubator-skywalking/pull/1366#issuecomment-398085867 [![Coverage Status](https://coveralls.io/builds/17560724/badge)](https://coveralls.io/builds/17560724) Coverage remained

[GitHub] adriancole commented on issue #1273: Zipkin receiver in SkyWalking collector

2018-06-18 Thread GitBox
adriancole commented on issue #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-398256498 in general, things not defined (which many things are not) simply go into the relevant namespace. ex

[GitHub] ascrutae commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent

2018-06-18 Thread GitBox
ascrutae commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent URL: https://github.com/apache/incubator-skywalking/issues/1361#issuecomment-398260578 @gamefundas I had been reproduce this issue. I will try to find the cause about this

[GitHub] xyydcoo commented on issue #1312: Spring cloud support error

2018-06-12 Thread GitBox
xyydcoo commented on issue #1312: Spring cloud support error URL: https://github.com/apache/incubator-skywalking/issues/1312#issuecomment-396795917 @ascrutae my issus is #989(closed) ,but my data was cleared. This is an

[GitHub] wu-sheng commented on issue #1312: Spring cloud support error

2018-06-12 Thread GitBox
wu-sheng commented on issue #1312: Spring cloud support error URL: https://github.com/apache/incubator-skywalking/issues/1312#issuecomment-396796098 @ascrutae Could you recheck the agent log, please. This is an automated

[GitHub] ascrutae commented on issue #1312: Spring cloud support error

2018-06-12 Thread GitBox
ascrutae commented on issue #1312: Spring cloud support error URL: https://github.com/apache/incubator-skywalking/issues/1312#issuecomment-396761989 @eaglewa @xyydcoo I had test the demo with the latest agent. But it cannot reproduce this issue. Here is the screen snapshot about that

[GitHub] wu-sheng closed issue #1312: Spring cloud support error

2018-06-12 Thread GitBox
wu-sheng closed issue #1312: Spring cloud support error URL: https://github.com/apache/incubator-skywalking/issues/1312 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng commented on issue #1312: Spring cloud support error

2018-06-12 Thread GitBox
wu-sheng commented on issue #1312: Spring cloud support error URL: https://github.com/apache/incubator-skywalking/issues/1312#issuecomment-396809782 Then I am going to close this. If anyome could provide a demo to trigger the issue, we can work on that again.

[GitHub] wu-sheng closed issue #1345: Questions about namespace

2018-06-12 Thread GitBox
wu-sheng closed issue #1345: Questions about namespace URL: https://github.com/apache/incubator-skywalking/issues/1345 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] ascrutae commented on issue #1312: Spring cloud support error

2018-06-12 Thread GitBox
ascrutae commented on issue #1312: Spring cloud support error URL: https://github.com/apache/incubator-skywalking/issues/1312#issuecomment-396801107 I double check it. but I don't got any error messages on my agent log. This

[GitHub] xyydcoo commented on issue #1312: Spring cloud support error

2018-06-12 Thread GitBox
xyydcoo commented on issue #1312: Spring cloud support error URL: https://github.com/apache/incubator-skywalking/issues/1312#issuecomment-396795217 @ascrutae my UI is ok, but agent throw a exception This is an automated

[GitHub] ascrutae commented on issue #1312: Spring cloud support error

2018-06-12 Thread GitBox
ascrutae commented on issue #1312: Spring cloud support error URL: https://github.com/apache/incubator-skywalking/issues/1312#issuecomment-396761989 @eaglewa @xyydcoo I had test the demo with the latest agent. But it cannot reproduce this issue. Here is the screen snapshot about that

[GitHub] haotian2015 commented on issue #1339: the latest code ui bugs

2018-06-13 Thread GitBox
haotian2015 commented on issue #1339: the latest code ui bugs URL: https://github.com/apache/incubator-skywalking/issues/1339#issuecomment-396884411 You may have some code that is not submitted.

[GitHub] wangjunniit commented on issue #443: Which companies are using SkyWalking

2018-06-13 Thread GitBox
wangjunniit commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-396866774 @wu-sheng [logo](http://weixinimg.mtydx.com/%E5%BE%AE%E4%BF%A1%E5%9B%BE%E7%89%87_20180613165812.jpg)

[GitHub] wangjunniit commented on issue #443: Which companies are using SkyWalking

2018-06-13 Thread GitBox
wangjunniit commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-396847631 河南有态度信息科技有限公司,微信小程序:得有生活 线下环境预研中,5.0.0-beta,即将在生产试用 This is

[GitHub] wu-sheng commented on issue #443: Which companies are using SkyWalking

2018-06-13 Thread GitBox
wu-sheng commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-396848008 > 河南有态度信息科技有限公司,微信小程序:得有生活 线下环境预研中,5.0.0-beta,即将在生产试用 @wangjunniit Do you have any logo we could use? Our use case wall

[GitHub] wangjunniit commented on issue #443: Which companies are using SkyWalking

2018-06-13 Thread GitBox
wangjunniit commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-396847631 河南有态度信息科技有限公司,微信小程序:得有生活 使用[.NET Core探针](https://github.com/OpenSkywalking/skywalking-netcore) 线下环境预研中,5.0.0-beta,即将在生产试用

[GitHub] liuhaoyang commented on issue #443: Which companies are using SkyWalking

2018-06-13 Thread GitBox
liuhaoyang commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-396866294 > Do you have any logo we could use? Our use case wall post logo only. :) @wu-sheng

[GitHub] wu-sheng commented on issue #1339: the latest code ui bugs

2018-06-13 Thread GitBox
wu-sheng commented on issue #1339: the latest code ui bugs URL: https://github.com/apache/incubator-skywalking/issues/1339#issuecomment-396926722 @haotian2015 I think @hanahmily just submits some codes this afternoon. But we don't sync them to main repo yet. I suggest you use the release

[GitHub] wu-sheng commented on issue #1339: the latest code ui bugs

2018-06-13 Thread GitBox
wu-sheng commented on issue #1339: the latest code ui bugs URL: https://github.com/apache/incubator-skywalking/issues/1339#issuecomment-396926722 @haotian2015 I think @hanahmily just submits some codes this afternoon. But we don't sync them to main repo yet. I suggest you use the release

[GitHub] peng-yongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature

2018-06-13 Thread GitBox
peng-yongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1347#discussion_r195148969 ## File path:

[GitHub] peng-yongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature

2018-06-13 Thread GitBox
peng-yongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1347#discussion_r195050107 ## File path:

[GitHub] peng-yongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature

2018-06-13 Thread GitBox
peng-yongsheng commented on a change in pull request #1347: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1347#discussion_r195150199 ## File path:

[GitHub] wu-sheng commented on issue #1348: Alarm UI error

2018-06-12 Thread GitBox
wu-sheng commented on issue #1348: Alarm UI error URL: https://github.com/apache/incubator-skywalking/issues/1348#issuecomment-396609314 @hanahmily Is this a collector or UI issue? This is an automated message from the

[GitHub] wu-sheng commented on a change in pull request #1347: support shardingjdbc database storage feature

2018-06-13 Thread GitBox
wu-sheng commented on a change in pull request #1347: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1347#discussion_r195275008 ## File path:

[GitHub] wu-sheng commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-14 Thread GitBox
wu-sheng commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-397333597 @peng-yongsheng @adriancole @jcchavezs @ascrutae I have finished the transfer codes. Zipkin spans -> SkyWalking

[GitHub] chidaodezhongsheng commented on issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
chidaodezhongsheng commented on issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352#issuecomment-397337241 Shardingjdbc support SQL grammar,not support mysql dialect,for example “case when”.I have checked the sqls In h2

[GitHub] jfclere commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy

2018-06-15 Thread GitBox
jfclere commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy URL: https://github.com/apache/incubator-skywalking/issues/1356#issuecomment-397568545 On 15/06/18 11:25, 吴晟 Wu Sheng wrote: > @jfclere This version should have the

[GitHub] wu-sheng commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy

2018-06-15 Thread GitBox
wu-sheng commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy URL: https://github.com/apache/incubator-skywalking/issues/1356#issuecomment-397574625 @ascrutae Please help to check which version of `com.fasterxml.jackson` in the latest Dubbo release. If still

<    4   5   6   7   8   9   10   11   12   13   >