[GitHub] coveralls commented on issue #1273: Zipkin receiver in SkyWalking collector

2018-06-15 Thread GitBox
coveralls commented on issue #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-392457692 [![Coverage Status](https://coveralls.io/builds/17509910/badge)](https://coveralls.io/builds/17509910) Coverage

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-06-15 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-397578969 See SkyWalking supports Zipkin formats in https://github.com/apache/incubator-skywalking/pull/1273 . Only tested in a

[GitHub] wu-sheng commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy

2018-06-15 Thread GitBox
wu-sheng commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy URL: https://github.com/apache/incubator-skywalking/issues/1356#issuecomment-397569275 I will try to find out. Many companies use old version Dubbo lib :) That is why we compile based on that.

[GitHub] peng-yongsheng commented on issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
peng-yongsheng commented on issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352#issuecomment-397331793 We can compare the data type and SQL grammar between ShardingJDBC and H2 first. Then make a decision about this finally.

[GitHub] wu-sheng commented on issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
wu-sheng commented on issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352#issuecomment-397326941 The question is, whether are ShardingJDBC(MySQL core) and H2 compatible in SQL level?

[GitHub] wu-sheng commented on issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
wu-sheng commented on issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352#issuecomment-397338001 My proposal is, evaluate could use shardingjdbc implementor sql in H2, without change required. @chidaodezhongsheng What do you think?

[GitHub] peng-yongsheng opened a new issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
peng-yongsheng opened a new issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352 Thanks to @chidaodezhongsheng for PR #1347 which is the storage implementation of ShardingJDBC. ShardingJDBC is using mysql driver based on the SQL

[GitHub] peng-yongsheng commented on issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
peng-yongsheng commented on issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352#issuecomment-397329172 > Compatibility modes for IBM DB2, Apache Derby, HSQLDB, MS SQL Server, MySQL, Oracle, and PostgreSQL.

[GitHub] coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-14 Thread GitBox
coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-392457692 [![Coverage Status](https://coveralls.io/builds/17493352/badge)](https://coveralls.io/builds/17493352) Coverage

[GitHub] peng-yongsheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-14 Thread GitBox
peng-yongsheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#discussion_r195477317 ## File path:

[GitHub] peng-yongsheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-14 Thread GitBox
peng-yongsheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#discussion_r195475764 ## File path:

[GitHub] peng-yongsheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-14 Thread GitBox
peng-yongsheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#discussion_r195479026 ## File path:

[GitHub] wu-sheng commented on issue #1273: Zipkin receiver in SkyWalking collector

2018-06-15 Thread GitBox
wu-sheng commented on issue #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-397635943 > first cut works.. well done! I'll review closely more easily later as my workspace is all sorted etc Yes. Do a lot of

[GitHub] wu-sheng commented on a change in pull request #1273: Zipkin receiver in SkyWalking collector

2018-06-15 Thread GitBox
wu-sheng commented on a change in pull request #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#discussion_r195775830 ## File path:

[GitHub] adriancole commented on issue #1273: Zipkin receiver in SkyWalking collector

2018-06-15 Thread GitBox
adriancole commented on issue #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-397631961 first cut works.. well done! I'll review closely more easily later as my workspace is all sorted etc

[GitHub] wu-sheng commented on issue #1273: Zipkin receiver in SkyWalking collector

2018-06-15 Thread GitBox
wu-sheng commented on issue #1273: Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-397561313 I finish the prototype of this feature. Here is how people to test this: 1. Download and build the project. 1. Find

[GitHub] wu-sheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-14 Thread GitBox
wu-sheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#discussion_r195586458 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-14 Thread GitBox
wu-sheng commented on a change in pull request #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#discussion_r195585973 ## File path:

[GitHub] liuhaoyang opened a new pull request #1362: Add AspNet component.

2018-06-17 Thread GitBox
liuhaoyang opened a new pull request #1362: Add AspNet component. URL: https://github.com/apache/incubator-skywalking/pull/1362 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] liuhaoyang closed pull request #1362: Add AspNet component.

2018-06-17 Thread GitBox
liuhaoyang closed pull request #1362: Add AspNet component. URL: https://github.com/apache/incubator-skywalking/pull/1362 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] liuhaoyang opened a new pull request #1363: Add AspNet component.

2018-06-17 Thread GitBox
liuhaoyang opened a new pull request #1363: Add AspNet component. URL: https://github.com/apache/incubator-skywalking/pull/1363 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] coveralls commented on issue #1362: Add AspNet component.

2018-06-17 Thread GitBox
coveralls commented on issue #1362: Add AspNet component. URL: https://github.com/apache/incubator-skywalking/pull/1362#issuecomment-397880413 [![Coverage Status](https://coveralls.io/builds/17536517/badge)](https://coveralls.io/builds/17536517) Coverage increased (+0.004%) to

[GitHub] liuhaoyang commented on issue #1362: Add AspNet component.

2018-06-17 Thread GitBox
liuhaoyang commented on issue #1362: Add AspNet component. URL: https://github.com/apache/incubator-skywalking/pull/1362#issuecomment-39787 This pr has some erroneous commits, so I opened a new pr https://github.com/apache/incubator-skywalking/pull/1363.

[GitHub] coveralls commented on issue #1363: Add AspNet component.

2018-06-17 Thread GitBox
coveralls commented on issue #1363: Add AspNet component. URL: https://github.com/apache/incubator-skywalking/pull/1363#issuecomment-397880486 [![Coverage Status](https://coveralls.io/builds/17536530/badge)](https://coveralls.io/builds/17536530) Coverage increased (+0.004%) to

[GitHub] wu-sheng closed pull request #1363: Add AspNet component.

2018-06-17 Thread GitBox
wu-sheng closed pull request #1363: Add AspNet component. URL: https://github.com/apache/incubator-skywalking/pull/1363 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] gamefundas commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent

2018-06-17 Thread GitBox
gamefundas commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent URL: https://github.com/apache/incubator-skywalking/issues/1361#issuecomment-397934423 The above information helps. Let me dig in a little bit on this and then get back on

[GitHub] gamefundas commented on issue #1364: Recommended architecture for micro services

2018-06-17 Thread GitBox
gamefundas commented on issue #1364: Recommended architecture for micro services URL: https://github.com/apache/incubator-skywalking/issues/1364#issuecomment-397936584 By APM infrastructure I meant, skywalking modules comprised of Zk, Collector and ES. I am getting a good feel about how

[GitHub] wu-sheng commented on issue #1364: Recommended architecture for micro services

2018-06-17 Thread GitBox
wu-sheng commented on issue #1364: Recommended architecture for micro services URL: https://github.com/apache/incubator-skywalking/issues/1364#issuecomment-397937689 Thanks for providing these detail info. As that, how do you think if we provide settings file change detected and take

[GitHub] wu-sheng commented on issue #1364: Recommended architecture for micro services

2018-06-17 Thread GitBox
wu-sheng commented on issue #1364: Recommended architecture for micro services URL: https://github.com/apache/incubator-skywalking/issues/1364#issuecomment-397913746 I can give you more details about the architecture. 1. Zookeeper is for collector cluster to detect each other. So

[GitHub] gamefundas commented on issue #1361: Spring Boot application startup fails with 5.0 beta agent

2018-06-17 Thread GitBox
gamefundas commented on issue #1361: Spring Boot application startup fails with 5.0 beta agent URL: https://github.com/apache/incubator-skywalking/issues/1361#issuecomment-397900583 Not related to SB2 as I am having the same trouble with SB 1.5. The problem lies somewhere in our Spring

[GitHub] gamefundas opened a new issue #1364: Recommended architecture for micro services

2018-06-17 Thread GitBox
gamefundas opened a new issue #1364: Recommended architecture for micro services URL: https://github.com/apache/incubator-skywalking/issues/1364 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Question or discussion - [ ] Bug

[GitHub] gamefundas opened a new issue #1365: Spring boot startup script integration

2018-06-17 Thread GitBox
gamefundas opened a new issue #1365: Spring boot startup script integration URL: https://github.com/apache/incubator-skywalking/issues/1365 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Question or discussion - [ ] Bug - [

[GitHub] wu-sheng commented on issue #1364: Recommended architecture for micro services

2018-06-17 Thread GitBox
wu-sheng commented on issue #1364: Recommended architecture for micro services URL: https://github.com/apache/incubator-skywalking/issues/1364#issuecomment-397913986 There is no central cluster node. Agent could connect anyone or some one in cluster, will get the full list finally.

[GitHub] wu-sheng commented on issue #1364: Recommended architecture for micro services

2018-06-17 Thread GitBox
wu-sheng commented on issue #1364: Recommended architecture for micro services URL: https://github.com/apache/incubator-skywalking/issues/1364#issuecomment-397913846 You don't need to reboot agent to get new collector address, the collector naming service provided at the endpoint of you

[GitHub] wu-sheng commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent

2018-06-17 Thread GitBox
wu-sheng commented on issue #1361: Spring Boot application with security filter startup fails with 5.0 beta agent URL: https://github.com/apache/incubator-skywalking/issues/1361#issuecomment-397914409 I can provide this detail to help you guess what is really happening. Each

[GitHub] wu-sheng commented on issue #1365: Spring boot integration and trying to get this to work

2018-06-17 Thread GitBox
wu-sheng commented on issue #1365: Spring boot integration and trying to get this to work URL: https://github.com/apache/incubator-skywalking/issues/1365#issuecomment-397912640 First, I am not familiar with that spring boot script, but in theory, you can check the os startup command by

[GitHub] brucewu-fly commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2018-06-17 Thread GitBox
brucewu-fly commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-397938780 @wu-sheng I can help you translate some documents.

[GitHub] wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2018-06-17 Thread GitBox
wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-397940366 Welcome for helping us. The Documents about deployment, optional plugins and incubating features have

[GitHub] ascrutae commented on issue #1280: RuntimeContext error when in errorHandler

2018-06-07 Thread GitBox
ascrutae commented on issue #1280: RuntimeContext error when in errorHandler URL: https://github.com/apache/incubator-skywalking/issues/1280#issuecomment-395597059 I had found the root cause about this issue. here is my analysis: **REASON**: The Spring MVC framework `forward` the

[GitHub] ascrutae commented on issue #1280: RuntimeContext error when in errorHandler

2018-06-07 Thread GitBox
ascrutae commented on issue #1280: RuntimeContext error when in errorHandler URL: https://github.com/apache/incubator-skywalking/issues/1280#issuecomment-395597059 I had found the root cause about this issue. here is my analysis: **REASON**: The Spring MVC framework `forward` the

[GitHub] coveralls commented on issue #1341: Update spring boot

2018-06-11 Thread GitBox
coveralls commented on issue #1341: Update spring boot URL: https://github.com/apache/incubator-skywalking/pull/1341#issuecomment-396334565 [![Coverage Status](https://coveralls.io/builds/17429244/badge)](https://coveralls.io/builds/17429244) Coverage remained the same at

[GitHub] ascrutae commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
ascrutae commented on a change in pull request #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#discussion_r194212804 ## File path:

[GitHub] peng-yongsheng commented on issue #1262: Filter non-active service name when UI query.

2018-06-08 Thread GitBox
peng-yongsheng commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-395940126 1. Add application id to be a query condition of searchService method. 2. Filter service name by given time which

[GitHub] wu-sheng commented on issue #1262: Filter non-active service name when UI query.

2018-06-08 Thread GitBox
wu-sheng commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-395940726 @peng-yongsheng ci fails. This is an automated message

[GitHub] coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395941131 [![Coverage Status](https://coveralls.io/builds/17403776/badge)](https://coveralls.io/builds/17403776) Coverage

[GitHub] coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-09 Thread GitBox
coveralls commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395941131 [![Coverage Status](https://coveralls.io/builds/17403964/badge)](https://coveralls.io/builds/17403964) Coverage

[GitHub] ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor

2018-06-08 Thread GitBox
ascrutae commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/incubator-skywalking/pull/1325#issuecomment-395940948 I had test this PR in the following scenarios: **Scenario One**: 1. visit `http://localhost:8080/test3` by using browser

[GitHub] liangxp opened a new issue #1368: can not trace springMCV controller

2018-06-18 Thread GitBox
liangxp opened a new issue #1368: can not trace springMCV controller URL: https://github.com/apache/incubator-skywalking/issues/1368 jdk8 server:undertow springboot:2.0.0 agant log: `ERROR 2018-06-19 10:38:29 InstMethodsInter : class[class

[GitHub] wu-sheng commented on issue #1368: can not trace springMCV controller

2018-06-18 Thread GitBox
wu-sheng commented on issue #1368: can not trace springMCV controller URL: https://github.com/apache/incubator-skywalking/issues/1368#issuecomment-398279519 Even `undertow` is unsupported, at least should not harm. This is

[GitHub] wu-sheng commented on issue #1367: HTTPS Req/Responses are not getting traced

2018-06-19 Thread GitBox
wu-sheng commented on issue #1367: HTTPS Req/Responses are not getting traced URL: https://github.com/apache/incubator-skywalking/issues/1367#issuecomment-398283519 If you are using SpringMVC or Struts, there should not relate to HTTPs. If not, just servlet, maybe.

[GitHub] iitsoft opened a new issue #1369: Table "APPLICATION" not found

2018-06-19 Thread GitBox
iitsoft opened a new issue #1369: Table "APPLICATION" not found URL: https://github.com/apache/incubator-skywalking/issues/1369 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ]

[GitHub] wu-sheng commented on issue #1370: can not trace JFinal project

2018-06-19 Thread GitBox
wu-sheng commented on issue #1370: can not trace JFinal project URL: https://github.com/apache/incubator-skywalking/issues/1370#issuecomment-398310392 JFinal has its own tech stack. We haven't supported that. You can help for this, or ask JFinal community to contribute, like Ant SOFA team

[GitHub] peng-yongsheng commented on issue #1369: Table "APPLICATION" not found

2018-06-19 Thread GitBox
peng-yongsheng commented on issue #1369: Table "APPLICATION" not found URL: https://github.com/apache/incubator-skywalking/issues/1369#issuecomment-398295084 H2 storage is not support now, please use elasticsearch. This is

[GitHub] liangxp commented on issue #1368: can not trace springMCV controller

2018-06-19 Thread GitBox
liangxp commented on issue #1368: can not trace springMCV controller URL: https://github.com/apache/incubator-skywalking/issues/1368#issuecomment-398311363 @wu-sheng now,I know the cause of the problem because of ` org.springframework.boot

[GitHub] chidaodezhongsheng opened a new pull request #1353: Add the Logger modifier "static" in pr #1347

2018-06-14 Thread GitBox
chidaodezhongsheng opened a new pull request #1353: Add the Logger modifier "static" in pr #1347 URL: https://github.com/apache/incubator-skywalking/pull/1353 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix -

[GitHub] coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-14 Thread GitBox
coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-392457692 [![Coverage Status](https://coveralls.io/builds/17505073/badge)](https://coveralls.io/builds/17505073) Coverage

[GitHub] wu-sheng closed pull request #1354: fix spymemcached plugin cant't work

2018-06-14 Thread GitBox
wu-sheng closed pull request #1354: fix spymemcached plugin cant't work URL: https://github.com/apache/incubator-skywalking/pull/1354 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] wu-sheng commented on issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
wu-sheng commented on issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352#issuecomment-397497253 > Shardingjdbc support SQL grammar,not support mysql dialect,for example “case when”.I have checked the sqls In h2 storage,Shardingjdbc not

[GitHub] hanahmily opened a new pull request #181: 5.0.0/beta2

2018-06-14 Thread GitBox
hanahmily opened a new pull request #181: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/181 Fix #180 #179 #177 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng closed pull request #181: 5.0.0/beta2

2018-06-14 Thread GitBox
wu-sheng closed pull request #181: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/181 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] hanahmily commented on issue #151: Place conjecture nodes outside application topology

2018-06-14 Thread GitBox
hanahmily commented on issue #151: Place conjecture nodes outside application topology URL: https://github.com/apache/incubator-skywalking-ui/issues/151#issuecomment-397504026 With more variable filters are going to be added, this feature seems more and more unimportant. So I just close

[GitHub] hanahmily closed issue #179: Change chars to black from white in trace page

2018-06-14 Thread GitBox
hanahmily closed issue #179: Change chars to black from white in trace page URL: https://github.com/apache/incubator-skywalking-ui/issues/179 This is an automated message from the Apache Git Service. To respond to the

[GitHub] hanahmily closed issue #177: Consider to add access control for UI

2018-06-14 Thread GitBox
hanahmily closed issue #177: Consider to add access control for UI URL: https://github.com/apache/incubator-skywalking-ui/issues/177 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] wu-sheng closed issue #180: Improve user experience of span detail in trace page

2018-06-14 Thread GitBox
wu-sheng closed issue #180: Improve user experience of span detail in trace page URL: https://github.com/apache/incubator-skywalking-ui/issues/180 This is an automated message from the Apache Git Service. To respond to the

[GitHub] hanahmily closed issue #151: Place conjecture nodes outside application topology

2018-06-14 Thread GitBox
hanahmily closed issue #151: Place conjecture nodes outside application topology URL: https://github.com/apache/incubator-skywalking-ui/issues/151 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng closed pull request #1353: Add the Logger modifier "static" in pr #1347

2018-06-14 Thread GitBox
wu-sheng closed pull request #1353: Add the Logger modifier "static" in pr #1347 URL: https://github.com/apache/incubator-skywalking/pull/1353 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] wu-sheng commented on issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
wu-sheng commented on issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352#issuecomment-397509009 If so, I prefer to separate the two implementors, don't depend on that. If compatible is not so good, codes will make people think strange.

[GitHub] chidaodezhongsheng commented on issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
chidaodezhongsheng commented on issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352#issuecomment-397337241 Shardingjdbc support SQL grammar,not support mysql dialect,for example “case when”.I have checked the sqls In h2

[GitHub] chidaodezhongsheng commented on issue #1352: H2 storage implementation

2018-06-14 Thread GitBox
chidaodezhongsheng commented on issue #1352: H2 storage implementation URL: https://github.com/apache/incubator-skywalking/issues/1352#issuecomment-397499807 I checked the SQLs in H2 implementor, the keyword "or" that Shardingjdbc not support.Besides, it not support read meta data of DB.

[GitHub] wu-sheng commented on a change in pull request #181: 5.0.0/beta2

2018-06-14 Thread GitBox
wu-sheng commented on a change in pull request #181: 5.0.0/beta2 URL: https://github.com/apache/incubator-skywalking-ui/pull/181#discussion_r195625159 ## File path: src/components/Login/LoginItem.js ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] coder-yqj opened a new pull request #1354: fix spymemcached plugin cant't work

2018-06-14 Thread GitBox
coder-yqj opened a new pull request #1354: fix spymemcached plugin cant't work URL: https://github.com/apache/incubator-skywalking/pull/1354 Please answer these questions before submitting pull request - Why submit this pull request? - [-] Bug fix - [ ] New feature provided

[GitHub] coveralls commented on issue #1353: Add the Logger modifier "static" in pr #1347

2018-06-14 Thread GitBox
coveralls commented on issue #1353: Add the Logger modifier "static" in pr #1347 URL: https://github.com/apache/incubator-skywalking/pull/1353#issuecomment-397512056 [![Coverage Status](https://coveralls.io/builds/17505388/badge)](https://coveralls.io/builds/17505388) Coverage

[GitHub] doublebody opened a new issue #1350: spring mvc 拦截失败

2018-06-14 Thread GitBox
doublebody opened a new issue #1350: spring mvc 拦截失败 URL: https://github.com/apache/incubator-skywalking/issues/1350 Please answer these questions before submitting your issue. - Why do you submit this issue? - [√ ] Bug ___ ### Question - What do you want to know?

[GitHub] ascrutae commented on issue #1350: spring mvc plugin fails

2018-06-14 Thread GitBox
ascrutae commented on issue #1350: spring mvc plugin fails URL: https://github.com/apache/incubator-skywalking/issues/1350#issuecomment-397201861 Could you give me an demo to reproduce this issue? This is an automated

[GitHub] wu-sheng commented on issue #1350: spring mvc plugin fails

2018-06-14 Thread GitBox
wu-sheng commented on issue #1350: spring mvc plugin fails URL: https://github.com/apache/incubator-skywalking/issues/1350#issuecomment-397202250 @ascrutae Maybe this is an issue we already fixed? Can you tell that from the stack only? @doublebody I am not sure that you provided

[GitHub] coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-14 Thread GitBox
coveralls commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-392457692 [![Coverage Status](https://coveralls.io/builds/17486026/badge)](https://coveralls.io/builds/17486026) Coverage

[GitHub] coder-yqj opened a new pull request #1351: 修改更新

2018-06-14 Thread GitBox
coder-yqj opened a new pull request #1351: 修改更新 URL: https://github.com/apache/incubator-skywalking/pull/1351 update Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] coder-yqj closed pull request #1351: 修改更新

2018-06-14 Thread GitBox
coder-yqj closed pull request #1351: 修改更新 URL: https://github.com/apache/incubator-skywalking/pull/1351 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] jameskypee commented on issue #443: Which companies are using SkyWalking

2018-06-15 Thread GitBox
jameskypee commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-397552916 @wu-sheng 中企动力科技股份有限公司 http://www.300.cn/ 线上3.6.0,即将切换5.0

[GitHub] sky-syk opened a new issue #1349: collector always print errro logs

2018-06-13 Thread GitBox
sky-syk opened a new issue #1349: collector always print errro logs URL: https://github.com/apache/incubator-skywalking/issues/1349 Please answer these questions before submitting your issue. - Why do you submit this issue? - [√] Question or discussion - [ ] Bug - [ ]

[GitHub] sky-syk commented on issue #1349: collector always print errro logs

2018-06-14 Thread GitBox
sky-syk commented on issue #1349: collector always print errro logs URL: https://github.com/apache/incubator-skywalking/issues/1349#issuecomment-397183262 ![image](https://user-images.githubusercontent.com/18712087/41394613-30115ca8-6fdd-11e8-8836-0d2fdd0fce46.png) Does the cause of

[GitHub] wu-sheng closed issue #1349: collector always print errro logs

2018-06-13 Thread GitBox
wu-sheng closed issue #1349: collector always print errro logs URL: https://github.com/apache/incubator-skywalking/issues/1349 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wu-sheng commented on issue #1349: collector always print errro logs

2018-06-13 Thread GitBox
wu-sheng commented on issue #1349: collector always print errro logs URL: https://github.com/apache/incubator-skywalking/issues/1349#issuecomment-397175262 Check your ElasticSearch version, status, and connection. This means data can't be written into.

[GitHub] sky-syk commented on issue #1349: collector always print errro logs

2018-06-14 Thread GitBox
sky-syk commented on issue #1349: collector always print errro logs URL: https://github.com/apache/incubator-skywalking/issues/1349#issuecomment-397181751 my ElasticSearch version is 5.2.2 ,but there are some data has already be written in ,Why would this be a problem

[GitHub] haotian2015 commented on issue #1339: the latest code ui bugs

2018-06-13 Thread GitBox
haotian2015 commented on issue #1339: the latest code ui bugs URL: https://github.com/apache/incubator-skywalking/issues/1339#issuecomment-397141702 @wu-sheng Thank you. I will try 5.0.0.beta. This is an automated message

[GitHub] wu-sheng closed issue #1339: the latest code ui bugs

2018-06-13 Thread GitBox
wu-sheng closed issue #1339: the latest code ui bugs URL: https://github.com/apache/incubator-skywalking/issues/1339 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] coveralls commented on issue #1354: fix spymemcached plugin cant't work

2018-06-15 Thread GitBox
coveralls commented on issue #1354: fix spymemcached plugin cant't work URL: https://github.com/apache/incubator-skywalking/pull/1354#issuecomment-397519543 [![Coverage Status](https://coveralls.io/builds/17506030/badge)](https://coveralls.io/builds/17506030) Coverage

[GitHub] coveralls commented on issue #1354: fix spymemcached plugin cant't work

2018-06-14 Thread GitBox
coveralls commented on issue #1354: fix spymemcached plugin cant't work URL: https://github.com/apache/incubator-skywalking/pull/1354#issuecomment-397519543 [![Coverage Status](https://coveralls.io/builds/17505885/badge)](https://coveralls.io/builds/17505885) Coverage

[GitHub] coveralls commented on issue #1354: fix spymemcached plugin cant't work

2018-06-14 Thread GitBox
coveralls commented on issue #1354: fix spymemcached plugin cant't work URL: https://github.com/apache/incubator-skywalking/pull/1354#issuecomment-397519543 [![Coverage Status](https://coveralls.io/builds/17505902/badge)](https://coveralls.io/builds/17505902) Coverage

[GitHub] ascrutae commented on issue #1354: fix spymemcached plugin cant't work

2018-06-14 Thread GitBox
ascrutae commented on issue #1354: fix spymemcached plugin cant't work URL: https://github.com/apache/incubator-skywalking/pull/1354#issuecomment-397520013 I will add test case for this plugin This is an automated message

[GitHub] liangxp opened a new issue #1355: httpclient version error

2018-06-15 Thread GitBox
liangxp opened a new issue #1355: httpclient version error URL: https://github.com/apache/incubator-skywalking/issues/1355 when "mvn compile -Dmaven.test.skip=true" have some error. `[INFO] apm-webapp . FAILURE [03:30 min] [INFO]

[GitHub] wu-sheng closed issue #1355: httpclient version error

2018-06-15 Thread GitBox
wu-sheng closed issue #1355: httpclient version error URL: https://github.com/apache/incubator-skywalking/issues/1355 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng commented on issue #1355: httpclient version error

2018-06-15 Thread GitBox
wu-sheng commented on issue #1355: httpclient version error URL: https://github.com/apache/incubator-skywalking/issues/1355#issuecomment-397525676 Please check your local maven repository. According to Apache HTTPComponent official documents, this package existed from 4.0, see here:

[GitHub] jameskypee commented on issue #443: Which companies are using SkyWalking

2018-06-15 Thread GitBox
jameskypee commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-397552916 @wu-sheng 中企动力科技股份有限公司 http://www.300.cn/ 线上3.2.6,即将切换5.0

[GitHub] wu-sheng commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-15 Thread GitBox
wu-sheng commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-397561313 I finish the prototype of this feature. Here is how people to test this: 1. Download and build the project. 1.

[GitHub] jfclere opened a new issue #1356: the dubbo-plugin use an unsupported version of RestEasyx

2018-06-15 Thread GitBox
jfclere opened a new issue #1356: the dubbo-plugin use an unsupported version of RestEasyx URL: https://github.com/apache/incubator-skywalking/issues/1356 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion -

[GitHub] jfclere commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy

2018-06-15 Thread GitBox
jfclere commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy URL: https://github.com/apache/incubator-skywalking/issues/1356#issuecomment-397565020 See apm-sniffer/apm-sdk-plugin/dubbo-plugin/pom.xml The dependencies bring com.fasterxml.jackson version

[GitHub] wu-sheng commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy

2018-06-15 Thread GitBox
wu-sheng commented on issue #1356: the dubbo-plugin uses an unsupported version of RestEasy URL: https://github.com/apache/incubator-skywalking/issues/1356#issuecomment-397565579 @jfclere This version should have the bad influence in running status, right? The Dubbo lib for this

[GitHub] wu-sheng commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

2018-06-15 Thread GitBox
wu-sheng commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-397566362 I tested and only tested by basic sleuth example: https://github.com/openzipkin/sleuth-webmvc-example So, I intend to

[GitHub] youtsea closed issue #1309: org.apache.skywalking.apm.collector.agent.grpc.provider.handler.TraceSegmentServiceHandler

2018-06-07 Thread GitBox
youtsea closed issue #1309: org.apache.skywalking.apm.collector.agent.grpc.provider.handler.TraceSegmentServiceHandler URL: https://github.com/apache/incubator-skywalking/issues/1309 This is an automated message from the

<    5   6   7   8   9   10   11   12   13   14   >