[GitHub] wu-sheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-17 Thread GitBox
wu-sheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-390079342 @chidaodezhongsheng You are still missing @peng-yongsheng 's review. -

[GitHub] wu-sheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-16 Thread GitBox
wu-sheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-389755119 @chidaodezhongsheng @oracle219 Could you finish this pr soon?

[GitHub] wu-sheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-16 Thread GitBox
wu-sheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-389537307 version updated. please resolve conflicts. and follow peng's guide. Thanks ---

[GitHub] wu-sheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-389055453 @chidaodezhongsheng Your CI fails This is an automate

[GitHub] wu-sheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-13 Thread GitBox
wu-sheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388715549 @chidaodezhongsheng Conflicts must be resolved. This is a