[GitHub] wu-sheng commented on issue #1302: There's a bit of doubt about the way springMVC gets the operationName

2018-06-03 Thread GitBox
wu-sheng commented on issue #1302: There's a bit of doubt about the way 
springMVC gets the operationName
URL: 
https://github.com/apache/incubator-skywalking/issues/1302#issuecomment-394226236
 
 
   I guess `parsed path pattern`, you mean the real URL? 
   
   - Pattern: ${spring.application.name}/access/page
   - URI: application-xxx/access/page
   
   Right? If yes, try to thing some one will put userid, accountid in the url, 
the patter looks like `/prod/order/${orderid}`. Then you can image what 
happens... Metrics will be useless..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1302: There's a bit of doubt about the way springMVC gets the operationName

2018-06-03 Thread GitBox
wu-sheng commented on issue #1302: There's a bit of doubt about the way 
springMVC gets the operationName
URL: 
https://github.com/apache/incubator-skywalking/issues/1302#issuecomment-394222863
 
 
   Yes. only use path pattern as the operation name, the backend will aggregate 
and analysis the metrics for the service(based on operation name).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services