[GitHub] [skywalking] EvanLjp commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651611657 I know your feeling,thanks for your helping This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] EvanLjp commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651595221 I thought about it again, this thing is not suitable for appearing in the official version,If the set method is added, basically no one else will use it in official plugin

[GitHub] [skywalking] EvanLjp commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651592080 in our company , all pv coross bfe (cncf) ,and all the pv will be add a unique bfeid as a http header. we want to use bfeid as a part of traceid. I know this is a abnormal

[GitHub] [skywalking] EvanLjp commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
EvanLjp commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651567868 I also thought about making it plug-in for example: 1. the GlobalIdGenerator add a function Supplier method to To expose the algorithm implementation 2. a plugin service