[GitHub] [skywalking] lujiajing1126 edited a comment on issue #5494: Support metrics APIs for agent plugin
lujiajing1126 edited a comment on issue #5494: URL: https://github.com/apache/skywalking/issues/5494#issuecomment-696500172 > As I mentioned, shade is not the problem, the problem is why you need this. API-based instrumentation(Prometheus SDK or MicroMeter) solution should not be mixed with the agent. That breaks the design at the both side. > If you have some private agenda on this, it is fine. But base on your given information, it doesn't make sense to me. I see what you meant. So I guess the so-called native implementation (metrics of the instrumented library) without third-party dependency is still acceptable in the community, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] lujiajing1126 edited a comment on issue #5494: Support metrics APIs for agent plugin
lujiajing1126 edited a comment on issue #5494: URL: https://github.com/apache/skywalking/issues/5494#issuecomment-696500172 > As I mentioned, shade is not the problem, the problem is why you need this. API-based instrumentation(Prometheus SDK or MicroMeter) solution should not be mixed with the agent. That breaks the design at the both side. > If you have some private agenda on this, it is fine. But base on your given information, it doesn't make sense to me. I see what you meant. So I guess the so-called native implementation (metrics of the instrumented library) without third-party dependency is still acceptable in the community, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
