novayoung commented on a change in pull request #5396:
URL: https://github.com/apache/skywalking/pull/5396#discussion_r478128141
##########
File path:
apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/PreparedStatementParameterBuilder.java
##########
@@ -58,6 +57,11 @@ private String getParameterString() {
}
stringBuilder.append(parameter);
first = false;
+
+ // cut the string as soon as it reached the length limitation
+ if (maxLength > 0 && stringBuilder.length() > maxLength){
+ return String.format("[%s]",
stringBuilder.toString().substring(0, maxLength) + "...");
Review comment:
> Why don't you place `...` in `[%s]` like `[%s....]`. :-)
nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
