[GitHub] [skywalking] qxo commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log

2020-08-08 Thread GitBox
qxo commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670990184 > That is unexpected, why we need to ignore those? We don't have tests for JVM crashing. The ignore file is not for all caees, it just ignore for tool config or test generated

[GitHub] [skywalking] qxo commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log

2020-08-08 Thread GitBox
qxo commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670989292 > This pr conflicts with master. And where are these logs from? hs_err_pid*.log/replay_pid*.log generated when jvm crash on maven build.