[GitHub] [skywalking] wu-sheng commented on a change in pull request #5038: Fix no telemetry metrics when the oap role is receiver.

[GitBox]

wu-sheng commented on a change in pull request #5038:
URL: https://github.com/apache/skywalking/pull/5038#discussion_r450052172



##########
File path: 
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java
##########
@@ -282,14 +282,15 @@ public void start() throws ModuleStartException {
             throw new ModuleStartException(e.getMessage(), e);
         }
 
+        Address gRPCServerInstanceAddress = new 
Address(moduleConfig.getGRPCHost(), moduleConfig.getGRPCPort(), true);
+        
TelemetryRelatedContext.INSTANCE.setId(gRPCServerInstanceAddress.toString());

Review comment:
       As you have moved `#setId` here, please remove all old ones in the 
coordinator implementations.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org