[GitHub] [skywalking] wu-sheng commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
wu-sheng commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651622887 Look forward you could make BFE supported SkyWalking. This is an automated message from the Apache Git Service.

[GitHub] [skywalking] wu-sheng commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
wu-sheng commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651606975 I have a feeling, you treat trace context in an easier way, which is not correct. No matter what in the header(in HTTP only), we should not use it as a trace, because

[GitHub] [skywalking] wu-sheng commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
wu-sheng commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651581468 `GlobalIdGenerator` should be refactored as a service, which could provide the override mechanism in the plugin system. But if this is an internal service, which generation

[GitHub] [skywalking] wu-sheng commented on issue #4991: Open global traceId set

2020-06-30 Thread GitBox
wu-sheng commented on issue #4991: URL: https://github.com/apache/skywalking/issues/4991#issuecomment-651580558 I don't think setting the global trace id is a good idea. Basically, and mostly in SkyWalking, we do auto-instrumentation, right? The app developer is mostly impossible to set