wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-822877562
With namespace, cpp SDK and Envoy integration are working now, we are
closing this.
--
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-747410755
@ZackButcher We add `package` for cpp,
https://github.com/apache/skywalking-data-collect-protocol/pull/37.
This
wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-672762426
> The project already uses GitHub actions for its normal CI, right?
Yes.
This is an automated message
wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-671919582
@kezhenxu94 The reason I pinged you all is, I want if only OAP upgrade this,
but the agent doesn't, the things still work. Vice versa, such as the existing
8.x agent still works
wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-67160
> I was going to test myself - I was hoping this would work but wasn't 100%
sure. So, the name changes should not be breaking (ideally we should verify
across all agent
wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-671032254
Hi, @dio @ZackButcher I did a small experience.
I changed SegmentObject to `segment_object`, the compiling in Java still
passed. But I haven't verified the e2e. Is that
wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-671006364
I will do a test whether there is a chance to change the naming style.
Also, a package declerance should not affact java. Could you give me an
example of the trace proto?
wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-670989879
What new API? Envoy existing proto is in sake case, but generated java codes
are camel case.
Anyway. Breaking generated codes a would affect the existing agent codes a
wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-670810670
Zack, one more thing, there is naming style in your linter logs, please make
sure the refactor would break the generated fields and methods.
wu-sheng commented on issue #5266:
URL: https://github.com/apache/skywalking/issues/5266#issuecomment-670782679
Hi, Zack. It is good for me to enhance the document for those protos. And I
think you will need CI, such as GitHub action, to check those protobuf, right?
I could open it
10 matches
Mail list logo
