[GitHub] [skywalking] wu-sheng commented on pull request #5002: fix shardingsphere plugin span to DB type

2020-07-01 Thread GitBox
wu-sheng commented on pull request #5002: URL: https://github.com/apache/skywalking/pull/5002#issuecomment-652768188 > Do you think we should add a span type for local span because there are many local span To say what? Local? ---

[GitHub] [skywalking] wu-sheng commented on pull request #5002: fix shardingsphere plugin span to DB type

2020-07-01 Thread GitBox
wu-sheng commented on pull request #5002: URL: https://github.com/apache/skywalking/pull/5002#issuecomment-652451803 This thing is called `span layer`. There is no value for the local span. ```Java public enum SpanLayer { DB(1), RPC_FRAMEWORK(2), HTTP(3), MQ(4), CACHE(5);