[GitHub] [skywalking] wu-sheng commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log

2020-08-08 Thread GitBox
wu-sheng commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670990993 You could have many files, such as dump file. It is not reasonable to add ignore for all. This is an

[GitHub] [skywalking] wu-sheng commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log

2020-08-08 Thread GitBox
wu-sheng commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670989431 That is unexpected, why we need to ignore those? We don't have tests for JVM crashing. The ignore file is not for all caees, it just ignore for tool config or test

[GitHub] [skywalking] wu-sheng commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log

2020-08-08 Thread GitBox
wu-sheng commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670988037 This pr conflicts with master. And where are these logs from? This is an automated message from the Apache