wu-sheng commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723463453
One last thing, `CHANGES.md` is not updated. You are adding a new plugin.
This is an automated message from
wu-sheng commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723451353
> Dear sir, Is cache classification appropriate？or create a new
classification named DBCP?
Add `Pool` catalog.
wu-sheng commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723441026
@Jargon96 The ShardingSphere plugin has fixed their plugin test w/o the DBCP
dependency. Please resolve the conflicts and make your test passed. Other cases
should be not
wu-sheng commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-721489338
@Jargon96 I think you have to modify the shardingsphere's expected data
file. Because you added the DBCP plugin, and they use it in their plugin too.
As this is a new
