[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-870279331 @a1vin-tian Thank you so much for your good polish, patient, and keeping testing in real env. I am going to merge this. -- This is an automated message from the Apache

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-870279331 @a1vin-tian Thank you so much for your good polish, patient, and keeping testing in real env. I am going to merge this. -- This is an automated message from the Apache

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-869087112 @a1vin-tian Before merge, could you run this latest codes on prod or test env, let's see how self observability looks like. -- This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866899323 @EvanLjp @dmsolr Could you check the latest codes, it should be easier to read. I have commented about what should be polished. -- This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866873762 You update `skywalking-ui` submodule incorrectly. Please make sure it is unchanged. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866678666 @a1vin-tian I am thinking about how to polish the codes in an easier way. 2 key points we need to think about. 1. Could you add an internal queue concept to avoid using

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866066707 Hi @a1vin-tian, generally the codes are good. Could you add some comments in the codes for helping readers in the future? It is easier to read currently, but more

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865774882 And CIs fail, please recheck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865506285 You should update the changelog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865506285 You should update the changelog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to