[GitHub] [skywalking] wu-sheng edited a comment on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol

wu-sheng edited a comment on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-671032254 Hi, @dio @ZackButcher I did a small experience. I changed SegmentObject to , ```proto message SegmentObject { // A string id represents the whole

[GitHub] [skywalking] wu-sheng edited a comment on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol

wu-sheng edited a comment on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-671006364 Adding a package declerance should not affact java. Could you give me an example of the trace proto? I could change and do a test locally, to see whethet there is a

[GitHub] [skywalking] wu-sheng edited a comment on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol

wu-sheng edited a comment on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-670989879 What new API? Envoy existing proto is in sake case, but generated java codes are camel case. But still, it is high risk. Anyway. Breaking generated codes a would

[GitHub] [skywalking] wu-sheng edited a comment on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol

wu-sheng edited a comment on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-670810670 Zack, one more thing, there is naming style in your linter logs, please make sure the refactor would NOT break the generated fields and methods.