zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-493687219
case1:common route
```yml
server:
port: 8080
spring:
cloud:
gateway:
routes:
- id: provider_route
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-493681391
> As the test tool can't support your PR. Could you provide a screenshot to
show the result?
OK
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-491586725
Some difficulties encountered:
1 testcase gateway 2.1.0 version, the result of trace data collection is not
very stable, sometimes it will
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-491236066
I didn't find out why `actual data` has no trace data, it looks like it
didn't make a http request, but it can't be reproduced in my local
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-490741815
> OK. I has ping @ascrutae to deal with your other PRs.
OK
This is an
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-490741126
> We need to add witness class for this plugin, right?
Yes, I am still trying to be compatible with the low version
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489672272
> > I think it's best to separate reactor-netty, webflux, and gateway.
>
> If you can do this, I think it is a good idea. If you could
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489670411
> > I think it's best to separate reactor-netty, webflux, and gateway.
>
> If you can do this, I think it is a good idea. If you could
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489664577
> @zhaoyuguang Is this plugin too complex and conflict with other plugins?
If so, let's discuss how to do it first. I noticed this PR is still
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin
URL: https://github.com/apache/skywalking/pull/2517#issuecomment-489661461
> In my opinion, this plugin could be split into two plugins: reactor netty
http plugin + spring cloud gateway plugin?
This also relate
10 matches
Mail list logo
