mrproliu commented on code in PR #33: URL: https://github.com/apache/skywalking-go/pull/33#discussion_r1193305805
########## plugins/dubbo/filter/graceful_shutdown/server_intercepter.go: ########## @@ -0,0 +1,58 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// nolint +package graceful_shutdown + +import ( + "dubbo.apache.org/dubbo-go/v3/protocol" + + "github.com/apache/skywalking-go/plugins/core/operator" + "github.com/apache/skywalking-go/plugins/core/tracing" +) + +type ServerInterceptor struct { +} + +func (c *ServerInterceptor) BeforeInvoke(invocation operator.Invocation) error { + filterInvoker := invocation.Args()[1].(protocol.Invoker) + dubboInv := invocation.Args()[2].(protocol.Invocation) + url := filterInvoker.GetURL() + if url == nil { + return nil + } + s, err := tracing.CreateEntrySpan(generateOperationName(filterInvoker, dubboInv), func(k string) (string, error) { + attachment, _ := dubboInv.GetAttachment(k) + return attachment, nil + }, tracing.WithLayer(tracing.SpanLayerRPCFramework), + tracing.WithTag(tracing.TagURL, url.String()), + tracing.WithComponent(3)) Review Comment: I could add a section to help developers find the component ID. I think we don't need the management of the component ID registration in the go agent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
