[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-06-03 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394156287 @wu-sheng ok, I will submit a new pr . This is an automated message

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-06-03 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394156287 @wu-sheng ok, I wil submit a new pr . This is an automated message

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-06-03 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394153312 @wu-sheng let me fix it..I did not organize them before.just copy from another module.

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-06-02 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394136948 @wu-sheng ok..Thanks for your help. This is an automated message from

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-06-02 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394086809 https://github.com/SkywalkingTest/skywalking-agent-testcases/pull/17#issuecomment-394086718 @wu-sheng I have tested again based

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-06-02 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394083166 @wu-sheng I will use 43 as sofarpc id, ok? This is an automated

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-30 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393365944 @wu-sheng ok, after released, I will fix and test asap This is an

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-30 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393355460 @wu-sheng we are preparing to release, maybe today or tomorrow, after released, I will resolve the conflict and test again.

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388835222 @ascrutae I have changed sofarpc componentId to be 32 This is an

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388747564 When we release sofarpc 5.4.0 I will provide a new test report This is

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388742185 @wu-sheng I have tested it, It seems everything is ok,

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388693585 ignore me This is an automated message from the Apache Git Service. To

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388693585 -javaagent:~/skywalking-agent/skywalking-agent.jar ``` private static AbstractTracerContext getOrCreate(String operationName,

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798 ![image](https://user-images.githubusercontent.com/2684384/39975112-40e321f6-575f-11e8-8bfc-4e895f779cb3.png) I debuged locally,

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798 ![image](https://user-images.githubusercontent.com/2684384/39975112-40e321f6-575f-11e8-8bfc-4e895f779cb3.png) I debuged locally,

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798 ![image](https://user-images.githubusercontent.com/2684384/39975112-40e321f6-575f-11e8-8bfc-4e895f779cb3.png) I debuged

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388529703 I will test it and provide report in https://github.com/SkywalkingTest/skywalking-agent-testcases .

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388524439 @wu-sheng ContextManagerExtendOverrideService I saw dubbo does this. I thought It was a rule. I will remove it.

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388076819 @wu-sheng ok, I will add some changes. I debuged my demo application and skywalking-agent ,I can make sure there has an