[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394156287 @wu-sheng ok, I will submit a new pr . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394136948 @wu-sheng ok..Thanks for your help. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394086809 https://github.com/SkywalkingTest/skywalking-agent-testcases/pull/17#issuecomment-394086718 @wu-sheng I have tested again based on the commit just now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394083166 @wu-sheng I will use 43 as sofarpc id, ok? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393365944 @wu-sheng ok, after released, I will fix and test asap This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393355460 @wu-sheng we are preparing to release, maybe today or tomorrow, after released, I will resolve the conflict and test again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388835222 @ascrutae I have changed sofarpc componentId to be 32 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388747564 When we release sofarpc 5.4.0 I will provide a new test report This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL:
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169
@wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local
m2 repo
I tested it like this.
env settings
```
export project_name=sofarpc-scenario
export agent_repository_branch=sofarpc-integration
export
agent_repository_url=https://github.com/leizhiyuan/incubator-skywalking.git
export testcase_branch=sofarpc-testcase-scenario
```
test command
```
sh deploy-test.sh \
-p ${project_name} \
-b ${agent_repository_branch} \
-r ${agent_repository_url} \
-tcb ${testcase_branch}
```
after run this ,It asks me private password of github to publish reports . I
can not access master branch
('https://github.com/SkywalkingTest/agent-integration-test-report.git/'),so I
copied it there to inform you
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL:
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169
@wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local
m2 repo
I tested it like this.
env settings
```
export project_name=sofarpc-scenario
export agent_repository_branch=sofarpc-integration
export
agent_repository_url=https://github.com/leizhiyuan/incubator-skywalking.git
export testcase_branch=sofarpc-testcase-scenario
```
test command
```
sh deploy-test.sh \
-p ${project_name} \
-b ${agent_repository_branch} \
-r ${agent_repository_url} \
-tcb ${testcase_branch}
```
after run this ,It asks me private password of github to publish reports . I
can not access master branch ,so I copied it there
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL:
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169
@wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local
m2 repo
I tested it like this.
env settings
```
export project_name=sofarpc-scenario
export agent_repository_branch=sofarpc-integration
export
agent_repository_url=https://github.com/leizhiyuan/incubator-skywalking.git
export testcase_branch=sofarpc-testcase-scenario
```
test command
```
sh deploy-test.sh \
-p ${project_name} \
-b ${agent_repository_branch} \
-r ${agent_repository_url} \
-tcb ${testcase_branch}
```
after run this ,It asks me private password of github to publish reports . I
can not access master branch
('https://github.com/SkywalkingTest/agent-integration-test-report.git/'),so I
copied it there
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388742185 @wu-sheng I have tested it, It seems everything is ok, https://github.com/SkywalkingTest/skywalking-agent-testcases/pull/17#issuecomment-388741798 we will publish sofarpc 5.4.0 soon ,then I will update this issue, and this pr can be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388693585 ignore me This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL:
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388693585
-javaagent:~/skywalking-agent/skywalking-agent.jar
```
private static AbstractTracerContext getOrCreate(String operationName,
boolean forceSampling) {
AbstractTracerContext context = CONTEXT.get();
if (EXTEND_SERVICE == null) {
EXTEND_SERVICE =
ServiceManager.INSTANCE.findService(ContextManagerExtendService.class);
}
if (context == null) {
if (StringUtil.isEmpty(operationName)) {
if (logger.isDebugEnable()) {
logger.debug("No operation name, ignore this trace.");
}
context = new IgnoredTracerContext();
} else {
if (RemoteDownstreamConfig.Agent.APPLICATION_ID !=
DictionaryUtil.nullValue()
&& RemoteDownstreamConfig.Agent.APPLICATION_INSTANCE_ID
!= DictionaryUtil.nullValue()
) {
context =
EXTEND_SERVICE.createTraceContext(operationName, forceSampling);
} else {
/**
* Can't register to collector, no need to trace
anything.
*/
context = new IgnoredTracerContext();
}
}
CONTEXT.set(context);
}
return context;
}
```
RemoteDownstreamConfig.Agent.APPLICATION_ID is 0
so context is IgnoredTracerContext,will not step into TracingContext
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798  I debuged locally, you can see the stack elements(the pic may load slowly,wait a minute),interfaceName is absolutely not null, is it possible because of transient keyword? ``` /** * 接口名 */ private transient String interfaceName; ``` any ideas about classes or methods should I debug during sending to skywalking-ui ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798  I debuged locally, you can see the stack elements,interfaceName is absolutely not null, is it possible because of transient keyword? ``` /** * 接口名 */ private transient String interfaceName; ``` any ideas about classes or methods should I debug during sending to skywalking-ui ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388677798  I debuged locally, you can see the stack elements,interfaceName is absolutely not null, is it possible because of transient keyword? ``` /** * 接口名 */ private transient String interfaceName; ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388529703 I will test it and provide report in https://github.com/SkywalkingTest/skywalking-agent-testcases . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388524439 @wu-sheng ContextManagerExtendOverrideService I saw dubbo does this. I thought It was a rule. I will remove it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388076819 @wu-sheng ok, I will add some changes. I debuged my demo application and skywalking-agent ,I can make sure there has an value.. I will check later. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
