[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-06-03 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394156229 @leizhiyuan merged. Thanks. And I think you should submit another Pr to add Sofa into supported list doc.

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-06-02 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394136610 If you are sure, could you open a new one? I am trying to update, to see whether could I restore the right status.

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-06-02 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394136864 Look like it works.. This is an automated message from the Apache Git

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-06-02 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-394136562 @leizhiyuan I am not sure what is happening, look like somehow, you merge all commits and file changes, even they have merged before.

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-30 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-393365696 @leizhiyuan Ping me after you have done. I definitely hope this could be provided in beta2 release.

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-28 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-392639522 @leizhiyuan You have conflicts to resolve. And when do you release? This

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388745138 @leizhiyuan Ping us when you are ready (after release). And I have to ask, where does

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388687519 @leizhiyuan You could debug the `TracingContext#finish`. The `TraceSegment` in the method should contain all the data you need.

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-11 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388524628 Dubbo has it because dubbo is our first plugin, some no-dubbo test codes are in it, because it need test in plugin modules.

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388089270 @leizhiyuan My suggestion is based on operation name is treated as a string only, and I saw dot and method name in it. So the agent,

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388079962 For validate your plugin, there are several steps you should follow: 1. Provide Topology, trace and service map to prove your data.

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-10 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388057995 FYI @candyleer welcome to join the reviewer team. This is an automated