[GitHub] wu-sheng commented on issue #1262: Filter non-active service name when UI query.

2018-06-08 Thread GitBox
wu-sheng commented on issue #1262: Filter non-active service name when UI query.
URL: 
https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-395940726
 
 
   @peng-yongsheng  ci fails.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1262: Filter non-active service name when UI query.

2018-05-28 Thread GitBox
wu-sheng commented on issue #1262: Filter non-active service name when UI query.
URL: 
https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-392468657
 
 
   I think we can move on this. Based on #1268 TTL settings.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1262: Filter non-active service name when UI query.

2018-05-24 Thread GitBox
wu-sheng commented on issue #1262: Filter non-active service name when UI query.
URL: 
https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-391730284
 
 
   And 24 hours look like too unpredict to end user. I suggest we support 
ttl-day, ttl-year to remove data. And the service status of valid could be 
considered by the ttl-*.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services