[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-12-13 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-447109667 Move to #2044 . A more reliable and high-performance way to do this, and make them production ready.

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-06-15 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-397578969 See SkyWalking supports Zipkin formats in https://github.com/apache/incubator-skywalking/pull/1273 . Only tested in a

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-25 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-392228770 `origin/zipkin/receiver-v1` branch has been created. I am going to build the skeleton for Zipkin data, started with

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-21 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-390805885 @candyleer Can you provide me your zipkin demo? I will do this in these days.

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517882 > apm-collector-thirdparty-agent I didn't like the `agent` part, even we are using this in existed collector

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517882 > apm-collector-thirdparty-agent I didn't like the `agent` part, even we are using this in existed collector

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386514348 @candyleer Thanks for providing this sample data. I suggest we could work on this first with a prototype. 1. Add a

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-02 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386181340 Great to know, I suggest two types of sample data. - **A -(http)->B-(http)->C** - **A -(http)->B-(mq)->C**

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-02 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386180512 @candyleer Are you working on this? If so, could you provide some sample data from Zipkin(or Jaeger if you want to do

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-29 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385262431 @yurishkuro This proposal is about provding a transform server, which transfers data from jaeger SDKs, to SkyWalking

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-29 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385255598 @adriancole goes to Euro for the next tracing work shop. I assume he is busy, maybe we need to find these data.

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-29 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385246946 For Jaeger, @yurishkuro @pavolloffay @jpkrohling . Do any of you, or Jaeger team member/contributor have time to help

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-29 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385229543 Who would like to start the basic codes framework? @peng-yongsheng or @candyleer ? It is your decision. I am OK with

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-29 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385228761 @candyleer @peng-yongsheng Also I am considering whether we should use collector core for implementing modulization,

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385226415 @candyleer cross-thread scenario is not so important, as a manual instrument, it could deal with it bettet than

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385222669 @candyleer Yes, that is the complex part. @peng-yongsheng Agree, but as a new part of our ecosystem, if cache

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385218354 @adriancole I think we need some sample data about zipkin, which represents a RPC call like grpc or dubbo, and a MQ

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385218259 >Perhaps Mongo DB or ElasticSearch is suitable I have a proposal that, use redis with traceid as key, and an

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385216195 One thing need to correct, library is not enough. We will need a cluster to support that, if ypu compare SkyWalking and

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385216039 And for zipkin and jaeger, I prefer zipkin first. They have more end users and better community support.

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385214512 We should start our discussions about the process flow and architecture. Could provide a draft? Then I and

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385214192 I am glad to work with you about both of these two.

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-04-28 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-385214104 yes, for zipkin, I and @adriancole finished the document, https://github.com/OpenSkywalking/zipkin-skywalking