[GitHub] codecov-io commented on issue #5155: [migrations] Cleanup recent migrations

codecov-io commented on issue #5155: [migrations] Cleanup recent migrations URL: https://github.com/apache/incubator-superset/pull/5155#issuecomment-395300026 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5155?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4822: Superset v0.24.0 translation for Chinese language is broken for Chart menu part

mistercrunch commented on issue #4822: Superset v0.24.0 translation for Chinese language is broken for Chart menu part URL: https://github.com/apache/incubator-superset/issues/4822#issuecomment-395292570 I think https://github.com/apache/incubator-superset/pull/5008 broke translations

[GitHub] mistercrunch commented on issue #4822: Superset v0.24.0 translation for Chinese language is broken for Chart menu part

mistercrunch commented on issue #4822: Superset v0.24.0 translation for Chinese language is broken for Chart menu part URL: https://github.com/apache/incubator-superset/issues/4822#issuecomment-395292104 Looks like translations stopped working somewhere between `0.25.6` and `0.26.0rc1`

[GitHub] codecov-io commented on issue #5122: Bump FAB and a bunch of JS libs

codecov-io commented on issue #5122: Bump FAB and a bunch of JS libs URL: https://github.com/apache/incubator-superset/pull/5122#issuecomment-395291087 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5122?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #5028: [druid] Fixing Druid version check

mistercrunch commented on issue #5028: [druid] Fixing Druid version check URL: https://github.com/apache/incubator-superset/pull/5028#issuecomment-395290752 LGTM This is an automated message from the Apache Git Service. To

[GitHub] mistercrunch commented on issue #5142: when try the Sankey visualization --An error occurred while rendering the visualization: TypeError: n.replace is not a function

mistercrunch commented on issue #5142: when try the Sankey visualization --An error occurred while rendering the visualization: TypeError: n.replace is not a function URL: https://github.com/apache/incubator-superset/issues/5142#issuecomment-395290449 Pushed a fix here:

[GitHub] mistercrunch opened a new pull request #5154: [bugfix] add support for numeric nodes in Sankey

mistercrunch opened a new pull request #5154: [bugfix] add support for numeric nodes in Sankey URL: https://github.com/apache/incubator-superset/pull/5154 closes https://github.com/apache/incubator-superset/issues/5142 This

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395289500 Did you have to modify anything from python-rison? We could ask the maintainer for write-rights and pypi access on rison too.

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395288787 READABLE URLS! This is an automated message from the Apache Git Service.

[GitHub] mistercrunch closed pull request #5140: Improve time shift

mistercrunch closed pull request #5140: Improve time shift URL: https://github.com/apache/incubator-superset/pull/5140 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] xzGithu commented on issue #5142: when try the Sankey visualization --An error occurred while rendering the visualization: TypeError: n.replace is not a function

xzGithu commented on issue #5142: when try the Sankey visualization --An error occurred while rendering the visualization: TypeError: n.replace is not a function URL: https://github.com/apache/incubator-superset/issues/5142#issuecomment-395272085 @mistercrunch yeah thanks, In the

[GitHub] argman opened a new issue #5153: Superset does not stop hive sessions

argman opened a new issue #5153: Superset does not stop hive sessions URL: https://github.com/apache/incubator-superset/issues/5153 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included

[GitHub] codecov-io commented on issue #5152: Use Rison for the explore URL

codecov-io commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395258925 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5152?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5152: Use Rison for the explore URL

codecov-io commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395258925 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5152?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5152: Use Rison for the explore URL

codecov-io commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395258925 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5152?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #5150: pin kombu dependency

john-bodley commented on issue #5150: pin kombu dependency URL: https://github.com/apache/incubator-superset/pull/5150#issuecomment-395257389 @timifasubaa could you please also add this dependency to `setup.py`. Also we should track when the Celery/Kombo issue has been resolved and bump

[GitHub] williaster closed pull request #5151: [dashboard v2] better grid drop ux, fix tab bugs 

williaster closed pull request #5151: [dashboard v2] better grid drop ux, fix tab bugs  URL: https://github.com/apache/incubator-superset/pull/5151 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] john-bodley commented on issue #5150: pin kombu dependency

john-bodley commented on issue #5150: pin kombu dependency URL: https://github.com/apache/incubator-superset/pull/5150#issuecomment-395257389 @timifasubaa could you please also add this dependency to `setup.py`. This is an

[GitHub] betodealmeida opened a new pull request #5152: Use Rison for the explore URL

betodealmeida opened a new pull request #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152 [Rison](https://github.com/Nanonid/rison) is a data serialization format optimized for compactness in URIs. Rison is a slight variation of JSON that

[GitHub] graceguo-supercat commented on issue #5151: [dashboard v2] better grid drop ux, fix tab bugs 

graceguo-supercat commented on issue #5151: [dashboard v2] better grid drop ux, fix tab bugs  URL: https://github.com/apache/incubator-superset/pull/5151#issuecomment-395256525 LGTM! This is an automated message from the

[GitHub] williaster closed pull request #5131: Fix dashboard position row data

williaster closed pull request #5131: Fix dashboard position row data URL: https://github.com/apache/incubator-superset/pull/5131 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] williaster closed pull request #5141: allow add chart from explore view

williaster closed pull request #5141: allow add chart from explore view URL: https://github.com/apache/incubator-superset/pull/5141 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] john-bodley closed pull request #5135: [migrations] Fix time grain SQLA

john-bodley closed pull request #5135: [migrations] Fix time grain SQLA URL: https://github.com/apache/incubator-superset/pull/5135 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] graceguo-supercat commented on a change in pull request #5141: allow add chart from explore view

graceguo-supercat commented on a change in pull request #5141: allow add chart from explore view URL: https://github.com/apache/incubator-superset/pull/5141#discussion_r193585328 ## File path: superset/assets/src/dashboard/reducers/getInitialState.js ## @@ -6,12 +6,17 @@

[GitHub] graceguo-supercat commented on a change in pull request #5141: allow add chart from explore view

graceguo-supercat commented on a change in pull request #5141: allow add chart from explore view URL: https://github.com/apache/incubator-superset/pull/5141#discussion_r193585422 ## File path: superset/assets/src/dashboard/reducers/getInitialState.js ## @@ -92,6 +86,26

[GitHub] graceguo-supercat commented on a change in pull request #5141: allow add chart from explore view

graceguo-supercat commented on a change in pull request #5141: allow add chart from explore view URL: https://github.com/apache/incubator-superset/pull/5141#discussion_r193585361 ## File path: superset/assets/src/dashboard/util/findFirstParentContainer.js ## @@ -0,0

[GitHub] graceguo-supercat commented on a change in pull request #5131: Fix dashboard position row data

graceguo-supercat commented on a change in pull request #5131: Fix dashboard position row data URL: https://github.com/apache/incubator-superset/pull/5131#discussion_r193585227 ## File path: superset/models/core.py ## @@ -347,7 +347,7 @@ def url(self):

[GitHub] graceguo-supercat commented on a change in pull request #5131: Fix dashboard position row data

graceguo-supercat commented on a change in pull request #5131: Fix dashboard position row data URL: https://github.com/apache/incubator-superset/pull/5131#discussion_r193585279 ## File path: superset/assets/src/dashboard/util/dashboardLayoutConverter.js ## @@ -303,26

[GitHub] k-hashimoto commented on issue #5146: Configure to use Google BigQuery

k-hashimoto commented on issue #5146: Configure to use Google BigQuery URL: https://github.com/apache/incubator-superset/issues/5146#issuecomment-395226764 Instead of `pip install pybigquery` ? This is an automated message

[GitHub] k-hashimoto commented on issue #5146: Configure to use Google BigQuery

k-hashimoto commented on issue #5146: Configure to use Google BigQuery URL: https://github.com/apache/incubator-superset/issues/5146#issuecomment-395226764 Instead of `pip3 install pybigquery` ? This is an automated message

[GitHub] williaster closed pull request #5150: pin kombu dependency

williaster closed pull request #5150: pin kombu dependency URL: https://github.com/apache/incubator-superset/pull/5150 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] williaster commented on issue #5150: pin kombu dependency

williaster commented on issue #5150: pin kombu dependency URL: https://github.com/apache/incubator-superset/pull/5150#issuecomment-395219885 LGTM This is an automated message from the Apache Git Service. To respond to the

[GitHub] michellethomas commented on issue #5119: [sqllab] allow gamma users to access their SQLLab views

michellethomas commented on issue #5119: [sqllab] allow gamma users to access their SQLLab views URL: https://github.com/apache/incubator-superset/pull/5119#issuecomment-395219695 We've seen people run into this issue often, thanks for addressing this issue! cc: @john-bodley

[GitHub] williaster commented on issue #4528: [wip] dashboard builder v2

williaster commented on issue #4528: [wip] dashboard builder v2 URL: https://github.com/apache/incubator-superset/pull/4528#issuecomment-395216091 ⚠️ Noting that all Dashboard v1 changes will now need to be manually added back to this branch because we copied it into

[GitHub] codecov-io commented on issue #5150: pin kombu dependency

codecov-io commented on issue #5150: pin kombu dependency URL: https://github.com/apache/incubator-superset/pull/5150#issuecomment-395215483 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5150?src=pr=h1) Report > Merging

[GitHub] williaster commented on issue #5126: [dashboard v2] add v1 switch

williaster commented on issue #5126: [dashboard v2] add v1 switch URL: https://github.com/apache/incubator-superset/pull/5126#issuecomment-395214981 Spoke with @graceguo-supercat offline, the remaining build issues should be resolved by this separate

[GitHub] codecov-io commented on issue #5140: Improve time shift

codecov-io commented on issue #5140: Improve time shift URL: https://github.com/apache/incubator-superset/pull/5140#issuecomment-394840213 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5140?src=pr=h1) Report > Merging

[GitHub] timifasubaa opened a new pull request #5150: pin kombu dependency

timifasubaa opened a new pull request #5150: pin kombu dependency URL: https://github.com/apache/incubator-superset/pull/5150 CI is failing (https://travis-ci.org/apache/incubator-superset/jobs/388955214#L730) because the kombu 4.2 is incompatible with 4.1 and we didn't pin it. This PR

[GitHub] codecov-io commented on issue #5135: [migrations] Fix time grain SQLA

codecov-io commented on issue #5135: [migrations] Fix time grain SQLA URL: https://github.com/apache/incubator-superset/pull/5135#issuecomment-394544372 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5135?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #5135: [migrations] Fix time grain SQLA

john-bodley commented on issue #5135: [migrations] Fix time grain SQLA URL: https://github.com/apache/incubator-superset/pull/5135#issuecomment-395174335 @mistercrunch could you PTAL at this PR? We're trying to tie up a few bug fixes which are required for an upcoming deployment.

[GitHub] john-bodley commented on issue #5028: [druid] Fixing Druid version check

john-bodley commented on issue #5028: [druid] Fixing Druid version check URL: https://github.com/apache/incubator-superset/pull/5028#issuecomment-395165131 ping @GabeLoins This is an automated message from the Apache Git

[GitHub] mistercrunch commented on issue #5142: when try the Sankey visualization --An error occurred while rendering the visualization: TypeError: n.replace is not a function

mistercrunch commented on issue #5142: when try the Sankey visualization --An error occurred while rendering the visualization: TypeError: n.replace is not a function URL: https://github.com/apache/incubator-superset/issues/5142#issuecomment-395143108 I have not dug it but I think the

[GitHub] mistercrunch closed issue #5149: [Session] How to set session timeout?

mistercrunch closed issue #5149: [Session] How to set session timeout? URL: https://github.com/apache/incubator-superset/issues/5149 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mistercrunch commented on issue #5149: [Session] How to set session timeout?

mistercrunch commented on issue #5149: [Session] How to set session timeout? URL: https://github.com/apache/incubator-superset/issues/5149#issuecomment-395139469 We use flask-appbuilder which uses flask-login, so all you have to do is add these configurations to your `superset_config.py`:

[GitHub] oxydash commented on issue #5128: [Question] The row-level security absence problem and it’s solving with the use of reverse proxy (OpenResty)

oxydash commented on issue #5128: [Question] The row-level security absence problem and it’s solving with the use of reverse proxy (OpenResty) URL: https://github.com/apache/incubator-superset/issues/5128#issuecomment-394176171 I’ve found the way how to change http-header, for this

[GitHub] oxydash commented on issue #5128: [Question] The row-level security absence problem and it’s solving with the use of reverse proxy (OpenResty)

oxydash commented on issue #5128: [Question] The row-level security absence problem and it’s solving with the use of reverse proxy (OpenResty) URL: https://github.com/apache/incubator-superset/issues/5128#issuecomment-394176171 I’ve found the way how to change http-header, for this

[GitHub] oxydash commented on issue #5128: [Question] The row-level security absence problem and it’s solving with the use of reverse proxy (OpenResty)

oxydash commented on issue #5128: [Question] The row-level security absence problem and it’s solving with the use of reverse proxy (OpenResty) URL: https://github.com/apache/incubator-superset/issues/5128#issuecomment-394176171 I’ve found the way how to change http-header, for this

[GitHub] oxydash commented on issue #5128: [Question] The row-level security absence problem and it’s solving with the use of reverse proxy (OpenResty)

oxydash commented on issue #5128: [Question] The row-level security absence problem and it’s solving with the use of reverse proxy (OpenResty) URL: https://github.com/apache/incubator-superset/issues/5128#issuecomment-394176171 I’ve found the way how to change http-header, for this

[GitHub] xrmx commented on issue #5148: Portuguese Translation Doesn't Translate Everything

xrmx commented on issue #5148: Portuguese Translation Doesn't Translate Everything URL: https://github.com/apache/incubator-superset/issues/5148#issuecomment-395046659 Please reproduce with 0.25 or master This is an

[GitHub] qin4zhang opened a new issue #5149: [Session] How to set session timeout?

qin4zhang opened a new issue #5149: [Session] How to set session timeout? URL: https://github.com/apache/incubator-superset/issues/5149 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and

[GitHub] claycrosby opened a new issue #5148: Portuguese Translation Doesn't Translate Everything

claycrosby opened a new issue #5148: Portuguese Translation Doesn't Translate Everything URL: https://github.com/apache/incubator-superset/issues/5148 ### Superset version 0.24.0 ### Expected results All tabs, non-data words (e.g. "since" and "until," month names) are

[GitHub] MAliNaqvi opened a new issue #5147: Change iframe result based on selection in the filterbox

MAliNaqvi opened a new issue #5147: Change iframe result based on selection in the filterbox URL: https://github.com/apache/incubator-superset/issues/5147 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python

[GitHub] k-hashimoto opened a new issue #5146: Configure to use Google BigQuery

k-hashimoto opened a new issue #5146: Configure to use Google BigQuery URL: https://github.com/apache/incubator-superset/issues/5146 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python stacktraces and included

[GitHub] nukeu666 opened a new issue #5145: Can see all datasources while making charts

nukeu666 opened a new issue #5145: Can see all datasources while making charts URL: https://github.com/apache/incubator-superset/issues/5145 Make sure these boxes are checked before submitting your issue - thank you! - [-] I have checked the superset logs for python stacktraces and

[GitHub] codecov-io commented on issue #5144: Adding a new viz line-bar chart

codecov-io commented on issue #5144: Adding a new viz line-bar chart URL: https://github.com/apache/incubator-superset/pull/5144#issuecomment-394998044 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5144?src=pr=h1) Report > Merging

[GitHub] VinodLouis opened a new pull request #5144: Adding a new viz line-bar chart

VinodLouis opened a new pull request #5144: Adding a new viz line-bar chart URL: https://github.com/apache/incubator-superset/pull/5144 This pull request is a very simple and straightforward implementation of a line-bar chart. I recently added this in my project and thought it would be an

[GitHub] liyuance opened a new pull request #5143: strip druid metric type when value is postagg

liyuance opened a new pull request #5143: strip druid metric type when value is postagg URL: https://github.com/apache/incubator-superset/pull/5143 When some blank character ahead druid metric type specified as ‘postagg’, like :