[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2020-03-25 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-604024366 @axelet hey, thanks for that! It looks good to me; I must have introduced that in one of the query format changes.

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2020-03-13 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-598860699 @AaronCH5 It looks from a few posts past that you're using Druid. The filtering occurs in `sqla/models.py` so it probably isn't ap

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2020-03-13 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-598858227 As far as I know they should be applied on-the-fly, and shouldn't require a re-login. Maybe take that with a grain of salt though;

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2020-03-12 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-598269364 Hi @AaronCH5, I'm not completely certain what you're asking, but one difference is that in this pull request (which has been merge

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2020-02-21 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-589890236 @villebro - added! This is an automated message from the Apache Gi

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2020-02-13 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-585991917 @villebro - added This is an automated message from the Apache Git

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2020-02-10 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-584377759 @dpgaspar, @villebro; What test do you want? This is an automated

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2019-12-11 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-564445828 @toop I think (if memory serves) single quotes are used to enclose literals in Oracle. Using double quotes in that situation is pr

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2019-12-10 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-563938471 @villebro Awesome, thanks! This is an automated message from the A

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2019-12-08 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-563109754 * Added template processing and tested it with the RLS clause `advertiser_name = "{{ current_username() }}"` * Added RLS IDs to

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2019-12-04 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-561807079 @mistercrunch thanks! RLS filters should now be many-to-many to roles. I've moved the logic to `get_sqla_query`, using SQLA expre

[GitHub] [incubator-superset] altef commented on issue #8699: [SIP-29] Add support for row-level security

2019-11-30 Thread GitBox
altef commented on issue #8699: [SIP-29] Add support for row-level security URL: https://github.com/apache/incubator-superset/pull/8699#issuecomment-560004957 Hey - thanks for looking it over! I wanted to point that out in the docs for clarity, and viewed it as more of something the u