[GitHub] [incubator-superset] codecov-io commented on issue #8219: [WIP] Build better support for schema permissions

Wed, 18 Sep 2019 18:57:12 -0700 

codecov-io commented on issue #8219: [WIP] Build better support for schema 
permissions
URL: 
https://github.com/apache/incubator-superset/pull/8219#issuecomment-532932389
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=h1)
 Report
   > Merging 
[#8219](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/799e08d76f8489dc4a6a711d42f1f2b7308b6c67?src=pr&el=desc)
 will **increase** coverage by `0.15%`.
   > The diff coverage is `95.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/8219/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8219      +/-   ##
   ==========================================
   + Coverage   65.67%   65.82%   +0.15%     
   ==========================================
     Files         481      481              
     Lines       23349    23361      +12     
     Branches     2572     2572              
   ==========================================
   + Hits        15334    15378      +44     
   + Misses       7877     7845      -32     
     Partials      138      138
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/views/database/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvX19pbml0X18ucHk=)
 | `87.5% <100%> (+5.86%)` | :arrow_up: |
   | 
[superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==)
 | `69.94% <100%> (-1%)` | :arrow_down: |
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `82.13% <100%> (+0.41%)` | :arrow_up: |
   | 
[superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==)
 | `86.11% <100%> (ø)` | :arrow_up: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `84.43% <100%> (+0.16%)` | :arrow_up: |
   | 
[superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==)
 | `90.05% <100%> (+0.05%)` | :arrow_up: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `81.99% <100%> (+0.05%)` | :arrow_up: |
   | 
[superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=)
 | `88.23% <100%> (+0.35%)` | :arrow_up: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `70.28% <100%> (+0.04%)` | :arrow_up: |
   | 
[superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=)
 | `84.09% <92.59%> (+10%)` | :arrow_up: |
   | ... and [3 
more](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=footer).
 Last update 
[799e08d...4c72837](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to