[GitHub] [superset] lyndsiWilliams opened a new pull request #15412: style: Database Connection Modal UI Polish R5

[GitBox]

lyndsiWilliams opened a new pull request #15412:
URL: https://github.com/apache/superset/pull/15412


   ### SUMMARY
   Implemented UI polish tasks in [Clubhouse 
ticket](https://app.clubhouse.io/preset/story/17847/ui-polish-r5)
   - Centered modal in window
   - Fixed inconsistent header spacing
   - Touched up tooltips
   - Added red *s to BigQuery form
   
   Extra:
   - Styled placeholder text in BigQuery > Service Account
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   - #### Centered modal, Consistent header spacing, Styled placeholder text in 
BigQuery > Service Account
   
![dbmServiceAcct](https://user-images.githubusercontent.com/55605634/123584038-4a897f00-d7a6-11eb-9a38-ee0862174699.gif)
   
   - #### Red *s in BigQuery form
   <img width="502" alt="BQJSON" 
src="https://user-images.githubusercontent.com/55605634/123584969-f089b900-d7a7-11eb-9cf9-a37bf33a4093.png";>
   <img width="502" alt="BQcopyPaste" 
src="https://user-images.githubusercontent.com/55605634/123584974-f2ec1300-d7a7-11eb-83ac-cf2c4ededd9b.png";>
   
   - #### Tooltips
   <img width="347" alt="hostTooltip" 
src="https://user-images.githubusercontent.com/55605634/123584618-50cc2b00-d7a7-11eb-9e0d-24b2620065bc.png";>
   <img width="641" alt="SQLAlchemyTooltip" 
src="https://user-images.githubusercontent.com/55605634/123584624-53c71b80-d7a7-11eb-9510-a5074de465aa.png";>
   <img width="425" alt="uploadCredentialsTooltip" 
src="https://user-images.githubusercontent.com/55605634/123584631-5590df00-d7a7-11eb-85d8-ea8fec223296.png";>
   
   
   ### TESTING INSTRUCTIONS
   From the Superset home page:
   - Hover over "Data" in the upper navigation bar
   - Click "Database"
   - Click the "+ Database" button below the navigation bar and to the right
   - Navigation through the database modal and observe the styling described 
above
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org