[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-07-27 Thread GitBox
villebro commented on a change in pull request #15279: URL: https://github.com/apache/superset/pull/15279#discussion_r677236878 ## File path: .pylintrc ## @@ -90,6 +90,8 @@ disable= super-with-arguments, too-few-public-methods, too-many-locals, +

[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-07-27 Thread GitBox
villebro commented on a change in pull request #15279: URL: https://github.com/apache/superset/pull/15279#discussion_r677236088 ## File path: .pylintrc ## @@ -81,7 +81,7 @@ confidence= # --enable=similarities". If you want to run only the classes checker, but have # no

[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-07-27 Thread GitBox
villebro commented on a change in pull request #15279: URL: https://github.com/apache/superset/pull/15279#discussion_r677234899 ## File path: superset/common/query_context.py ## @@ -101,21 +104,143 @@ def __init__( # pylint: disable=too-many-arguments

[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-07-27 Thread GitBox
villebro commented on a change in pull request #15279: URL: https://github.com/apache/superset/pull/15279#discussion_r677228313 ## File path: superset/utils/core.py ## @@ -115,6 +115,8 @@ DTTM_ALIAS = "__timestamp" +TIME_COMPARISION = "__" Review comment: > I have

[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-23 Thread GitBox
villebro commented on a change in pull request #15279: URL: https://github.com/apache/superset/pull/15279#discussion_r656928933 ## File path: superset/common/query_context.py ## @@ -97,6 +101,62 @@ def __init__( # pylint: disable=too-many-arguments

[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing

2021-06-23 Thread GitBox
villebro commented on a change in pull request #15279: URL: https://github.com/apache/superset/pull/15279#discussion_r656877011 ## File path: superset/utils/pandas_postprocessing.py ## @@ -425,9 +429,11 @@ def select( @validate_column_args("columns") -def diff(df: