[GitHub] GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

[GitBox]

GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding 
the Adhoc Filter popover when the content expands
URL: https://github.com/apache/incubator-superset/pull/5032
 
 
   Previously to this PR, when adding/viewing a simple filter with number of 
comparators this could happen:
   
   
![image](https://user-images.githubusercontent.com/2455694/40211068-45f30c10-59fd-11e8-8261-c6746bf59568.png)
   
   That doesn't look so great and also makes it quite annoying to make any 
changes because you are forced to manually expand the box to hit save. In this 
PR I have the popover expand in reaction when the input field expands.
   
   
![autoexpanding](https://user-images.githubusercontent.com/2455694/40211024-00e76c10-59fd-11e8-934f-5ee1f4c3c2f5.gif)
   
   test plan:
   - ran the example shown in the above gif
   - ran the spec
   
   reviewers:
   @michellethomas @john-bodley @williaster @mistercrunch
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org