[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-390806412 @mistercrunch added tests, thanks for the suggestion!

[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389699387 @mistercrunch I didn't see a lot of tests for this section of the code. Did you have thoughts on

[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389699387 @mistercrunch I didn't see a lot of tests for this section of the code. Did you have thoughts on

[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389699387 @mistercrunch I didn't see a lot of tests for this section of the code. Did you have thoughts on